Skip to content

Commit 9b3ddbf

Browse files
committed
test(queue): use Promise.allSettled for robust testing
Convert Promise.all to Promise.allSettled in queue tests to ensure all promises complete even if one fails. This provides better test error messages and prevents memory leaks from short-circuit behavior.
1 parent bc80b19 commit 9b3ddbf

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/cli/src/utils/promise/queue.test.mts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ describe('PromiseQueue', () => {
1414
})
1515
})
1616

17-
const results = await Promise.all(tasks.map(task => queue.add(task)))
17+
const results = await Promise.allSettled(tasks.map(task => queue.add(task)))
1818

19-
expect(results).toEqual([0, 1, 2, 3, 4])
19+
expect(results.map(r => r.status === 'fulfilled' ? r.value : null)).toEqual([0, 1, 2, 3, 4])
2020
})
2121

2222
it('should track active and pending counts', async () => {
@@ -29,7 +29,7 @@ describe('PromiseQueue', () => {
2929
expect(queue.activeCount).toBe(1)
3030
expect(queue.pendingCount).toBe(1)
3131

32-
await Promise.all([p1, p2])
32+
await Promise.allSettled([p1, p2])
3333

3434
expect(queue.activeCount).toBe(0)
3535
expect(queue.pendingCount).toBe(0)

0 commit comments

Comments
 (0)