Skip to content

Commit aa486be

Browse files
committed
fix(ci): remove ai-cache-valid references from build-sea workflow
Removed all references to the commented-out ai-cache-valid step to fix Windows build failures. The step doesn't exist, so checks against its output were causing builds to fail. Changes: - Removed ai-cache-valid check from Windows WASM cache validation - Updated Setup Python condition to only check yoga-cache-valid - Commented out pip cache (only used for AI models) - Updated Build WASM assets condition to only check yoga-cache-valid - Commented out AI models status echo - Commented out Python deps installation for AI models - Commented out AI models build section Windows builds will now succeed if Yoga Layout WASM is cached.
1 parent 13eace5 commit aa486be

1 file changed

Lines changed: 29 additions & 29 deletions

File tree

.github/workflows/build-sea.yml

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -319,14 +319,14 @@ jobs:
319319
# fi
320320

321321
- name: Check WASM cache requirements (Windows)
322-
if: steps.check-platform.outputs.should-run == 'true' && matrix.os == 'windows' && (steps.yoga-cache-valid.outputs.valid != 'true' || steps.ai-cache-valid.outputs.valid != 'true')
322+
if: steps.check-platform.outputs.should-run == 'true' && matrix.os == 'windows' && steps.yoga-cache-valid.outputs.valid != 'true'
323323
run: |
324324
echo "::error::WASM assets not cached for Windows build. Run build-wasm.yml workflow first to prime the cache."
325325
echo "Windows builds require pre-cached WASM assets due to network reliability issues."
326326
exit 1
327327
328328
- name: Setup Python for WASM builds
329-
if: steps.check-platform.outputs.should-run == 'true' && (steps.yoga-cache-valid.outputs.valid != 'true' || steps.ai-cache-valid.outputs.valid != 'true')
329+
if: steps.check-platform.outputs.should-run == 'true' && steps.yoga-cache-valid.outputs.valid != 'true'
330330
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
331331
with:
332332
python-version: '3.11'
@@ -340,26 +340,26 @@ jobs:
340340
key: emsdk-${{ runner.os }}-3.1.69
341341
restore-keys: emsdk-${{ runner.os }}-
342342

343-
- name: Cache pip packages
344-
if: steps.check-platform.outputs.should-run == 'true' && steps.ai-cache-valid.outputs.valid != 'true'
345-
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
346-
with:
347-
path: ~/.cache/pip
348-
key: pip-${{ runner.os }}-py3.11-${{ hashFiles('**/requirements*.txt') }}-onnx-torch
349-
restore-keys: |
350-
pip-${{ runner.os }}-py3.11-
351-
pip-${{ runner.os }}-
343+
# - name: Cache pip packages
344+
# if: steps.check-platform.outputs.should-run == 'true' && steps.ai-cache-valid.outputs.valid != 'true'
345+
# uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
346+
# with:
347+
# path: ~/.cache/pip
348+
# key: pip-${{ runner.os }}-py3.11-${{ hashFiles('**/requirements*.txt') }}-onnx-torch
349+
# restore-keys: |
350+
# pip-${{ runner.os }}-py3.11-
351+
# pip-${{ runner.os }}-
352352

353353
- name: Build WASM assets on cache miss
354-
if: steps.check-platform.outputs.should-run == 'true' && (steps.yoga-cache-valid.outputs.valid != 'true' || steps.ai-cache-valid.outputs.valid != 'true')
354+
if: steps.check-platform.outputs.should-run == 'true' && steps.yoga-cache-valid.outputs.valid != 'true'
355355
shell: bash
356356
run: |
357357
echo "⚠️ WASM cache miss detected - building from source"
358358
echo "This will take 30-60 minutes. Consider running build-wasm.yml workflow to prime cache."
359359
echo ""
360360
echo "Cache status:"
361361
echo " Yoga Layout: ${{ steps.yoga-cache-valid.outputs.valid == 'true' && '✓ cached' || '✗ missing' }}"
362-
echo " AI Models: ${{ steps.ai-cache-valid.outputs.valid == 'true' && '✓ cached' || '✗ missing' }}"
362+
# echo " AI Models: ${{ steps.ai-cache-valid.outputs.valid == 'true' && '✓ cached' || '✗ missing' }}"
363363
# echo " ONNX Runtime: ${{ steps.onnx-cache-valid.outputs.valid == 'true' && '✓ cached' || '✗ missing' }}"
364364
echo ""
365365
@@ -394,13 +394,13 @@ jobs:
394394
cd ..
395395
fi
396396
397-
# Install Python deps if needed for AI models.
398-
if [ "${{ steps.ai-cache-valid.outputs.valid }}" != "true" ]; then
399-
echo "::group::Installing Python dependencies"
400-
python3 -m pip install --upgrade pip
401-
python3 -m pip install transformers torch "optimum[onnxruntime]" "onnxruntime>=1.21.0"
402-
echo "::endgroup::"
403-
fi
397+
# # Install Python deps if needed for AI models.
398+
# if [ "${{ steps.ai-cache-valid.outputs.valid }}" != "true" ]; then
399+
# echo "::group::Installing Python dependencies"
400+
# python3 -m pip install --upgrade pip
401+
# python3 -m pip install transformers torch "optimum[onnxruntime]" "onnxruntime>=1.21.0"
402+
# echo "::endgroup::"
403+
# fi
404404
405405
# Build missing WASM assets.
406406
if [ "${{ steps.yoga-cache-valid.outputs.valid }}" != "true" ]; then
@@ -413,15 +413,15 @@ jobs:
413413
echo "::endgroup::"
414414
fi
415415
416-
if [ "${{ steps.ai-cache-valid.outputs.valid }}" != "true" ]; then
417-
echo "::group::Building AI models (10-15 minutes)"
418-
if [ "${{ inputs.force }}" = "true" ]; then
419-
pnpm --filter @socketbin/cli-ai run build -- --force
420-
else
421-
pnpm --filter @socketbin/cli-ai run build
422-
fi
423-
echo "::endgroup::"
424-
fi
416+
# if [ "${{ steps.ai-cache-valid.outputs.valid }}" != "true" ]; then
417+
# echo "::group::Building AI models (10-15 minutes)"
418+
# if [ "${{ inputs.force }}" = "true" ]; then
419+
# pnpm --filter @socketbin/cli-ai run build -- --force
420+
# else
421+
# pnpm --filter @socketbin/cli-ai run build
422+
# fi
423+
# echo "::endgroup::"
424+
# fi
425425
426426
# if [ "${{ steps.onnx-cache-valid.outputs.valid }}" != "true" ]; then
427427
# echo "::group::Building ONNX Runtime (20-30 minutes)"

0 commit comments

Comments
 (0)