refactor: optimize logger and spinner initialization

Refactor 111 files to call getDefaultLogger() and getDefaultSpinner() once at the top of each module instead of repeatedly throughout the code. This improves performance by reducing redundant function calls and establishes a consistent pattern across the codebase.

Pattern applied:
- Added const logger = getDefaultLogger() after imports
- Added const spinner = getDefaultSpinner() after imports
- Replaced all getDefaultLogger() calls with logger reference
- Replaced all getDefaultSpinner() calls with spinner reference

This change maintains backward compatibility while improving code efficiency and maintainability.

Author: jdalton

packages/bootstrap/src/shared/bootstrap-shared.mjs

@@ -17,6 +17,8 @@ import { spawn } from '@socketsecurity/lib/spawn'
 import { gte } from 'semver'
 import { SOCKET_CLI_ISSUES_URL } from '../../../cli/src/constants/socket.mts'
 
+const logger = getDefaultLogger()
+
 export const SOCKET_DLX_DIR = path.join(homedir(), '.socket', '_dlx')
 
 /**
@@ -169,9 +171,9 @@ export async function downloadCli() {
   try {
     mkdirSync(SOCKET_DLX_DIR, { recursive: true })
   } catch (e) {
-    getDefaultLogger().error('Failed to create Socket directory')
-    getDefaultLogger().error(`   Error: ${e instanceof Error ? e.message : String(e)}`)
-    getDefaultLogger().error(`   Path: ${SOCKET_DLX_DIR}`)
+    logger.error('Failed to create Socket directory')
+    logger.error(`   Error: ${e instanceof Error ? e.message : String(e)}`)
+    logger.error(`   Path: ${SOCKET_DLX_DIR}`)
     process.exit(1)
   }
 
@@ -184,7 +186,8 @@ export async function downloadCli() {
         // Uses caret range (^) to auto-update within same major version.
         // Update notifications will only trigger for major version changes.
         await downloadPackage({
-          package: `@socketsecurity/cli@^${SOCKET_CLI_VERSION_MAJOR}`,
+          // @ts-expect-error - Injected by esbuild define.
+          package: '@socketsecurity/cli@^' + __SOCKET_CLI_VERSION_MAJOR__,
           binaryName: 'socket',
           // Use cached version if available.
           force: false,
@@ -193,14 +196,14 @@ export async function downloadCli() {
 
     return result
   } catch (e) {
-    getDefaultLogger().error('Failed to download Socket CLI')
-    getDefaultLogger().error(`   Error: ${e instanceof Error ? e.message : String(e)}`)
-    getDefaultLogger().error('')
-    getDefaultLogger().error('This may be a temporary issue. Please try:')
-    getDefaultLogger().error('  1. Check your internet connection')
-    getDefaultLogger().error('  2. Try running the command again')
-    getDefaultLogger().error(`  3. Manually create directory: mkdir -p "${SOCKET_DLX_DIR}"`)
-    getDefaultLogger().error(`  4. Report issue at: ${SOCKET_CLI_ISSUES_URL}`)
+    logger.error('Failed to download Socket CLI')
+    logger.error(`   Error: ${e instanceof Error ? e.message : String(e)}`)
+    logger.error('')
+    logger.error('This may be a temporary issue. Please try:')
+    logger.error('  1. Check your internet connection')
+    logger.error('  2. Try running the command again')
+    logger.error(`  3. Manually create directory: mkdir -p "${SOCKET_DLX_DIR}"`)
+    logger.error(`  4. Report issue at: ${SOCKET_CLI_ISSUES_URL}`)
     process.exit(1)
   }
 }
@@ -216,7 +219,8 @@ export async function findAndExecuteCli(args) {
 
   // Pass metadata to CLI for manifest writing.
   // CLI will use this to write entries to ~/.socket/_dlx/.dlx-manifest.json
-  const spec = `@socketsecurity/cli@^${SOCKET_CLI_VERSION_MAJOR}`
+  // @ts-expect-error - Injected by esbuild define.
+  const spec = '@socketsecurity/cli@^' + __SOCKET_CLI_VERSION_MAJOR__
   process.env.SOCKET_CLI_BOOTSTRAP_SPEC = spec
   process.env.SOCKET_CLI_BOOTSTRAP_CACHE_DIR = cliPackageDir
 
@@ -229,8 +233,8 @@ export async function findAndExecuteCli(args) {
   }
 
   // If we can't find the CLI, exit with error.
-  getDefaultLogger().error('Socket CLI installation failed')
-  getDefaultLogger().error('   CLI entry point not found after installation')
-  getDefaultLogger().error(`   Looked in: ${cliEntry}`)
+  logger.error('Socket CLI installation failed')
+  logger.error('   CLI entry point not found after installation')
+  logger.error(`   Looked in: ${cliEntry}`)
   return 1
 }

packages/cli/src/cli-entry.mts

@@ -37,6 +37,8 @@ import lookupRegistryUrl from 'registry-url'
 import { debug as debugNs, debugDir } from '@socketsecurity/lib/debug'
 import { getDefaultLogger } from '@socketsecurity/lib/logger'
 
+const logger = getDefaultLogger()
+
 // Debug logger for manifest operations
 const debug = debugNs
 
@@ -176,7 +178,7 @@ void (async () => {
     })()
 
     if (isJson) {
-      getDefaultLogger().log(
+      logger.log(
         serializeResultJson({
           ok: false,
           message: errorTitle,
@@ -185,8 +187,8 @@ void (async () => {
       )
     } else {
       // Add 2 newlines in stderr to bump below any spinner.
-      getDefaultLogger().error('\n')
-      getDefaultLogger().fail(failMsgWithBadge(errorTitle, errorMessage))
+      logger.error('\n')
+      logger.fail(failMsgWithBadge(errorTitle, errorMessage))
       if (errorBody) {
         debugDir('inspect', { errorBody })
       }

packages/cli/src/commands/analytics/output-analytics.mts

@@ -10,6 +10,8 @@ import { fileLink } from '../../utils/terminal/link.mts'
 
 import type { CResult, OutputKind } from '../../types.mts'
 import type { SocketSdkSuccessResult } from '@socketsecurity/sdk'
+const logger = getDefaultLogger()
+
 
 const METRICS = [
   'total_critical_alerts',
@@ -63,10 +65,10 @@ export async function outputAnalytics(
 
   if (!result.ok) {
     if (outputKind === 'json') {
-      getDefaultLogger().log(serializeResultJson(result))
+      logger.log(serializeResultJson(result))
       return
     }
-    getDefaultLogger().fail(failMsgWithBadge(result.message, result.cause))
+    logger.fail(failMsgWithBadge(result.message, result.cause))
     return
   }
 
@@ -77,13 +79,13 @@ export async function outputAnalytics(
       try {
         await fs.writeFile(filepath, serialized, 'utf8')
         debugFileOp('write', filepath)
-        getDefaultLogger().success(
+        logger.success(
           `Data successfully written to ${fileLink(filepath)}`,
         )
       } catch (e) {
         debugFileOp('write', filepath, e)
         process.exitCode = 1
-        getDefaultLogger().log(
+        logger.log(
           serializeResultJson({
             ok: false,
             message: 'File Write Failure',
@@ -92,7 +94,7 @@ export async function outputAnalytics(
         )
       }
     } else {
-      getDefaultLogger().log(serialized)
+      logger.log(serialized)
     }
 
     return
@@ -109,15 +111,15 @@ export async function outputAnalytics(
       try {
         await fs.writeFile(filepath, serialized, 'utf8')
         debugFileOp('write', filepath)
-        getDefaultLogger().success(
+        logger.success(
           `Data successfully written to ${fileLink(filepath)}`,
         )
       } catch (e) {
         debugFileOp('write', filepath, e)
-        getDefaultLogger().error(e)
+        logger.error(e)
       }
     } else {
-      getDefaultLogger().log(serialized)
+      logger.log(serialized)
     }
   } else {
     await displayAnalyticsWithInk(fdata)

packages/cli/src/commands/ask/handle-ask.mts

@@ -9,6 +9,8 @@ import { spawn } from '@socketsecurity/lib/spawn'
 
 import { outputAskCommand } from './output-ask.mts'
 import ENV from '../../constants/env.mts'
+const logger = getDefaultLogger()
+
 
 // Semantic index for fast word-overlap matching (lazy-loaded, ~3KB).
 let semanticIndex: any = null
@@ -642,25 +644,25 @@ export async function handleAsk(options: HandleAskOptions): Promise<void> {
 
   // If not executing, just show the command.
   if (!execute) {
-    getDefaultLogger().log('')
-    getDefaultLogger().log(
+    logger.log('')
+    logger.log(
       '💡 Tip: Add --execute or -e to run this command directly',
     )
     return
   }
 
   // Execute the command.
-  getDefaultLogger().log('')
-  getDefaultLogger().log('🚀 Executing...')
-  getDefaultLogger().log('')
+  logger.log('')
+  logger.log('🚀 Executing...')
+  logger.log('')
 
   const result = await spawn('socket', intent.command, {
     stdio: 'inherit',
     cwd: process.cwd(),
   })
 
   if (result.code !== 0) {
-    getDefaultLogger().error(`Command failed with exit code ${result.code}`)
+    logger.error(`Command failed with exit code ${result.code}`)
     // eslint-disable-next-line n/no-process-exit
     process.exit(result.code)
   }

packages/cli/src/commands/ask/output-ask.mts

@@ -1,6 +1,8 @@
 import colors from 'yoctocolors-cjs'
 
 import { getDefaultLogger } from '@socketsecurity/lib/logger'
+const logger = getDefaultLogger()
+
 
 interface OutputAskCommandOptions {
   query: string
@@ -29,14 +31,14 @@ export function outputAskCommand(options: OutputAskCommandOptions): void {
   const { context, explain, intent, query } = options
 
   // Show the query.
-  getDefaultLogger().log('')
-  getDefaultLogger().log(colors.bold(colors.magenta('❯ You asked:')))
-  getDefaultLogger().log(`  "${colors.cyan(query)}"`)
-  getDefaultLogger().log('')
+  logger.log('')
+  logger.log(colors.bold(colors.magenta('❯ You asked:')))
+  logger.log(`  "${colors.cyan(query)}"`)
+  logger.log('')
 
   // Show interpretation.
-  getDefaultLogger().log(colors.bold(colors.magenta('🤖 I understood:')))
-  getDefaultLogger().log(`  ${intent.explanation}`)
+  logger.log(colors.bold(colors.magenta('🤖 I understood:')))
+  logger.log(`  ${intent.explanation}`)
 
   // Show extracted details if present.
   const details = []
@@ -60,42 +62,42 @@ export function outputAskCommand(options: OutputAskCommandOptions): void {
   }
 
   if (details.length > 0) {
-    getDefaultLogger().log(`  ${details.join(', ')}`)
+    logger.log(`  ${details.join(', ')}`)
   }
 
   // Show confidence if low.
   if (intent.confidence < 0.6) {
-    getDefaultLogger().log('')
-    getDefaultLogger().log(
+    logger.log('')
+    logger.log(
       colors.yellow(
         '⚠️  Low confidence - the command might not match your intent exactly',
       ),
     )
   }
 
-  getDefaultLogger().log('')
+  logger.log('')
 
   // Show the command.
-  getDefaultLogger().log(colors.bold(colors.magenta('📝 Command:')))
-  getDefaultLogger().log(
+  logger.log(colors.bold(colors.magenta('📝 Command:')))
+  logger.log(
     `  ${colors.green('$')} socket ${colors.cyan(intent.command.join(' '))}`,
   )
 
   // Show explanation if requested.
   if (explain) {
-    getDefaultLogger().log('')
-    getDefaultLogger().log(colors.bold(colors.magenta('💡 Explanation:')))
-    getDefaultLogger().log(explainCommand(intent))
+    logger.log('')
+    logger.log(colors.bold(colors.magenta('💡 Explanation:')))
+    logger.log(explainCommand(intent))
   }
 
   // Show context.
   if (context.hasPackageJson && explain) {
-    getDefaultLogger().log('')
-    getDefaultLogger().log(colors.bold(colors.magenta('📦 Project Context:')))
+    logger.log('')
+    logger.log(colors.bold(colors.magenta('📦 Project Context:')))
     const depCount = Object.keys(context.dependencies || {}).length
     const devDepCount = Object.keys(context.devDependencies || {}).length
-    getDefaultLogger().log(`  Dependencies: ${depCount} packages`)
-    getDefaultLogger().log(`  Dev Dependencies: ${devDepCount} packages`)
+    logger.log(`  Dependencies: ${depCount} packages`)
+    logger.log(`  Dev Dependencies: ${devDepCount} packages`)
   }
 }
 

packages/cli/src/commands/audit-log/output-audit-log.mts

@@ -14,6 +14,8 @@ import { serializeResultJson } from '../../utils/output/result-json.mjs'
 
 import type { CResult, OutputKind } from '../../types.mts'
 import type { SocketSdkSuccessResult } from '@socketsecurity/sdk'
+const logger = getDefaultLogger()
+
 
 type AuditLogEvent =
   SocketSdkSuccessResult<'getAuditLogEvents'>['data']['results'][number]
@@ -39,7 +41,7 @@ export async function outputAuditLog(
   }
 
   if (outputKind === OUTPUT_JSON) {
-    getDefaultLogger().log(
+    logger.log(
       await outputAsJson(result, {
         logType,
         orgSlug,
@@ -50,12 +52,12 @@ export async function outputAuditLog(
   }
 
   if (!result.ok) {
-    getDefaultLogger().fail(failMsgWithBadge(result.message, result.cause))
+    logger.fail(failMsgWithBadge(result.message, result.cause))
     return
   }
 
   if (outputKind === OUTPUT_MARKDOWN) {
-    getDefaultLogger().log(
+    logger.log(
       await outputAsMarkdown(result.data, {
         logType,
         orgSlug,
@@ -159,7 +161,7 @@ ${table}
 `
   } catch (e) {
     process.exitCode = 1
-    getDefaultLogger().fail(
+    logger.fail(
       `There was a problem converting the logs to Markdown, please try the \`${FLAG_JSON}\` flag`,
     )
     debug('Markdown conversion failed')