Optimize rendered sample buffering in audio output path#1
Open
Solvely-Colin wants to merge 1 commit into
Open
Conversation
Replace front-removal dequeue operations in RenderedSampleBuffer with an offset-based queue and periodic compaction to avoid O(n) work on every audio callback-driven dequeue/enqueue path. Add focused tests for FIFO behavior and bounded-capacity trimming. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR optimizes the RenderedSampleBuffer used in the audio output path by replacing Array.removeFirst(...)-based dequeuing/trimming (O(n) per operation) with an offset-based queue and periodic compaction, reducing steady-state work in render-adjacent code. It also adds unit tests to validate FIFO ordering and bounded-capacity drop behavior.
Changes:
- Track a
readOffsetinto the backing[Float]array to avoid front-removal shifts on every dequeue/trim. - Periodically compact backing storage (and reset when empty) instead of shifting on each operation.
- Add
RenderedSampleBuffertests for dequeue ordering and capacity trimming.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/OpenFaderCore/AudioRenderLoop.swift | Reworks RenderedSampleBuffer to use an offset-based queue with periodic compaction to avoid O(n) removeFirst shifting. |
| Tests/OpenFaderCoreTests/RenderedSampleBufferTests.swift | Adds tests for FIFO dequeue order and dropping oldest samples when exceeding maximum capacity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+369
to
+372
| private func compactStorageIfNeeded() { | ||
| guard readOffset > 0, | ||
| readOffset >= 4096, | ||
| readOffset * 2 >= samples.count else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
emoveFirst(...) on Array is O(n) and was used in the render-adjacent buffering path. This change avoids repeated full-array shifts in steady-state callback traffic.
Testing