fix(wix): Start menu shortcut becomes smart launcher, not setup-only

The Start menu shortcut had Arguments='setup' which forced the setup
wizard every time the user clicked it. After someone successfully
completed setup, clicking the shortcut to launch the camera dashboard
re-prompted for Node ID + API key + URL — making it look like
credentials weren't being saved when in fact they were saved fine,
the shortcut just always took the explicit setup path.

Root cause in main.rs:261:
  let needs_setup = match &args.command {
      Some(Commands::Setup { .. }) => true,  // always true
      Some(Commands::Run { .. }) | None => /* check creds */,
      ...
  };

`Commands::Setup` unconditionally re-runs the wizard. The bare
invocation (`None` arm) is the smart path — it checks Config::load
for existing credentials and runs the node if they're present, or
falls through to the wizard if not.

Fix: drop the Arguments='setup' attribute on the Start menu shortcut
so clicking it invokes the binary with no subcommand. The bare path
then handles both first-launch (no creds → wizard → run) and every-
launch-after (creds present → straight to dashboard).

Also renamed the shortcut from "SourceBox Sentry CloudNode Setup"
(implies setup-only behaviour) to "SourceBox Sentry CloudNode"
(reflects its new role as a normal app launcher). Shortcut Id
changed from ShortcutSetup → ShortcutLauncher; the WiX Component
Guid is unchanged so the upgrade chain still recognises this as the
same shortcut row, just renamed.

The MSI Finish-dialog LaunchSetup CustomAction (top of wxs) is
unaffected — it's a separate code path that explicitly passes
`setup` because the Finish dialog needs to spawn a fresh console.
That path correctly forces the wizard on first install.

Operators who genuinely want to RECONFIGURE (change Node ID, point
at a different Command Center, etc.) can run
`sourcebox-sentry-cloudnode setup` from any console — the explicit
subcommand still forces the wizard, by design.

Bumps version to 0.1.33.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Sbussiso

Cargo.lock

@@ -5,7 +5,7 @@
 # should reflect that. Going from `opensentry-cloudnode` to
 # `sourcebox-sentry-cloudnode` keeps the binary name explicit + branded.
 name = "sourcebox-sentry-cloudnode"
-version = "0.1.32"
+version = "0.1.33"
 edition = "2021"
 authors = ["SourceBox LLC"]
 description = "SourceBox Sentry CloudNode — turns a USB webcam into a cloud-connected security camera."

Cargo.toml

@@ -332,19 +332,37 @@
                 </Directory>
             </Directory>
 
-            <!-- Start menu shortcut so the user can launch a console
-                 invocation of the binary without typing the full path.
-                 The shortcut runs `sourcebox-sentry-cloudnode setup` since
-                 that's the most likely first action after install. -->
+            <!-- Start menu shortcut: smart launcher.
+                 No `Arguments=` attribute → the binary runs with no
+                 subcommand, which hits the bare-invocation path in
+                 main.rs. That path checks Config::load for existing
+                 credentials and chooses:
+                   - creds present → run_cloudnode (foreground TUI
+                     dashboard, cameras stream)
+                   - creds missing → run setup wizard, then
+                     run_cloudnode
+                 So the same shortcut handles both first-launch (runs
+                 the wizard then streams) and every-launch-after
+                 (just streams).
+                 The MSI Finish dialog's LaunchSetup CustomAction at
+                 the top of this file handles the very first launch
+                 after install via cmd /c start with `setup` arg
+                 explicitly — that's a separate code path because the
+                 Finish dialog needs to spawn a new console window.
+                 The shortcut here is what the operator clicks on
+                 every subsequent launch; previously it had
+                 `Arguments='setup'` which forced the wizard to re-
+                 prompt for credentials every single time. v0.1.33
+                 dropped the argument so the shortcut becomes a
+                 normal app launcher. -->
             <Directory Id='ProgramMenuFolder'>
                 <Directory Id='ApplicationProgramsFolder' Name='SourceBox Sentry CloudNode'>
                     <Component Id='cmpStartMenu'
                                Guid='9DAB7EBC-6F4F-4C3D-B05E-C2F8FAD47069'>
-                        <Shortcut Id='ShortcutSetup'
-                                  Name='SourceBox Sentry CloudNode Setup'
-                                  Description='Run the interactive setup wizard to enrol this machine.'
+                        <Shortcut Id='ShortcutLauncher'
+                                  Name='SourceBox Sentry CloudNode'
+                                  Description='Launch the CloudNode dashboard. Runs the setup wizard the first time, streams cameras every time after.'
                                   Target='[#filServiceExe]'
-                                  Arguments='setup'
                                   WorkingDirectory='APPLICATIONFOLDER' />
                         <RemoveFolder Id='RemoveProgramsFolder'
                                       Directory='ApplicationProgramsFolder'