Commit 29fa9bc
committed
cleanup: dead component, misleading label, dead-email contact paths
Three small UX/legal fixes for the public-eyes polish pass.
1. Delete EmptyState component + tests
─────────────────────────────────
``frontend/src/components/EmptyState.jsx`` exported a generic
empty-state primitive plus two pre-baked variants
(DiscoveringState, NoCamerasState). Verified via grep across
``frontend/src/`` that none of the three is imported anywhere
in the actual app — the dashboard's empty states are now
handled by ``WelcomeHero`` and ``MemberWelcomeHero`` shipped
in the first-touch UX work last week, and the install widget
handles the ``DiscoveringState`` use case in-context.
The file had a test file pinning its API. Tests-pinning-
dead-code is the worst-of-both-worlds shape — maintenance
cost for code nobody uses. Deleted both files; if anyone
needs the primitive back they pull it from git history.
2. Drop ``"(legacy)"`` from the recording_toggled audit label
─────────────────────────────────────────────────────────
``frontend/src/components/OrgAuditLogPanel.jsx`` had
"Recording toggled (legacy)" in the event-filter dropdown.
The backend at ``app/api/cameras.py:150`` actively emits
the event from the dashboard's manual record button (via
POST /api/cameras/{id}/recording). The "legacy" suffix
was wrong — the endpoint is a thin wrapper over
``continuous_24_7`` per its docstring, but it's a live
admin action with audit value. Renamed to
"Manual recording toggle" to match what it actually is.
3. Replace dead ``legal@sourcebox.dev`` with working channels
──────────────────────────────────────────────────────
Same dead-email pattern as the security.txt + welcome-email
fixes earlier this week — ``LegalPage.jsx`` had
``mailto:legal@sourcebox.dev`` in 4 contact paragraphs
(Terms, GDPR rights, CCPA rights, Privacy contact). The
address doesn't exist; ``sourceboxsentry.com`` isn't
provisioned for incoming mail yet. A bounced DSAR is a
real GDPR Article 12 violation once the first EU customer
files one.
Replaced with two working channels:
- **In-app self-serve** for Article 17 + 20 + CCPA delete:
Settings → Privacy & Data → Download my data (export)
and Danger Zone → Reset Everything (erasure). Both
shipped last week.
- **GitHub Issues** for everything else, with explicit
guidance not to paste PII in the public issue body
and a note that we'll arrange a private follow-up.
``CONTACT_EMAIL`` constant replaced with
``CONTACT_GITHUB_ISSUES_URL``. Module-top comment
documents the swap-back plan for when MX records land.
Frontend: 55 passing (was 60; -5 from the deleted EmptyState
suite). Build clean. Backend untouched.1 parent 6c93153 commit 29fa9bc
4 files changed
Lines changed: 68 additions & 122 deletions
File tree
- frontend
- src
- components
- pages
- tests/components
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
5 | 20 | | |
6 | 21 | | |
7 | 22 | | |
| |||
327 | 342 | | |
328 | 343 | | |
329 | 344 | | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
334 | 351 | | |
335 | | - | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
336 | 357 | | |
337 | 358 | | |
338 | 359 | | |
| |||
515 | 536 | | |
516 | 537 | | |
517 | 538 | | |
518 | | - | |
519 | | - | |
520 | | - | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
521 | 556 | | |
522 | 557 | | |
523 | 558 | | |
| |||
556 | 591 | | |
557 | 592 | | |
558 | 593 | | |
559 | | - | |
560 | | - | |
561 | | - | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
562 | 605 | | |
563 | 606 | | |
564 | 607 | | |
| |||
572 | 615 | | |
573 | 616 | | |
574 | 617 | | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
580 | 624 | | |
581 | | - | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
582 | 631 | | |
583 | 632 | | |
584 | 633 | | |
| |||
This file was deleted.
0 commit comments