fix(mcp-setup): pause before exit so the terminal stays open

User reported the script "just closes when you run it with the client
still on so I couldn't read the terminal." Confirmed root cause: when
the script is launched into a fresh PowerShell window (double-click,
Run dialog, or any parent process that runs powershell.exe and exits)
the host closes as soon as the script returns — wiping the
"Setup did NOT complete" / "Skipped (still running)" output the
previous commit was specifically meant to surface.

Add a Wait-ForExitKey / wait_for_exit_key call before each summary
exit point in both scripts. The pause:

  - Skips when SOURCEBOX_SENTRY_MCP_NO_PAUSE=1 (CI / scripted callers
    won't hang waiting for keyboard input)
  - Skips when there's no interactive console (PowerShell: not
    ConsoleHost or not UserInteractive; bash: no tty and no /dev/tty)
  - Otherwise prompts "Press Enter to close..." and reads one line

Only added to the three end-of-script summary exits, not the early
arg-validation / cancel exits — those don't fire after the user has
spent time selecting clients, so a sudden close isn't the same UX
trap.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Sbussiso

backend/scripts/mcp-setup.ps1

@@ -345,6 +345,23 @@ foreach ($idx in $selected) {
     Configure-Client -Name $c.Name -ConfigPath $c.Path
 }
 
+# Wait for the user before exiting so the terminal window doesn't slam
+# shut on them mid-summary.  Only relevant when the script was launched
+# into a fresh PowerShell window (double-click, "Run" dialog, or a
+# parent process that runs powershell.exe and exits) -- in those cases
+# the host closes as soon as the script returns.  Skip when:
+#   - SOURCEBOX_SENTRY_MCP_NO_PAUSE=1 (CI / scripted callers)
+#   - We're not in an interactive console (piped stdin, no UI)
+function Wait-ForExitKey {
+    if ($env:SOURCEBOX_SENTRY_MCP_NO_PAUSE -eq '1') { return }
+    if (-not [Environment]::UserInteractive) { return }
+    if ($Host.Name -ne 'ConsoleHost') { return }
+
+    Write-Host ""
+    Write-Host "  Press Enter to close..." -ForegroundColor DarkGray
+    try { $null = Read-Host } catch { }
+}
+
 # -- Summary -------------------------------------------
 #
 # Three possible end-states; pick the right banner + exit code for each.
@@ -399,6 +416,7 @@ if ($configuredCount -eq 0) {
     $dashUrl = $ServerUrl -replace "/mcp$", "/mcp"
     Write-Host "  $dashUrl" -ForegroundColor Cyan
     Write-Host ""
+    Wait-ForExitKey
     exit 1
 } elseif ($skippedCount -gt 0 -or $failedCount -gt 0) {
     # At least one configured, but at least one didn't.  Don't claim
@@ -416,6 +434,7 @@ if ($configuredCount -eq 0) {
     # Exit 0 -- the script did configure something, the user just needs
     # a follow-up run for the rest.  Use the warning banner to make that
     # visible without breaking shell pipelines that key off exit codes.
+    Wait-ForExitKey
     exit 0
 } else {
     # Clean success.
@@ -429,5 +448,6 @@ if ($configuredCount -eq 0) {
     $dashUrl = $ServerUrl -replace "/mcp$", "/mcp"
     Write-Host "  $dashUrl" -ForegroundColor Cyan
     Write-Host ""
+    Wait-ForExitKey
     exit 0
 }

backend/scripts/mcp-setup.sh

@@ -335,6 +335,24 @@ for idx in "${SELECTED[@]}"; do
     configure_client "${CLIENT_NAMES[$idx]}" "${CLIENT_CONFIGS[$idx]}"
 done
 
+# Wait for the user before exiting so a terminal launched just to run
+# this script doesn't slam shut on them mid-summary.  Skip when:
+#   - SOURCEBOX_SENTRY_MCP_NO_PAUSE=1 (CI / scripted callers)
+#   - We're not attached to a tty (curl|bash | piped output)
+wait_for_exit_key() {
+    if [[ "${SOURCEBOX_SENTRY_MCP_NO_PAUSE:-0}" == "1" ]]; then return; fi
+    # If neither stdin nor /dev/tty is usable, we're being piped or run
+    # under a context with no controlling terminal — don't block forever.
+    if [[ ! -t 0 ]] && [[ ! -e /dev/tty ]]; then return; fi
+    echo ""
+    echo -e "  ${DIM}Press Enter to close...${NC}"
+    if [[ -t 0 ]]; then
+        read -r _ || true
+    else
+        read -r _ </dev/tty || true
+    fi
+}
+
 # ── Summary ───────────────────────────────────────────
 #
 # Three possible end-states; pick the right banner + exit code for each.
@@ -394,6 +412,7 @@ if [[ $CONFIGURED_COUNT -eq 0 ]]; then
     echo -e "  ${DIM}Manage your MCP keys at:${NC}"
     echo -e "  ${CYAN}${DASHBOARD_URL}${NC}"
     echo ""
+    wait_for_exit_key
     exit 1
 elif [[ $SKIPPED_COUNT -gt 0 || $FAILED_COUNT -gt 0 ]]; then
     # At least one configured, but at least one didn't.  Don't claim
@@ -410,6 +429,7 @@ elif [[ $SKIPPED_COUNT -gt 0 || $FAILED_COUNT -gt 0 ]]; then
     # Exit 0 -- the script did configure something, the user just needs
     # a follow-up run for the rest.  Use the warning banner to make that
     # visible without breaking shell pipelines that key off exit codes.
+    wait_for_exit_key
     exit 0
 else
     # Clean success.
@@ -422,5 +442,6 @@ else
     echo -e "  ${DIM}Manage your MCP keys at:${NC}"
     echo -e "  ${CYAN}${DASHBOARD_URL}${NC}"
     echo ""
+    wait_for_exit_key
     exit 0
 fi