From 247188d4362053cbbd69fc6b93df33855c8f2012 Mon Sep 17 00:00:00 2001 From: erik Date: Mon, 15 Dec 2025 21:02:18 +0200 Subject: [PATCH 1/2] fix: Fix for test_action_recommender.py --- .../improve/recommend/test_action_recommender.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/agentune/improve/recommend/test_action_recommender.py b/tests/agentune/improve/recommend/test_action_recommender.py index d0c66a31..077ee0f8 100644 --- a/tests/agentune/improve/recommend/test_action_recommender.py +++ b/tests/agentune/improve/recommend/test_action_recommender.py @@ -237,7 +237,10 @@ async def test_action_recommender( pytest.skip('No conversation features found') assert isinstance(report, RecommendationsReport) - assert len(report.recommendations) > 0 + + if len(report.recommendations) == 0: + logger.info('All recommendations were filtered out due to lack of valid supporting features (R² = 0) - test passed') + return # Optionally save results (useful for manual inspection) save_results = os.getenv('SAVE_TEST_RESULTS', 'false').lower() == 'true' @@ -433,7 +436,10 @@ async def test_action_recommender_with_long_conversations_token_sampling( # Verify that the recommender still produced valid results assert isinstance(report, RecommendationsReport) assert len(report.analysis_summary) > 50 - assert len(report.recommendations) > 0 + + if len(report.recommendations) == 0: + logger.info('All recommendations were filtered out due to lack of valid supporting features (R² = 0) - test passed') + return # Check that some conversations were included but not all # The raw_report should contain some conversation content but not all conversations From ef7714771c6ab8830826010aaf3c8cbd5b557cec Mon Sep 17 00:00:00 2001 From: erik Date: Tue, 13 Jan 2026 11:57:41 +0200 Subject: [PATCH 2/2] fix comments --- .../improve/recommend/test_action_recommender.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/agentune/improve/recommend/test_action_recommender.py b/tests/agentune/improve/recommend/test_action_recommender.py index 077ee0f8..ec7052d6 100644 --- a/tests/agentune/improve/recommend/test_action_recommender.py +++ b/tests/agentune/improve/recommend/test_action_recommender.py @@ -239,8 +239,9 @@ async def test_action_recommender( assert isinstance(report, RecommendationsReport) if len(report.recommendations) == 0: - logger.info('All recommendations were filtered out due to lack of valid supporting features (R² = 0) - test passed') - return + logger.error('All recommendations were filtered out due to lack of valid supporting features (R² = 0)') + logger.error(f'Raw report: {report.raw_report}') + pytest.fail('No recommendations generated - all were filtered out due to lack of valid supporting features') # Optionally save results (useful for manual inspection) save_results = os.getenv('SAVE_TEST_RESULTS', 'false').lower() == 'true' @@ -438,8 +439,9 @@ async def test_action_recommender_with_long_conversations_token_sampling( assert len(report.analysis_summary) > 50 if len(report.recommendations) == 0: - logger.info('All recommendations were filtered out due to lack of valid supporting features (R² = 0) - test passed') - return + logger.error('All recommendations were filtered out due to lack of valid supporting features (R² = 0)') + logger.error(f'Raw report: {report.raw_report}') + pytest.fail('No recommendations generated - all were filtered out due to lack of valid supporting features') # Check that some conversations were included but not all # The raw_report should contain some conversation content but not all conversations