Background
Per pinned feedback_no_planning_artifact_test_names.md: test names describe behavior, not provenance; no T#/story#/ticket# prefixes. Pre-existing test files contain section headers and (potentially) test names that violate this rule with planning-artifact identifiers like be-F2, sec-M5, te-MED-1, arch2-M2, sec-F1, etc. These are tracker-style references to specific planning rounds, audit cycles, or finding IDs from prior work.
Surfaced by pact-test-engineer-620 review of PR #638 (docs/review/620-test-engineer-review.md, finding F3-te → relabeled F6 in synthesis).
Confirmed occurrences (incomplete)
In pact-plugin/tests/test_inbox_wake_lifecycle_emitter.py:
- L408 `# ---------- Terminal-status detection covers deleted (be-F2) ----------`
- L457 `# ---------- Lead-session guard (sec-M5 / te-MED-1) ----------`
- L523 `# ---------- Perf reorder (arch2-M2) ----------`
- L612 `# ---------- Stdin payload size limit (sec-F1) ----------`
Likely more across other test files; suite-wide scrub needed.
Scope
- Grep across `pact-plugin/tests/**` for planning-artifact identifier patterns: `be-F\d`, `sec-[MF]\d`, `te-(MED|HIGH|LOW)`, `arch\d?-[MF]\d`, similar.
- Rewrite section header comments and test names to describe BEHAVIOR, not planning-provenance.
- If load-bearing context exists, move citations to a docstring or comment INSIDE the test, not the test name or section header.
- Run full pact-plugin/tests/ to verify no behavior change.
Acceptance
- Grep for the patterns above returns zero matches in `pact-plugin/tests/`.
- Full test suite still passes.
- Section headers and test names describe what the test asserts, not which planning round added it.
Cross-references
Background
Per pinned
feedback_no_planning_artifact_test_names.md: test names describe behavior, not provenance; no T#/story#/ticket# prefixes. Pre-existing test files contain section headers and (potentially) test names that violate this rule with planning-artifact identifiers likebe-F2,sec-M5,te-MED-1,arch2-M2,sec-F1, etc. These are tracker-style references to specific planning rounds, audit cycles, or finding IDs from prior work.Surfaced by
pact-test-engineer-620review of PR #638 (docs/review/620-test-engineer-review.md, finding F3-te → relabeled F6 in synthesis).Confirmed occurrences (incomplete)
In
pact-plugin/tests/test_inbox_wake_lifecycle_emitter.py:Likely more across other test files; suite-wide scrub needed.
Scope
Acceptance
Cross-references