Refactor: wake_lifecycle hot-spot files exceed 600-line maintainability threshold

[michael-wojcik]

Context

Surfaced during CODE phase of PR for #781/#786/#760/#738 bundle (capture-shape HARD GATE), session pact-7642b0c9, 2026-05-19. Out of scope for that bundle — these files were already oversized before the bundle work began; that bundle's edits are minimal string-pin syncs, not the cause.

Affected files (current line counts at issue-file time)

File	Lines	Threshold
pact-plugin/hooks/wake_lifecycle_emitter.py	1041	600
pact-plugin/tests/test_wake_inbox_drain.py	1783	600
pact-plugin/tests/test_inbox_wake_lifecycle_emitter.py	1230	600
pact-plugin/tests/test_wake_lifecycle_emitter.py	869	600
pact-plugin/tests/test_wake_lifecycle_arm_edge_cases.py	683	600

The production hook (wake_lifecycle_emitter.py) is the most actionable — it consolidates Arm/Teardown directive emission, transition detection, lead-session guarding, session_init delegation, and journal-event paired-write logic in one file. Per the maintainability-warning hook's own recommendation:

• Single Responsibility: does wake_lifecycle_emitter.py do one thing? Currently combines directive emission + transition detection + lead-session guard + session_init delegation + journal-event coordination.
• Modular design: candidates for extraction:
  • shared/wake_directives.py — _ARM_DIRECTIVE / _TEARDOWN_DIRECTIVE constants + anti-softening guards
  • shared/wake_transitions.py — _decide_directive / _arm_or_none / count_active_tasks logic
  • shared/wake_journal.py — scan_armed / scan_disarmed paired-write coordination
• Test files: split by concern (per-helper test modules, fixture-driven shape pinning module, etc.).

Scope discipline

• ⚠️ DO NOT bundle into the TaskCompleted actor-discriminator empirical capture + teardown_request_emitter.py migration (follow-up to #611/#778) #781/Investigate: /PACT:start-pending-scan directive misrouting into teammate session (post-#611 fresh-session verification) #786/wake_lifecycle_emitter: strengthen scan-arm/teardown directives to 'You MUST' phrasing #760/wake_lifecycle_emitter directive misfires 'First active teammate task created' message on every task create #738 PR. That PR's commit-sequence (C1+C3a+C3b) is already scope-controlled per architect §4 R3; a refactor would balloon the diff and re-open the hook_infrastructure calibration risk (PR fix(#611, #778): in-process teammate wake-arm via agent_id field-presence discriminator #783 ex-ante 10 → ex-post 11; scope ~14 LOC → ~563 LOC via fix-all-in-PR fold-ins, per orchestration_calibration corpus).
• This issue is the follow-up tracking surface for the refactor as a separate workstream.

Suggested approach

1. /PACT:plan-mode consultation with pact-architect (the maintainability-warning hook's explicit recommendation) once TaskCompleted actor-discriminator empirical capture + teardown_request_emitter.py migration (follow-up to #611/#778) #781 bundle merges.
2. SEC-AC-2 disk-verify discipline applies: re-grep usage of every extracted symbol against pact-plugin/ to enumerate import sites before module reshuffle.
3. Counter-test-by-revert cardinality must be re-measured post-refactor — the test corpus codifying legacy contracts (TestStdinShapePin, TestGate0LeadSessionGuard, named-invariant tests landed by TaskCompleted actor-discriminator empirical capture + teardown_request_emitter.py migration (follow-up to #611/#778) #781) will need their import paths updated atomically with the source-module relocation.

Falsifier

Refactor lands; production hooks still behave byte-identically (same scan_armed / scan_disarmed events written, same _ARM_DIRECTIVE / _TEARDOWN_DIRECTIVE strings emitted, same lead-session guard semantics); test cardinality unchanged.

Provenance

• Session pact-7642b0c9, CODE-phase advisories triggered by backend-coder editing wake_lifecycle_emitter.py:185-197 for TaskCompleted actor-discriminator empirical capture + teardown_request_emitter.py migration (follow-up to #611/#778) #781/Investigate: /PACT:start-pending-scan directive misrouting into teammate session (post-#611 fresh-session verification) #786/wake_lifecycle_emitter: strengthen scan-arm/teardown directives to 'You MUST' phrasing #760/wake_lifecycle_emitter directive misfires 'First active teammate task created' message on every task create #738 bundle
• Maintainability-warning hook recommendation: "Use the pact-architect agent to analyze this file and design a refactoring strategy"
• NOT a bug — the hooks work correctly; this is technical-debt tracking