stdin入力で末尾改行のみを除去し先頭/末尾スペースを保持する修正#14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
get_input_textの stdin 分岐でread_lineによる末尾改行のみを除去し、ユーザが入力した先頭/末尾の空白を保持するための修正。\nDescription
get_input_textの(None, None)ブランチでinput.trim()をやめ、trim_trailing_newline(&input).to_string()を返すように変更しました。\ntrim_trailing_newlineを追加し、内部でtrim_end_matches(['\n', '\r'])を使用するように実装しました。\ntest_trim_trailing_newline_preserves_leading_and_trailing_spacesをsrc/cli.rsのtestsモジュールに追加しました。\nTesting
cargo test test_trim_trailing_newline_preserves_leading_and_trailing_spaces -- --nocaptureを実行し、追加したテストは成功しました。\nCodex Task