Enhance game state management and improve board visuals

- Updated the updateBoardVisuals function in game.js to include king check status for better visual feedback.
- Added getters for game state variables in game.js to facilitate easier access in tests and improve encapsulation.
- Refactored test setup in game-flow.test.js and game-moves.test.js to utilize new getters for game state, enhancing clarity and maintainability.
- Removed unnecessary console logs from pieces.js to clean up the initialization process.

Author: TMHSDigital

js/game.js

@@ -88,7 +88,7 @@ function resetGame() {
     renderPieces(boardState);
     updateStatusDisplay();
     updateMoveHistoryDisplay();
-    updateBoardVisuals(boardState);
+    updateBoardVisuals(boardState, findKingInCheck(currentPlayer));
 }
 
 /**
@@ -916,6 +916,15 @@ if (typeof module !== 'undefined' && module.exports) {
         isStalemate,
         canCastle,
         generateNotation,
-        generateNotationWithDisambiguation
+        generateNotationWithDisambiguation,
+        // Export state variables for test access
+        get boardState() { return boardState; },
+        get currentPlayer() { return currentPlayer; },
+        get moveHistory() { return moveHistory; },
+        get isGameOver() { return isGameOver; },
+        get kingPositions() { return kingPositions; },
+        get currentStatus() { return currentStatus; },
+        get enPassantTarget() { return enPassantTarget; },
+        get positionHistory() { return positionHistory; }
     };
 } 

js/pieces.js

@@ -103,28 +103,21 @@ function isPseudoLegalMove(piece, startRow, startCol, endRow, endCol, isCapture)
  * @returns {Array<Array<Piece|null>>} A 2D array representing the board state.
  */
 function getInitialPieces() {
-    console.log("Initializing pieces...");
     const board = Array(8).fill(null).map(() => Array(8).fill(null));
 
     // Place pawns
     for (let col = 0; col < 8; col++) {
         board[1][col] = new Piece(PAWN, BLACK);
         board[6][col] = new Piece(PAWN, WHITE);
-        console.log(`Created pawns at: [1,${col}] (Black) and [6,${col}] (White)`);
     }
 
     // Place other pieces
     const backRank = [ROOK, KNIGHT, BISHOP, QUEEN, KING, BISHOP, KNIGHT, ROOK];
     for (let col = 0; col < 8; col++) {
         board[0][col] = new Piece(backRank[col], BLACK);
         board[7][col] = new Piece(backRank[col], WHITE);
-        console.log(`Created ${backRank[col]} at: [0,${col}] (Black) and [7,${col}] (White)`);
     }
 
-    // Log the first row to validate
-    console.log("First row (black pieces):", board[0].map(p => p ? p.type : 'null'));
-    console.log("Last row (white pieces):", board[7].map(p => p ? p.type : 'null'));
-
     return board;
 }
 

tests/integration/game-flow.test.js

@@ -59,9 +59,48 @@ describe('integration: game flow', () => {
     initializeGame = game.initializeGame;
     handleBoardClick = game.handleBoardClick;
 
+    // Set up game state globals that board.js functions expect
+    // Use getters to always reference current state
+    Object.defineProperty(global, 'moveHistory', {
+      get: () => game.moveHistory,
+      configurable: true
+    });
+    Object.defineProperty(global, 'boardState', {
+      get: () => game.boardState,
+      configurable: true
+    });
+    Object.defineProperty(global, 'currentPlayer', {
+      get: () => game.currentPlayer,
+      configurable: true
+    });
+    Object.defineProperty(global, 'isGameOver', {
+      get: () => game.isGameOver,
+      configurable: true
+    });
+    Object.defineProperty(global, 'kingPositions', {
+      get: () => game.kingPositions,
+      configurable: true
+    });
+    Object.defineProperty(global, 'currentStatus', {
+      get: () => game.currentStatus,
+      configurable: true
+    });
+    Object.defineProperty(global, 'enPassantTarget', {
+      get: () => game.enPassantTarget,
+      configurable: true
+    });
+    Object.defineProperty(global, 'positionHistory', {
+      get: () => game.positionHistory,
+      configurable: true
+    });
+    
     // Also attach to window for code that expects window.*
     window.initializeGame = initializeGame;
     window.handleBoardClick = handleBoardClick;
+    Object.defineProperty(window, 'moveHistory', {
+      get: () => game.moveHistory,
+      configurable: true
+    });
 
     initializeGame();
   });

tests/unit/game-moves.test.js

@@ -51,10 +51,49 @@ describe('game core', () => {
     handleBoardClick = game.handleBoardClick;
     generateLegalMovesForPiece = game.generateLegalMovesForPiece;
 
+    // Set up game state globals that board.js functions expect
+    // Use getters to always reference current state
+    Object.defineProperty(global, 'moveHistory', {
+      get: () => game.moveHistory,
+      configurable: true
+    });
+    Object.defineProperty(global, 'boardState', {
+      get: () => game.boardState,
+      configurable: true
+    });
+    Object.defineProperty(global, 'currentPlayer', {
+      get: () => game.currentPlayer,
+      configurable: true
+    });
+    Object.defineProperty(global, 'isGameOver', {
+      get: () => game.isGameOver,
+      configurable: true
+    });
+    Object.defineProperty(global, 'kingPositions', {
+      get: () => game.kingPositions,
+      configurable: true
+    });
+    Object.defineProperty(global, 'currentStatus', {
+      get: () => game.currentStatus,
+      configurable: true
+    });
+    Object.defineProperty(global, 'enPassantTarget', {
+      get: () => game.enPassantTarget,
+      configurable: true
+    });
+    Object.defineProperty(global, 'positionHistory', {
+      get: () => game.positionHistory,
+      configurable: true
+    });
+    
     // Also attach to window for code that expects window.*
     window.initializeGame = initializeGame;
     window.handleBoardClick = handleBoardClick;
     window.generateLegalMovesForPiece = generateLegalMovesForPiece;
+    Object.defineProperty(window, 'moveHistory', {
+      get: () => game.moveHistory,
+      configurable: true
+    });
 
     initializeGame();
   });