From 0ebadda10050cb231660b274126424397ace6031 Mon Sep 17 00:00:00 2001 From: Patrick Wehbe Date: Sat, 20 Jun 2026 20:50:55 +0300 Subject: [PATCH] docs: correct withFieldGroup props runtime note The withFieldGroup props comment said the props are "not used at runtime", but they are. In createFormHook the render call spreads them (render({ ...props, ...innerProps, group })), so they act as default values that innerProps can override, the same as withForm does with render({ ...props, ...innerProps }). The withForm docs already describe this correctly as default values, so this updates the react, solid and preact copies to match. Closes #2099 --- docs/framework/preact/guides/form-composition.md | 2 +- docs/framework/react/guides/form-composition.md | 2 +- docs/framework/solid/guides/form-composition.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/framework/preact/guides/form-composition.md b/docs/framework/preact/guides/form-composition.md index 66b2da4b0..cb9923fac 100644 --- a/docs/framework/preact/guides/form-composition.md +++ b/docs/framework/preact/guides/form-composition.md @@ -345,7 +345,7 @@ const FieldGroupPasswordFields = withFieldGroup({ // Optional, but adds props to the `render` function in addition to `form` props: { - // These default values are also for type-checking and are not used at runtime + // These props are set as default values for the `render` function title: 'Password', }, // Internally, you will have access to a `group` instead of a `form` diff --git a/docs/framework/react/guides/form-composition.md b/docs/framework/react/guides/form-composition.md index 81f7e8d7d..b782a5a8b 100644 --- a/docs/framework/react/guides/form-composition.md +++ b/docs/framework/react/guides/form-composition.md @@ -418,7 +418,7 @@ const FieldGroupPasswordFields = withFieldGroup({ // Optional, but adds props to the `render` function in addition to `form` props: { - // These default values are also for type-checking and are not used at runtime + // These props are set as default values for the `render` function title: 'Password', }, // Internally, you will have access to a `group` instead of a `form` diff --git a/docs/framework/solid/guides/form-composition.md b/docs/framework/solid/guides/form-composition.md index 053aa0831..2325694eb 100644 --- a/docs/framework/solid/guides/form-composition.md +++ b/docs/framework/solid/guides/form-composition.md @@ -258,7 +258,7 @@ const FieldGroupPasswordFields = withFieldGroup({ // Optional, but adds props to the `render` function in addition to `form` props: { - // These default values are also for type-checking and are not used at runtime + // These props are set as default values for the `render` function title: 'Password', }, // Internally, you will have access to a `group` instead of a `form`