From 1f1dbcb8716c877d7665abbc9fbdd6690a216920 Mon Sep 17 00:00:00 2001 From: AlexKlimenkov Date: Fri, 21 Dec 2018 16:24:10 +0300 Subject: [PATCH 1/2] [fix] node/getRequest.js code example --- node/getRequest.js | 41 ++++++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/node/getRequest.js b/node/getRequest.js index cf59603..007deec 100644 --- a/node/getRequest.js +++ b/node/getRequest.js @@ -1,30 +1,29 @@ -var http = require('request'); -var company = "YOUR_TEAMWORK_SITE_NAME"; -var key = "YOUR_API_KEY"; - -var base64 = new Buffer(key + ":xxx").toString("base64"); - -var options = { - hostname: company + ".teamwork.com", - path: "/projects.json", +const request = require('request'); +const company = "YOUR_TEAMWORK_SITE_NAME"; +const key = "YOUR_API_KEY"; + +const base64 = Buffer.from(key + ":xxx").toString("base64"); + +const options = { + uri: `https://${company}.teamwork.com/projects.json`, method: "GET", headers: { - "Authorization": "BASIC " + base64, + "Authorization": `BASIC ${base64}`, "Content-Type": "application/json" } }; -var req = request(options, function(res) { - console.log("STATUS: " + res.statusCode); - console.log("HEADERS: " + JSON.stringify(res.headers)); +const req = request(options, (error, res, body) => { + if (error) { + console.log(`ERROR: ${error.message}`); + return; + } + + console.log(`STATUS: ${res.statusCode}`); + console.log(`HEADERS: ${JSON.stringify(res.headers)}`); res.setEncoding("utf8"); - res.on("data", function (chunk) { - console.log("BODY: " + chunk); - }); + + console.log(`BODY: ${body}`); }); - -req.on("error", function(e) { - console.log("ERROR: " + e.message); -}); - + req.end(); \ No newline at end of file From 707a73d1e4b2d937b5c6d7b377a11ad87d558a3e Mon Sep 17 00:00:00 2001 From: AlexKlimenkov Date: Fri, 21 Dec 2018 18:20:02 +0300 Subject: [PATCH 2/2] [fix] node/getRequest.js - switch back to http module --- node/getRequest.js | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/node/getRequest.js b/node/getRequest.js index 007deec..68d981d 100644 --- a/node/getRequest.js +++ b/node/getRequest.js @@ -1,29 +1,30 @@ -const request = require('request'); +const http = require('http'); const company = "YOUR_TEAMWORK_SITE_NAME"; const key = "YOUR_API_KEY"; -const base64 = Buffer.from(key + ":xxx").toString("base64"); +const base64 = Buffer.from(`${key}:xxx`).toString("base64"); const options = { - uri: `https://${company}.teamwork.com/projects.json`, + hostname: `${company}.teamwork.com`, + path: "/projects.json", method: "GET", headers: { "Authorization": `BASIC ${base64}`, "Content-Type": "application/json" } }; - -const req = request(options, (error, res, body) => { - if (error) { - console.log(`ERROR: ${error.message}`); - return; - } +const req = http.request(options, function(res) { console.log(`STATUS: ${res.statusCode}`); console.log(`HEADERS: ${JSON.stringify(res.headers)}`); res.setEncoding("utf8"); + res.on("data", function (chunk) { + console.log(`BODY: ${chunk}`); + }); +}); - console.log(`BODY: ${body}`); +req.on("error", function(e) { + console.log(`ERROR: ${error.message}`); }); req.end(); \ No newline at end of file