From 92d22c030929fb43e6e1d916568667679977f88a Mon Sep 17 00:00:00 2001 From: "Terry.Mao" Date: Wed, 10 Jun 2026 12:23:05 +0800 Subject: [PATCH] fix(update-triage): treat maintainer login as additive --- .../update-triage/scripts/aggregate_triage_feedback.py | 4 ++-- .../aicodingflow-tests/test_aggregate_triage_feedback.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.agents/skills/update-triage/scripts/aggregate_triage_feedback.py b/.agents/skills/update-triage/scripts/aggregate_triage_feedback.py index ab9c82bd..4375491d 100644 --- a/.agents/skills/update-triage/scripts/aggregate_triage_feedback.py +++ b/.agents/skills/update-triage/scripts/aggregate_triage_feedback.py @@ -333,8 +333,8 @@ def is_maintainer_signal( return False if is_bot_user(login, typename) and not include_bots: return False - if maintainer_logins: - return login in maintainer_logins + if maintainer_logins and login in maintainer_logins: + return True if association in MAINTAINER_ASSOCIATIONS: return True if org_member_fallback: diff --git a/.github/aicodingflow-tests/test_aggregate_triage_feedback.py b/.github/aicodingflow-tests/test_aggregate_triage_feedback.py index b87c03c7..827c16f1 100644 --- a/.github/aicodingflow-tests/test_aggregate_triage_feedback.py +++ b/.github/aicodingflow-tests/test_aggregate_triage_feedback.py @@ -276,8 +276,8 @@ def test_org_member_fallback_uses_permission_cache(self) -> None: ) ) - def test_maintainer_login_allowlist_restricts_other_maintainers(self) -> None: - self.assertFalse( + def test_maintainer_login_adds_to_association_and_fallback_sources(self) -> None: + self.assertTrue( aggregate.is_maintainer_signal( repo="o/r", login="other-maintainer", @@ -285,7 +285,7 @@ def test_maintainer_login_allowlist_restricts_other_maintainers(self) -> None: maintainer_logins={"target-maintainer"}, ) ) - self.assertFalse( + self.assertTrue( aggregate.is_maintainer_signal( repo="o/r", login="other-maintainer",