For the review:
Better example
A simplier example than exampleCitiesHover would be nice.
Something simple, a circle when pressed or hovered that changed its color.
Remove the GeoViewPickingEvent
There is an event named GeoViewPickingEvent.
I found it very confusing.
This event is trigger by GeoViewInteractionsStrategy every time you try to select any (or zero) objects.
I would rename this event GeoCursorPressedEvent or GeoViewObjectSelectionPickingEvent
=> @Nyan11 I will refactor this event in OpenSmock, with a new name (soon).
Fix the GeoViewLayerEvent
GeoViewLayerRemovedEvent and GeoViewLayerAddedEvent should herit GeoViewLayerEvent
=> @Nyan11 I will refactor these events in OpenSmock, with a correct hierarchy (soon).
Originally posted by @Nyan11 in #158 (comment)
For the review:
Better example
A simplier example than exampleCitiesHover would be nice.
Something simple, a circle when pressed or hovered that changed its color.
Remove the GeoViewPickingEvent
There is an event named GeoViewPickingEvent.
I found it very confusing.
This event is trigger by GeoViewInteractionsStrategy every time you try to select any (or zero) objects.
I would rename this event GeoCursorPressedEvent or GeoViewObjectSelectionPickingEvent
=> @Nyan11 I will refactor this event in OpenSmock, with a new name (soon).
Fix the GeoViewLayerEvent
GeoViewLayerRemovedEvent and GeoViewLayerAddedEvent should herit GeoViewLayerEvent
=> @Nyan11 I will refactor these events in OpenSmock, with a correct hierarchy (soon).
Originally posted by @Nyan11 in #158 (comment)