Handling refunds

[PavelGutin]

Have you given any thoughts on how to handle refunds? A refund_total field is available in the transaction from amazon-data. And YNAB transaction in case of a refund would be positive. But I am running into a wall when trying to use this information. I just can't see a way to figure out a consistent way to get the tool to match a transaction. Ideally, I'd want to see a refund transaction get handled just a like a regular one but there are at least three issues I can see right away:

• The amounts will rarely match exactly due to taxes
• A single refund transaction can have multiple items
• A single purchase may result in multiple refund transactions

This is the only thing that's keeping from fully embracing this workflow.

[TheFern2]

I wonder if this can be done by matching order number and checking total, if total has changed, we can assume a refund was made. Then add a split with the refund as in flow. I think it will be pita for sure, will need some thinking on this one. I hadn't thought about refunds until now, I barely deal with refunds.

[PavelGutin]

I opened an issue with amazon-orders to see if that's something that can be done on their end. alexdlaird/amazon-orders#64

[TheFern2]

I would think if would be more of an application handling, than the library, the library job is just to fill data into the order transaction.

[PavelGutin]

The library does provide information about orders, so knowing what items from the order have been returned doesn't seem like too much of a stretch for me. But, I do see your point.

[TheFern2]

yeah from a design POV, the only sane way to do it would be to keep amazon_orders_old.json, and when fetching new orders again compare with old ones by id. The library won't know, it just knows orders as they come. I think is doable, let's get current PR done first, then I need to do some clean up. Then this can be tackled.