From e6f13966d2c24bf82768e7e2d2109e89566c720b Mon Sep 17 00:00:00 2001 From: Guilherme Pimenta Date: Wed, 15 Apr 2026 18:46:09 -0300 Subject: [PATCH] fix(playground): remove broken UMD fallback and add favicon The playground fell back to the UMD build (ts.js) when the IIFE failed to load. The UMD treats @topsort/sdk as an external dependency, so in a browser without a bundler, TopsortClient is undefined and all events are silently dropped after detection. - Remove UMD fallback since it can never work standalone in a browser - Stop deploying ts.js to the playground (unused) - Add empty favicon to suppress 404 Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/deploy-playground.yml | 1 - demo/index.html | 10 ++++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/deploy-playground.yml b/.github/workflows/deploy-playground.yml index 70b6c37..5087f50 100644 --- a/.github/workflows/deploy-playground.yml +++ b/.github/workflows/deploy-playground.yml @@ -51,7 +51,6 @@ jobs: mkdir -p _site/dist cp demo/index.html _site/index.html cp dist/ts.iife.js _site/dist/ts.iife.js - cp dist/ts.js _site/dist/ts.js - name: Upload artifact uses: actions/upload-pages-artifact@v4 diff --git a/demo/index.html b/demo/index.html index 92abccc..d8d5c72 100644 --- a/demo/index.html +++ b/demo/index.html @@ -3,6 +3,7 @@ + analytics.js Playground