Skip to content

[Bug] Incomplete version synchronization in release-gui.yml #2

@ZhanZiyuan

Description

@ZhanZiyuan

Description:

In release-gui.yml, the workflow synchronizes the version from cli/package.json to gui/src-tauri/Cargo.toml using sed. However, Tauri requires the version to be consistent across multiple files for a correct build and updater metadata.

Issues:

  • tauri.conf.json ignored: The version field in gui/src-tauri/tauri.conf.json is not updated. This version is what Tauri uses for the actual application bundle and the auto-updater.
  • Cargo.lock inconsistency: Updating Cargo.toml via sed without running a subsequent cargo command might lead to an out-of-sync Cargo.lock in some environments, although the current build might pass.

Suggested Solution:

  • Update the sync step to also modify gui/src-tauri/tauri.conf.json.

  • Use a tool like jq to safely update the JSON file:

    jq '.version = "'$version'"' gui/src-tauri/tauri.conf.json > temp.json && mv temp.json gui/src-tauri/tauri.conf.json

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdocumentationImprovements or additions to documentationduplicateThis issue or pull request already existsenhancementNew feature or requestgood first issueGood for newcomershelp wantedExtra attention is neededinvalidThis doesn't seem rightquestionFurther information is requestedwontfixThis will not be worked on

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions