-
Notifications
You must be signed in to change notification settings - Fork 0
[Bug] Incomplete version synchronization in release-gui.yml #2
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightquestionFurther information is requestedFurther information is requestedwontfixThis will not be worked onThis will not be worked on
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightquestionFurther information is requestedFurther information is requestedwontfixThis will not be worked onThis will not be worked on
Description:
In
release-gui.yml, the workflow synchronizes the version fromcli/package.jsontogui/src-tauri/Cargo.tomlusingsed. However, Tauri requires the version to be consistent across multiple files for a correct build and updater metadata.Issues:
tauri.conf.jsonignored: Theversionfield ingui/src-tauri/tauri.conf.jsonis not updated. This version is what Tauri uses for the actual application bundle and the auto-updater.Cargo.lockinconsistency: UpdatingCargo.tomlviasedwithout running a subsequent cargo command might lead to an out-of-syncCargo.lockin some environments, although the current build might pass.Suggested Solution:
Update the sync step to also modify
gui/src-tauri/tauri.conf.json.Use a tool like
jqto safely update the JSON file: