Support manual tag ordering within inner repeating groups#41
Open
mobiletradingpartners wants to merge 2 commits intoTrumid:masterfrom
Open
Support manual tag ordering within inner repeating groups#41mobiletradingpartners wants to merge 2 commits intoTrumid:masterfrom
mobiletradingpartners wants to merge 2 commits intoTrumid:masterfrom
Conversation
Adding support for manual tags order for inner repeating group
anon-sportycto
approved these changes
Oct 4, 2017
|
Oh God this would've saved me loads of time a month or so ago. LGTM. Why's it not merged yet? I had to hack in the correct order by using a group within a group within a group. @mobiletradingpartners who should we chase/tag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for manual tags order within inner repeating groups, it requires that the special JS field 'order' is provided for that group. This is required by some LPs. For example:
'order': [11, 1, 55, 54, 60, 38, 40, 44, 59],
Patch developed by our colleague Bohdan Kovalchuk