Skip to content

Level-as-Time-Series retrieval has overlapping times for non-UTC tz with small intervals #1606

@zack-rma

Description

@zack-rma

Describe the bug
Using a non-UTC time zone with a small regular interval (<1hr) to retrieve levels as time series data results in overlapping times that cause issues downstream. These overlapping times occur on DST crossover points, suggesting DST is not being handled correctly. Most likely an issue with this method: https://github.com/USACE/cwms-data-api/blob/develop/cwms-data-api/src/main/java/cwms/cda/data/dao/LocationLevelsDaoImpl.java#L997

Expected behavior
Successful retrieval of data with non-UTC time zone and any regular interval.

To Reproduce
See #1605 for reproduction test.

CDA Version (please complete the following information):
Latest develop.

Additional context
Breaks within the AbstractRegularTimeSeries class of HCDA when times are checked to verify that they are increasing. This causes retrieval failure in projects using the HCDA level retrieval as time series method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions