Skip to content

[REVIEW] agentic-top-10: add tool-output taint and delegated capability evidence gates #1581

@wangedmund77-cmyk

Description

@wangedmund77-cmyk

Skill Being Reviewed

Skill name: agentic-top-10
Skill path: skills/ai-security/agentic-top-10/SKILL.md

False Positive Analysis

Benign code/configuration that can be over-flagged:

worker_agent can summarize docs; orchestrator validates signed tool result envelope before taking action

Why this is a false positive:
worker_agent can summarize docs; orchestrator validates signed tool result envelope before taking action can be safe when the missing compensating evidence is present, but the current skill does not ask reviewers to distinguish that evidence from the risky pattern. The review should require proof of the guardrail before escalating severity.

Coverage Gaps

Missed variant 1:

tool_result = web_fetch(url)
agent_context.append(tool_result)
# tool output can instruct the agent to call deploy_production

Why it should be caught:
This variant leaves a realistic attack path open while still satisfying the current high-level checklist language.

Missed variant 2:

research_agent asks executor_agent to run shell command
# executor does not verify requester capability or original user approval

Why it should be caught:
This is a common production edge case where policy exists on paper but does not bind the runtime behavior or evidence trail.

Edge Cases

The skill covers excessive agency and trust boundaries, but tool outputs and delegated agent messages need a taint model so untrusted content cannot become instructions or inherited authority.

Remediation Quality

  • Fix resolves the vulnerability
  • Fix doesn't introduce new security issues
  • Fix doesn't break functionality
  • Issues found: Add gates for tool-output trust labels, signed result envelopes, instruction/data separation, delegated capability checks, original-user approval propagation, and audit logs tying tool calls to the requesting agent.

Comparison to Other Tools

Tool Catches this? Notes
Prompt-injection scanners Partial Can test direct injections, less reliable for multi-hop delegation.
Agent framework logs Partial Useful only if identity and capability context are recorded.
Traditional SAST No Does not model agent/tool semantic authority.

Overall Assessment

Strengths:
The skill has strong coverage of agent permissions, memory, and trust boundaries.

Needs improvement:
It should make taint propagation through tool outputs and delegated agent requests explicit.

Priority recommendations:

  1. Add a tool-output taint model with instruction/data separation checks.
  2. Require delegated capability verification for every agent-to-agent request.
  3. Require audit evidence that records requester agent, user approval scope, and resulting tool call.

Bounty Info

  • I have read and agree to the CONTRIBUTING.md bounty terms
  • Preferred payment method: Crypto or PayPal after maintainer acceptance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions