[BUG]: Global Search Modal does not index Cover Letters and routes to wrong paths

[Gautam25Raj]

Affected Apps / Packages

Studio (apps/studio)

Description

The global search shortcut (Ctrl + K) only searches through resumes, leaving out Cover Letters entirely. Furthermore, selection routing in StudioShell.tsx is hardcoded to /editor/resume/${id}, which causes navigation errors when non-resume document types are selected.

Steps to Reproduce

1. Press Ctrl + K to open the search modal.
2. Search for an existing Cover Letter; notice it does not appear in the results.
3. Observe that selecting a search item redirects to /editor/resume/[id] unconditionally.

Expected Behavior

The search modal should query and index both resumes and cover letters, and routing should dynamically dispatch to /editor/resume/[id] or /editor/cover_letter/[id] based on the document type.

Environment Information

• OS: Windows
• Browser: Chrome / Edge
• Node.js: 20.x

Relevant Logs

No response

Proposed Fix / Suggestions

1. Search Integration: Refactor WorkspaceSearchModal to retrieve documents using getDocumentLibrarySnapshot() (which unifies Resumes and Cover Letters):

   // In apps/studio/components/dashboard/WorkspaceSearchModal.tsx:
   const docs = getDocumentLibrarySnapshot();

2. Dynamic Routing: Pass document type back in the onOpenDocument callback in StudioShell.tsx and route conditionally:

   onOpenDocument={(id, type) => router.push(`/editor/${type.toLowerCase()}/${id}`)}

[franko-c]

looks like the search is already indexing all types — listDocuments() in document-workspace-service.ts:48 returns ["RESUME", "COVER_LETTER", "FORMAL_LETTER", "INVOICE"] when called without a type arg, and WorkspaceSearchModal.tsx:43 calls it that way. cover letters should already appear in results.

the routing is the part that's broken. StudioShell.tsx passes onOpenDocument={() => router.push("/documents")} — the id from the search result is discarded entirely, so clicking any result just navigates back to the documents list rather than opening the document. the callback signature in WorkspaceSearchModal is (id: string) => void but doc.type is already available in the search results:

// WorkspaceSearchModal.tsx — pass type alongside id
onOpenDocument: (id: string, type: DocumentType) => void;
// ...
onClick={() => { onClose(); onOpenDocument(doc.id, doc.type); }}

// StudioShell.tsx — route by type
onOpenDocument={(id, type) => router.push(`/editor/${type.toLowerCase()}/${id}`)}

also noticed the empty state text on line ~114 says "Try another resume title or role." — might want to update that to "document" since formal letters and invoices are also searchable now. haven't checked whether the /editor/cover_letter/[id] route actually exists yet or if it needs creating — the routing fix above assumes it does.

[Gautam25Raj]

Thanks for taking a look at this.

To clarify the current implementation details in the codebase:

• Search Indexing: The search modal currently calls listSavedResumes() (not listDocuments()), which is why Cover Letters do not appear in the results. We will refactor this to use getDocumentLibrarySnapshot() to unify them.
• Current Routing: Selecting a search result routes to /editor/resume/${id} (it does not discard the ID to go to /documents), which is why it breaks for non-resume types.
• Document Types: The active schema only defines RESUME and COVER_LETTER at this time. FORMAL_LETTER and INVOICE will be added later.

The suggestion to update onOpenDocument to accept a document type and route dynamically is correct. We will update the search modal to index all documents and implement dynamic routing in an upcoming PR.

[franko-c]

from what I can see, my mistake — I was looking at listDocuments in the service layer and missed that the search modal calls listSavedResumes() directly. once search uses getDocumentLibrarySnapshot(), does StudioShell also need a route update? the current /editor/resume/${id} path would still hardcode the resume route for cover letter results.

[Gautam25Raj]

Spot on, you are absolutely correct. If we only updated the search indexing, cover letters would still route to /editor/resume/${id} and fail.

We have addressed this in a recent PR (#95) that is now merged into main. The routing in StudioShell has been updated to be fully dynamic:

1. Dynamic Routing: In StudioShell.tsx, onOpenDocument now receives the full document object and uses a helper to generate paths dynamically:

   onOpenDocument={(doc) => router.push(getDocumentEditorPath(doc.type, doc.id))}

2. Unified Path Generation: getDocumentEditorPath resolves the correct route based on the document type:

   export function getDocumentEditorPath(type: DocumentType, id: string) {
     return `/editor/${type.toLowerCase()}/${id}`;
   }

3. Unified Indexing: WorkspaceSearchModal.tsx now queries all workspace documents instead of just resumes:

   const documents: SearchResult[] = listDocuments().map((document) => {
     const definition = getDocumentDefinition(document.type);
      return {
        id: document.id,
        type: document.type,
        title: document.title,
        subtitle: definition.label,
        updatedAt: document.updatedAt,
      };
   });

Thanks for double-checking and calling this out!