From 98deb73d225ce13064085522141b5418c1a54f49 Mon Sep 17 00:00:00 2001
From: owaisahmed5300 <owaisahmed5300@gmail.com>
Date: Wed, 26 Nov 2025 21:08:54 +0500
Subject: [PATCH] feat(ruleset)!: upgrade slevomat to 8.22 and enforce strict
 config

---
 WPTechnix/ruleset.xml | 55 +++++++++++++++++++++++++++++++++----------
 composer.json         |  2 +-
 2 files changed, 44 insertions(+), 13 deletions(-)

diff --git a/WPTechnix/ruleset.xml b/WPTechnix/ruleset.xml
index 4991b5d..029e2c4 100644
--- a/WPTechnix/ruleset.xml
+++ b/WPTechnix/ruleset.xml
@@ -143,6 +143,7 @@
         <properties>
             <property name="checkPromoted" value="true" />
             <property name="allowReadonly" value="true" />
+            <property name="allowNonPublicSet" value="true" />
         </properties>
     </rule>
 
@@ -433,7 +434,16 @@
 
     <rule ref="SlevomatCodingStandard.Classes.RequireSelfReference"/>
     <rule ref="SlevomatCodingStandard.Classes.TraitUseDeclaration"/>
-    <rule ref="SlevomatCodingStandard.Classes.TraitUseSpacing"/>
+    <rule ref="SlevomatCodingStandard.Classes.TraitUseSpacing">
+        <properties>
+            <property name="linesCountBeforeFirstUse" value="1"/>
+            <property name="linesCountBeforeFirstUseWhenFirstInClass" value="0"/>
+            <property name="linesCountBetweenUses" value="0"/>
+            <property name="linesCountAfterLastUse" value="1"/>
+            <property name="linesCountAfterLastUseWhenLastInClass" value="1"/>
+        </properties>
+    </rule>
+
     <rule ref="SlevomatCodingStandard.Classes.UselessLateStaticBinding"/>
 
     <!-- ################################################################## -->
@@ -587,7 +597,11 @@
 
     <rule ref="SlevomatCodingStandard.ControlStructures.LanguageConstructWithParentheses"/>
     <rule ref="SlevomatCodingStandard.ControlStructures.NewWithParentheses"/>
-    <rule ref="SlevomatCodingStandard.ControlStructures.RequireTernaryOperator"/>
+    <rule ref="SlevomatCodingStandard.ControlStructures.RequireTernaryOperator">
+        <properties>
+            <property name="ignoreMultiLine" value="false" />
+        </properties>
+    </rule>
     <rule ref="SlevomatCodingStandard.ControlStructures.UselessIfConditionWithReturn"/>
     <rule ref="SlevomatCodingStandard.ControlStructures.UselessTernaryOperator"/>
 
@@ -603,8 +617,6 @@
         </properties>
     </rule>
 
-    <rule ref="SlevomatCodingStandard.Files.TypeNameMatchesFileName"/>
-
     <!-- ################################################################## -->
     <!-- ##                        FUNCTIONS                             ## -->
     <!-- ################################################################## -->
@@ -650,13 +662,32 @@
 
     <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly">
         <properties>
-            <property name="searchAnnotations" value="true"/>
-            <property name="allowFullyQualifiedGlobalClasses" value="false"/>
+
+            <!-- ALLOW USING BUILT-IN GLOBAL FUNCTIONS WITHOUT IMPORTS -->
+            <property name="allowFallbackGlobalFunctions" value="true"/>
+
+            <!-- ALLOW USING BUILT-IN GLOBAL CONSTANTS WITHOUT IMPORTS -->
+            <property name="allowFallbackGlobalConstants" value="true"/>
+
+            <!-- ALLOW USING BUILT-IN CLASSES/FUNCTIONS/CONSTANTS WITH LEADING \ -->
+            <property name="allowFullyQualifiedGlobalClasses" value="true"/>
             <property name="allowFullyQualifiedGlobalFunctions" value="true"/>
             <property name="allowFullyQualifiedGlobalConstants" value="true"/>
-            <property name="allowFallbackGlobalFunctions" value="false"/>
-            <property name="allowFallbackGlobalConstants" value="false"/>
+
+            <!-- DISALLOW PARTIAL NAMESPACE IMPORTS (best practice) -->
             <property name="allowPartialUses" value="false"/>
+
+            <!-- KEEP DEFAULT BEHAVIOR EVEN IN FILES WITHOUT A NAMESPACE -->
+            <property name="allowWhenNoNamespace" value="true"/>
+
+            <!-- KEEP DEFAULTS FOR ADVANCED OPTIONS YOU DO NOT NEED -->
+            <!-- searchAnnotations: leave false -->
+            <!-- namespacesRequiredToUse: leave unset -->
+            <!-- allowFullyQualifiedExceptions: leave unset -->
+            <!-- specialExceptionNames: leave unset -->
+            <!-- ignoredNames: leave unset -->
+            <!-- allowFullyQualifiedNameForColliding*: leave unset -->
+
         </properties>
     </rule>
 
@@ -723,7 +754,7 @@
 
     <rule ref="SlevomatCodingStandard.PHP.UselessParentheses">
         <properties>
-            <property name="ignoreComplexTernaryConditions" value="false"/>
+            <property name="ignoreComplexTernaryConditions" value="true" />
         </properties>
     </rule>
 
@@ -814,10 +845,10 @@
         </properties>
     </rule>
     <rule ref="Squiz.Commenting.VariableComment" />
-<!--    <rule ref="Squiz.Commenting.BlockComment" />-->
-<!--    <rule ref="Squiz.Commenting.FileComment" />-->
+    <!--    <rule ref="Squiz.Commenting.BlockComment" />-->
+    <!--    <rule ref="Squiz.Commenting.FileComment" />-->
     <rule ref="Squiz.Commenting.ClassComment" />
-<!--    <rule ref="Squiz.Commenting.FunctionComment"/>-->
+    <!--    <rule ref="Squiz.Commenting.FunctionComment"/>-->
     <rule ref="Squiz.Commenting.InlineComment" />
     <rule ref="PEAR.Commenting.InlineComment"/>
 
diff --git a/composer.json b/composer.json
index d7d6c75..dcd78f7 100644
--- a/composer.json
+++ b/composer.json
@@ -23,7 +23,7 @@
         "php": "^8.0",
         "squizlabs/php_codesniffer": "^3.13.0 || ^4.0",
         "phpcsstandards/phpcsextra": "^1.4",
-        "slevomat/coding-standard": "^8.0"
+        "slevomat/coding-standard": "^8.22"
     },
     "suggest": {
         "dealerdirect/phpcodesniffer-composer-installer": "For automatic registration of the coding standard with PHP_CodeSniffer"