From 4f38caf921aee54d1362a6f1c91a4af7013b8d1e Mon Sep 17 00:00:00 2001
From: Brent Wilson <brent@clariio.com>
Date: Tue, 26 Aug 2025 14:56:50 -0700
Subject: [PATCH 1/3] =?UTF-8?q?Docs:=20document=20(double|real)=20?=
 =?UTF-8?q?=E2=86=92=20(float)=20normalization=20for=20WordPress.PHP.TypeC?=
 =?UTF-8?q?asts?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 WordPress/Docs/PHP/TypeCastsStandard.xml | 38 ++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 WordPress/Docs/PHP/TypeCastsStandard.xml

diff --git a/WordPress/Docs/PHP/TypeCastsStandard.xml b/WordPress/Docs/PHP/TypeCastsStandard.xml
new file mode 100644
index 0000000000..d9ae471612
--- /dev/null
+++ b/WordPress/Docs/PHP/TypeCastsStandard.xml
@@ -0,0 +1,38 @@
+<?xml version="1.0"?>
+<documentation title="Type Casts">
+    <standard>
+    <![CDATA[
+      This sniff normalizes float type cast keywords.
+
+      Use (float) instead of legacy synonyms:
+      - Disallowed: (double), (real)
+      - Allowed:    (float)
+
+      Note: Other type-cast rules in the WordPress standard
+      are enforced by different sniffs:
+      - Short forms like (int), (bool), (string):
+        PSR12.Keywords.ShortFormTypeKeywords
+      - No spaces inside parentheses:
+        Squiz.WhiteSpace.CastSpacing
+      - Exactly one space after the cast:
+        Generic.Formatting.SpaceAfterCast
+    ]]>
+    </standard>
+
+    <code_comparison>
+        <code title="Invalid: legacy float casts">
+        <![CDATA[
+<?php
+$price = <em>(double)</em> $value;
+$size  = <em>(real)</em>   $value;
+        ]]>
+        </code>
+        <code title="Valid: normalized float cast">
+        <![CDATA[
+<?php
+$price = <em>(float)</em> $value;
+$size  = <em>(float)</em> $value;
+        ]]>
+        </code>
+    </code_comparison>
+</documentation>

From 795e5ff9145d59e7166e8ffd1c53a7f807a7bb79 Mon Sep 17 00:00:00 2001
From: Brent Wilson <brent@clariio.com>
Date: Tue, 26 Aug 2025 15:39:53 -0700
Subject: [PATCH 2/3] =?UTF-8?q?Docs:=20refine=20TypeCasts=20docs=20per=20r?=
 =?UTF-8?q?eview=20(double/real=E2=86=92float,=20forbid=20(unset),=20disco?=
 =?UTF-8?q?urage=20(binary))?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 WordPress/Docs/PHP/TypeCastsStandard.xml | 54 ++++++++++++++++--------
 1 file changed, 36 insertions(+), 18 deletions(-)

diff --git a/WordPress/Docs/PHP/TypeCastsStandard.xml b/WordPress/Docs/PHP/TypeCastsStandard.xml
index d9ae471612..a55ca4874a 100644
--- a/WordPress/Docs/PHP/TypeCastsStandard.xml
+++ b/WordPress/Docs/PHP/TypeCastsStandard.xml
@@ -1,38 +1,56 @@
 <?xml version="1.0"?>
-<documentation title="Type Casts">
+<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
+    title="Type Casts"
+>
     <standard>
     <![CDATA[
-      This sniff normalizes float type cast keywords.
+      Enforce normalized and safe type casts.
 
-      Use (float) instead of legacy synonyms:
-      - Disallowed: (double), (real)
-      - Allowed:    (float)
-
-      Note: Other type-cast rules in the WordPress standard
-      are enforced by different sniffs:
-      - Short forms like (int), (bool), (string):
-        PSR12.Keywords.ShortFormTypeKeywords
-      - No spaces inside parentheses:
-        Squiz.WhiteSpace.CastSpacing
-      - Exactly one space after the cast:
-        Generic.Formatting.SpaceAfterCast
+      • Use (float) instead of legacy float casts.
+      • Do not use the (unset) cast. Use unset().
+      • Avoid the (binary) cast (discouraged).
     ]]>
     </standard>
 
     <code_comparison>
-        <code title="Invalid: legacy float casts">
+        <code title="Invalid: Using legacy float casts.">
         <![CDATA[
-<?php
 $price = <em>(double)</em> $value;
 $size  = <em>(real)</em>   $value;
         ]]>
         </code>
-        <code title="Valid: normalized float cast">
+        <code title="Valid: Using normalized float casts.">
         <![CDATA[
-<?php
 $price = <em>(float)</em> $value;
 $size  = <em>(float)</em> $value;
         ]]>
         </code>
     </code_comparison>
+
+    <code_comparison>
+        <code title="Invalid: Using the (unset) cast.">
+        <![CDATA[
+$result = <em>(unset)</em> $value;
+        ]]>
+        </code>
+        <code title="Valid: Use unset().">
+        <![CDATA[
+unset( $value );
+        ]]>
+        </code>
+    </code_comparison>
+
+    <code_comparison>
+        <code title="Invalid: Using the (binary) cast.">
+        <![CDATA[
+$bytes = <em>(binary)</em> $value;
+        ]]>
+        </code>
+        <code title="Valid: Prefer a clear alternative.">
+        <![CDATA[
+$bytes = (string) $value;
+        ]]>
+        </code>
+    </code_comparison>
 </documentation>

From 6bf9ab7081b31fe35c7019e73cbbb4e145d6e50e Mon Sep 17 00:00:00 2001
From: Brent Wilson <brent@clariio.com>
Date: Tue, 26 Aug 2025 15:51:51 -0700
Subject: [PATCH 3/3] Docs: reorder TypeCasts code examples to Valid (left) /
 Invalid (right) per review

---
 WordPress/Docs/PHP/TypeCastsStandard.xml | 28 ++++++++++++------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/WordPress/Docs/PHP/TypeCastsStandard.xml b/WordPress/Docs/PHP/TypeCastsStandard.xml
index a55ca4874a..4ae707a604 100644
--- a/WordPress/Docs/PHP/TypeCastsStandard.xml
+++ b/WordPress/Docs/PHP/TypeCastsStandard.xml
@@ -14,42 +14,42 @@
     </standard>
 
     <code_comparison>
-        <code title="Invalid: Using legacy float casts.">
-        <![CDATA[
-$price = <em>(double)</em> $value;
-$size  = <em>(real)</em>   $value;
-        ]]>
-        </code>
         <code title="Valid: Using normalized float casts.">
         <![CDATA[
 $price = <em>(float)</em> $value;
 $size  = <em>(float)</em> $value;
         ]]>
         </code>
+        <code title="Invalid: Using legacy float casts.">
+        <![CDATA[
+$price = <em>(double)</em> $value;
+$size  = <em>(real)</em>   $value;
+        ]]>
+        </code>
     </code_comparison>
 
     <code_comparison>
-        <code title="Invalid: Using the (unset) cast.">
+        <code title="Valid: Use unset().">
         <![CDATA[
-$result = <em>(unset)</em> $value;
+unset( $value );
         ]]>
         </code>
-        <code title="Valid: Use unset().">
+        <code title="Invalid: Using the (unset) cast.">
         <![CDATA[
-unset( $value );
+result = <em>(unset)</em> $value;
         ]]>
         </code>
     </code_comparison>
 
     <code_comparison>
-        <code title="Invalid: Using the (binary) cast.">
+        <code title="Valid: Prefer a clear alternative.">
         <![CDATA[
-$bytes = <em>(binary)</em> $value;
+bytes = (string) $value;
         ]]>
         </code>
-        <code title="Valid: Prefer a clear alternative.">
+        <code title="Invalid: Using the (binary) cast.">
         <![CDATA[
-$bytes = (string) $value;
+bytes = <em>(binary)</em> $value;
         ]]>
         </code>
     </code_comparison>