From d779cf818ebc91590770a325df5d0bf5cd22e86d Mon Sep 17 00:00:00 2001 From: Christian Glingener Date: Thu, 8 Nov 2018 17:19:51 +0100 Subject: [PATCH 1/2] Fix length check on object --- packages/editor/src/store/selectors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor/src/store/selectors.js b/packages/editor/src/store/selectors.js index a4e426507f8167..8b8f7136ce3dc2 100644 --- a/packages/editor/src/store/selectors.js +++ b/packages/editor/src/store/selectors.js @@ -2056,7 +2056,7 @@ export function isPostLocked( state ) { * @return {boolean} Is locked. */ export function isPostSavingLocked( state ) { - return state.postSavingLock.length > 0; + return Object.keys( state.postSavingLock ).length > 0; } /** From cfdc3b7472d08fb0bce0e210155001cec9f84516 Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Thu, 8 Nov 2018 15:03:36 -0500 Subject: [PATCH 2/2] Editor: Correct state shape of tested post saving lock --- packages/editor/src/store/test/selectors.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/editor/src/store/test/selectors.js b/packages/editor/src/store/test/selectors.js index 2474cc1e2565f8..4f9e3fa0fd7752 100644 --- a/packages/editor/src/store/test/selectors.js +++ b/packages/editor/src/store/test/selectors.js @@ -964,7 +964,7 @@ describe( 'selectors', () => { describe( 'isPostSavingLocked', () => { it( 'should return true if the post has postSavingLocks', () => { const state = { - postSavingLock: [ { 1: true } ], + postSavingLock: { example: true }, currentPost: {}, saving: {}, }; @@ -974,7 +974,7 @@ describe( 'selectors', () => { it( 'should return false if the post has no postSavingLocks', () => { const state = { - postSavingLock: [], + postSavingLock: {}, currentPost: {}, saving: {}, };