Skip to content

Remove redundant (duplicated) reducers#15142

Merged
ellatrix merged 1 commit into
masterfrom
remove/redundant-reducers
May 6, 2019
Merged

Remove redundant (duplicated) reducers#15142
ellatrix merged 1 commit into
masterfrom
remove/redundant-reducers

Conversation

@ellatrix
Copy link
Copy Markdown
Member

@ellatrix ellatrix commented Apr 24, 2019

Description

Seems to have been forgotten in #13088 when moving the reducers to a new package.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Apr 24, 2019
@ellatrix ellatrix requested a review from youknowriad April 24, 2019 11:15
@ellatrix ellatrix added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label May 1, 2019
@youknowriad
Copy link
Copy Markdown
Contributor

I'm pretty sure I removed these :) maybe some merge brought them back :)

@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented May 6, 2019

Thanks @youknowriad. It looks like some, but not all the code was removed.

@ellatrix ellatrix merged commit 06c9f4a into master May 6, 2019
@ellatrix ellatrix deleted the remove/redundant-reducers branch May 6, 2019 15:11
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants