Pass all extra attributes down in get_block_wrapper_attributes#26280
Merged
Conversation
youknowriad
added
[Feature] Block API
youknowriad
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
mcsf
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To match developer expectations, the extra attributes are passed down to the caller of
get_block_wrapper_attributes. Also this implementation is more future proof to potential support for other attributes in "block-supports".Related here #26192 (comment)