Editor store: remove createUndoLevel and refreshPost actions#38585
Merged
Conversation
|
Size Change: -48 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Feb 7, 2022
youknowriad
reviewed
Feb 8, 2022
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Should we keep the functions with a deprecated call (and remove their content) instead for some versions to avoid creating JS errors for potential plugins using them even if they don't do anything?
jsnajdr
force-pushed
the
remove/editor-create-undo-level
branch
from
0f95628 to
f6c3fd6
Compare
Member
Author
Yes I changed the patch to make the action creators empty (returning a One thing I'm not sure about is how to express the "deprecated since" versions. Since WordPress 5.9? Since Gutenberg 13.0.0? Both versioning lines seem to be used. |
Contributor
|
I think it should be |
Contributor
|
We use Gutenberg version only for things that didn't make it yet to WordPress. |
Member
Author
|
Pushed a commit that clarifies the versions: deprecated in 6.0, removed in 6.3. |
youknowriad
reviewed
Feb 8, 2022
| return { type: 'CREATE_UNDO_LEVEL' }; | ||
| deprecated( "wp.data.dispatch( 'core/editor' ).createUndoLevel", { | ||
| since: '5.9', | ||
| alternative: 'Use the core entities store instead', |
Contributor
There was a problem hiding this comment.
Is GitHub missing a commit or something, I don't see the "version": "6.0"
Member
Author
There was a problem hiding this comment.
Sorry, turns out I didn't really push the commit to the server 🙂 Please look again now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two
editorstore actions that are unused. Even if someone tried to use them, they would discover they don't do anything useful at all.createUndoLevelwas gradually moved to thecorestore (especially in #13088), and today theeditorreducer doesn't react to theCREATE_UNDO_LEVELaction at all.refreshPostused to be used in thePostPermalinkcomponent, but that one was removed in #21099. The action used to fetch the latest version of the post from REST API, and store it in state withresetPost. But today theresetPostaction resets just theidandtypefields, which are kind of guaranteed to never change.In short, gradual and mechanical refactorings removed all meaning from these two actions. Regarding backward compatibility, can we safely remove them? Given that the Gutenberg codebase doesn't use them, and anyone else doesn't have any reason to call them?
Discovered this when refreshing #35929, my PR to migrate the
editorstore to thunks.