Remove the insert.ref field from insertUsage data#51130
Merged
Conversation
jsnajdr
force-pushed
the
remove/insert-usage-ref
branch
from
cf1df97 to
456d570
Compare
|
Size Change: +226 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 456d570. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5132452163
|
youknowriad
approved these changes
Jun 1, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Remove the insert.ref field from insertUsage data * Update test data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the
insertUsagedata, I was wondering where theinsert.reffield is used. And it turns out that it's not used at all. 4 years ago, there was ablock-editorrefactoring in #13088 which removed theREMOVE_REUSABLE_BLOCKaction. It was using the field to remove usage data for the reusable block being removed.But removing reusable block is not nowadays present in the editor at all. You can only create them, but removing can be done only on the dedicated
edit.php?post_type=wp_blockWP Admin page.It's also worth noting that the
insert.refinformation can be completely reconstructed from the ID.insert.nameis the leadinga/bpart, theinsert.refis the trailing part after the optional second slash.