From f7c82af01ceff0aabf3b876168a04eb787f0fc49 Mon Sep 17 00:00:00 2001 From: Carlos Bravo <37012961+cbravobernal@users.noreply.github.com> Date: Fri, 3 Oct 2025 17:32:10 +0200 Subject: [PATCH 1/5] First implementation, parallax not working --- lib/compat/wordpress-6.9/block-bindings.php | 2 +- packages/block-library/src/cover/block.json | 3 +++ packages/block-library/src/cover/save.js | 5 +++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/compat/wordpress-6.9/block-bindings.php b/lib/compat/wordpress-6.9/block-bindings.php index a54ddf45809766..fe41cd9ab72357 100644 --- a/lib/compat/wordpress-6.9/block-bindings.php +++ b/lib/compat/wordpress-6.9/block-bindings.php @@ -19,7 +19,7 @@ function ( $attributes, $block_type ) { $attributes[] = 'datetime'; } if ( - in_array( $block_type, array( 'core/navigation-link', 'core/navigation-submenu' ), true ) && + in_array( $block_type, array( 'core/navigation-link', 'core/navigation-submenu', 'core/cover' ), true ) && ! in_array( 'url', $attributes, true ) ) { $attributes[] = 'url'; diff --git a/packages/block-library/src/cover/block.json b/packages/block-library/src/cover/block.json index 97095ab4b95152..e70d9b339f1f4d 100644 --- a/packages/block-library/src/cover/block.json +++ b/packages/block-library/src/cover/block.json @@ -9,6 +9,9 @@ "attributes": { "url": { "type": "string", + "source": "attribute", + "selector": "img", + "attribute": "src", "role": "content" }, "useFeaturedImage": { diff --git a/packages/block-library/src/cover/save.js b/packages/block-library/src/cover/save.js index f4fce991630678..5abd4a010097f7 100644 --- a/packages/block-library/src/cover/save.js +++ b/packages/block-library/src/cover/save.js @@ -48,6 +48,7 @@ export default function save( { attributes } ) { tagName: Tag, sizeSlug, poster, + metadata: { bindings = {} } = {}, } = attributes; const overlayColorClass = getColorClassName( 'background-color', @@ -112,7 +113,7 @@ export default function save( { attributes } ) { { ! useFeaturedImage && isImageBackground && - url && + ( url || bindings?.url ) && ( isImgElement ? ( ) ) } - { isVideoBackground && url && ( + { isVideoBackground && ( url || bindings?.url ) && (