[DRAFT] Moving @php-wasm/node's files correctly when sourcemaps & source trees are present#130
Draft
seanmorris wants to merge 1 commit into
Draft
Conversation
Collaborator
|
@seanmorris FYI you can use the "draft PR" feature for drafts:
|
adamziel
reviewed
Dec 8, 2023
| "cp packages/vscode-extension/package.json dist/packages/vscode-extension", | ||
| "cp packages/vscode-extension/README.md dist/packages/vscode-extension", | ||
| "cp node_modules/@php-wasm/node/*.wasm dist/packages/vscode-extension" | ||
| "find node_modules/@php-wasm/node/ -type f -name php_*.wasm | while read FILE; do cp $FILE dist/packages/vscode-extension; done" |
Collaborator
There was a problem hiding this comment.
will that re-create nested directories like kitchen-sink?
Collaborator
|
How can this be tested? Or is this not meant for testing at this point? I see there's [DRAFT] in the title so I went ahead and converted this to a draft PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT
What?
This ensures @php-wasm/nodes' files are copied properly when the wordpress-playground package has been built with sourcemaps.
Why?
When wordpress-playground builds php-wasm with sourcemaps, the directory structure changes slightly. This change updates the code to account for that.
How?
It iterates over the directory where the sub-directories containing the files live, and moves them, preserving the sub-paths.
Testing Instructions
...