WP-NOW: Remove message about node v20 limitation for blueprints#216
Merged
Conversation
Collaborator
|
Lovely! |
johnhooks
pushed a commit
to johnhooks/playground-tools
that referenced
this pull request
Oct 11, 2024
…dpress` path (WordPress#216) Use playground.documentRoot from playground to avoid hardcoded paths. This commit also fixes the documentRoot getter in base-php.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove message that asks for Node v20 when
--blueprintparam is present.Why?
Since the polyfills were implemented on WordPress/wordpress-playground#882 , blueprints can be executed on Node v18
Testing Instructions
b.jsonwith a valid blueprint like:nvm use && npm install && npx nx run wp-now:build# nvm use will set the node version 18.18.2node dist/packages/wp-now/with-node-version.js start --blueprint=b.jsonThis script is requires node version v20.0.0 or above when --blueprint=<file> is used; found v18.18.2