Skip to content

WP-NOW: Remove message about node v20 limitation for blueprints#216

Merged
adamziel merged 1 commit into
trunkfrom
update/minimum-version-v18-for-blueprints
Apr 3, 2024
Merged

WP-NOW: Remove message about node v20 limitation for blueprints#216
adamziel merged 1 commit into
trunkfrom
update/minimum-version-v18-for-blueprints

Conversation

@sejas
Copy link
Copy Markdown
Collaborator

@sejas sejas commented Apr 3, 2024

What?

Remove message that asks for Node v20 when--blueprint param is present.

Why?

Since the polyfills were implemented on WordPress/wordpress-playground#882 , blueprints can be executed on Node v18

Testing Instructions

  • Create a new blueprint file b.json with a valid blueprint like:
{
    "landingPage": "/wp-admin/",
    "features": {
        "networking": true
    },
    "steps": [
        {
            "step": "login",
            "username": "admin",
            "password": "password"
        }
    ]
}
  • Run nvm use && npm install && npx nx run wp-now:build # nvm use will set the node version 18.18.2
  • Run node dist/packages/wp-now/with-node-version.js start --blueprint=b.json
  • Observe the blueprint runs as expected and there is no the following error This script is requires node version v20.0.0 or above when --blueprint=<file> is used; found v18.18.2

@sejas sejas added the wp-now label Apr 3, 2024
@sejas sejas self-assigned this Apr 3, 2024
@sejas sejas requested review from adamziel, bgrgicak and wojtekn April 3, 2024 21:39
@adamziel adamziel merged commit 371f30b into trunk Apr 3, 2024
@adamziel adamziel deleted the update/minimum-version-v18-for-blueprints branch April 3, 2024 22:13
@adamziel
Copy link
Copy Markdown
Collaborator

adamziel commented Apr 3, 2024

Lovely!

johnhooks pushed a commit to johnhooks/playground-tools that referenced this pull request Oct 11, 2024
…dpress` path (WordPress#216)

Use playground.documentRoot from playground to avoid hardcoded paths. This commit also fixes the documentRoot getter in base-php.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants