Skip to content

Update @wordpress npm packages.#626

Closed
tellthemachines wants to merge 19 commits into
WordPress:masterfrom
tellthemachines:update/npm-packages
Closed

Update @wordpress npm packages.#626
tellthemachines wants to merge 19 commits into
WordPress:masterfrom
tellthemachines:update/npm-packages

Conversation

@tellthemachines
Copy link
Copy Markdown
Contributor

Updates @WordPress npm packages to their latest versions, prior to 5.6 Beta 1.

Trac ticket: https://core.trac.wordpress.org/ticket/51570


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Comment thread src/wp-includes/class-wp-block.php Outdated
Comment thread src/wp-includes/class-wp-block-supports.php Outdated
@@ -0,0 +1,196 @@
<?php
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this file to src/wp-includes/block-supports/class-wp-block-supports.php.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually reverted this change, I believe it's better there with the other classes and src/wp-includes/block-supports only includes the actual block supports not the framework for it.

Comment thread src/wp-includes/class-wp-block-supports.php
Comment thread src/wp-includes/class-wp-block-supports.php
Comment thread src/wp-includes/class-wp-block-supports.php
Comment thread src/wp-includes/blocks.php
Comment thread src/wp-includes/block-supports/align.php
@youknowriad
Copy link
Copy Markdown
Contributor

Ok this is looking good to me now, I'm going to proceed and commit this patch.

Comment thread src/wp-admin/includes/update-core.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants