Phase 10: Implement full MCP wrapper synchronization

[aberemia24]

Context: Daily sync feature currently has stub implementations for Phase 10.

Tasks:

1. Integrate with MCPClientPool.discoverMCPTools() for schema fetching
2. Implement full schema hashing algorithm (normalize, sort, SHA-256)
3. Reconstruct MCPServerSelection from wrapper entries
4. Implement full wrapper regeneration

Locations:

• src/cli/daily-sync.ts:322 - Schema fetching TODO
• src/cli/daily-sync.ts:334 - Hash computation TODO
• src/cli/daily-sync.ts:351 - MCPServerSelection reconstruction TODO
• src/cli/daily-sync.ts:363 - Wrapper regeneration TODO

Priority: Enhancement (Phase 10, post-v1.0.0)

Current Behavior: Stub implementations return deterministic test data.

Desired Behavior: Full integration with MCP discovery and wrapper generation.

Dependencies: Phase 8 (wrapper-generator) completion

Algorithm (from code comments):

1. Call discoverMCPTools({ search: [mcpName] })
2. Extract tools array, sort by name (deterministic order)
3. JSON.stringify with sorted keys
4. Compute SHA-256 hash
5. Reconstruct config and regenerate wrappers

[aberemia24]

✅ Phase 10 Complete: Full MCP Wrapper Synchronization Implemented

Implementation Summary

Successfully integrated full MCP wrapper synchronization into the daily sync feature by replacing stub implementations with production-ready code.

Changes Implemented

1. Dependencies Added ()

• Added MCPClientPool and SchemaCache to DailySyncOptions interface
• Updated constructor to accept and store new dependencies (lines 64-72, 161-162)

2. Schema Fetching & Hashing (computeCurrentSchemaHash())

• Fetches all tool schemas via MCPClientPool.listAllToolSchemas()
• Filters tools by MCP server name (format: mcp__servername__toolname)
• Sorts tools by name for deterministic hashing
• Normalizes JSON with sorted object keys
• Computes SHA-256 hash of normalized schemas
• Lines 372-393

3. Wrapper Regeneration (regenerateWrapper())

• Fetches current tool schemas for MCP server
• Converts discovery tool schemas to CLI format (type compatibility)
• Reconstructs MCPServerSelection from wrapper entry
• Calls WrapperGenerator.generateWrapper() with force mode
• Returns success/failure status with error handling
• Lines 440-479

4. Type Conversion Helper (convertToCLIToolSchema())

• Safely converts DiscoveryToolSchema (JSONSchema7) to CLIToolSchema (object format)
• Type guards for properties and required fields
• Zero any types - strict type narrowing
• Lines 346-370

5. Test Updates (tests/cli/daily-sync.test.ts)

• Added mocked MCPClientPool and SchemaCache dependencies
• Updated all constructor calls with new required parameters
• All 11 tests passing ✅

Validation

• ✅ TypeScript: Compilation passes with zero errors
• ✅ Lint: Zero new warnings (strict type checking maintained)
• ✅ Tests: All 11 daily-sync tests passing
• ✅ Architecture: SOLID principles adhered to (SRP, DIP with dependency injection)

Algorithm Details

Schema Hash Computation:

1. Fetch all tools from MCP Client Pool
2. Filter by MCP server name (e.g., filesystem, github)
3. Sort by tool name (deterministic order)
4. Normalize: JSON.stringify with sorted object keys
5. SHA-256 hash of normalized JSON

Wrapper Regeneration:

1. Fetch current tool schemas for MCP server
2. Convert DiscoveryToolSchema → CLIToolSchema (type compatibility)
3. Reconstruct MCPServerSelection with minimal required fields
4. Generate wrapper with force mode (override existing)
5. Return success/failure status

Files Modified

• src/cli/daily-sync.ts - Implementation (4 TODOs resolved)
• tests/cli/daily-sync.test.ts - Test updates

No Breaking Changes - Daily sync tests remain passing with enhanced functionality.