From a2f875f081ba037d438ecde18223fd765ce95790 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 13 Dec 2022 19:58:00 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- setup.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 7565258..1cc904d 100644 --- a/setup.py +++ b/setup.py @@ -23,7 +23,26 @@ outfile.write(r.content) # urlretrieve(eigen_url, tar_path) with tarfile.open(tar_path, 'r') as tar: - tar.extractall('include') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, "include") thedir = glob(os.path.join('include', 'eigen-*'))[0] shutil.move(os.path.join(thedir, 'Eigen'), eigen_dir) shutil.move(os.path.join(thedir, 'unsupported'), os.path.join('include', 'unsupported'))