chore: rename altcha session timeout env variable

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Author: keshav-space

vulnerabilities/middleware/altcha_protection.py

@@ -13,7 +13,7 @@
 from django.shortcuts import redirect
 from django.utils.deprecation import MiddlewareMixin
 
-from vulnerablecode.settings import ALTCHA_SESSION_TIMEOUT
+from vulnerablecode.settings import VULNERABLECODE_ALTCHA_SESSION_TIMEOUT
 
 ALTCHA_PROTECTED_PREFIXES = (
     "/packages/",
@@ -26,7 +26,7 @@
 
 class AltchaProtectionMiddleware(MiddlewareMixin):
     def __call__(self, request):
-        if not ALTCHA_SESSION_TIMEOUT:
+        if not VULNERABLECODE_ALTCHA_SESSION_TIMEOUT:
             return self.get_response(request)
 
         protected = any(request.path.startswith(prefix) for prefix in ALTCHA_PROTECTED_PREFIXES)
@@ -40,7 +40,7 @@ def __call__(self, request):
         if not verified_at:
             return redirect(f"/altcha/?{urlencode({'next': next_url})}")
 
-        if time.time() - verified_at > ALTCHA_SESSION_TIMEOUT:
+        if time.time() - verified_at > VULNERABLECODE_ALTCHA_SESSION_TIMEOUT:
             request.session.pop("altcha_verified_at", None)
             return redirect(f"/altcha/?{urlencode({'next': next_url})}")
 

vulnerabilities/views.py

@@ -65,7 +65,7 @@
 from vulnerabilities.utils import get_advisories_from_groups
 from vulnerabilities.utils import safe_altcha_redirect
 from vulnerablecode import __version__ as VULNERABLECODE_VERSION
-from vulnerablecode.settings import ALTCHA_SESSION_TIMEOUT
+from vulnerablecode.settings import VULNERABLECODE_ALTCHA_SESSION_TIMEOUT
 from vulnerablecode.settings import env
 
 PAGE_SIZE = 10
@@ -1166,7 +1166,7 @@ def dispatch(self, request, *args, **kwargs):
         verified_at = request.session.get("altcha_verified_at")
 
         if verified_at:
-            if time.time() - verified_at < ALTCHA_SESSION_TIMEOUT:
+            if time.time() - verified_at < VULNERABLECODE_ALTCHA_SESSION_TIMEOUT:
                 next_url = request.GET.get("next", "/")
                 return safe_altcha_redirect(next_url)
 

vulnerablecode/settings.py

@@ -42,7 +42,7 @@
 
 ALTCHA_HMAC_KEY = env.str("ALTCHA_HMAC_KEY")
 
-ALTCHA_SESSION_TIMEOUT = env.int("ALTCHA_SESSION_TIMEOUT", None)
+VULNERABLECODE_ALTCHA_SESSION_TIMEOUT = env.int("VULNERABLECODE_ALTCHA_SESSION_TIMEOUT", None)
 
 # SECURITY WARNING: do not run with debug turned on in production
 DEBUG = env.bool("VULNERABLECODE_DEBUG", default=False)
@@ -218,7 +218,7 @@
 
 if IS_TESTS:
     VULNERABLECODEIO_REQUIRE_AUTHENTICATION = False
-    ALTCHA_SESSION_TIMEOUT = 900
+    VULNERABLECODE_ALTCHA_SESSION_TIMEOUT = 900
 
 USE_L10N = True
 

vulnerablecode/urls.py

@@ -40,9 +40,9 @@
 from vulnerabilities.views import PipelineRunDetailView
 from vulnerabilities.views import PipelineRunListView
 from vulnerabilities.views import PipelineScheduleListView
-from vulnerablecode.settings import ALTCHA_SESSION_TIMEOUT
 from vulnerablecode.settings import DEBUG
 from vulnerablecode.settings import DEBUG_TOOLBAR
+from vulnerablecode.settings import VULNERABLECODE_ALTCHA_SESSION_TIMEOUT
 
 
 # See the comment at https://stackoverflow.com/a/46163870.
@@ -175,7 +175,7 @@ def __init__(self, *args, **kwargs):
     # ),
 ]
 
-if ALTCHA_SESSION_TIMEOUT:
+if VULNERABLECODE_ALTCHA_SESSION_TIMEOUT:
     urlpatterns += [path("altcha/", AltchaView.as_view(), name="altcha")]
 
 if DEBUG: