You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #609 adds targeted regression coverage for #601, specifically around config precedence when CLI or environment values are explicitly set to their defaults. While reviewing that work, a few broader CLI test gaps became clear that are adjacent to the fix but not required for it.
Suggested test improvements
Replace stale default-node tests that manually simulate old Run() behavior with tests that exercise the real applyBackendDefaults() path and backend Run() wiring.
Add table-driven tests for config source tracking from Kong:
global CLI flags
global env vars
representative backend flags such as --node, --scheme, --file, --filter, and Secrets Manager/ACM flags
aliases where TOML and CLI names differ, such as TOML nodes versus CLI node
Context
PR #609 adds targeted regression coverage for #601, specifically around config precedence when CLI or environment values are explicitly set to their defaults. While reviewing that work, a few broader CLI test gaps became clear that are adjacent to the fix but not required for it.
Suggested test improvements
Run()behavior with tests that exercise the realapplyBackendDefaults()path and backendRun()wiring.--node,--scheme,--file,--filter, and Secrets Manager/ACM flagsnodesversus CLInodeAcceptance criteria
go test ./cmd/confdpasses.