From da5efc4b0bf81e4a0ff228ceb68b30f53ea3bfa9 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sun, 22 Feb 2026 13:04:40 +0100 Subject: [PATCH] tools: avoid building twice in coverage jobs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/61899 Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca --- .github/workflows/coverage-linux-without-intl.yml | 6 +++--- .github/workflows/coverage-linux.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/coverage-linux-without-intl.yml b/.github/workflows/coverage-linux-without-intl.yml index 64f8fe1ff3161e..feb4021c2ecafe 100644 --- a/.github/workflows/coverage-linux-without-intl.yml +++ b/.github/workflows/coverage-linux-without-intl.yml @@ -71,11 +71,11 @@ jobs: run: npx envinfo - name: Install gcovr run: pip install gcovr==7.2 - - name: Build - run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl" + - name: Configure + run: ./configure --verbose --error-on-warn --coverage --without-intl # TODO(bcoe): fix the couple tests that fail with the inspector enabled. # The cause is most likely coverage's use of the inspector. - - name: Test + - name: Build and test run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0 - name: Report JS run: npx c8 report --check-coverage diff --git a/.github/workflows/coverage-linux.yml b/.github/workflows/coverage-linux.yml index 666f0568f4c4b7..9a961f5588946b 100644 --- a/.github/workflows/coverage-linux.yml +++ b/.github/workflows/coverage-linux.yml @@ -71,11 +71,11 @@ jobs: run: npx envinfo - name: Install gcovr run: pip install gcovr==7.2 - - name: Build - run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage" + - name: Configure + run: ./configure --verbose --error-on-warn --coverage # TODO(bcoe): fix the couple tests that fail with the inspector enabled. # The cause is most likely coverage's use of the inspector. - - name: Test + - name: Build and test run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0 - name: Report JS run: npx c8 report --check-coverage