Skip to content

[Bug]: sp-menu: should skip hidden items when navigating via keyboard #6307

@pinkhominid

Description

@pinkhominid

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-menu, sp-menu-item

Library version

1.9.0

Expected behavior

Hidden sp-menu-items would not participate in focus traversal of sp-menu items.

Actual behavior

Hidden sp-menu-items are tab stops on focus traversal of sp-menu items.

Screenshots

Image

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

  1. Open https://opensource.adobe.com/spectrum-web-components/components/menu/#anatomy in Chrome
  2. Inspect an sp-menu-item in Chrome Dev Tools
  3. Add a hidden attribute
  4. Use the up/down arrows to navigate the list
  5. Note the tabstop on the hidden item

Sample code or abstract reproduction which illustrates the problem

No response

Severity

None

Logs taken while reproducing problem

No response

Would you like to track this issue in Jira?

  • Yes, please tell me the ticket number!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds-jira-ticketIssue has yet to be imported to JiratriageAn issue needing triage

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions