Skip to content

fix(build): replace process.env.NODE_ENV in 1st-gen and 2nd-gen builds #6264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubencarvalho wants to merge 2 commits into from
+22 −6
Closed

fix(build): replace process.env.NODE_ENV in 1st-gen and 2nd-gen builds #6264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41c4139
fix(build): replace process.env.NODE_ENV at esbuild time
rubencarvalho May 11, 2026
89e88be
fix(2nd-gen): replace process.env.NODE_ENV in Vite library builds
rubencarvalho May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions 1st-gen/scripts/ts-tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,21 @@ export const buildPackage = async (paths) => {
build({
...config,
entryPoints: devPaths,
define: { 'window.__swc.DEBUG': 'true' },
define: {
'window.__swc.DEBUG': 'true',
'process.env.NODE_ENV': '"development"',
},
outExtension: { '.js': '.dev.js' },
plugins: devPlugins,
}).catch(() => process.exit(1))
);
}
const prodConfig = {
...config,
define: { 'window.__swc.DEBUG': 'false' },
define: {
'window.__swc.DEBUG': 'false',
'process.env.NODE_ENV': '"production"',
},
plugins: paths.length === 1 ? [] : prodPlugins,
};
if (prodPath.length) {
Expand Down
9 changes: 7 additions & 2 deletions 2nd-gen/packages/core/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,12 @@ function getEntries() {
return entries;
}

export default defineConfig({
export default defineConfig(({ mode }) => ({
define: {
'process.env.NODE_ENV': JSON.stringify(
mode === 'development' ? 'development' : 'production'
),
},
plugins: [
dts({
include: ['**/*.ts'],
Expand Down Expand Up @@ -125,4 +130,4 @@ export default defineConfig({
esbuild: {
target: 'es2018',
},
});
}));
9 changes: 7 additions & 2 deletions 2nd-gen/packages/swc/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,12 @@ function processStylesheets(): Plugin {
};
}

export default defineConfig({
export default defineConfig(({ mode }) => ({
define: {
'process.env.NODE_ENV': JSON.stringify(
mode === 'development' ? 'development' : 'production'
),
},
plugins: [
litCss({ exclude: ['./stylesheets/**/*.css'] }),
processStylesheets(),
Expand Down Expand Up @@ -147,4 +152,4 @@ export default defineConfig({
esbuild: {
target: 'es2018',
},
});
}));
Loading