Skip to content

[Bug]: ValidateCommand creates and discards DataFixer instance #205

@Splatcrafter

Description

@Splatcrafter

AI REVIEWED

Module: cli
File: cli/command/ValidateCommand.java (~line 235-239)
Severity: Medium

Summary

new DataFixerRuntimeFactory().create(targetVersion, bootstrap); // created and discarded

The DataFixer is instantiated but never assigned or used. This is either a missing variable assignment or unnecessary work.

Suggested Fix

Either remove the unused instantiation, or assign it for use in validation:

AetherDataFixer fixer = new DataFixerRuntimeFactory().create(targetVersion, bootstrap);
// use fixer for actual validation

If this is an intentional "smoke test" (verifying bootstrap doesn't throw), add a comment explaining the intent.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions