Skip to content

JOSS Review: Example of suggested code formatting changes #42

Description

@hemmelig

This is related to some code-formatting feedback as part of the review of gemlog for JOSS, over at openjournals/joss-reviews#5256 (comment).

Describe the suggested changes

  • Organise import section. Motivation here is to minimise unnecessary imports and use preferred standard library packages
  • Move to pathlib over os.path. I don't think os.path can handle hardcoded / path delimiters when package running on Windows. setup.py indicates the package is intended to be OS independent.
  • Apply Black auto-formatting, with line length set to 100 characters.

Desktop (please complete the following information):

  • Operating System: macOS 12.5.1
  • Python version: 3.8
  • gemlog version: 1.7.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions