From 9b0be32ab71c4aa83cc768f411ec95a851519f33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=B5=96=E5=B0=A7?= Date: Tue, 25 Nov 2025 21:32:02 +0800 Subject: [PATCH 1/2] fix: Endpoint#toString host formatting; add Endpoint unit test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: 赖尧 --- .../com/alibaba/csp/sentinel/transport/endpoint/Endpoint.java | 2 +- .../alibaba/csp/sentinel/transport/endpoint.EndpointTest.java | 0 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint.EndpointTest.java diff --git a/sentinel-transport/sentinel-transport-common/src/main/java/com/alibaba/csp/sentinel/transport/endpoint/Endpoint.java b/sentinel-transport/sentinel-transport-common/src/main/java/com/alibaba/csp/sentinel/transport/endpoint/Endpoint.java index d1181e58d1..92ae6e4e2f 100644 --- a/sentinel-transport/sentinel-transport-common/src/main/java/com/alibaba/csp/sentinel/transport/endpoint/Endpoint.java +++ b/sentinel-transport/sentinel-transport-common/src/main/java/com/alibaba/csp/sentinel/transport/endpoint/Endpoint.java @@ -44,6 +44,6 @@ public void setPort(int port) { @Override public String toString() { - return "Endpoint{" + "protocol=" + protocol + ", host='" + host + ", port=" + port + '}'; + return "Endpoint{" + "protocol=" + protocol + ", host='" + host + '\'' + ", port=" + port + '}'; } } diff --git a/sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint.EndpointTest.java b/sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint.EndpointTest.java new file mode 100644 index 0000000000..e69de29bb2 From 563663ee8c2dec3d995c17e9abfbdce9d8e390ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=B5=96=E5=B0=A7?= Date: Wed, 26 Nov 2025 09:22:07 +0000 Subject: [PATCH 2/2] test: remove empty EndpointTest.java (fix accidental PR changes) --- .../transport/endpoint.EndpointTest.java | 0 .../transport/endpoint/EndpointTest.java | 32 +++++++++++++++++++ 2 files changed, 32 insertions(+) delete mode 100644 sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint.EndpointTest.java create mode 100644 sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint/EndpointTest.java diff --git a/sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint.EndpointTest.java b/sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint.EndpointTest.java deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint/EndpointTest.java b/sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint/EndpointTest.java new file mode 100644 index 0000000000..a20f1301eb --- /dev/null +++ b/sentinel-transport/sentinel-transport-common/src/test/java/com/alibaba/csp/sentinel/transport/endpoint/EndpointTest.java @@ -0,0 +1,32 @@ +package com.alibaba.csp.sentinel.transport.endpoint; + +import static org.junit.Assert.assertEquals; + +import org.junit.Test; + +public class EndpointTest { + @Test + public void testToStringIPv4() { + Endpoint e = new Endpoint(Protocol.HTTP, "127.0.0.1", 8080); + assertEquals("Endpoint{protocol=HTTP, host='127.0.0.1', port=8080}", e.toString()); + } + + @Test + public void testToStringIPv6() { + Endpoint e = new Endpoint(Protocol.HTTP, "fe80::1", 8080); + // Endpoint#toString doesn't modify the host, so IPv6 remains unbracketed + assertEquals("Endpoint{protocol=HTTP, host='fe80::1', port=8080}", e.toString()); + } + + @Test + public void testToStringAlreadyBracketed() { + Endpoint e = new Endpoint(Protocol.HTTPS, "[fe80::2]", 443); + assertEquals("Endpoint{protocol=HTTPS, host='[fe80::2]', port=443}", e.toString()); + } + + @Test + public void testToStringNullHost() { + Endpoint e = new Endpoint(Protocol.HTTP, null, 0); + assertEquals("Endpoint{protocol=HTTP, host='null', port=0}", e.toString()); + } +}