From 74da77aac08965ae47aa50f472cd3e74e1aac5c2 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 24 Jun 2026 21:19:40 +0800 Subject: [PATCH 01/41] refactor: use dlopen --- src/core/algorithm/diskann/CMakeLists.txt | 9 +++-- .../algorithm/diskann/diskann_file_reader.cc | 36 ++++++++++++++----- .../algorithm/diskann/diskann_file_reader.h | 2 +- 3 files changed, 33 insertions(+), 14 deletions(-) diff --git a/src/core/algorithm/diskann/CMakeLists.txt b/src/core/algorithm/diskann/CMakeLists.txt index 1b2252497..e2fa911f5 100644 --- a/src/core/algorithm/diskann/CMakeLists.txt +++ b/src/core/algorithm/diskann/CMakeLists.txt @@ -13,14 +13,13 @@ file(GLOB_RECURSE ALL_SRCS *.cc *.c) # before invoking dlopen's RTLD_GLOBAL symbol sharing, and the Python wheel # (which only ships _zvec.so + the plugin) would fail to load. # -# We therefore link the plugin only against its system-level dependency -# (libaio) and rely on the global include dirs plus -Wl,--unresolved-symbols -# =ignore-all to let the linker build a shared library with unresolved -# references to internal APIs. +# libaio is loaded at runtime via dlopen()/dlsym() (see libaio_loader.h), so +# we do NOT link against -laio. The only system-level link dependency is +# ${CMAKE_DL_LIBS} for dlopen/dlsym/dlclose. set(CORE_KNN_DISKANN_LIBS "") if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|i686|i386") - list(APPEND CORE_KNN_DISKANN_LIBS aio) + list(APPEND CORE_KNN_DISKANN_LIBS ${CMAKE_DL_LIBS}) endif() cc_library( diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index 4268d5156..34584d935 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -32,7 +32,10 @@ typedef struct iocb iocb_t; int setup_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) - int ret = io_setup(MAX_EVENTS, &ctx); + if (!LibAioLoader::Instance().Load()) { + return -ENOSYS; + } + int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); return ret; #else @@ -42,7 +45,10 @@ int setup_io_ctx(IOContext &ctx) { int destroy_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) - int ret = io_destroy(ctx); + if (!LibAioLoader::Instance().IsAvailable()) { + return 0; + } + int ret = LibAioLoader::Instance().io_destroy(ctx); return ret; #else @@ -71,6 +77,9 @@ static int execute_io_pread(int fd, std::vector &read_reqs) { int execute_io(IOContext ctx, int fd, std::vector &read_reqs, uint64_t n_retries = 0) { #if (defined(__linux) || defined(__linux__)) + if (!LibAioLoader::Instance().Load()) { + return execute_io_pread(fd, read_reqs); + } uint64_t iters = DiskAnnUtil::div_round_up(read_reqs.size(), MAX_EVENTS); for (uint64_t iter = 0; iter < iters; iter++) { @@ -93,7 +102,8 @@ int execute_io(IOContext ctx, int fd, std::vector &read_reqs, size_t n_tries = 0; // Phase 1: io_submit with retry. while (true) { - int ret = io_submit(ctx, (int64_t)n_ops, cbs.data()); + int ret = + LibAioLoader::Instance().io_submit(ctx, (int64_t)n_ops, cbs.data()); if (ret == (int)n_ops) { break; } @@ -111,8 +121,8 @@ int execute_io(IOContext ctx, int fd, std::vector &read_reqs, // Phase 2: io_getevents with retry (never re-submits). n_tries = 0; while (true) { - int ret = io_getevents(ctx, (int64_t)n_ops, (int64_t)n_ops, evts.data(), - nullptr); + int ret = LibAioLoader::Instance().io_getevents( + ctx, (int64_t)n_ops, (int64_t)n_ops, evts.data(), nullptr); if (ret == (int)n_ops) { break; } @@ -188,7 +198,12 @@ void LinuxAlignedFileReader::register_thread() { IOContext ctx = nullptr; - int ret = io_setup(MAX_EVENTS, &ctx); + if (!LibAioLoader::Instance().Load()) { + LOG_ERROR("libaio not available; cannot register thread for async I/O"); + lk.unlock(); + return; + } + int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); if (ret != 0) { lk.unlock(); if (ret == -EAGAIN) { @@ -226,7 +241,9 @@ void LinuxAlignedFileReader::deregister_thread() { } // io_destroy is a syscall; keep it outside the lock to avoid blocking others - io_destroy(ctx); + if (LibAioLoader::Instance().IsAvailable()) { + LibAioLoader::Instance().io_destroy(ctx); + } LOG_INFO("returned ctx from thread"); #endif } @@ -234,9 +251,12 @@ void LinuxAlignedFileReader::deregister_thread() { void LinuxAlignedFileReader::deregister_all_threads() { #if (defined(__linux) || defined(__linux__)) std::unique_lock lk(ctx_mut); + bool aio_available = LibAioLoader::Instance().IsAvailable(); for (auto x = ctx_map.begin(); x != ctx_map.end(); x++) { IOContext ctx = x->second; - io_destroy(ctx); + if (aio_available) { + LibAioLoader::Instance().io_destroy(ctx); + } } ctx_map.clear(); #endif diff --git a/src/core/algorithm/diskann/diskann_file_reader.h b/src/core/algorithm/diskann/diskann_file_reader.h index 432247e79..2abe8c1aa 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.h +++ b/src/core/algorithm/diskann/diskann_file_reader.h @@ -18,7 +18,7 @@ #include #if (defined(__linux) || defined(__linux__)) -#include +#include "libaio_loader.h" // dlopen-based libaio wrapper #endif #include From 17a7fd50f788450072300216095c202128fd2069 Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 25 Jun 2026 16:16:16 +0800 Subject: [PATCH 02/41] refactor: use dlopen to load libaio --- CMakeLists.txt | 13 +- python/tests/detail/fixture_helper.py | 36 ++- python/tests/test_collection_diskann.py | 12 +- python/zvec/__init__.py | 2 +- src/binding/python/CMakeLists.txt | 36 +-- src/binding/python/binding.cc | 16 +- src/binding/python/exports.map | 19 +- src/core/CMakeLists.txt | 7 +- src/core/algorithm/diskann/CMakeLists.txt | 50 +-- .../algorithm/diskann/diskann_file_reader.cc | 5 +- src/core/algorithm/diskann/libaio_def.h | 190 ++++++++++++ src/core/algorithm/diskann/libaio_loader.h | 144 +++++++++ src/core/interface/indexes/diskann_index.cc | 53 +--- src/core/plugin/CMakeLists.txt | 6 +- src/core/plugin/diskann_plugin.cc | 289 +++--------------- src/db/index/common/schema.cc | 19 +- src/include/zvec/ailego/pattern/factory.h | 21 +- src/include/zvec/plugin/diskann_plugin.h | 34 +-- .../algorithm/diskann/diskann_builder_test.cc | 8 +- 19 files changed, 508 insertions(+), 452 deletions(-) create mode 100644 src/core/algorithm/diskann/libaio_def.h create mode 100644 src/core/algorithm/diskann/libaio_loader.h diff --git a/CMakeLists.txt b/CMakeLists.txt index 392dbdac8..fe8e2e89a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -190,17 +190,8 @@ if(BUILD_PYTHON_BINDINGS) message(STATUS "Zvec install path: ${ZVEC_PY_INSTALL_DIR}") install(TARGETS _zvec LIBRARY DESTINATION ${ZVEC_PY_INSTALL_DIR}) - # DiskAnn ships as a runtime-loaded shared module - # (libzvec_diskann_plugin.so) that is brought online implicitly the - # first time a DiskAnn index is created — users never call any load - # function. The Python extension resolves the module next to _zvec.so - # (see the $ORIGIN rpath in src/binding/python/CMakeLists.txt); the - # module must therefore be installed alongside _zvec.so in the wheel. - # The target exists only on platforms where DiskAnn is buildable - # (currently Linux x86_64 with libaio). - if(TARGET core_knn_diskann) - install(TARGETS core_knn_diskann LIBRARY DESTINATION ${ZVEC_PY_INSTALL_DIR}) - endif() + # DiskAnn is now statically linked into _zvec.so via --whole-archive, + # so no separate runtime .so needs to be installed in the wheel. # Bundle cppjieba's dictionary files so the `jieba` FTS tokenizer works # out of the box. python/zvec/__init__.py resolves this directory via # importlib.resources and registers it with set_default_jieba_dict_dir(). diff --git a/python/tests/detail/fixture_helper.py b/python/tests/detail/fixture_helper.py index 63aac799c..2054546cf 100644 --- a/python/tests/detail/fixture_helper.py +++ b/python/tests/detail/fixture_helper.py @@ -14,18 +14,21 @@ import zvec -# Cache the DiskAnn plugin preload status so we pay the load cost once per -# test session. The plugin normally auto-loads on first DiskAnn use, but we -# preload it explicitly here so a missing libaio / misplaced plugin .so -# surfaces as a clear pytest skip instead of a confusing -# "Create vector column indexer failed" deep inside the collection code path. +# Cache the DiskAnn runtime preload status so we pay the init cost once per +# test session. The runtime normally auto-loads on first DiskAnn use, but we +# preload it explicitly here so a missing libaio surfaces as a clear pytest +# skip instead of a confusing "Create vector column indexer failed" deep +# inside the collection code path. +# Note: DiskAnn is now compiled directly into _zvec.so — there is no separate +# plugin .so to locate. If libaio is missing, DiskAnn falls back to +# synchronous pread() with degraded performance. _DISKANN_PRELOAD_REASON: str | None = None _DISKANN_PRELOAD_DONE: bool = False def _ensure_diskann_runtime_or_reason() -> str | None: - """Preload the DiskAnn plugin and return None on success or a human-readable - skip reason on failure. Idempotent across calls.""" + """Initialize the DiskAnn runtime and return None on success or a + human-readable skip reason on failure. Idempotent across calls.""" global _DISKANN_PRELOAD_DONE, _DISKANN_PRELOAD_REASON if _DISKANN_PRELOAD_DONE: return _DISKANN_PRELOAD_REASON @@ -35,19 +38,20 @@ def _ensure_diskann_runtime_or_reason() -> str | None: _DISKANN_PRELOAD_REASON = "DiskAnn only supported on Linux x86_64" return _DISKANN_PRELOAD_REASON - if not zvec.is_libaio_available(): + status = zvec.load_diskann_plugin() + if status == zvec.DISKANN_PLUGIN_UNSUPPORTED_PLATFORM: _DISKANN_PRELOAD_REASON = ( - "libaio is not available on this host; DiskAnn cannot run. " - "Install libaio1 (or libaio1t64 on Ubuntu 24.04+) and retry." + f"DiskAnn is not supported on this platform (status={status})." ) return _DISKANN_PRELOAD_REASON - - status = zvec.load_diskann_plugin() - if status != zvec.DISKANN_PLUGIN_OK: + # DISKANN_PLUGIN_OK and DISKANN_PLUGIN_LIBAIO_MISSING are both acceptable: + # the latter means DiskAnn will use synchronous pread() instead of async I/O. + if status not in ( + zvec.DISKANN_PLUGIN_OK, + zvec.DISKANN_PLUGIN_LIBAIO_MISSING, + ): _DISKANN_PRELOAD_REASON = ( - f"Failed to load DiskAnn plugin (status={status}); " - "check that libzvec_diskann_plugin.so is installed alongside " - "_zvec.so in the Python site-packages directory." + f"Failed to initialize DiskAnn runtime (status={status})." ) return _DISKANN_PRELOAD_REASON diff --git a/python/tests/test_collection_diskann.py b/python/tests/test_collection_diskann.py index b0e12ce7e..92cbc74e4 100644 --- a/python/tests/test_collection_diskann.py +++ b/python/tests/test_collection_diskann.py @@ -13,17 +13,17 @@ # limitations under the License. """End-to-end collection tests for the DiskAnn index. -Mirrors ``test_collection_hnsw_rabitq.py`` but targets the DiskAnn plugin. +Mirrors ``test_collection_hnsw_rabitq.py`` but targets the DiskAnn index. Two platform-level prerequisites are enforced at module import time: 1. DiskAnn is currently built only for Linux x86_64 — other platforms are skipped wholesale. -2. The DiskAnn backend lives in a *runtime-loaded* plugin - (``libzvec_diskann_plugin.so``). It must be loaded with ``RTLD_GLOBAL | - RTLD_NOW`` BEFORE ``import zvec`` so that the plugin's ``IndexFactory`` - singleton is unified with the one inside ``_zvec.so``. After ``import - zvec`` we must also call ``zvec.load_diskann_plugin()`` exactly once. +2. The DiskAnn runtime is initialized via ``zvec.load_diskann_plugin()``, + which eagerly loads libaio via dlopen(). If libaio is missing, DiskAnn + falls back to synchronous pread() — the tests still run but with degraded + performance. DiskAnn is compiled directly into ``_zvec.so``; there is no + separate plugin .so to locate. If either prerequisite fails the whole module is skipped so the rest of the test-suite is not affected. diff --git a/python/zvec/__init__.py b/python/zvec/__init__.py index 5fdf9732c..a78fcdd75 100644 --- a/python/zvec/__init__.py +++ b/python/zvec/__init__.py @@ -201,7 +201,7 @@ "StatusCode", # Tools "require_module", - # DiskAnn plugin + # DiskAnn runtime "load_diskann_plugin", "is_diskann_plugin_loaded", "is_libaio_available", diff --git a/src/binding/python/CMakeLists.txt b/src/binding/python/CMakeLists.txt index 0db6d75ff..4cc53b6da 100644 --- a/src/binding/python/CMakeLists.txt +++ b/src/binding/python/CMakeLists.txt @@ -22,13 +22,12 @@ pybind11_add_module(_zvec ${SRC_LISTS}) # pybind11_add_module() defaults to CXX_VISIBILITY_PRESET=hidden + # VISIBILITY_INLINES_HIDDEN=ON, which hides the compiler-generated helper # symbols attached to inline functions (guard variables for static locals, -# vtables, typeinfo ...). The DiskAnn runtime plugin has its own copy of -# Factory::Instance()'s guard variable; if _zvec.so's copy -# is hidden, the two guards are separate and the factory constructor runs -# twice during plugin load, wiping out the registrations that happened -# during _zvec.so import. We switch to default visibility here and rely on -# the version script (exports.map / exports.mac) to keep the dynamic -# symbol table small by exporting only zvec::* and PyInit_*. +# vtables, typeinfo ...). DiskAnn is now whole-archived directly into +# _zvec.so (no separate runtime .so), so guard-variable duplication across +# DSOs is no longer a concern. We still keep default visibility so that +# the version script (exports.map / exports.mac) — not the compiler — is +# the sole gatekeeper of the dynamic symbol table, exporting only zvec::* +# and PyInit_*. set_target_properties(_zvec PROPERTIES CXX_VISIBILITY_PRESET default C_VISIBILITY_PRESET default @@ -57,6 +56,7 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux") $ $ $ + $ $ $ $ @@ -69,21 +69,11 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux") target_link_options(_zvec PRIVATE "LINKER:--version-script=${CMAKE_CURRENT_SOURCE_DIR}/exports.map" ) - # DiskAnn is x86-only (it depends on libaio, unavailable on ARM64), so the - # runtime plugin (libzvec_diskann_plugin.so) is only produced on non-ARM - # builds. It is shipped as a runtime-loaded shared module and brought up - # implicitly the first time a DiskAnn index is created — users never need to - # call any load function. If libaio is missing at runtime the auto-load - # fails cleanly and the error is surfaced only when DiskAnn is actually - # used; other index types (HNSW/IVF/Flat/Vamana) remain fully functional. - # The .so must therefore be discoverable next to the extension module, - # hence the $ORIGIN rpath below. - if (NOT CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64|arm64|arm") - set_target_properties(_zvec PROPERTIES - BUILD_RPATH "$ORIGIN" - INSTALL_RPATH "$ORIGIN" - ) - endif() + # DiskAnn is now statically linked into _zvec.so via --whole-archive, so + # no separate runtime .so is shipped in the wheel. libaio is still loaded + # at runtime via dlopen() (see libaio_loader.h); if it is missing, DiskAnn + # fails cleanly with an actionable error while other index types + # (HNSW/IVF/Flat/Vamana) remain fully functional. elseif (APPLE) target_link_libraries(_zvec PRIVATE -Wl,-force_load,$ @@ -94,6 +84,7 @@ elseif (APPLE) -Wl,-force_load,$ -Wl,-force_load,$ -Wl,-force_load,$ + -Wl,-force_load,$ -Wl,-force_load,$ -Wl,-force_load,$ -Wl,-force_load,$ @@ -113,6 +104,7 @@ elseif (MSVC) core_knn_ivf_static core_knn_vamana_static core_knn_cluster_static + core_knn_diskann_static core_mix_reducer_static core_metric_static core_utility_static diff --git a/src/binding/python/binding.cc b/src/binding/python/binding.cc index ecb4d91bb..4e257472f 100644 --- a/src/binding/python/binding.cc +++ b/src/binding/python/binding.cc @@ -26,18 +26,20 @@ namespace zvec { namespace { -// Expose DiskAnn plugin management to Python. The DiskAnn runtime normally -// auto-loads on first use, but tests (and diagnostic tooling) need a way to -// force a load up-front and get actionable errors when libaio is missing or -// the plugin shared object cannot be located. +// Expose DiskAnn runtime management to Python. DiskAnn is compiled directly +// into _zvec.so, so "loading" just means eagerly dlopen()-ing libaio and +// caching the result. Tests (and diagnostic tooling) use these entry points +// to force the load up-front and get actionable warnings when libaio is +// missing. void InitializeDiskAnnPluginBindings(pybind11::module_ &m) { m.def( "load_diskann_plugin", [](const std::string &path) { return ::zvec::LoadDiskAnnPlugin(path); }, pybind11::arg("path") = std::string(), - "Load the DiskAnn runtime plugin. Returns 0 on success or a negative " - "DiskAnnPluginStatus code on failure (unsupported platform, libaio " - "missing, or dlopen failure)."); + "Load libaio for the DiskAnn runtime. Returns DISKANN_PLUGIN_OK (0) " + "on success, or DISKANN_PLUGIN_LIBAIO_MISSING if libaio is not " + "available (DiskAnn falls back to synchronous pread in that case). " + "Returns a negative code for unsupported platforms."); m.def("is_diskann_plugin_loaded", &::zvec::IsDiskAnnPluginLoaded, "Return True if the DiskAnn runtime plugin is currently loaded."); m.def("is_libaio_available", &::zvec::IsLibAioAvailable, diff --git a/src/binding/python/exports.map b/src/binding/python/exports.map index 553da0055..76cc27953 100644 --- a/src/binding/python/exports.map +++ b/src/binding/python/exports.map @@ -3,23 +3,20 @@ # Python module entry point(s). PyInit_*; - # Expose the full zvec C++ namespace so the DiskAnn runtime plugin - # (libzvec_diskann_plugin.so), which is dlopen()ed with - # RTLD_NOW | RTLD_GLOBAL after the interpreter has loaded _zvec.so, - # can resolve its undefined references against this module. Without - # this, the plugin fails to load with errors like - # undefined symbol: _ZN4zvec6ailego6Logger10LEVEL_INFOE - # because the default version script hides every internal symbol. + # Expose the full zvec C++ namespace so that the C API binding + # (and any C++ consumer that links against _zvec.so) can resolve + # zvec:: symbols. DiskAnn is now statically linked into _zvec.so, + # so these exports are no longer needed for runtime plugin loading, + # but they are still required for the C API and for C++ consumers + # that link against the shared module. extern "C++" { "zvec::*"; zvec::*; # Also export the compiler-generated helper symbols that live # alongside symbols in the zvec namespace (guard variables for # static locals, vtables, typeinfo, VTT, construction vtables, - # thunks). Without these, the DiskAnn plugin and _zvec.so each - # get their own copy of e.g. the guard for Factory::Instance's - # static local, which causes the factory constructor to run - # twice - wiping out registrations done during _zvec.so load. + # thunks). These are needed so that factory singletons and + # vtables are unified across translation units. "guard variable for zvec::*"; "vtable for zvec::*"; "VTT for zvec::*"; diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 6405c3220..15e684188 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -63,9 +63,10 @@ endif() # Always exclude algorithm/diskann implementation files from zvec_core. # The DiskAnn algorithm is provided by the separate core_knn_diskann library -# (real on Linux x86_64, stub on other platforms). Including them here causes -# duplicate symbols and missing -laio when test binaries link both zvec_core -# (via zvec) and core_knn_diskann. +# (STATIC+SHARED, real on Linux x86_64, stub on other platforms). The static +# variant is whole-archived into _zvec.so for the Python wheel; the shared +# variant is used by C++ tools and tests. Including the sources here would +# cause duplicate symbols. list(FILTER ALL_CORE_SRCS EXCLUDE REGEX ".*/algorithm/diskann/.*") if(NOT DISKANN_SUPPORTED) list(FILTER ALL_CORE_SRCS EXCLUDE REGEX ".*/interface/indexes/diskann_index\\.cc") diff --git a/src/core/algorithm/diskann/CMakeLists.txt b/src/core/algorithm/diskann/CMakeLists.txt index e2fa911f5..5f1b7bf7f 100644 --- a/src/core/algorithm/diskann/CMakeLists.txt +++ b/src/core/algorithm/diskann/CMakeLists.txt @@ -1,56 +1,34 @@ include(${PROJECT_ROOT_DIR}/cmake/bazel.cmake) +include(${PROJECT_ROOT_DIR}/cmake/option.cmake) file(GLOB_RECURSE ALL_SRCS *.cc *.c) -# The DiskAnn plugin is loaded at runtime via zvec::LoadDiskAnnPlugin() with -# RTLD_GLOBAL, so its undefined references to internal zvec symbols -# (core_framework, core_knn_cluster, zvec_ailego, ...) are resolved at load -# time against the hosting binary (_zvec.so for the Python extension, the -# test executable for gtest, or libzvec_core for tools). -# -# As a consequence the plugin .so must NOT carry NEEDED entries for those -# libs: otherwise the dynamic loader would try to resolve them from disk -# before invoking dlopen's RTLD_GLOBAL symbol sharing, and the Python wheel -# (which only ships _zvec.so + the plugin) would fail to load. +# DiskAnn is compiled as a STATIC+SHARED library (matching the pattern used by +# core_knn_hnsw, core_knn_cluster, etc.). The static variant +# (core_knn_diskann_static) is whole-archived into _zvec.so for the Python +# wheel, so no separate runtime .so is needed. The shared variant is used by +# C++ tools and tests that link against it directly. # # libaio is loaded at runtime via dlopen()/dlsym() (see libaio_loader.h), so # we do NOT link against -laio. The only system-level link dependency is # ${CMAKE_DL_LIBS} for dlopen/dlsym/dlclose. -set(CORE_KNN_DISKANN_LIBS "") +set(CORE_KNN_DISKANN_LIBS core_framework core_knn_cluster) if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|i686|i386") list(APPEND CORE_KNN_DISKANN_LIBS ${CMAKE_DL_LIBS}) endif() +if(NOT APPLE) + set(CORE_KNN_DISKANN_LDFLAGS + "-Wl,--exclude-libs,libparquet.a:libarrow.a:libarrow_bundled_dependencies.a") +endif() + cc_library( NAME core_knn_diskann - SHARED STRICT + STATIC SHARED STRICT ALWAYS_LINK SRCS *.cc LIBS ${CORE_KNN_DISKANN_LIBS} INCS . ${PROJECT_ROOT_DIR}/src/core ${PROJECT_ROOT_DIR}/src/core/algorithm + LDFLAGS "${CORE_KNN_DISKANN_LDFLAGS}" VERSION "${PROXIMA_ZVEC_VERSION}" -) - -# Internal zvec libs are referenced only for header availability; the actual -# symbol resolution happens at dlopen time. Expose their public include dirs -# without adding them as link dependencies. -foreach(_dep zvec_ailego core_framework core_knn_cluster) - if(TARGET ${_dep}) - target_include_directories(core_knn_diskann PRIVATE - $) - add_dependencies(core_knn_diskann ${_dep}) - endif() -endforeach() - -# Allow the plugin to have unresolved symbols that will be satisfied at -# dlopen(RTLD_NOW | RTLD_GLOBAL) time by the hosting binary. -if(CMAKE_SYSTEM_NAME STREQUAL "Linux") - target_link_options(core_knn_diskann PRIVATE - "LINKER:--unresolved-symbols=ignore-all") -endif() - -# Rename the artifact to libzvec_diskann_plugin.so so it is clearly identified -# as an optional plugin that users load at runtime via zvec::LoadDiskAnnPlugin(). -set_target_properties(core_knn_diskann PROPERTIES - OUTPUT_NAME zvec_diskann_plugin ) \ No newline at end of file diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index 34584d935..c8d8bdd0b 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -33,7 +33,8 @@ typedef struct iocb iocb_t; int setup_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) if (!LibAioLoader::Instance().Load()) { - return -ENOSYS; + LOG_WARN("libaio not available; falling back to synchronous pread"); + return 0; } int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); @@ -199,7 +200,7 @@ void LinuxAlignedFileReader::register_thread() { IOContext ctx = nullptr; if (!LibAioLoader::Instance().Load()) { - LOG_ERROR("libaio not available; cannot register thread for async I/O"); + LOG_WARN("libaio not available; async I/O disabled, will use pread"); lk.unlock(); return; } diff --git a/src/core/algorithm/diskann/libaio_def.h b/src/core/algorithm/diskann/libaio_def.h new file mode 100644 index 000000000..ce95bc982 --- /dev/null +++ b/src/core/algorithm/diskann/libaio_def.h @@ -0,0 +1,190 @@ +// Copyright 2025-present the zvec project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Private replacement for . +// +// This header declares *only* the types, constants, and inline helpers that +// zvec needs from libaio. By doing so the project is completely decoupled +// from the system libaio-dev header: there is no `#include ` anywhere +// in the source tree, which means libaio-dev does not need to be installed at +// build time and the code is portable to cross-compilation environments that +// lack the header. +// +// The struct layouts (struct iocb, struct io_event, ...) are part of the Linux +// kernel ABI. They are copied verbatim from the upstream , including +// the PADDED macros that handle architecture-specific padding. The inline +// helper io_prep_pread() is likewise copied — it only manipulates struct fields +// and does not call into the library. + +#pragma once + +#include // struct timespec (used by io_getevents signature) +#include // memset() — used by io_prep_pread() inline helper + +#if defined(__linux) || defined(__linux__) + +struct sockaddr; +struct iovec; + +// --------------------------------------------------------------------------- +// Type and struct definitions copied from +// --------------------------------------------------------------------------- + +typedef struct io_context *io_context_t; + +typedef enum io_iocb_cmd { + IO_CMD_PREAD = 0, + IO_CMD_PWRITE = 1, + IO_CMD_FSYNC = 2, + IO_CMD_FDSYNC = 3, + IO_CMD_POLL = 5, + IO_CMD_NOOP = 6, + IO_CMD_PREADV = 7, + IO_CMD_PWRITEV = 8, +} io_iocb_cmd_t; + +// PADDED macros — copied verbatim from to guarantee ABI-compatible +// struct layout on every supported architecture. + +/* little endian, 32 bits */ +#if defined(__i386__) || (defined(__x86_64__) && defined(__ILP32__)) || \ + (defined(__arm__) && !defined(__ARMEB__)) || \ + (defined(__sh__) && defined(__LITTLE_ENDIAN__)) || defined(__bfin__) || \ + (defined(__MIPSEL__) && !defined(__mips64)) || defined(__cris__) || \ + defined(__loongarch32) || (defined(__riscv) && __riscv_xlen == 32) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ && __SIZEOF_LONG__ == 4) +#define AIO_PADDED(x, y) \ + x; \ + unsigned y +#define AIO_PADDEDptr(x, y) \ + x; \ + unsigned y +#define AIO_PADDEDul(x, y) \ + unsigned long x; \ + unsigned y + +/* little endian, 64 bits */ +#elif defined(__ia64__) || defined(__x86_64__) || defined(__alpha__) || \ + (defined(__mips64) && defined(__MIPSEL__)) || \ + (defined(__aarch64__) && defined(__AARCH64EL__)) || \ + defined(__loongarch64) || (defined(__riscv) && __riscv_xlen == 64) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ && __SIZEOF_LONG__ == 8) +#define AIO_PADDED(x, y) x, y +#define AIO_PADDEDptr(x, y) x +#define AIO_PADDEDul(x, y) unsigned long x + +/* big endian, 64 bits */ +#elif defined(__powerpc64__) || defined(__s390x__) || \ + (defined(__hppa__) && defined(__arch64__)) || \ + (defined(__sparc__) && defined(__arch64__)) || \ + (defined(__mips64) && defined(__MIPSEB__)) || \ + (defined(__aarch64__) && defined(__AARCH64EB__)) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ && __SIZEOF_LONG__ == 8) +#define AIO_PADDED(x, y) \ + unsigned y; \ + x +#define AIO_PADDEDptr(x, y) x +#define AIO_PADDEDul(x, y) unsigned long x + +/* big endian, 32 bits */ +#elif defined(__PPC__) || defined(__s390__) || \ + (defined(__arm__) && defined(__ARMEB__)) || \ + (defined(__sh__) && defined(__BIG_ENDIAN__)) || defined(__sparc__) || \ + defined(__MIPSEB__) || defined(__m68k__) || defined(__hppa__) || \ + defined(__frv__) || defined(__avr32__) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ && __SIZEOF_LONG__ == 4) +#define AIO_PADDED(x, y) \ + unsigned y; \ + x +#define AIO_PADDEDptr(x, y) \ + unsigned y; \ + x +#define AIO_PADDEDul(x, y) \ + unsigned y; \ + unsigned long x + +#else +#error endianness? +#endif + +struct io_iocb_poll { + AIO_PADDED(int events, __pad1); +}; + +struct io_iocb_sockaddr { + AIO_PADDEDptr(struct sockaddr *addr, __pad1); + AIO_PADDEDul(len, __pad2); +}; + +struct io_iocb_common { + AIO_PADDEDptr(void *buf, __pad1); + AIO_PADDEDul(nbytes, __pad2); + long long offset; + long long __pad3; + unsigned flags; + unsigned resfd; +}; + +struct io_iocb_vector { + AIO_PADDEDptr(const struct iovec *vec, __pad1); + AIO_PADDEDul(nr, __pad2); + long long offset; +}; + +struct iocb { + AIO_PADDEDptr(void *data, __pad1); + AIO_PADDED(unsigned key, aio_rw_flags); + short aio_lio_opcode; + short aio_reqprio; + int aio_fildes; + union { + struct io_iocb_common c; + struct io_iocb_vector v; + struct io_iocb_poll poll; + struct io_iocb_sockaddr saddr; + } u; +}; + +struct io_event { + AIO_PADDEDptr(void *data, __pad1); + AIO_PADDEDptr(struct iocb *obj, __pad2); + AIO_PADDEDul(res, __pad3); + AIO_PADDEDul(res2, __pad4); +}; + +#undef AIO_PADDED +#undef AIO_PADDEDptr +#undef AIO_PADDEDul + +// Inline helper — copied from . Only manipulates struct fields. +static inline void io_prep_pread(struct iocb *iocb, int fd, void *buf, + size_t count, long long offset) { + memset(iocb, 0, sizeof(*iocb)); + iocb->aio_fildes = fd; + iocb->aio_lio_opcode = IO_CMD_PREAD; + iocb->aio_reqprio = 0; + iocb->u.c.buf = buf; + iocb->u.c.nbytes = count; + iocb->u.c.offset = offset; +} + +// --------------------------------------------------------------------------- +// End: type and struct definitions from +// --------------------------------------------------------------------------- + +#endif // __linux__ diff --git a/src/core/algorithm/diskann/libaio_loader.h b/src/core/algorithm/diskann/libaio_loader.h new file mode 100644 index 000000000..dca400ff9 --- /dev/null +++ b/src/core/algorithm/diskann/libaio_loader.h @@ -0,0 +1,144 @@ +// Copyright 2025-present the zvec project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// dlopen-based wrapper for libaio. Instead of linking against -laio at build +// time, the DiskAnn plugin loads libaio at runtime via dlopen()/dlsym(). This +// removes libaio as a hard build- and load-time dependency: the plugin .so no +// longer carries a NEEDED entry for libaio.so.1, so it can be dlopen'ed on +// hosts that don't have libaio installed. Callers that actually exercise the +// async-I/O path will fall back to synchronous pread() when libaio is absent. +// +// All ABI-stable type and struct definitions (struct iocb, struct io_event, +// io_context_t, PADDED macros, io_prep_pread(), ...) now live in libaio_def.h — +// a private header that replaces so the project has zero build-time +// dependency on libaio-dev. + +#pragma once + +#if defined(__linux) || defined(__linux__) + +#include +#include +#include +#include +#include "libaio_def.h" // ABI-stable struct definitions (replaces ) + +// Function-pointer typedefs for the four libaio syscalls used by DiskAnn. +typedef int (*aio_setup_fn)(int maxevents, io_context_t *ctxp); +typedef int (*aio_destroy_fn)(io_context_t ctx); +typedef int (*aio_submit_fn)(io_context_t ctx, long nr, struct iocb *ios[]); +typedef int (*aio_getevents_fn)(io_context_t ctx, long min_nr, long nr, + struct io_event *events, + struct timespec *timeout); + +// Runtime loader for libaio. Thread-safe singleton that dlopen()'s libaio +// once and caches the function pointers. If libaio is not present on the +// host, all pointers remain nullptr and callers should fall back to +// synchronous I/O (pread). +// +// Usage: +// if (LibAioLoader::Instance().Load()) { +// LibAioLoader::Instance().io_setup(...); +// } +class LibAioLoader { + public: + static LibAioLoader &Instance() { + static LibAioLoader instance; + return instance; + } + + // Load (or confirm already loaded) libaio. Returns true on success. + // Thread-safe and idempotent. + bool Load() { + if (available_.load(std::memory_order_acquire)) { + return true; + } + std::call_once(once_, [this] { this->TryLoad(); }); + return available_.load(std::memory_order_relaxed); + } + + bool IsAvailable() const { + return available_.load(std::memory_order_acquire); + } + + // Function pointers — nullptr until Load() succeeds. + aio_setup_fn io_setup; + aio_destroy_fn io_destroy; + aio_submit_fn io_submit; + aio_getevents_fn io_getevents; + + private: + LibAioLoader() + : io_setup(nullptr), + io_destroy(nullptr), + io_submit(nullptr), + io_getevents(nullptr) {} + + ~LibAioLoader() { + if (handle_ != nullptr) { + dlclose(handle_); + } + } + + LibAioLoader(const LibAioLoader &) = delete; + LibAioLoader &operator=(const LibAioLoader &) = delete; + + void TryLoad() { + // On Ubuntu 24.04 the libaio package was renamed with the t64 suffix + // (64-bit time_t transition), so probe both spellings. + static constexpr const char *kSonames[] = { + "libaio.so.1", + "libaio.so.1t64", + }; + + for (const char *soname : kSonames) { + void *h = dlopen(soname, RTLD_LAZY); + if (h == nullptr) { + continue; + } + + io_setup = reinterpret_cast(dlsym(h, "io_setup")); + io_destroy = reinterpret_cast(dlsym(h, "io_destroy")); + io_submit = reinterpret_cast(dlsym(h, "io_submit")); + + // io_getevents may be redirected to io_getevents_time64 on 32-bit + // platforms compiled with _TIME_BITS=64. + io_getevents = + reinterpret_cast(dlsym(h, "io_getevents")); + if (io_getevents == nullptr) { + io_getevents = + reinterpret_cast(dlsym(h, "io_getevents_time64")); + } + + if (io_setup && io_destroy && io_submit && io_getevents) { + handle_ = h; + available_.store(true, std::memory_order_release); + return; + } + + // Some symbols missing — try the next soname. + dlclose(h); + io_setup = nullptr; + io_destroy = nullptr; + io_submit = nullptr; + io_getevents = nullptr; + } + } + + std::once_flag once_; + std::atomic available_{false}; + void *handle_{nullptr}; +}; + +#endif // __linux__ diff --git a/src/core/interface/indexes/diskann_index.cc b/src/core/interface/indexes/diskann_index.cc index 7615ed354..1ec54f265 100644 --- a/src/core/interface/indexes/diskann_index.cc +++ b/src/core/interface/indexes/diskann_index.cc @@ -16,61 +16,16 @@ #include #include #include -#include #include "algorithm/diskann/diskann_params.h" #include "holder_builder.h" namespace zvec::core_interface { -namespace { - -// Implicitly bring the DiskAnn runtime online on first use. This keeps the -// DiskAnn index an ordinary public API (users just instantiate a -// DiskAnnIndexParam) while still letting the rest of the library — HNSW, -// IVF, Flat, Vamana — run on hosts that happen to lack libaio. On such -// hosts only DiskAnn fails, with a clear, actionable error message, and -// every other index type stays fully functional. -int EnsureDiskAnnRuntimeReady() { - static std::once_flag once; - static int cached_result = 0; - std::call_once(once, []() { - const int status = ::zvec::LoadDiskAnnPlugin(); - if (status == kDiskAnnPluginOk) { - cached_result = 0; - return; - } - switch (status) { - case kDiskAnnPluginLibAioMissing: - LOG_ERROR( - "DiskAnn requires libaio at runtime, but it was not found on this " - "host. Install it (e.g. 'apt-get install libaio1' on " - "Debian/Ubuntu, " - "or 'libaio1t64' on Ubuntu 24.04+) and retry."); - break; - case kDiskAnnPluginUnsupportedPlatform: - LOG_ERROR("DiskAnn is only supported on Linux x86_64."); - break; - case kDiskAnnPluginDlopenFailed: - default: - LOG_ERROR("Failed to initialize the DiskAnn runtime (status=%d).", - status); - break; - } - cached_result = core::IndexError_Runtime; - }); - return cached_result; -} - -} // namespace - int DiskAnnIndex::CreateAndInitStreamer(const BaseIndexParam ¶m) { - // Fail fast and cleanly if the DiskAnn runtime cannot be brought up on - // this host (most commonly: libaio is missing). The rest of zvec keeps - // running; only DiskAnn is unusable. - if (int rc = EnsureDiskAnnRuntimeReady(); rc != 0) { - return rc; - } - + // Platform and libaio checks are handled earlier at schema validation + // time (schema.cc calls LoadDiskAnnPlugin). If libaio is missing, DiskAnn + // falls back to synchronous pread() in diskann_file_reader.cc — no need + // to re-check here. if (is_sparse_) { LOG_ERROR("Failed to create streamer. Sparse is not Supported."); return core::IndexError_Unsupported; diff --git a/src/core/plugin/CMakeLists.txt b/src/core/plugin/CMakeLists.txt index 510677aed..808e35f57 100644 --- a/src/core/plugin/CMakeLists.txt +++ b/src/core/plugin/CMakeLists.txt @@ -2,13 +2,13 @@ ## Copyright (C) The Software Authors. All rights reserved. ## ## \file CMakeLists.txt -## \brief Build script for the zvec internal plugin-loading glue library. +## \brief Build script for the zvec internal DiskAnn runtime-init glue. ## Lives inside the main zvec_core artifact and provides the ## implicit DiskAnn runtime bring-up used by DiskAnnIndex on first ## use. These APIs are NOT part of the public user surface: users ## simply instantiate ``DiskAnnIndexParam`` / ``DiskAnnIndex`` and -## the runtime (``libzvec_diskann_plugin.so``) is loaded behind -## the scenes. +## libaio is loaded behind the scenes via dlopen(). DiskAnn itself +## is compiled directly into the hosting binary. ## include(${PROJECT_ROOT_DIR}/cmake/bazel.cmake) diff --git a/src/core/plugin/diskann_plugin.cc b/src/core/plugin/diskann_plugin.cc index 9d4e9d0f5..d9af30276 100644 --- a/src/core/plugin/diskann_plugin.cc +++ b/src/core/plugin/diskann_plugin.cc @@ -15,7 +15,6 @@ #include #include #include -#include #include #include @@ -28,295 +27,97 @@ #include #endif +// Include the libaio dlopen wrapper so we can load libaio eagerly at DiskAnn +// bring-up time (instead of waiting for the first I/O operation). +#if defined(__linux__) || defined(__linux) +#include "algorithm/diskann/libaio_loader.h" +#endif + namespace zvec { namespace { #if defined(__linux__) || defined(__linux) -constexpr const char *kPluginFileName = "libzvec_diskann_plugin.so"; -// Candidate soname list. On Ubuntu 24.04 the libaio package was renamed with -// the t64 suffix (64-bit time_t transition), so we probe both spellings. -constexpr const char *kLibAioSoNames[] = { - "libaio.so.1", - "libaio.so.1t64", -}; -constexpr bool kPlatformSupportsDiskAnnPlugin = true; +constexpr bool kPlatformSupportsDiskAnn = true; #elif defined(__APPLE__) -[[maybe_unused]] constexpr const char *kPluginFileName = - "libzvec_diskann_plugin.dylib"; -constexpr bool kPlatformSupportsDiskAnnPlugin = false; +constexpr bool kPlatformSupportsDiskAnn = false; #else -[[maybe_unused]] constexpr const char *kPluginFileName = - "zvec_diskann_plugin.dll"; -constexpr bool kPlatformSupportsDiskAnnPlugin = false; +constexpr bool kPlatformSupportsDiskAnn = false; #endif -// Global plugin handle. Nullptr means "not loaded". -std::atomic g_plugin_handle{nullptr}; -std::mutex g_plugin_mutex; - -#if defined(__linux__) || defined(__linux) - -// Resolve the directory containing the currently running executable, so we -// can look for the plugin next to it regardless of the working directory. -std::string GetExecutableDir() { - char buf[PATH_MAX]; - ssize_t n = ::readlink("/proc/self/exe", buf, sizeof(buf) - 1); - if (n <= 0) { - return {}; - } - buf[n] = '\0'; - std::string path(buf); - auto slash = path.find_last_of('/'); - if (slash == std::string::npos) { - return {}; - } - return path.substr(0, slash); -} - -// Resolve the directory containing the shared object that hosts this -// function. For Python wheels this is the directory of -// ``_zvec.cpython-*.so``; for regular C++ binaries it is the directory of -// ``libzvec_core.so``. In either case the DiskAnn plugin is shipped -// alongside, so this is the most reliable lookup location. -// -// NOTE: we pass the address of an *exported* function (LoadDiskAnnPlugin) -// rather than one in this anonymous namespace, because dladdr() on a symbol -// with internal linkage can report the main executable instead of the -// hosting shared object when the translation unit is whole-archived into -// another .so. -std::string ResolveHostingSoDir() { - ::Dl_info info{}; - if (::dladdr(reinterpret_cast(&::zvec::LoadDiskAnnPlugin), &info) == - 0 || - info.dli_fname == nullptr) { - return {}; - } - std::string path(info.dli_fname); - auto slash = path.find_last_of('/'); - if (slash == std::string::npos) { - return {}; - } - return path.substr(0, slash); -} - -// Full path of the shared object that hosts LoadDiskAnnPlugin, or empty -// string on failure. -std::string ResolveHostingSoPath() { - ::Dl_info info{}; - if (::dladdr(reinterpret_cast(&::zvec::LoadDiskAnnPlugin), &info) == - 0 || - info.dli_fname == nullptr) { - return {}; - } - return std::string(info.dli_fname); -} - -// Promote the hosting shared object (e.g. the Python extension module -// ``_zvec.cpython-*.so``) to the global symbol scope. Python loads C -// extensions with RTLD_LOCAL by default, which means their C++ symbols are -// invisible to subsequently dlopen(RTLD_GLOBAL)ed libraries. Without this -// promotion, the DiskAnn plugin's undefined references to zvec:: symbols -// cannot be resolved against the already-loaded host module and dlopen -// fails with messages like: -// -// undefined symbol: _ZN4zvec6ailego6Logger10LEVEL_INFOE -// -// Using RTLD_NOLOAD re-opens the existing image without loading it again, -// while RTLD_GLOBAL merges its symbols into the global scope. This is a -// no-op for hosts that were already loaded with RTLD_GLOBAL. -void PromoteHostingSoToGlobal() { - const std::string host = ResolveHostingSoPath(); - if (host.empty()) { - return; - } - // When LoadDiskAnnPlugin is statically linked into the main executable, - // dladdr resolves to the executable itself. The main exe's symbols are - // already in the global scope by definition, so skip promotion. - const std::string exe_path = GetExecutableDir(); - if (!exe_path.empty()) { - char exe_buf[PATH_MAX]; - ssize_t n = ::readlink("/proc/self/exe", exe_buf, sizeof(exe_buf) - 1); - if (n > 0) { - exe_buf[n] = '\0'; - // Compare resolved real paths to handle relative vs absolute. - char host_real[PATH_MAX]; - char exe_real[PATH_MAX]; - if (::realpath(host.c_str(), host_real) != nullptr && - ::realpath(exe_buf, exe_real) != nullptr && - std::string(host_real) == std::string(exe_real)) { - // Host IS the main executable; symbols are already global. - return; - } - } - } - void *h = ::dlopen(host.c_str(), RTLD_NOW | RTLD_GLOBAL | RTLD_NOLOAD); - if (h == nullptr) { - const char *err = ::dlerror(); - LOG_WARN("Could not promote host '%s' to RTLD_GLOBAL: %s", host.c_str(), - err ? err : "unknown"); - return; - } - // We purposely keep the handle refcount incremented for the life of the - // process: there is no safe point at which to dlclose() it, and doing so - // would only decrement the count anyway (the image remains mapped because - // Python still holds its own reference). - (void)h; -} - -// Build the list of candidate paths for the plugin. -std::vector BuildCandidatePaths(const std::string &explicit_path) { - std::vector candidates; - if (!explicit_path.empty()) { - candidates.push_back(explicit_path); - return candidates; - } - - // Helper that pushes both ``/`` and ``/../lib/`` - // to handle the conventional CMake build layout where executables live in - // ``bin/`` while shared objects (including this plugin) live in ``lib/``. - auto push_dir_candidates = [&candidates](const std::string &dir) { - if (dir.empty()) { - return; - } - candidates.push_back(dir + "/" + kPluginFileName); - candidates.push_back(dir + "/../lib/" + kPluginFileName); - }; - - // 1. Directory of the library that hosts LoadDiskAnnPlugin (e.g. the - // Python extension module or libzvec_core). This works for Python, - // C++ embedding, and most packaging layouts. - const std::string own_dir = ResolveHostingSoDir(); - push_dir_candidates(own_dir); - // 2. Directory of the running executable. Useful for self-contained C++ - // tools that drop the plugin next to their binary, as well as for the - // standard CMake bin/lib split (handled by ``../lib/`` above). - const std::string exe_dir = GetExecutableDir(); - if (!exe_dir.empty() && exe_dir != own_dir) { - push_dir_candidates(exe_dir); - } - // 3. Fallback: rely on the dynamic linker's default search path - // (RPATH / LD_LIBRARY_PATH / /etc/ld.so.conf). - candidates.emplace_back(kPluginFileName); - return candidates; -} - -#endif // linux +// Tracks whether the DiskAnn runtime has been initialised. Since DiskAnn is +// now compiled directly into the hosting binary (_zvec.so for Python, the test +// executable for gtest, etc.) there is no separate .so to dlopen; the "loaded" +// flag simply means libaio has been probed and the result cached. +std::atomic g_runtime_ready{false}; +std::mutex g_runtime_mutex; } // namespace bool IsLibAioAvailable() { #if defined(__linux__) || defined(__linux) - const char *kRequiredSymbols[] = {"io_setup", "io_submit", "io_getevents", - "io_destroy"}; - for (const char *soname : kLibAioSoNames) { - // RTLD_LAZY keeps the cost low; we only need to know whether the library - // is resolvable and exposes the symbols DiskAnn actually calls. - void *handle = ::dlopen(soname, RTLD_LAZY); - if (handle == nullptr) { - continue; - } - bool ok = true; - for (const char *sym : kRequiredSymbols) { - if (::dlsym(handle, sym) == nullptr) { - ok = false; - break; - } - } - ::dlclose(handle); - if (ok) { - return true; - } - } - return false; + // Use the LibAioLoader singleton so we share the cached dlopen handle with + // the DiskAnn file reader. Load() is idempotent and thread-safe. + return LibAioLoader::Instance().Load(); #else return false; #endif } bool IsDiskAnnPluginLoaded() { - return g_plugin_handle.load(std::memory_order_acquire) != nullptr; + return g_runtime_ready.load(std::memory_order_acquire); } int LoadDiskAnnPlugin(const std::string &path) { - if (!kPlatformSupportsDiskAnnPlugin) { + (void)path; // No external path needed — DiskAnn is linked in statically. + + if (!kPlatformSupportsDiskAnn) { LOG_ERROR( - "DiskAnn plugin is not supported on this platform; it is only " + "DiskAnn is not supported on this platform; it is only " "available on Linux x86_64 with libaio."); return kDiskAnnPluginUnsupportedPlatform; } #if defined(__linux__) || defined(__linux) - // Fast path: already loaded. - if (g_plugin_handle.load(std::memory_order_acquire) != nullptr) { + // Fast path: already initialised. + if (g_runtime_ready.load(std::memory_order_acquire)) { return kDiskAnnPluginOk; } - std::lock_guard lock(g_plugin_mutex); - if (g_plugin_handle.load(std::memory_order_relaxed) != nullptr) { + std::lock_guard lock(g_runtime_mutex); + if (g_runtime_ready.load(std::memory_order_relaxed)) { return kDiskAnnPluginOk; } - if (!IsLibAioAvailable()) { - LOG_ERROR( - "libaio is not available on this host; the DiskAnn runtime cannot be " - "activated. Install libaio1 (e.g. 'apt-get install libaio1', or " - "'libaio1t64' on Ubuntu 24.04+) and retry. This does not affect " - "other index types (HNSW, IVF, Flat, Vamana)."); + // Eagerly load libaio at DiskAnn bring-up time so the user gets immediate + // feedback (success or failure) rather than a delayed error on the first + // async-I/O operation. + LOG_INFO("DiskAnn: initializing runtime — loading libaio ..."); + if (!LibAioLoader::Instance().Load()) { + LOG_WARN( + "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " + "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " + "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " + "to synchronous pread() — performance will be degraded. Other " + "index types (HNSW/IVF/Flat/Vamana) are unaffected."); + // We still mark the runtime as "ready" — DiskAnn code is linked in and + // the file reader will gracefully fall back to pread(). The user gets + // a clear warning now rather than a hard failure later. + g_runtime_ready.store(true, std::memory_order_release); return kDiskAnnPluginLibAioMissing; } - const std::vector candidates = BuildCandidatePaths(path); - // Ensure the hosting module's C++ symbols (zvec::*) are visible to the - // plugin at dlopen time. See PromoteHostingSoToGlobal() for the rationale. - PromoteHostingSoToGlobal(); - void *handle = nullptr; - std::string last_error; - for (const std::string &candidate : candidates) { - // RTLD_GLOBAL so the plugin's factory registrations (which live in the - // plugin's own static-init code) can reference symbols from the main - // library, and any callers that later dlsym against the process can see - // the plugin's symbols. - handle = ::dlopen(candidate.c_str(), RTLD_NOW | RTLD_GLOBAL); - if (handle != nullptr) { - LOG_INFO("Loaded DiskAnn plugin from: %s", candidate.c_str()); - break; - } - const char *err = ::dlerror(); - last_error = err ? err : "unknown dlopen error"; - LOG_DEBUG("dlopen(%s) failed: %s", candidate.c_str(), last_error.c_str()); - } - - if (handle == nullptr) { - LOG_ERROR("Failed to load DiskAnn plugin; last error: %s", - last_error.c_str()); - return kDiskAnnPluginDlopenFailed; - } - - g_plugin_handle.store(handle, std::memory_order_release); + LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); + g_runtime_ready.store(true, std::memory_order_release); return kDiskAnnPluginOk; #else - (void)path; return kDiskAnnPluginUnsupportedPlatform; #endif } bool UnloadDiskAnnPlugin() { -#if defined(__linux__) || defined(__linux) - std::lock_guard lock(g_plugin_mutex); - void *handle = g_plugin_handle.exchange(nullptr, std::memory_order_acq_rel); - if (handle == nullptr) { - return false; - } - if (::dlclose(handle) != 0) { - const char *err = ::dlerror(); - LOG_WARN("dlclose for DiskAnn plugin returned non-zero: %s", - err ? err : "unknown"); - } - return true; -#else + // DiskAnn is statically linked — there is nothing to unload. return false; -#endif } } // namespace zvec diff --git a/src/db/index/common/schema.cc b/src/db/index/common/schema.cc index 9471eee90..bf5b02d38 100644 --- a/src/db/index/common/schema.cc +++ b/src/db/index/common/schema.cc @@ -175,25 +175,22 @@ Status FieldSchema::validate() const { if (index_params_->type() == IndexType::DISKANN) { // Probe the DiskAnn runtime eagerly at creation time so unsupported - // platforms (non Linux x86_64), missing libaio, or a missing plugin - // .so fail fast with a clear message instead of surfacing later during - // optimize(). This reuses the same gate DiskAnnIndex applies on first - // use (zvec::LoadDiskAnnPlugin, wrapped by EnsureDiskAnnRuntimeReady). - // All validate() call sites are creation-time only, so triggering the - // plugin load here is safe (and idempotent/cached). + // platforms (non Linux x86_64) fail fast with a clear message instead + // of surfacing later during optimize(). All validate() call sites + // are creation-time only, so triggering the runtime init here is + // safe (and idempotent/cached). + // + // kDiskAnnPluginLibAioMissing is non-fatal: DiskAnn falls back to + // synchronous pread() with degraded performance. const int rc = ::zvec::LoadDiskAnnPlugin(); switch (rc) { case kDiskAnnPluginOk: + case kDiskAnnPluginLibAioMissing: break; case kDiskAnnPluginUnsupportedPlatform: return Status::NotSupported( "DiskAnn is not supported on this platform (Linux x86_64 " "only)"); - case kDiskAnnPluginLibAioMissing: - return Status::NotSupported( - "DiskAnn requires libaio at runtime, but it was not found on " - "this host. Install it (e.g. 'apt-get install libaio1', or " - "'libaio1t64' on Ubuntu 24.04+) and retry."); default: return Status::NotSupported( "DiskAnn runtime could not be initialized on this host"); diff --git a/src/include/zvec/ailego/pattern/factory.h b/src/include/zvec/ailego/pattern/factory.h index 9b292b90a..3ffbfcc1f 100644 --- a/src/include/zvec/ailego/pattern/factory.h +++ b/src/include/zvec/ailego/pattern/factory.h @@ -120,15 +120,18 @@ class Factory { //! a guard variable (`_ZGVZN...E7factory`) alongside the object, and both //! must be unified across DSOs for the singleton to be shared. //! - //! In the Python extension build the _zvec.so version script exports the - //! storage (`zvec::*` matches its demangled name) while the guard variable, - //! whose demangled form is `guard variable for zvec::...`, ends up hidden - //! (compilers emit the guard in a COMDAT group whose visibility is not - //! upgraded by our version script). When libzvec_diskann_plugin.so is - //! loaded, _zvec.so and the plugin then share the `factory` storage but - //! each have their own guard; the plugin's still-zero guard triggers a - //! second run of the Factory constructor on the shared storage, wiping - //! all registrations performed during _zvec.so import (e.g. FlatStreamer). + //! Historically (when DiskAnn was a runtime-loaded shared plugin) the + //! _zvec.so version script exported the storage (`zvec::*` matches its + //! demangled name) while the guard variable, whose demangled form is + //! `guard variable for zvec::...`, ended up hidden (compilers emit the + //! guard in a COMDAT group whose visibility is not upgraded by our version + //! script). When the plugin was loaded, _zvec.so and the plugin shared the + //! `factory` storage but each had its own guard; the plugin's still-zero + //! guard triggered a second run of the Factory constructor on the shared + //! storage, wiping out registrations performed during _zvec.so import. + //! DiskAnn is now statically linked into _zvec.so, so this DSO-splitting + //! issue no longer applies, but the atomic-pointer pattern is retained as + //! a defensive measure. //! //! A constant-initialized static std::atomic has NO guard variable //! (its zero init is compile-time), so we use a leaked heap singleton with diff --git a/src/include/zvec/plugin/diskann_plugin.h b/src/include/zvec/plugin/diskann_plugin.h index 988187068..ef1437692 100644 --- a/src/include/zvec/plugin/diskann_plugin.h +++ b/src/include/zvec/plugin/diskann_plugin.h @@ -20,9 +20,14 @@ // invoked implicitly by ``DiskAnnIndex`` on first use so that DiskAnn works // out of the box, without users ever calling a ``load_diskann_plugin()`` / // ``is_libaio_available()`` entry point. External callers should not depend -// on these symbols; they may change or be removed in future releases. On -// hosts missing libaio the bring-up fails cleanly and only DiskAnn becomes -// unavailable — other index types (HNSW / IVF / Flat / Vamana) keep working. +// on these symbols; they may change or be removed in future releases. +// +// DiskAnn is compiled directly into the hosting binary (_zvec.so for the +// Python wheel, the test executable for gtest, or the tool binary for C++ +// tools). ``LoadDiskAnnPlugin`` no longer dlopens a separate .so — it simply +// loads libaio eagerly via dlopen()/dlsym() and logs the result. On hosts +// missing libaio, DiskAnn falls back to synchronous pread() (with a warning) +// while other index types (HNSW / IVF / Flat / Vamana) keep working. #if defined(_WIN32) || defined(__CYGWIN__) #ifdef ZVEC_BUILD_SHARED @@ -58,27 +63,22 @@ enum DiskAnnPluginStatus { // part of the user-facing API. ZVEC_PLUGIN_EXPORT bool IsLibAioAvailable(); -// Load the DiskAnn runtime shared library (libzvec_diskann_plugin.so) via -// dlopen(). Invoked implicitly by ``DiskAnnIndex::CreateAndInitStreamer`` on -// first use; callers should not invoke it directly. The call is idempotent -// and returns ``kDiskAnnPluginOk`` when the runtime is already active. +// Load libaio at runtime via dlopen()/dlsym() and mark the DiskAnn runtime +// as ready. DiskAnn code is compiled directly into the hosting binary, so +// no separate .so is loaded. Invoked implicitly by +// ``DiskAnnIndex::CreateAndInitStreamer`` on first use; callers should not +// invoke it directly. The call is idempotent and returns +// ``kDiskAnnPluginOk`` when the runtime is already active. // -// Search order when ``path`` is empty: -// 1. next to the currently running executable (``/proc/self/exe`` on Linux); -// 2. next to the hosting shared object (e.g. ``_zvec.cpython-*.so``); -// 3. the platform default dynamic-linker search path (RPATH, -// ``LD_LIBRARY_PATH``, ``/etc/ld.so.conf``, …). +// The ``path`` parameter is retained for API compatibility but is ignored. ZVEC_PLUGIN_EXPORT int LoadDiskAnnPlugin(const std::string &path = ""); // Returns true if the DiskAnn runtime is currently loaded in this process. // Internal diagnostic; not a user-facing API. ZVEC_PLUGIN_EXPORT bool IsDiskAnnPluginLoaded(); -// Unload the DiskAnn runtime. Internal only — unloading a library that has -// registered itself into global factory singletons is inherently racy; -// callers must guarantee that no DiskAnn objects are still alive and no -// background threads are executing DiskAnn code before calling this. Returns -// true when a live handle was released. +// Unload the DiskAnn runtime. Since DiskAnn is statically linked, this is +// a no-op that always returns false. Retained for API compatibility. ZVEC_PLUGIN_EXPORT bool UnloadDiskAnnPlugin(); } // namespace zvec diff --git a/tests/core/algorithm/diskann/diskann_builder_test.cc b/tests/core/algorithm/diskann/diskann_builder_test.cc index 098765c3d..42b04bf7e 100644 --- a/tests/core/algorithm/diskann/diskann_builder_test.cc +++ b/tests/core/algorithm/diskann/diskann_builder_test.cc @@ -107,10 +107,10 @@ TEST_F(DiskAnnBuilderTest, TestGeneral) { // test via the ``core_knn_diskann`` target), its factory entries are // registered automatically and the global ``IndexFactory`` can hand out a // ``DiskAnnBuilder`` without any explicit setup step. On hosts missing -// libaio, DiskAnn would fail at the index-creation layer with a clear error -// while other index types (HNSW/IVF/Flat/Vamana) remain unaffected; that -// runtime branch lives in ``DiskAnnIndex::CreateAndInitStreamer`` and is -// covered by the higher-level interface tests. +// libaio, DiskAnn falls back to synchronous pread() with a warning while +// other index types (HNSW/IVF/Flat/Vamana) remain unaffected; that runtime +// branch lives in ``DiskAnnIndex::CreateAndInitStreamer`` and is covered by +// the higher-level interface tests. TEST_F(DiskAnnBuilderTest, TestImplicitFactoryRegistration) { IndexBuilder::Pointer builder = IndexFactory::CreateBuilder("DiskAnnBuilder"); ASSERT_NE(builder, nullptr) From 1dd03d4e6f621b188af54defbfe38cd9e9dcaf2f Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 25 Jun 2026 17:50:59 +0800 Subject: [PATCH 03/41] feat: add diskann windows --- CMakeLists.txt | 22 +- src/core/algorithm/diskann/CMakeLists.txt | 40 ++-- src/core/algorithm/diskann/diskann_context.cc | 12 +- src/core/algorithm/diskann/diskann_context.h | 2 +- .../algorithm/diskann/diskann_file_reader.cc | 217 +++++++++++++++++- .../algorithm/diskann/diskann_file_reader.h | 50 +++- src/core/algorithm/diskann/diskann_indexer.cc | 4 +- src/core/algorithm/diskann/diskann_indexer.h | 4 +- src/core/algorithm/diskann/diskann_searcher.h | 2 - src/core/algorithm/diskann/diskann_streamer.h | 2 - src/core/algorithm/diskann/diskann_util.h | 13 +- src/core/plugin/diskann_plugin.cc | 128 +++++++++++ 12 files changed, 433 insertions(+), 63 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 392dbdac8..febae9c98 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -131,14 +131,15 @@ else() endif() message(STATUS "RABITQ_ARCH_FLAG: ${RABITQ_ARCH_FLAG}") -# DiskAnn support (Linux x86_64 only, requires libaio) -if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|i686|i386" AND NOT ANDROID AND NOT IOS) +# DiskAnn support (Linux x86_64 with libaio, or Windows x86_64/x86 with IOCP) +if((CMAKE_SYSTEM_NAME STREQUAL "Linux" AND CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|i686|i386" AND NOT ANDROID AND NOT IOS) + OR (WIN32 AND CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64|amd64|i686|i386")) set(DISKANN_SUPPORTED ON) add_definitions(-DDISKANN_SUPPORTED=1) else() set(DISKANN_SUPPORTED OFF) add_definitions(-DDISKANN_SUPPORTED=0) - message(STATUS "DiskAnn support disabled - only supported on Linux x86_64") + message(STATUS "DiskAnn support disabled - only supported on Linux x86_64 or Windows") endif() message(STATUS "DISKANN_SUPPORTED: ${DISKANN_SUPPORTED}") @@ -191,13 +192,14 @@ if(BUILD_PYTHON_BINDINGS) install(TARGETS _zvec LIBRARY DESTINATION ${ZVEC_PY_INSTALL_DIR}) # DiskAnn ships as a runtime-loaded shared module - # (libzvec_diskann_plugin.so) that is brought online implicitly the - # first time a DiskAnn index is created — users never call any load - # function. The Python extension resolves the module next to _zvec.so - # (see the $ORIGIN rpath in src/binding/python/CMakeLists.txt); the - # module must therefore be installed alongside _zvec.so in the wheel. - # The target exists only on platforms where DiskAnn is buildable - # (currently Linux x86_64 with libaio). + # (libzvec_diskann_plugin.so on Linux, zvec_diskann_plugin.dll on + # Windows) that is brought online implicitly the first time a DiskAnn + # index is created — users never call any load function. The Python + # extension resolves the module next to _zvec.so/.pyd (see the $ORIGIN + # rpath in src/binding/python/CMakeLists.txt); the module must therefore + # be installed alongside _zvec in the wheel. The target exists only on + # platforms where DiskAnn is buildable (Linux x86_64 with libaio or + # Windows x86_64 with IOCP). if(TARGET core_knn_diskann) install(TARGETS core_knn_diskann LIBRARY DESTINATION ${ZVEC_PY_INSTALL_DIR}) endif() diff --git a/src/core/algorithm/diskann/CMakeLists.txt b/src/core/algorithm/diskann/CMakeLists.txt index 1b2252497..1e110ea10 100644 --- a/src/core/algorithm/diskann/CMakeLists.txt +++ b/src/core/algorithm/diskann/CMakeLists.txt @@ -2,21 +2,13 @@ include(${PROJECT_ROOT_DIR}/cmake/bazel.cmake) file(GLOB_RECURSE ALL_SRCS *.cc *.c) -# The DiskAnn plugin is loaded at runtime via zvec::LoadDiskAnnPlugin() with -# RTLD_GLOBAL, so its undefined references to internal zvec symbols -# (core_framework, core_knn_cluster, zvec_ailego, ...) are resolved at load -# time against the hosting binary (_zvec.so for the Python extension, the -# test executable for gtest, or libzvec_core for tools). +# DiskAnn plugin build configuration. # -# As a consequence the plugin .so must NOT carry NEEDED entries for those -# libs: otherwise the dynamic loader would try to resolve them from disk -# before invoking dlopen's RTLD_GLOBAL symbol sharing, and the Python wheel -# (which only ships _zvec.so + the plugin) would fail to load. -# -# We therefore link the plugin only against its system-level dependency -# (libaio) and rely on the global include dirs plus -Wl,--unresolved-symbols -# =ignore-all to let the linker build a shared library with unresolved -# references to internal APIs. +# On Linux the plugin is loaded at runtime via dlopen(RTLD_GLOBAL), so its +# undefined references to internal zvec symbols are resolved at load time +# against the hosting binary. On Windows the plugin DLL is loaded via +# LoadLibrary and must be linked against the zvec core import libraries at +# build time because Windows has no RTLD_GLOBAL equivalent. set(CORE_KNN_DISKANN_LIBS "") if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|i686|i386") @@ -32,26 +24,32 @@ cc_library( VERSION "${PROXIMA_ZVEC_VERSION}" ) -# Internal zvec libs are referenced only for header availability; the actual -# symbol resolution happens at dlopen time. Expose their public include dirs -# without adding them as link dependencies. +# Expose internal zvec lib include dirs. On Linux, symbol resolution happens +# at dlopen time via RTLD_GLOBAL so we do NOT add link dependencies. On +# Windows, we must link against the import libraries because Windows has no +# equivalent of RTLD_GLOBAL. foreach(_dep zvec_ailego core_framework core_knn_cluster) if(TARGET ${_dep}) target_include_directories(core_knn_diskann PRIVATE $) add_dependencies(core_knn_diskann ${_dep}) + if(MSVC) + target_link_libraries(core_knn_diskann PRIVATE ${_dep}) + endif() endif() endforeach() -# Allow the plugin to have unresolved symbols that will be satisfied at -# dlopen(RTLD_NOW | RTLD_GLOBAL) time by the hosting binary. +# On Linux, allow the plugin to have unresolved symbols that will be satisfied +# at dlopen(RTLD_NOW | RTLD_GLOBAL) time by the hosting binary. if(CMAKE_SYSTEM_NAME STREQUAL "Linux") target_link_options(core_knn_diskann PRIVATE "LINKER:--unresolved-symbols=ignore-all") endif() -# Rename the artifact to libzvec_diskann_plugin.so so it is clearly identified -# as an optional plugin that users load at runtime via zvec::LoadDiskAnnPlugin(). +# Rename the artifact so it is clearly identified as an optional plugin that +# users load at runtime via zvec::LoadDiskAnnPlugin(). +# On Linux: libzvec_diskann_plugin.so +# On Windows: zvec_diskann_plugin.dll set_target_properties(core_knn_diskann PROPERTIES OUTPUT_NAME zvec_diskann_plugin ) \ No newline at end of file diff --git a/src/core/algorithm/diskann/diskann_context.cc b/src/core/algorithm/diskann/diskann_context.cc index f13affb74..f25973dd0 100644 --- a/src/core/algorithm/diskann/diskann_context.cc +++ b/src/core/algorithm/diskann/diskann_context.cc @@ -82,12 +82,12 @@ int DiskAnnContext::init(ContextType type, uint32_t graph_degree, } DiskAnnContext::~DiskAnnContext() { - free(query_); - free(query_rotated_); - free(pq_table_dist_buffer_); - free(pq_coord_buffer_); - free(coord_buffer_); - free(sector_buffer_); + DiskAnnUtil::free_aligned(query_); + DiskAnnUtil::free_aligned(query_rotated_); + DiskAnnUtil::free_aligned(pq_table_dist_buffer_); + DiskAnnUtil::free_aligned(pq_coord_buffer_); + DiskAnnUtil::free_aligned(coord_buffer_); + DiskAnnUtil::free_aligned(sector_buffer_); if (type_ == kSearcherContext) { destroy_io_ctx(io_ctx_); diff --git a/src/core/algorithm/diskann/diskann_context.h b/src/core/algorithm/diskann/diskann_context.h index f8a736cdf..4c5df6ace 100644 --- a/src/core/algorithm/diskann/diskann_context.h +++ b/src/core/algorithm/diskann/diskann_context.h @@ -341,7 +341,7 @@ class DiskAnnContext : public IndexContext, uint32_t group_num_{0}; std::map group_topk_heaps_{}; - IOContext io_ctx_{0}; + IOContext io_ctx_{}; SearchStats query_stats_; float *pq_table_dist_buffer_{nullptr}; diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index 4268d5156..758e560c9 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -30,26 +30,33 @@ typedef struct io_event io_event_t; typedef struct iocb iocb_t; #endif -int setup_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) +int setup_io_ctx(IOContext &ctx) { int ret = io_setup(MAX_EVENTS, &ctx); - return ret; -#else - return 0; -#endif } int destroy_io_ctx(IOContext &ctx) { -#if (defined(__linux) || defined(__linux__)) int ret = io_destroy(ctx); - return ret; -#else +} +#elif defined(_WIN32) || defined(_WIN64) +int setup_io_ctx(IOContext &ctx) { + for (uint64_t i = 0; i < MAX_IO_DEPTH; i++) { + OVERLAPPED os; + memset(&os, 0, sizeof(OVERLAPPED)); + ctx.reqs.push_back(os); + } + return 0; +} + +int destroy_io_ctx(IOContext &ctx) { + ctx.reqs.clear(); return 0; -#endif } +#endif +#if (defined(__linux) || defined(__linux__)) static int execute_io_pread(int fd, std::vector &read_reqs) { for (auto &req : read_reqs) { ssize_t bytes_read = ::pread(fd, req.buf, req.len, req.offset); @@ -294,6 +301,198 @@ int LinuxAlignedFileReader::read(std::vector &read_reqs, return ret; } +#endif // (defined(__linux) || defined(__linux__)) + +#if defined(_WIN32) || defined(_WIN64) + +// ============================================================================ +// Windows implementation using I/O Completion Ports (IOCP) +// Based on the DiskANN Windows aligned file reader. +// ============================================================================ + +WindowsAlignedFileReader::WindowsAlignedFileReader() {} + +WindowsAlignedFileReader::~WindowsAlignedFileReader() { + deregister_all_threads(); + close(); +} + +IOContext &WindowsAlignedFileReader::get_ctx() { + std::unique_lock lk(ctx_mut); + auto thread_id = std::this_thread::get_id(); + auto it = ctx_map.find(thread_id); + if (it == ctx_map.end()) { + LOG_ERROR("unable to find IOContext for thread_id"); + static IOContext empty_ctx; + return empty_ctx; + } + return it->second; +} + +void WindowsAlignedFileReader::register_thread() { + auto thread_id = std::this_thread::get_id(); + std::unique_lock lk(ctx_mut); + if (ctx_map.find(thread_id) != ctx_map.end()) { + LOG_ERROR("multiple calls to register_thread from the same thread"); + return; + } + + IOContext ctx; + setup_io_ctx(ctx); + ctx_map[thread_id] = std::move(ctx); +} + +void WindowsAlignedFileReader::deregister_thread() { + auto thread_id = std::this_thread::get_id(); + std::unique_lock lk(ctx_mut); + auto it = ctx_map.find(thread_id); + if (it == ctx_map.end()) { + LOG_ERROR("deregister_thread: thread not registered"); + return; + } + ctx_map.erase(it); +} + +void WindowsAlignedFileReader::deregister_all_threads() { + std::unique_lock lk(ctx_mut); + ctx_map.clear(); +} + +void WindowsAlignedFileReader::open(const std::string &fname) { + file_handle_ = CreateFileA(fname.c_str(), GENERIC_READ, FILE_SHARE_READ, NULL, + OPEN_EXISTING, + FILE_ATTRIBUTE_READONLY | FILE_FLAG_NO_BUFFERING | + FILE_FLAG_OVERLAPPED | FILE_FLAG_RANDOM_ACCESS, + NULL); + + if (file_handle_ == INVALID_HANDLE_VALUE) { + DWORD error = GetLastError(); + LOG_ERROR("Failed to open file: %s (error=%lu)", fname.c_str(), error); + return; + } + + // Create an I/O Completion Port and associate the file handle with it. + iocp_ = CreateIoCompletionPort(file_handle_, NULL, 0, 0); + if (iocp_ == NULL) { + DWORD error = GetLastError(); + LOG_ERROR("CreateIoCompletionPort failed (error=%lu)", error); + CloseHandle(file_handle_); + file_handle_ = INVALID_HANDLE_VALUE; + return; + } + + LOG_INFO("Opened file: %s", fname.c_str()); +} + +void WindowsAlignedFileReader::close() { + if (file_handle_ != INVALID_HANDLE_VALUE) { + CloseHandle(file_handle_); + file_handle_ = INVALID_HANDLE_VALUE; + } + if (iocp_ != NULL) { + CloseHandle(iocp_); + iocp_ = NULL; + } +} + +int WindowsAlignedFileReader::read(std::vector &read_reqs, + IOContext &ctx, bool async) { + if (async == true) { + LOG_WARN("Async currently not supported"); + } + + if (file_handle_ == INVALID_HANDLE_VALUE) { + LOG_ERROR("Attempt to read from invalid file handle"); + return IndexError_Runtime; + } + + // Ensure the context has enough OVERLAPPED slots. + if (ctx.reqs.size() < MAX_IO_DEPTH) { + for (size_t i = ctx.reqs.size(); i < MAX_IO_DEPTH; i++) { + OVERLAPPED os; + memset(&os, 0, sizeof(OVERLAPPED)); + ctx.reqs.push_back(os); + } + } + + static const DWORD kSectorLen = 4096; + size_t n_reqs = read_reqs.size(); + uint64_t n_batches = DiskAnnUtil::div_round_up(n_reqs, MAX_IO_DEPTH); + + for (uint64_t batch = 0; batch < n_batches; batch++) { + // Reset all OVERLAPPED objects for this batch. + for (auto &os : ctx.reqs) { + memset(&os, 0, sizeof(OVERLAPPED)); + } + + uint64_t batch_start = MAX_IO_DEPTH * batch; + uint64_t batch_size = + std::min((uint64_t)(n_reqs - batch_start), (uint64_t)MAX_IO_DEPTH); + + // Issue ReadFile calls for this batch. + for (uint64_t j = 0; j < batch_size; j++) { + AlignedRead &req = read_reqs[batch_start + j]; + OVERLAPPED &os = ctx.reqs[j]; + + uint64_t offset = req.offset; + uint64_t nbytes = req.len; + char *read_buf = (char *)req.buf; + + // Alignment assertions (must be sector-aligned for unbuffered I/O). + assert((size_t)read_buf % kSectorLen == 0); + assert(offset % kSectorLen == 0); + assert(nbytes % kSectorLen == 0); + + // Fill in the OVERLAPPED struct with the file offset. + os.Offset = (DWORD)(offset & 0xffffffff); + os.OffsetHigh = (DWORD)(offset >> 32); + + BOOL ret = ReadFile(file_handle_, read_buf, (DWORD)nbytes, NULL, &os); + if (ret == FALSE) { + DWORD error = GetLastError(); + if (error != ERROR_IO_PENDING) { + LOG_ERROR("Error queuing IO -- error=%lu", error); + return IndexError_Runtime; + } + } + } + + // Wait for all batch reads to complete via the IOCP. + DWORD n_read = 0; + uint64_t n_complete = 0; + ULONG_PTR completion_key = 0; + OVERLAPPED *lp_os = NULL; + + while (n_complete < batch_size) { + BOOL ok = GetQueuedCompletionStatus(iocp_, &n_read, &completion_key, + &lp_os, INFINITE); + if (ok != 0) { + // Successfully dequeued a completed I/O. + n_complete++; + } else { + if (lp_os == NULL) { + DWORD error = GetLastError(); + if (error != WAIT_TIMEOUT) { + LOG_ERROR("GetQueuedCompletionStatus() failed with error = %lu", + error); + return IndexError_Runtime; + } + // No completion packet dequeued; sleep briefly and retry. + std::this_thread::sleep_for(std::chrono::microseconds(5)); + } else { + // Completion packet for a failed I/O. + DWORD error = GetLastError(); + LOG_ERROR("I/O failed with error code: %lu", error); + return IndexError_Runtime; + } + } + } + } + + return 0; +} + +#endif // defined(_WIN32) || defined(_WIN64) } // namespace core } // namespace zvec diff --git a/src/core/algorithm/diskann/diskann_file_reader.h b/src/core/algorithm/diskann/diskann_file_reader.h index 432247e79..ce148401c 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.h +++ b/src/core/algorithm/diskann/diskann_file_reader.h @@ -15,23 +15,28 @@ #define MAX_IO_DEPTH 128 -#include - -#if (defined(__linux) || defined(__linux__)) -#include -#endif - -#include #include #include #include #include "diskann_util.h" +#if (defined(__linux) || defined(__linux__)) +#include +#include +#include +#elif defined(_WIN32) || defined(_WIN64) +#include +#endif + namespace zvec { namespace core { #if (defined(__linux) || defined(__linux__)) typedef io_context_t IOContext; +#elif defined(_WIN32) || defined(_WIN64) +struct IOContext { + std::vector reqs; +}; #else typedef uint32_t IOContext; #endif @@ -75,6 +80,7 @@ class AlignedFileReader { bool async = false) = 0; }; +#if (defined(__linux) || defined(__linux__)) class LinuxAlignedFileReader : public AlignedFileReader { private: int file_desc; @@ -98,6 +104,36 @@ class LinuxAlignedFileReader : public AlignedFileReader { int read(std::vector &read_reqs, IOContext &ctx, bool async = false); }; +#elif defined(_WIN32) || defined(_WIN64) +class WindowsAlignedFileReader : public AlignedFileReader { + private: + HANDLE file_handle_ = INVALID_HANDLE_VALUE; + HANDLE iocp_ = NULL; + + public: + WindowsAlignedFileReader(); + ~WindowsAlignedFileReader(); + + public: + IOContext &get_ctx(); + + void register_thread(); + void deregister_thread(); + void deregister_all_threads(); + void open(const std::string &fname); + void close(); + + int read(std::vector &read_reqs, IOContext &ctx, + bool async = false); +}; +#endif + +// Platform-agnostic reader typedef +#if (defined(__linux) || defined(__linux__)) +typedef LinuxAlignedFileReader PlatformAlignedFileReader; +#elif defined(_WIN32) || defined(_WIN64) +typedef WindowsAlignedFileReader PlatformAlignedFileReader; +#endif } // namespace core } // namespace zvec diff --git a/src/core/algorithm/diskann/diskann_indexer.cc b/src/core/algorithm/diskann/diskann_indexer.cc index 32e7ff67c..0f4d7971e 100644 --- a/src/core/algorithm/diskann/diskann_indexer.cc +++ b/src/core/algorithm/diskann/diskann_indexer.cc @@ -30,7 +30,7 @@ DiskAnnIndexer::DiskAnnIndexer(const IndexMeta &meta) { DiskAnnIndexer::~DiskAnnIndexer() { destroy_io_ctx(init_ctx_); if (centroid_data_) { - free(centroid_data_); + DiskAnnUtil::free_aligned(centroid_data_); } DiskAnnUtil::free_aligned(coord_cache_buf_); } @@ -45,7 +45,7 @@ int DiskAnnIndexer::init(DiskAnnSearcherEntity &entity) { index_segment_offset_ = vector_segment->data_offset(); - reader_.reset(new LinuxAlignedFileReader()); + reader_.reset(new PlatformAlignedFileReader()); auto file_path = storage->file_path(); reader_->open(file_path); diff --git a/src/core/algorithm/diskann/diskann_indexer.h b/src/core/algorithm/diskann/diskann_indexer.h index c372d288f..8eae84a49 100644 --- a/src/core/algorithm/diskann/diskann_indexer.h +++ b/src/core/algorithm/diskann/diskann_indexer.h @@ -87,11 +87,11 @@ class DiskAnnIndexer { diskann_id_t medoid_; std::vector entrypoints_; - std::shared_ptr reader_{nullptr}; + std::shared_ptr reader_{nullptr}; PQTable::Pointer pq_table_; - IOContext init_ctx_{0}; + IOContext init_ctx_{}; std::vector neighbor_cache_buffer_; void *coord_cache_buf_{nullptr}; diff --git a/src/core/algorithm/diskann/diskann_searcher.h b/src/core/algorithm/diskann/diskann_searcher.h index 99584fa35..903259c86 100644 --- a/src/core/algorithm/diskann/diskann_searcher.h +++ b/src/core/algorithm/diskann/diskann_searcher.h @@ -17,8 +17,6 @@ #include "diskann_context.h" #include "diskann_indexer.h" -class LinuxAlignedFileReader; - namespace zvec { namespace core { diff --git a/src/core/algorithm/diskann/diskann_streamer.h b/src/core/algorithm/diskann/diskann_streamer.h index 8d731f399..b60bc2a00 100644 --- a/src/core/algorithm/diskann/diskann_streamer.h +++ b/src/core/algorithm/diskann/diskann_streamer.h @@ -17,8 +17,6 @@ #include "diskann_context.h" #include "diskann_indexer.h" -class LinuxAlignedFileReader; - namespace zvec { namespace core { diff --git a/src/core/algorithm/diskann/diskann_util.h b/src/core/algorithm/diskann/diskann_util.h index a02130bf0..a54fb5d71 100644 --- a/src/core/algorithm/diskann/diskann_util.h +++ b/src/core/algorithm/diskann/diskann_util.h @@ -17,6 +17,10 @@ #include #include "diskann_entity.h" +#if defined(_WIN32) || defined(_WIN64) +#include +#endif + namespace zvec { namespace core { @@ -35,15 +39,22 @@ class DiskAnnUtil { } static inline void alloc_aligned(void **ptr, size_t size, size_t align) { +#if defined(_WIN32) || defined(_WIN64) + *ptr = ::_aligned_malloc(size, align); +#else *ptr = ::aligned_alloc(align, size); +#endif } static inline void free_aligned(void *ptr) { if (ptr == nullptr) { return; } - +#if defined(_WIN32) || defined(_WIN64) + ::_aligned_free(ptr); +#else free(ptr); +#endif } template diff --git a/src/core/plugin/diskann_plugin.cc b/src/core/plugin/diskann_plugin.cc index 9d4e9d0f5..be9f2c689 100644 --- a/src/core/plugin/diskann_plugin.cc +++ b/src/core/plugin/diskann_plugin.cc @@ -28,6 +28,10 @@ #include #endif +#if defined(_WIN32) || defined(_WIN64) +#include +#endif + namespace zvec { namespace { @@ -41,6 +45,9 @@ constexpr const char *kLibAioSoNames[] = { "libaio.so.1t64", }; constexpr bool kPlatformSupportsDiskAnnPlugin = true; +#elif defined(_WIN32) || defined(_WIN64) +constexpr const char *kPluginFileName = "zvec_diskann_plugin.dll"; +constexpr bool kPlatformSupportsDiskAnnPlugin = true; #elif defined(__APPLE__) [[maybe_unused]] constexpr const char *kPluginFileName = "libzvec_diskann_plugin.dylib"; @@ -203,6 +210,78 @@ std::vector BuildCandidatePaths(const std::string &explicit_path) { #endif // linux +#if defined(_WIN32) || defined(_WIN64) + +// Resolve the directory containing the currently running executable. +std::string GetExecutableDir() { + char buf[MAX_PATH]; + DWORD n = ::GetModuleFileNameA(NULL, buf, sizeof(buf)); + if (n == 0 || n >= sizeof(buf)) { + return {}; + } + std::string path(buf); + auto slash = path.find_last_of("\\/"); + if (slash == std::string::npos) { + return {}; + } + return path.substr(0, slash); +} + +// Resolve the directory containing the DLL that hosts this function. +// Uses GetModuleHandleEx to find the module from a function address. +std::string ResolveHostingSoDir() { + HMODULE hmod = NULL; + BOOL ok = ::GetModuleHandleExA( + GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | + GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT, + reinterpret_cast(&::zvec::LoadDiskAnnPlugin), &hmod); + if (!ok || hmod == NULL) { + return {}; + } + char buf[MAX_PATH]; + DWORD n = ::GetModuleFileNameA(hmod, buf, sizeof(buf)); + if (n == 0 || n >= sizeof(buf)) { + return {}; + } + std::string path(buf); + auto slash = path.find_last_of("\\/"); + if (slash == std::string::npos) { + return {}; + } + return path.substr(0, slash); +} + +// Build the list of candidate paths for the plugin. +std::vector BuildCandidatePaths(const std::string &explicit_path) { + std::vector candidates; + if (!explicit_path.empty()) { + candidates.push_back(explicit_path); + return candidates; + } + + auto push_dir_candidates = [&candidates](const std::string &dir) { + if (dir.empty()) { + return; + } + candidates.push_back(dir + "\\" + kPluginFileName); + }; + + // 1. Directory of the module that hosts LoadDiskAnnPlugin. + const std::string own_dir = ResolveHostingSoDir(); + push_dir_candidates(own_dir); + // 2. Directory of the running executable. + const std::string exe_dir = GetExecutableDir(); + if (!exe_dir.empty() && exe_dir != own_dir) { + push_dir_candidates(exe_dir); + } + // 3. Fallback: let Windows search the default paths (application dir, + // system dirs, PATH). + candidates.emplace_back(kPluginFileName); + return candidates; +} + +#endif // _WIN32 + } // namespace bool IsLibAioAvailable() { @@ -229,6 +308,9 @@ bool IsLibAioAvailable() { } } return false; +#elif defined(_WIN32) || defined(_WIN64) + // libaio is not needed on Windows; I/O Completion Ports are built-in. + return true; #else return false; #endif @@ -293,6 +375,40 @@ int LoadDiskAnnPlugin(const std::string &path) { return kDiskAnnPluginDlopenFailed; } + g_plugin_handle.store(handle, std::memory_order_release); + return kDiskAnnPluginOk; +#elif defined(_WIN32) || defined(_WIN64) + // Fast path: already loaded. + if (g_plugin_handle.load(std::memory_order_acquire) != nullptr) { + return kDiskAnnPluginOk; + } + + std::lock_guard lock(g_plugin_mutex); + if (g_plugin_handle.load(std::memory_order_relaxed) != nullptr) { + return kDiskAnnPluginOk; + } + + const std::vector candidates = BuildCandidatePaths(path); + HMODULE handle = nullptr; + std::string last_error; + for (const std::string &candidate : candidates) { + handle = ::LoadLibraryA(candidate.c_str()); + if (handle != nullptr) { + LOG_INFO("Loaded DiskAnn plugin from: %s", candidate.c_str()); + break; + } + DWORD err = ::GetLastError(); + last_error = "LoadLibraryA failed (error=" + std::to_string(err) + ")"; + LOG_DEBUG("LoadLibraryA(%s) failed: %s", candidate.c_str(), + last_error.c_str()); + } + + if (handle == nullptr) { + LOG_ERROR("Failed to load DiskAnn plugin; last error: %s", + last_error.c_str()); + return kDiskAnnPluginDlopenFailed; + } + g_plugin_handle.store(handle, std::memory_order_release); return kDiskAnnPluginOk; #else @@ -314,6 +430,18 @@ bool UnloadDiskAnnPlugin() { err ? err : "unknown"); } return true; +#elif defined(_WIN32) || defined(_WIN64) + std::lock_guard lock(g_plugin_mutex); + HMODULE handle = reinterpret_cast( + g_plugin_handle.exchange(nullptr, std::memory_order_acq_rel)); + if (handle == nullptr) { + return false; + } + if (!::FreeLibrary(handle)) { + DWORD err = ::GetLastError(); + LOG_WARN("FreeLibrary for DiskAnn plugin failed (error=%lu)", err); + } + return true; #else return false; #endif From 82d08f6a6590d91d2df2aa7fa96b51db3ebc6f83 Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 25 Jun 2026 19:03:09 +0800 Subject: [PATCH 04/41] fix: support io uring --- .../algorithm/diskann/diskann_file_reader.cc | 217 ++++++++++++--- .../algorithm/diskann/diskann_file_reader.h | 29 +- src/core/algorithm/diskann/iouring_def.h | 199 +++++++++++++ src/core/algorithm/diskann/iouring_loader.h | 261 ++++++++++++++++++ 4 files changed, 661 insertions(+), 45 deletions(-) create mode 100644 src/core/algorithm/diskann/iouring_def.h create mode 100644 src/core/algorithm/diskann/iouring_loader.h diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index c8d8bdd0b..6ff18d535 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -32,13 +32,33 @@ typedef struct iocb iocb_t; int setup_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) - if (!LibAioLoader::Instance().Load()) { - LOG_WARN("libaio not available; falling back to synchronous pread"); + ctx = new IoBackend(); + + // Priority 1: io_uring (raw kernel syscalls — zero dependency). + if (ctx->ring.setup(MAX_EVENTS)) { + ctx->backend = IoBackend::IO_URING; + LOG_INFO("io_uring backend selected for DiskAnn I/O"); return 0; } - int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); - return ret; + // Priority 2: libaio (dlopen — soft dependency). + if (LibAioLoader::Instance().Load()) { + int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx->aio_ctx); + if (ret == 0) { + ctx->backend = IoBackend::LIBAIO; + LOG_INFO("libaio backend selected for DiskAnn I/O"); + return 0; + } + LOG_WARN("io_setup failed; returned: %d, %s. falling back to pread", ret, + ::strerror(-ret)); + } else { + LOG_WARN("libaio not available; falling back to synchronous pread"); + } + + // Priority 3: synchronous pread (always available). + ctx->backend = IoBackend::NONE; + LOG_INFO("pread backend selected for DiskAnn I/O"); + return 0; #else return 0; #endif @@ -46,12 +66,21 @@ int setup_io_ctx(IOContext &ctx) { int destroy_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) - if (!LibAioLoader::Instance().IsAvailable()) { + if (ctx == nullptr || ctx == (IOContext)-1) { return 0; } - int ret = LibAioLoader::Instance().io_destroy(ctx); - return ret; + if (ctx->backend == IoBackend::IO_URING) { + ctx->ring.teardown(); + } else if (ctx->backend == IoBackend::LIBAIO && + LibAioLoader::Instance().IsAvailable()) { + LibAioLoader::Instance().io_destroy(ctx->aio_ctx); + } + // IoUringRing destructor also calls teardown() — idempotent and safe. + + delete ctx; + ctx = nullptr; + return 0; #else return 0; #endif @@ -75,12 +104,10 @@ static int execute_io_pread(int fd, std::vector &read_reqs) { return 0; } -int execute_io(IOContext ctx, int fd, std::vector &read_reqs, - uint64_t n_retries = 0) { +static int execute_io_libaio(io_context_t ctx, int fd, + std::vector &read_reqs, + uint64_t n_retries = 0) { #if (defined(__linux) || defined(__linux__)) - if (!LibAioLoader::Instance().Load()) { - return execute_io_pread(fd, read_reqs); - } uint64_t iters = DiskAnnUtil::div_round_up(read_reqs.size(), MAX_EVENTS); for (uint64_t iter = 0; iter < iters; iter++) { @@ -160,6 +187,135 @@ int execute_io(IOContext ctx, int fd, std::vector &read_reqs, #endif } +int execute_io(IOContext ctx, int fd, std::vector &read_reqs, + uint64_t n_retries = 0) { +#if (defined(__linux) || defined(__linux__)) + // Guard against null or sentinel contexts. + if (ctx == nullptr || ctx == (IOContext)-1) { + return execute_io_pread(fd, read_reqs); + } + + // Dispatch based on the active backend. + if (ctx->backend == IoBackend::IO_URING) { + int ret = ctx->ring.execute(fd, read_reqs); + if (ret == 0) { + return 0; + } + // io_uring failed — fall back to pread. + LOG_WARN("io_uring execute failed; falling back to pread"); + return execute_io_pread(fd, read_reqs); + } + + if (ctx->backend == IoBackend::LIBAIO) { + return execute_io_libaio(ctx->aio_ctx, fd, read_reqs, n_retries); + } + + // NONE backend — synchronous pread. + return execute_io_pread(fd, read_reqs); +#else + return execute_io_pread(fd, read_reqs); +#endif +} + +// --------------------------------------------------------------------------- +// IoUringRing::execute — defined here (not in iouring_loader.h) because it +// accesses AlignedRead members, and AlignedRead is defined in +// diskann_file_reader.h after iouring_loader.h is included. +// --------------------------------------------------------------------------- +#if (defined(__linux) || defined(__linux__)) +int IoUringRing::execute(int fd, std::vector &read_reqs) { + if (!is_valid()) { + return -1; + } + if (read_reqs.empty()) { + return 0; + } + + // Process in batches limited by the SQ ring size. + uint32_t batch_size = + std::min(sq_entries_, static_cast(kIoUringMaxBatch)); + uint64_t iters = DiskAnnUtil::div_round_up(read_reqs.size(), batch_size); + + for (uint64_t iter = 0; iter < iters; iter++) { + uint64_t n_ops = + std::min(static_cast(read_reqs.size()) - iter * batch_size, + static_cast(batch_size)); + + // --- Phase 1: Fill SQEs --- + + unsigned tail = __atomic_load_n(sq_tail_, __ATOMIC_ACQUIRE); + unsigned mask = *sq_ring_mask_; + + for (uint64_t j = 0; j < n_ops; j++) { + unsigned idx = (tail + static_cast(j)) & mask; + unsigned sqe_idx = sq_array_[idx]; + struct io_uring_sqe *sqe = &sqes_[sqe_idx]; + + uint64_t req_idx = j + iter * batch_size; + io_uring_prep_read(sqe, fd, read_reqs[req_idx].buf, + static_cast(read_reqs[req_idx].len), + read_reqs[req_idx].offset); + // Store the request index so we can verify the completion. + sqe->user_data = req_idx; + } + + // Memory barrier: ensure SQE contents are visible before tail update. + __sync_synchronize(); + __atomic_store_n(sq_tail_, tail + static_cast(n_ops), + __ATOMIC_RELEASE); + + // --- Phase 2: Submit and wait for completions --- + + int ret = static_cast( + syscall(__NR_io_uring_enter, ring_fd_, static_cast(n_ops), + static_cast(n_ops), IORING_ENTER_GETEVENTS, + static_cast(nullptr), static_cast(0))); + if (ret < 0) { + LOG_WARN( + "io_uring_enter failed; errno=%d, %s, n_ops=%lu. " + "falling back to pread", + errno, ::strerror(errno), (unsigned long)n_ops); + return -1; + } + + // --- Phase 3: Process CQEs --- + + unsigned head = __atomic_load_n(cq_head_, __ATOMIC_ACQUIRE); + unsigned cq_mask = *cq_ring_mask_; + bool all_ok = true; + uint64_t processed = 0; + + for (unsigned i = head; processed < n_ops; i = (i + 1), processed++) { + struct io_uring_cqe *cqe = &cqes_[i & cq_mask]; + uint64_t req_idx = cqe->user_data; + + if (cqe->res < 0) { + LOG_WARN("io_uring read failed: req=%lu, res=%d, offset=%lu", + (unsigned long)req_idx, cqe->res, + (unsigned long)read_reqs[req_idx].offset); + all_ok = false; + } else if (static_cast(cqe->res) != read_reqs[req_idx].len) { + LOG_WARN("io_uring short read: req=%lu, got=%d, expected=%lu", + (unsigned long)req_idx, cqe->res, + (unsigned long)read_reqs[req_idx].len); + all_ok = false; + } + } + + // Advance the CQ head to consume the completions. + __sync_synchronize(); + __atomic_store_n(cq_head_, head + static_cast(n_ops), + __ATOMIC_RELEASE); + + if (!all_ok) { + return -1; + } + } + + return 0; +} +#endif // __linux__ + LinuxAlignedFileReader::LinuxAlignedFileReader(int file_desc) { this->file_desc = file_desc; } @@ -180,7 +336,7 @@ IOContext &LinuxAlignedFileReader::get_ctx() { std::unique_lock lk(ctx_mut); auto it = ctx_map.find(std::this_thread::get_id()); if (it == ctx_map.end()) { - LOG_ERROR("bad thread access; returning -1 as io_context_t"); + LOG_ERROR("bad thread access; returning invalid IOContext"); return this->bad_ctx; } else { return it->second; @@ -193,34 +349,14 @@ void LinuxAlignedFileReader::register_thread() { std::unique_lock lk(ctx_mut); if (ctx_map.find(thread_id) != ctx_map.end()) { LOG_ERROR("multiple calls to register_thread from the same thread"); - return; } IOContext ctx = nullptr; - - if (!LibAioLoader::Instance().Load()) { - LOG_WARN("libaio not available; async I/O disabled, will use pread"); - lk.unlock(); - return; - } - int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); - if (ret != 0) { - lk.unlock(); - if (ret == -EAGAIN) { - LOG_ERROR( - "io_setup failed with EAGAIN: Consider increasing " - "/proc/sys/fs/aio-max-nr"); - } else { - LOG_ERROR("io_setup failed; returned: %d, %s", ret, ::strerror(-ret)); - ; - } - } else { - LOG_INFO("allocating ctx: %lu", (uint64_t)ctx); - + int ret = setup_io_ctx(ctx); + if (ret == 0 && ctx != nullptr) { ctx_map[thread_id] = ctx; } - lk.unlock(); #endif } @@ -241,10 +377,8 @@ void LinuxAlignedFileReader::deregister_thread() { ctx_map.erase(it); } - // io_destroy is a syscall; keep it outside the lock to avoid blocking others - if (LibAioLoader::Instance().IsAvailable()) { - LibAioLoader::Instance().io_destroy(ctx); - } + // teardown is a syscall; keep it outside the lock to avoid blocking others + destroy_io_ctx(ctx); LOG_INFO("returned ctx from thread"); #endif } @@ -252,12 +386,9 @@ void LinuxAlignedFileReader::deregister_thread() { void LinuxAlignedFileReader::deregister_all_threads() { #if (defined(__linux) || defined(__linux__)) std::unique_lock lk(ctx_mut); - bool aio_available = LibAioLoader::Instance().IsAvailable(); for (auto x = ctx_map.begin(); x != ctx_map.end(); x++) { IOContext ctx = x->second; - if (aio_available) { - LibAioLoader::Instance().io_destroy(ctx); - } + destroy_io_ctx(ctx); } ctx_map.clear(); #endif diff --git a/src/core/algorithm/diskann/diskann_file_reader.h b/src/core/algorithm/diskann/diskann_file_reader.h index 2abe8c1aa..244370e0a 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.h +++ b/src/core/algorithm/diskann/diskann_file_reader.h @@ -18,7 +18,8 @@ #include #if (defined(__linux) || defined(__linux__)) -#include "libaio_loader.h" // dlopen-based libaio wrapper +#include "iouring_loader.h" // raw-syscall io_uring wrapper +#include "libaio_loader.h" // dlopen-based libaio wrapper #endif #include @@ -31,7 +32,31 @@ namespace zvec { namespace core { #if (defined(__linux) || defined(__linux__)) -typedef io_context_t IOContext; + +// IoBackend holds the per-thread I/O context for whichever async backend +// was successfully initialised at setup time. The priority is: +// 1. io_uring (raw kernel syscalls — zero dependency) +// 2. libaio (dlopen — soft dependency) +// 3. pread (always available — synchronous fallback) +// +// IOContext is a *pointer* to IoBackend, which preserves the existing +// sentinel conventions: nullptr means uninitialised and (IOContext)-1 is +// the invalid-handle sentinel returned by get_ctx() for unregistered +// threads. +struct IoBackend { + enum Backend : uint8_t { + NONE = 0, // synchronous pread + IO_URING = 1, // io_uring via raw syscalls + LIBAIO = 2, // libaio via dlopen + }; + + Backend backend{NONE}; + IoUringRing ring{}; + io_context_t aio_ctx{nullptr}; +}; + +typedef IoBackend *IOContext; + #else typedef uint32_t IOContext; #endif diff --git a/src/core/algorithm/diskann/iouring_def.h b/src/core/algorithm/diskann/iouring_def.h new file mode 100644 index 000000000..2c0cd7bb4 --- /dev/null +++ b/src/core/algorithm/diskann/iouring_def.h @@ -0,0 +1,199 @@ +// Copyright 2025-present the zvec project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Private header defining the io_uring kernel ABI structures and constants. +// +// This header is the io_uring analogue of libaio_def.h: it declares *only* +// the types, constants, and inline helpers that zvec needs from the io_uring +// kernel interface. By defining these structures ourselves we avoid any +// build-time dependency on or liburing-dev, mirroring the +// project's zero-dependency philosophy established by the libaio dlopen +// approach. +// +// The struct layouts (io_uring_sqe, io_uring_cqe, io_uring_params, +// io_sqring_offsets, io_cqring_offsets) are part of the Linux kernel ABI +// and are copied verbatim from . + +#pragma once + +#include + +#if defined(__linux) || defined(__linux__) + +// --------------------------------------------------------------------------- +// Syscall numbers +// --------------------------------------------------------------------------- +// io_uring was introduced in Linux 5.1 (2019). The three syscalls share the +// same numbers across all supported architectures. We prefer the values +// from when available and fall back to hardcoded numbers. +#include + +#ifndef __NR_io_uring_setup +#define __NR_io_uring_setup 425 +#endif + +#ifndef __NR_io_uring_enter +#define __NR_io_uring_enter 426 +#endif + +#ifndef __NR_io_uring_register +#define __NR_io_uring_register 427 +#endif + +// --------------------------------------------------------------------------- +// Constants (from ) +// --------------------------------------------------------------------------- + +// mmap offsets for the three shared regions. +#define IORING_OFF_SQ_RING 0ULL +#define IORING_OFF_CQ_RING 0x8000000ULL +#define IORING_OFF_SQES 0x10000000ULL + +// io_uring_enter flags. +#define IORING_ENTER_GETEVENTS (1U << 0) + +// io_uring_setup flags (none used by default). +// IORING_SETUP_IOPOLL (1U << 0) +// IORING_SETUP_SQPOLL (1U << 1) +// IORING_SETUP_SQ_AFF (1U << 2) + +// SQE opcode values. +#define IORING_OP_NOP 0 +#define IORING_OP_READV 1 +#define IORING_OP_WRITEV 2 +#define IORING_OP_FSYNC 3 +#define IORING_OP_READ_FIXED 4 +#define IORING_OP_WRITE_FIXED 5 +#define IORING_OP_POLL_ADD 6 +#define IORING_OP_POLL_REMOVE 7 +#define IORING_OP_SYNC_FILE_RANGE 8 +#define IORING_OP_SENDMSG 9 +#define IORING_OP_RECVMSG 10 +#define IORING_OP_TIMEOUT 11 +#define IORING_OP_TIMEOUT_REMOVE 12 +#define IORING_OP_ACCEPT 13 +#define IORING_OP_ASYNC_CANCEL 14 +#define IORING_OP_LINK_TIMEOUT 15 +#define IORING_OP_CONNECT 16 +#define IORING_OP_FALLOCATE 17 +#define IORING_OP_OPENAT 18 +#define IORING_OP_CLOSE 19 +#define IORING_OP_FILES_UPDATE 20 +#define IORING_OP_STATX 21 +#define IORING_OP_READ 22 +#define IORING_OP_WRITE 23 + +// --------------------------------------------------------------------------- +// Struct definitions (copied verbatim from ) +// --------------------------------------------------------------------------- + +// Submission queue entry — 64 bytes. +struct io_uring_sqe { + uint8_t opcode; // type of operation for this sqe + uint8_t flags; // IOSQE_ flags + uint16_t ioprio; // ioprio for the request + int32_t fd; // file descriptor to do IO on + union { + uint64_t off; // offset into file + uint64_t addr2; + }; + union { + uint64_t addr; // buffer or iovecs + uint64_t splice_off_in; + }; + uint32_t len; // buffer size or number of iovecs + union { + uint32_t rw_flags; // read/write flags (union of all flag types) + }; + uint64_t user_data; // data to be passed back at completion time + union { + struct { + uint16_t buf_index; // index into fixed buffers, if used + uint16_t personality; + }; + uint64_t __pad2[3]; + }; +}; + +// Completion queue entry — 16 bytes. +struct io_uring_cqe { + uint64_t user_data; // sqe->user_data + int32_t res; // result code for this event + uint32_t flags; +}; + +// SQ ring offsets — returned by io_uring_setup in io_uring_params. +struct io_sqring_offsets { + uint32_t head; + uint32_t tail; + uint32_t ring_mask; + uint32_t ring_entries; + uint32_t flags; + uint32_t dropped; + uint32_t array; + uint32_t resv1; + uint64_t resv2; +}; + +// CQ ring offsets — returned by io_uring_setup in io_uring_params. +struct io_cqring_offsets { + uint32_t head; + uint32_t tail; + uint32_t ring_mask; + uint32_t ring_entries; + uint32_t overflow; + uint32_t cqes; + uint32_t flags; + uint32_t resv1; + uint64_t resv2; +}; + +// Parameters passed to io_uring_setup(). +struct io_uring_params { + uint32_t sq_entries; + uint32_t cq_entries; + uint32_t flags; + uint32_t sq_thread_cpu; + uint32_t sq_thread_idle; + uint32_t features; + uint32_t wq_fd; + uint32_t resv[3]; + struct io_sqring_offsets sq_off; + struct io_cqring_offsets cq_off; +}; + +// --------------------------------------------------------------------------- +// Inline helper — prepare an SQE for a read operation. +// --------------------------------------------------------------------------- +static inline void io_uring_prep_read(struct io_uring_sqe *sqe, int fd, + void *buf, uint32_t nbytes, + uint64_t offset) { + sqe->opcode = IORING_OP_READ; + sqe->flags = 0; + sqe->ioprio = 0; + sqe->fd = fd; + sqe->off = offset; + sqe->addr = reinterpret_cast(buf); + sqe->len = nbytes; + sqe->rw_flags = 0; + sqe->user_data = 0; + sqe->buf_index = 0; + sqe->personality = 0; +} + +// --------------------------------------------------------------------------- +// End: struct and constant definitions from +// --------------------------------------------------------------------------- + +#endif // __linux__ diff --git a/src/core/algorithm/diskann/iouring_loader.h b/src/core/algorithm/diskann/iouring_loader.h new file mode 100644 index 000000000..d14650109 --- /dev/null +++ b/src/core/algorithm/diskann/iouring_loader.h @@ -0,0 +1,261 @@ +// Copyright 2025-present the zvec project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Raw-syscall wrapper for Linux io_uring. +// +// This class implements the io_uring submission/completion queue lifecycle +// using *only* kernel syscalls (io_uring_setup, io_uring_enter) and mmap. +// There is zero dependency on liburing or liburing-dev: no build-time header, +// no runtime .so, and no dlopen. This mirrors the project's existing +// zero-dependency philosophy established by the libaio dlopen approach, but +// goes one step further — io_uring is a pure kernel ABI accessed via syscall. +// +// Runtime detection is automatic: if the kernel does not support io_uring +// (pre-5.1 or io_uring disabled), io_uring_setup() returns -ENOSYS and +// setup() returns false, allowing callers to fall back to libaio or pread. +// +// The ring is **not** thread-safe. Each thread that performs I/O must have +// its own IoUringRing instance (managed through IoBackend / IOContext). + +#pragma once + +#if defined(__linux) || defined(__linux__) + +#include +#include +#include +#include +#include +#include +#include "iouring_def.h" + +namespace zvec { +namespace core { + +// Forward declaration — AlignedRead is defined in diskann_file_reader.h +// after this header is included. The forward declaration is sufficient +// because IoUringRing::execute takes it by reference. +struct AlignedRead; + +// Maximum number of SQEs we submit in a single io_uring_enter() call. +static constexpr uint32_t kIoUringMaxBatch = 128; + +class IoUringRing { + public: + IoUringRing() = default; + ~IoUringRing() { + teardown(); + } + + IoUringRing(const IoUringRing &) = delete; + IoUringRing &operator=(const IoUringRing &) = delete; + + // Create an io_uring with the given number of entries. + // Returns true on success, false if the kernel does not support io_uring + // or setup failed for any reason. + bool setup(uint32_t entries) { + struct io_uring_params params; + std::memset(¶ms, 0, sizeof(params)); + + // io_uring_setup is a raw syscall — returns fd (>=0) or -1 with errno. + ring_fd_ = static_cast( + syscall(__NR_io_uring_setup, static_cast(entries), ¶ms)); + if (ring_fd_ < 0) { + // ENOSYS = kernel doesn't support io_uring. + // EPERM = io_uring disabled via sysctl. + // EINVAL = invalid parameters. + if (errno != ENOSYS) { + LOG_WARN("io_uring_setup failed; errno=%d, %s", errno, + ::strerror(errno)); + } + return false; + } + + sq_entries_ = params.sq_entries; + cq_entries_ = params.cq_entries; + + // --- mmap the three shared regions --- + + // 1. SQ ring (includes head, tail, mask, entries, flags, dropped, array). + size_t sq_ring_sz = static_cast(params.sq_off.array) + + sq_entries_ * sizeof(uint32_t); + sq_ring_ptr_ = ::mmap(nullptr, sq_ring_sz, PROT_READ | PROT_WRITE, + MAP_SHARED, ring_fd_, IORING_OFF_SQ_RING); + if (sq_ring_ptr_ == MAP_FAILED) { + LOG_ERROR("mmap SQ ring failed: %s", ::strerror(errno)); + sq_ring_ptr_ = nullptr; + teardown(); + return false; + } + + // 2. SQE array. + size_t sqes_sz = sq_entries_ * sizeof(struct io_uring_sqe); + sqes_ptr_ = reinterpret_cast( + ::mmap(nullptr, sqes_sz, PROT_READ | PROT_WRITE, MAP_SHARED, ring_fd_, + IORING_OFF_SQES)); + if (sqes_ptr_ == MAP_FAILED) { + LOG_ERROR("mmap SQEs failed: %s", ::strerror(errno)); + sqes_ptr_ = nullptr; + teardown(); + return false; + } + + // 3. CQ ring (includes head, tail, mask, entries, overflow, cqes[]). + size_t cq_ring_sz = static_cast(params.cq_off.cqes) + + cq_entries_ * sizeof(struct io_uring_cqe); + cq_ring_ptr_ = ::mmap(nullptr, cq_ring_sz, PROT_READ | PROT_WRITE, + MAP_SHARED, ring_fd_, IORING_OFF_CQ_RING); + if (cq_ring_ptr_ == MAP_FAILED) { + LOG_ERROR("mmap CQ ring failed: %s", ::strerror(errno)); + cq_ring_ptr_ = nullptr; + teardown(); + return false; + } + + // --- Set up typed pointers into the mmap'd regions --- + + // SQ ring fields. + sq_head_ = reinterpret_cast(static_cast(sq_ring_ptr_) + + params.sq_off.head); + sq_tail_ = reinterpret_cast(static_cast(sq_ring_ptr_) + + params.sq_off.tail); + sq_ring_mask_ = reinterpret_cast( + static_cast(sq_ring_ptr_) + params.sq_off.ring_mask); + sq_ring_entries_ = reinterpret_cast( + static_cast(sq_ring_ptr_) + params.sq_off.ring_entries); + sq_flags_ = reinterpret_cast(static_cast(sq_ring_ptr_) + + params.sq_off.flags); + sq_dropped_ = reinterpret_cast( + static_cast(sq_ring_ptr_) + params.sq_off.dropped); + sq_array_ = reinterpret_cast(static_cast(sq_ring_ptr_) + + params.sq_off.array); + + // CQ ring fields. + cq_head_ = reinterpret_cast(static_cast(cq_ring_ptr_) + + params.cq_off.head); + cq_tail_ = reinterpret_cast(static_cast(cq_ring_ptr_) + + params.cq_off.tail); + cq_ring_mask_ = reinterpret_cast( + static_cast(cq_ring_ptr_) + params.cq_off.ring_mask); + cq_ring_entries_ = reinterpret_cast( + static_cast(cq_ring_ptr_) + params.cq_off.ring_entries); + cq_overflow_ = reinterpret_cast( + static_cast(cq_ring_ptr_) + params.cq_off.overflow); + cqes_ = reinterpret_cast( + static_cast(cq_ring_ptr_) + params.cq_off.cqes); + + // SQE array. + sqes_ = sqes_ptr_; + + // Initialize the SQ array to identity mapping so that logical index == + // physical SQE index. This is the simplest and most common configuration. + for (uint32_t i = 0; i < sq_entries_; i++) { + sq_array_[i] = i; + } + + LOG_INFO("io_uring initialized: sq_entries=%u, cq_entries=%u", sq_entries_, + cq_entries_); + return true; + } + + // Tear down the ring: munmap all regions and close the ring fd. + void teardown() { + if (sq_ring_ptr_ && sq_ring_ptr_ != MAP_FAILED) { + // We don't track the exact mmap size; munmap with a large enough size + // is safe because the kernel only unmaps what was actually mapped. + // However, to be correct we use the page-aligned size. + size_t sz = static_cast(sq_entries_) * sizeof(uint32_t) + 4096; + ::munmap(sq_ring_ptr_, sz); + } + if (sqes_ptr_ && sqes_ptr_ != MAP_FAILED) { + size_t sz = + static_cast(sq_entries_) * sizeof(struct io_uring_sqe); + ::munmap(sqes_ptr_, sz); + } + if (cq_ring_ptr_ && cq_ring_ptr_ != MAP_FAILED) { + size_t sz = + static_cast(cq_entries_) * sizeof(struct io_uring_cqe) + 4096; + ::munmap(cq_ring_ptr_, sz); + } + + sq_ring_ptr_ = nullptr; + sqes_ptr_ = nullptr; + cq_ring_ptr_ = nullptr; + sqes_ = nullptr; + cqes_ = nullptr; + sq_head_ = sq_tail_ = sq_ring_mask_ = sq_ring_entries_ = nullptr; + sq_flags_ = sq_dropped_ = sq_array_ = nullptr; + cq_head_ = cq_tail_ = cq_ring_mask_ = cq_ring_entries_ = nullptr; + cq_overflow_ = nullptr; + + if (ring_fd_ >= 0) { + ::close(ring_fd_); + ring_fd_ = -1; + } + + sq_entries_ = 0; + cq_entries_ = 0; + } + + bool is_valid() const { + return ring_fd_ >= 0; + } + + // Execute a batch of aligned read requests via io_uring. + // + // Implemented in diskann_file_reader.cc to avoid a circular dependency: + // AlignedRead is defined in diskann_file_reader.h *after* this header is + // included, so the method body cannot be inline here. + // + // On success returns 0. On failure returns -1; the caller should fall + // back to pread. + int execute(int fd, std::vector &read_reqs); + + private: + int ring_fd_{-1}; + + // mmap'd region base pointers (needed for munmap). + void *sq_ring_ptr_{nullptr}; + struct io_uring_sqe *sqes_ptr_{nullptr}; + void *cq_ring_ptr_{nullptr}; + + // SQ ring field pointers (into sq_ring_ptr_). + unsigned *sq_head_{nullptr}; + unsigned *sq_tail_{nullptr}; + unsigned *sq_ring_mask_{nullptr}; + unsigned *sq_ring_entries_{nullptr}; + unsigned *sq_flags_{nullptr}; + unsigned *sq_dropped_{nullptr}; + unsigned *sq_array_{nullptr}; + + // CQ ring field pointers (into cq_ring_ptr_). + unsigned *cq_head_{nullptr}; + unsigned *cq_tail_{nullptr}; + unsigned *cq_ring_mask_{nullptr}; + unsigned *cq_ring_entries_{nullptr}; + unsigned *cq_overflow_{nullptr}; + struct io_uring_cqe *cqes_{nullptr}; + + // SQE array pointer. + struct io_uring_sqe *sqes_{nullptr}; + + // Ring capacities. + unsigned sq_entries_{0}; + unsigned cq_entries_{0}; +}; + +} // namespace core +} // namespace zvec + +#endif // __linux__ From 8ef5d2d8d4681ac174fb6cfad36abff7613b6778 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 26 Jun 2026 14:05:40 +0800 Subject: [PATCH 05/41] fix: log out the warning only once --- src/core/algorithm/diskann/diskann_file_reader.cc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index c8d8bdd0b..0d4d69cae 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -28,12 +28,18 @@ namespace core { #if (defined(__linux) || defined(__linux__)) typedef struct io_event io_event_t; typedef struct iocb iocb_t; + +// Ensures the libaio-unavailable warning is logged only once per process, +// regardless of how many threads or readers trigger the fallback path. +static std::once_flag g_libaio_warn_once; #endif int setup_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) if (!LibAioLoader::Instance().Load()) { - LOG_WARN("libaio not available; falling back to synchronous pread"); + std::call_once(g_libaio_warn_once, [] { + LOG_WARN("libaio not available; falling back to synchronous pread"); + }); return 0; } int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); @@ -200,7 +206,9 @@ void LinuxAlignedFileReader::register_thread() { IOContext ctx = nullptr; if (!LibAioLoader::Instance().Load()) { - LOG_WARN("libaio not available; async I/O disabled, will use pread"); + std::call_once(g_libaio_warn_once, [] { + LOG_WARN("libaio not available; async I/O disabled, will use pread"); + }); lk.unlock(); return; } From 50c6c8d9989b6332c19d80ea93f081f0b3d13e85 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 26 Jun 2026 15:16:44 +0800 Subject: [PATCH 06/41] fix: add log --- .../algorithm/diskann/diskann_file_reader.cc | 33 ++++++++++++------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index 0d4d69cae..bc19d8eb5 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -29,17 +29,23 @@ namespace core { typedef struct io_event io_event_t; typedef struct iocb iocb_t; -// Ensures the libaio-unavailable warning is logged only once per process, -// regardless of how many threads or readers trigger the fallback path. -static std::once_flag g_libaio_warn_once; +// Ensures the I/O backend selection is logged exactly once per process, +// regardless of which entry point (setup_io_ctx or register_thread) +// triggers it first. +static std::once_flag g_io_backend_log_once; #endif int setup_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) - if (!LibAioLoader::Instance().Load()) { - std::call_once(g_libaio_warn_once, [] { - LOG_WARN("libaio not available; falling back to synchronous pread"); - }); + LibAioLoader::Instance().Load(); + std::call_once(g_io_backend_log_once, [] { + if (LibAioLoader::Instance().IsAvailable()) { + LOG_INFO("DiskAnn I/O backend: libaio (async I/O enabled)"); + } else { + LOG_WARN("DiskAnn I/O backend: synchronous pread (libaio not available)"); + } + }); + if (!LibAioLoader::Instance().IsAvailable()) { return 0; } int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); @@ -205,10 +211,15 @@ void LinuxAlignedFileReader::register_thread() { IOContext ctx = nullptr; - if (!LibAioLoader::Instance().Load()) { - std::call_once(g_libaio_warn_once, [] { - LOG_WARN("libaio not available; async I/O disabled, will use pread"); - }); + LibAioLoader::Instance().Load(); + std::call_once(g_io_backend_log_once, [] { + if (LibAioLoader::Instance().IsAvailable()) { + LOG_INFO("DiskAnn I/O backend: libaio (async I/O enabled)"); + } else { + LOG_WARN("DiskAnn I/O backend: synchronous pread (libaio not available)"); + } + }); + if (!LibAioLoader::Instance().IsAvailable()) { lk.unlock(); return; } From ceee226125f6192077c006f250478d7b55eeaf96 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 26 Jun 2026 15:39:07 +0800 Subject: [PATCH 07/41] fix: add log --- tools/core/bench_original.cc | 1 + tools/core/recall_original.cc | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/core/bench_original.cc b/tools/core/bench_original.cc index 65a36d7ba..796ea399f 100644 --- a/tools/core/bench_original.cc +++ b/tools/core/bench_original.cc @@ -886,6 +886,7 @@ int main(int argc, char *argv[]) { transform(log_level.begin(), log_level.end(), log_level.begin(), ::tolower); if (LOG_LEVEL.find(log_level) != LOG_LEVEL.end()) { IndexLoggerBroker::SetLevel(LOG_LEVEL[log_level]); + zvec::ailego::LoggerBroker::SetLevel(LOG_LEVEL[log_level]); } // Calculate Bench diff --git a/tools/core/recall_original.cc b/tools/core/recall_original.cc index c8b2068ef..bf9b2c8a4 100644 --- a/tools/core/recall_original.cc +++ b/tools/core/recall_original.cc @@ -1883,6 +1883,7 @@ int main(int argc, char *argv[]) { transform(log_level.begin(), log_level.end(), log_level.begin(), ::tolower); if (LOG_LEVEL.find(log_level) != LOG_LEVEL.end()) { IndexLoggerBroker::SetLevel(LOG_LEVEL[log_level]); + zvec::ailego::LoggerBroker::SetLevel(LOG_LEVEL[log_level]); } // Calculate Recall From 29b59b92052fef0bd0b7188907c3b53e574c8a54 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 26 Jun 2026 15:49:28 +0800 Subject: [PATCH 08/41] fix: remove log --- src/core/algorithm/diskann/iouring_loader.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/algorithm/diskann/iouring_loader.h b/src/core/algorithm/diskann/iouring_loader.h index d14650109..1f0cf731a 100644 --- a/src/core/algorithm/diskann/iouring_loader.h +++ b/src/core/algorithm/diskann/iouring_loader.h @@ -164,8 +164,6 @@ class IoUringRing { sq_array_[i] = i; } - LOG_INFO("io_uring initialized: sq_entries=%u, cq_entries=%u", sq_entries_, - cq_entries_); return true; } From a2524ebd6f1c7ade392e57306ca110575c72d72d Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 1 Jul 2026 10:53:22 +0800 Subject: [PATCH 09/41] fix: fix windows build --- src/core/algorithm/CMakeLists.txt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/core/algorithm/CMakeLists.txt b/src/core/algorithm/CMakeLists.txt index bed772984..f874eba62 100644 --- a/src/core/algorithm/CMakeLists.txt +++ b/src/core/algorithm/CMakeLists.txt @@ -23,7 +23,12 @@ else() if(MSVC) # MSVC: STATIC-only stub to avoid creating an empty DLL with no exports - # (MSVC linker fails to produce an import library when there are zero exports) + # (MSVC linker fails to produce an import library when there are zero exports). + # cc_library with STATIC-only creates target "core_knn_diskann" but NOT the + # "core_knn_diskann_static" variant (that only happens with STATIC+SHARED). + # The Python binding references core_knn_diskann_static on all platforms, so + # create an ALIAS so the same target name works under MSVC as well. + # ($ supports ALIAS targets since CMake 3.18.) cc_library( NAME core_knn_diskann STATIC STRICT ALWAYS_LINK @@ -32,6 +37,7 @@ else() INCS . ${PROJECT_ROOT_DIR}/src ${PROJECT_ROOT_DIR}/src/core ${PROJECT_ROOT_DIR}/src/core/algorithm VERSION "${PROXIMA_ZVEC_VERSION}" ) + add_library(core_knn_diskann_static ALIAS core_knn_diskann) else() cc_library( NAME core_knn_diskann From 6688e1ab5baecefac3c5d6e30b7ddae0a7f299f7 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 1 Jul 2026 20:31:59 +0800 Subject: [PATCH 10/41] fix: remove libaio dependency --- .github/workflows/03-macos-linux-build.yml | 8 -------- .github/workflows/08-cmake-subproject-integration.yml | 7 ------- .github/workflows/clang_tidy.yml | 2 +- .github/workflows/nightly_coverage.yml | 2 +- CMakeLists.txt | 2 +- pyproject.toml | 6 +----- 6 files changed, 4 insertions(+), 23 deletions(-) diff --git a/.github/workflows/03-macos-linux-build.yml b/.github/workflows/03-macos-linux-build.yml index 4e4f1626f..03fe2cafa 100644 --- a/.github/workflows/03-macos-linux-build.yml +++ b/.github/workflows/03-macos-linux-build.yml @@ -60,14 +60,6 @@ jobs: sudo apt-get install -y clang libomp-dev shell: bash - - name: Install AIO - if: runner.os == 'Linux' && runner.arch == 'X64' - run: | - sudo apt-get update - sudo apt-get install -y --no-install-recommends \ - libaio-dev - shell: bash - - name: Print CPU info if: runner.os == 'Linux' run: lscpu diff --git a/.github/workflows/08-cmake-subproject-integration.yml b/.github/workflows/08-cmake-subproject-integration.yml index 564a30484..3c5d50e17 100644 --- a/.github/workflows/08-cmake-subproject-integration.yml +++ b/.github/workflows/08-cmake-subproject-integration.yml @@ -34,13 +34,6 @@ jobs: cache: 'pip' cache-dependency-path: 'pyproject.toml' - - name: Install system dependencies - run: | - sudo apt-get update - sudo apt-get install -y --no-install-recommends \ - libaio-dev - shell: bash - - name: Set up environment variables run: | NPROC=$(nproc 2>/dev/null || echo 2) diff --git a/.github/workflows/clang_tidy.yml b/.github/workflows/clang_tidy.yml index 20a302d73..5ab872d58 100644 --- a/.github/workflows/clang_tidy.yml +++ b/.github/workflows/clang_tidy.yml @@ -47,7 +47,7 @@ jobs: if: steps.changed_files.outputs.any_changed == 'true' run: | sudo apt-get update - sudo apt-get install -y clang-tidy=1:18.0-59~exp2 cmake ninja-build libomp-dev libaio-dev + sudo apt-get install -y clang-tidy=1:18.0-59~exp2 cmake ninja-build libomp-dev - name: Setup ccache if: steps.changed_files.outputs.any_changed == 'true' diff --git a/.github/workflows/nightly_coverage.yml b/.github/workflows/nightly_coverage.yml index 81429b1eb..4c9aca50b 100644 --- a/.github/workflows/nightly_coverage.yml +++ b/.github/workflows/nightly_coverage.yml @@ -49,7 +49,7 @@ jobs: run: | sudo apt-get update sudo apt-get install -y --no-install-recommends \ - lcov libaio-dev + lcov shell: bash - name: Install dependencies diff --git a/CMakeLists.txt b/CMakeLists.txt index 2ba9b597d..956ee5599 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -122,7 +122,7 @@ else() endif() message(STATUS "RABITQ_ARCH_FLAG: ${RABITQ_ARCH_FLAG}") -# DiskAnn support (Linux x86_64 only, requires libaio) +# DiskAnn support (Linux x86_64 only; libaio loaded at runtime via dlopen) if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|i686|i386" AND NOT ANDROID AND NOT IOS) set(DISKANN_SUPPORTED ON) add_definitions(-DDISKANN_SUPPORTED=1) diff --git a/pyproject.toml b/pyproject.toml index 4f7add507..bce1670d5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -181,11 +181,7 @@ test-command = "cd {project} && pytest python/tests -v --tb=short" build-verbosity = 1 [tool.cibuildwheel.linux] -# libaio is required by the C++ backend; install it inside the manylinux -# container (manylinux_2_28 is AlmaLinux 8 based, so use dnf/libaio-devel). -# libaio-devel lives in BaseOS; disable EPEL so a flaky EPEL mirror cannot -# break metadata refresh. -before-all = "dnf install -y --disablerepo=epel libaio-devel" +# libaio is loaded at runtime via dlopen (no build-time dependency). archs = ["auto"] environment = { CMAKE_GENERATOR = "Unix Makefiles", CMAKE_BUILD_PARALLEL_LEVEL = "16" } manylinux-x86_64-image = "manylinux_2_28" From 5d3b96a6cc67d62ecd9ac5c913f77bfacfe86e3d Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 2 Jul 2026 17:52:15 +0800 Subject: [PATCH 11/41] fix: fix --- src/core/algorithm/diskann/CMakeLists.txt | 34 +++++++++++++++++++ .../diskann/diskann_builder_entity.cc | 1 + src/core/algorithm/diskann/diskann_entity.h | 2 +- .../algorithm/diskann/diskann_file_reader.h | 3 ++ .../diskann/diskann_reducer_entity.cc | 2 +- 5 files changed, 40 insertions(+), 2 deletions(-) diff --git a/src/core/algorithm/diskann/CMakeLists.txt b/src/core/algorithm/diskann/CMakeLists.txt index 33269da5b..5f32c9598 100644 --- a/src/core/algorithm/diskann/CMakeLists.txt +++ b/src/core/algorithm/diskann/CMakeLists.txt @@ -33,4 +33,38 @@ cc_library( INCS . ${PROJECT_ROOT_DIR}/src/core ${PROJECT_ROOT_DIR}/src/core/algorithm LDFLAGS "${CORE_KNN_DISKANN_LDFLAGS}" VERSION "${PROXIMA_ZVEC_VERSION}" +) + +if(MSVC) + target_compile_definitions(core_knn_diskann PRIVATE NOMINMAX) +endif() + +# Expose internal zvec lib include dirs. On Linux, symbol resolution happens +# at dlopen time via RTLD_GLOBAL so we do NOT add link dependencies. On +# Windows, we must link against the import libraries because Windows has no +# equivalent of RTLD_GLOBAL. +foreach(_dep zvec_ailego core_framework core_knn_cluster) + if(TARGET ${_dep}) + target_include_directories(core_knn_diskann PRIVATE + $) + add_dependencies(core_knn_diskann ${_dep}) + if(MSVC) + target_link_libraries(core_knn_diskann ${_dep}) + endif() + endif() +endforeach() + +# On Linux, allow the plugin to have unresolved symbols that will be satisfied +# at dlopen(RTLD_NOW | RTLD_GLOBAL) time by the hosting binary. +if(CMAKE_SYSTEM_NAME STREQUAL "Linux") + target_link_options(core_knn_diskann PRIVATE + "LINKER:--unresolved-symbols=ignore-all") +endif() + +# Rename the artifact so it is clearly identified as an optional plugin that +# users load at runtime via zvec::LoadDiskAnnPlugin(). +# On Linux: libzvec_diskann_plugin.so +# On Windows: zvec_diskann_plugin.dll +set_target_properties(core_knn_diskann PROPERTIES + OUTPUT_NAME zvec_diskann_plugin ) \ No newline at end of file diff --git a/src/core/algorithm/diskann/diskann_builder_entity.cc b/src/core/algorithm/diskann/diskann_builder_entity.cc index 4381293a5..be0e7c75b 100644 --- a/src/core/algorithm/diskann/diskann_builder_entity.cc +++ b/src/core/algorithm/diskann/diskann_builder_entity.cc @@ -14,6 +14,7 @@ #include "diskann_builder_entity.h" #include +#include #include "diskann_algorithm.h" #include "diskann_util.h" diff --git a/src/core/algorithm/diskann/diskann_entity.h b/src/core/algorithm/diskann/diskann_entity.h index af302290d..02dc64e06 100644 --- a/src/core/algorithm/diskann/diskann_entity.h +++ b/src/core/algorithm/diskann/diskann_entity.h @@ -24,7 +24,7 @@ using diskann_key_t = uint64_t; using diskann_id_t = uint32_t; constexpr diskann_id_t kInvalidId = static_cast(-1); -constexpr diskann_key_t kInvalidKey = static_cast(-1); +constexpr diskann_key_t kInvalidKey = static_cast(-1); struct VectorInfo { float dist_; diff --git a/src/core/algorithm/diskann/diskann_file_reader.h b/src/core/algorithm/diskann/diskann_file_reader.h index acb7d5d9c..3118f34d9 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.h +++ b/src/core/algorithm/diskann/diskann_file_reader.h @@ -22,6 +22,9 @@ #include "iouring_loader.h" // raw-syscall io_uring wrapper #include "libaio_loader.h" // dlopen-based libaio wrapper #elif defined(_WIN32) || defined(_WIN64) +#ifndef NOMINMAX +#define NOMINMAX +#endif #include #endif diff --git a/src/core/algorithm/diskann/diskann_reducer_entity.cc b/src/core/algorithm/diskann/diskann_reducer_entity.cc index 4ccfb6d21..936e76f74 100644 --- a/src/core/algorithm/diskann/diskann_reducer_entity.cc +++ b/src/core/algorithm/diskann/diskann_reducer_entity.cc @@ -105,7 +105,7 @@ int DiskAnnReducerEntity::load_key_segment() { return IndexError_InvalidFormat; } - size_t key_data_len = doc_cnt() * sizeof(key_t); + size_t key_data_len = doc_cnt() * sizeof(diskann_key_t); // load key mapping key_mapping_segment_ = container_->get(kDiskAnnKeyMappingSegmentId); From 6cb054a25c3a0516457450dc7ea937068dbb0433 Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 2 Jul 2026 19:07:20 +0800 Subject: [PATCH 12/41] fix: fix makefile --- src/core/algorithm/diskann/CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/core/algorithm/diskann/CMakeLists.txt b/src/core/algorithm/diskann/CMakeLists.txt index 5f32c9598..ca9a308da 100644 --- a/src/core/algorithm/diskann/CMakeLists.txt +++ b/src/core/algorithm/diskann/CMakeLists.txt @@ -36,6 +36,12 @@ cc_library( ) if(MSVC) + # NOMINMAX must reach the _objects target, since _add_library() compiles + # sources there; the SHARED/STATIC targets only bundle object files and a + # PRIVATE define on them never reaches the compiler. Without this, the + # windows.h min/max macros collide with std::min/std::max and + # numeric_limits::max()/min() (error C4003). + target_compile_definitions(core_knn_diskann_objects PRIVATE NOMINMAX) target_compile_definitions(core_knn_diskann PRIVATE NOMINMAX) endif() From f2559b56734b2b30dc00b923317dd3b35d8bac93 Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 2 Jul 2026 19:20:48 +0800 Subject: [PATCH 13/41] fix: remove no use code --- tools/core/bench_original.cc | 1 - tools/core/recall_original.cc | 1 - 2 files changed, 2 deletions(-) diff --git a/tools/core/bench_original.cc b/tools/core/bench_original.cc index 796ea399f..c787b883b 100644 --- a/tools/core/bench_original.cc +++ b/tools/core/bench_original.cc @@ -885,7 +885,6 @@ int main(int argc, char *argv[]) { : "debug"; transform(log_level.begin(), log_level.end(), log_level.begin(), ::tolower); if (LOG_LEVEL.find(log_level) != LOG_LEVEL.end()) { - IndexLoggerBroker::SetLevel(LOG_LEVEL[log_level]); zvec::ailego::LoggerBroker::SetLevel(LOG_LEVEL[log_level]); } diff --git a/tools/core/recall_original.cc b/tools/core/recall_original.cc index bf9b2c8a4..997ef5ad7 100644 --- a/tools/core/recall_original.cc +++ b/tools/core/recall_original.cc @@ -1882,7 +1882,6 @@ int main(int argc, char *argv[]) { : "debug"; transform(log_level.begin(), log_level.end(), log_level.begin(), ::tolower); if (LOG_LEVEL.find(log_level) != LOG_LEVEL.end()) { - IndexLoggerBroker::SetLevel(LOG_LEVEL[log_level]); zvec::ailego::LoggerBroker::SetLevel(LOG_LEVEL[log_level]); } From d7530802df74abaab63d4c17f9a574087ee414bb Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 2 Jul 2026 19:39:29 +0800 Subject: [PATCH 14/41] fix: fix makefile --- thirdparty/arrow/CMakeLists.txt | 45 +++++---------------------------- 1 file changed, 7 insertions(+), 38 deletions(-) diff --git a/thirdparty/arrow/CMakeLists.txt b/thirdparty/arrow/CMakeLists.txt index 30d77545b..a20fa8816 100644 --- a/thirdparty/arrow/CMakeLists.txt +++ b/thirdparty/arrow/CMakeLists.txt @@ -42,45 +42,14 @@ endif() set(CONFIGURE_ENV_LIST "") if(USE_OSS_MIRROR) - set(_OSS_BASE "https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty") - - # Prefer local tarballs (manually placed in repo root) over network - # downloads to avoid flaky mirrors, HTTP/2 PROTOCOL_ERROR, or hash - # mismatches. Falls back to the OSS mirror when the local file is - # absent. Verified SHA-256 hashes match Arrow's expectations: - # boost-1.88.0-cmake.tar.gz dcea50f4... - # thrift-0.22.0.tar.gz 794a0e45... - # 13.0.0.tar.gz (xsimd) 8bdbbad0... - set(_LOCAL_BOOST "${PROJECT_ROOT_DIR}/boost-1.88.0-cmake.tar.gz") - if(EXISTS "${_LOCAL_BOOST}") - list(APPEND CONFIGURE_ENV_LIST "ARROW_BOOST_URL=file://${_LOCAL_BOOST}") - message(STATUS "Arrow: using local Boost tarball") - else() - list(APPEND CONFIGURE_ENV_LIST "ARROW_BOOST_URL=${_OSS_BASE}/boost-1.88.0-cmake.tar.gz") - endif() - - set(_LOCAL_THRIFT "${PROJECT_ROOT_DIR}/thrift-0.22.0.tar.gz") - if(EXISTS "${_LOCAL_THRIFT}") - list(APPEND CONFIGURE_ENV_LIST "ARROW_THRIFT_URL=file://${_LOCAL_THRIFT}") - message(STATUS "Arrow: using local Thrift tarball") - else() - list(APPEND CONFIGURE_ENV_LIST "ARROW_THRIFT_URL=${_OSS_BASE}/thrift-0.22.0.tar.gz") - endif() - - set(_LOCAL_XSIMD "${PROJECT_ROOT_DIR}/13.0.0.tar.gz") - if(EXISTS "${_LOCAL_XSIMD}") - list(APPEND CONFIGURE_ENV_LIST "ARROW_XSIMD_URL=file://${_LOCAL_XSIMD}") - message(STATUS "Arrow: using local xsimd tarball") - else() - list(APPEND CONFIGURE_ENV_LIST "ARROW_XSIMD_URL=${_OSS_BASE}/xsimd-13.0.0.tar.gz") - endif() - - # Dependencies without local copies — always use OSS mirror list(APPEND CONFIGURE_ENV_LIST - "ARROW_RAPIDJSON_URL=${_OSS_BASE}/rapidjson-232389d4f1012dddec4ef84861face2d2ba85709.tar.gz" - "ARROW_RE2_URL=${_OSS_BASE}/re2-2022-06-01.tar.gz" - "ARROW_UTF8PROC_URL=${_OSS_BASE}/utf8proc-2.10.0.tar.gz" - "ARROW_ZLIB_URL=${_OSS_BASE}/zlib-1.3.1.tar.gz" + "ARROW_BOOST_URL=https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty/boost-1.88.0-cmake.tar.gz" + "ARROW_RAPIDJSON_URL=https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty/rapidjson-232389d4f1012dddec4ef84861face2d2ba85709.tar.gz" + "ARROW_RE2_URL=https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty/re2-2022-06-01.tar.gz" + "ARROW_THRIFT_URL=https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty/thrift-0.22.0.tar.gz" + "ARROW_UTF8PROC_URL=https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty/utf8proc-2.10.0.tar.gz" + "ARROW_XSIMD_URL=https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty/xsimd-13.0.0.tar.gz" + "ARROW_ZLIB_URL=https://zvec-bj.oss-cn-beijing.aliyuncs.com/thirdparty/zlib-1.3.1.tar.gz" ) message(STATUS "Using OSS mirror for third-party downloads") endif() From c5ca7269df62db7ae0ba4769147dbf7e7decc77a Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 10:25:10 +0800 Subject: [PATCH 15/41] fix: support windows --- src/core/algorithm/diskann/diskann_context.cc | 7 ++- src/core/algorithm/diskann/diskann_context.h | 2 +- .../algorithm/diskann/diskann_searcher.cc | 49 ++++++++++++------- src/core/algorithm/diskann/diskann_searcher.h | 1 + .../algorithm/diskann/diskann_streamer.cc | 29 ++++++++--- src/core/algorithm/diskann/diskann_streamer.h | 1 + tools/core/recall_original.cc | 17 ++----- 7 files changed, 65 insertions(+), 41 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_context.cc b/src/core/algorithm/diskann/diskann_context.cc index f25973dd0..28969b8d8 100644 --- a/src/core/algorithm/diskann/diskann_context.cc +++ b/src/core/algorithm/diskann/diskann_context.cc @@ -27,7 +27,8 @@ DiskAnnContext::DiskAnnContext(const IndexMeta &meta, : dc_(entity.get(), measure, meta.dimension()), entity_{entity} {} int DiskAnnContext::init(ContextType type, uint32_t graph_degree, - uint32_t pq_chunk_num, uint32_t element_size) { + uint32_t pq_chunk_num, uint32_t element_size, + uint32_t disk_element_size) { type_ = type; element_size_ = element_size; pq_chunk_num_ = pq_chunk_num; @@ -60,7 +61,9 @@ int DiskAnnContext::init(ContextType type, uint32_t graph_degree, DiskAnnUtil::alloc_aligned((void **)&pq_coord_buffer_, graph_degree * pq_chunk_num_ * sizeof(uint8_t), 256); - DiskAnnUtil::alloc_aligned((void **)&coord_buffer_, element_size_, 256); + DiskAnnUtil::alloc_aligned( + (void **)&coord_buffer_, + disk_element_size > 0 ? disk_element_size : element_size_, 256); DiskAnnUtil::alloc_aligned( (void **)§or_buffer_, DiskAnnUtil::kMaxSectorReadNum * DiskAnnUtil::kSectorSize, diff --git a/src/core/algorithm/diskann/diskann_context.h b/src/core/algorithm/diskann/diskann_context.h index 4c5df6ace..c6cf8abbb 100644 --- a/src/core/algorithm/diskann/diskann_context.h +++ b/src/core/algorithm/diskann/diskann_context.h @@ -60,7 +60,7 @@ class DiskAnnContext : public IndexContext, public: //! Init int init(ContextType type, uint32_t graph_degree, uint32_t pq_chunk_num, - uint32_t element_size); + uint32_t element_size, uint32_t disk_element_size = 0); //! Update context, the context may be shared by different searcher/streamer int update_context(ContextType type, const IndexMeta &meta, diff --git a/src/core/algorithm/diskann/diskann_searcher.cc b/src/core/algorithm/diskann/diskann_searcher.cc index 905fdf2bd..ddb7d0f43 100644 --- a/src/core/algorithm/diskann/diskann_searcher.cc +++ b/src/core/algorithm/diskann/diskann_searcher.cc @@ -77,24 +77,33 @@ int DiskAnnSearcher::load(IndexStorage::Pointer storage, node_list.shrink_to_fit(); } - if (measure) { - measure_ = measure; - } else { - measure_ = IndexFactory::CreateMetric(meta_.metric_name()); - if (!measure_) { - LOG_ERROR("CreateMetric failed, name: %s", meta_.metric_name().c_str()); - return IndexError_NoExist; - } - ret = measure_->init(meta_, meta_.metric_params()); - if (ret != 0) { - LOG_ERROR("IndexMetric init failed, ret=%d", ret); - return ret; - } - if (measure_->query_metric()) { - measure_ = measure_->query_metric(); + search_meta_ = meta_; + if (meta_.metric_name() == "InnerProduct") { + search_meta_.set_metric("SquaredEuclidean", 0, ailego::Params()); + } else if (meta_.metric_name() == "Cosine") { + search_meta_.set_metric("SquaredEuclidean", 0, ailego::Params()); + if (meta_.data_type() == IndexMeta::DataType::DT_FP32) { + search_meta_.set_dimension(meta_.dimension() - 1); + } else { + search_meta_.set_dimension(meta_.dimension() - 2); } } + measure_ = IndexFactory::CreateMetric(search_meta_.metric_name()); + if (!measure_) { + LOG_ERROR("CreateMetric failed, name: %s", + search_meta_.metric_name().c_str()); + return IndexError_NoExist; + } + ret = measure_->init(search_meta_, search_meta_.metric_params()); + if (ret != 0) { + LOG_ERROR("IndexMetric init failed, ret=%d", ret); + return ret; + } + if (measure_->query_metric()) { + measure_ = measure_->query_metric(); + } + stats_.set_loaded_costtime(ailego::Monotime::MilliSeconds() - start_time); state_ = STATE_LOADED; @@ -120,8 +129,8 @@ int DiskAnnSearcher::update_context(DiskAnnContext *ctx) const { return IndexError_Runtime; } - return ctx->update_context(DiskAnnContext::kSearcherContext, meta_, measure_, - entity, magic_); + return ctx->update_context(DiskAnnContext::kSearcherContext, search_meta_, + measure_, entity, magic_); } int DiskAnnSearcher::search_impl(const void *query, const IndexQueryMeta &qmeta, @@ -286,14 +295,16 @@ IndexSearcher::Context::Pointer DiskAnnSearcher::create_context() const { } DiskAnnContext *ctx = - new (std::nothrow) DiskAnnContext(meta_, measure_, search_ctx_entity); + new (std::nothrow) DiskAnnContext(search_meta_, measure_, + search_ctx_entity); if (ctx == nullptr) { LOG_ERROR("Failed to allocate DiskAnn Context"); return Context::Pointer(); } if (ailego_unlikely(ctx->init( DiskAnnContext::kSearcherContext, search_ctx_entity->max_degree(), - search_ctx_entity->pq_chunk_num(), meta_.element_size())) != 0) { + search_ctx_entity->pq_chunk_num(), search_meta_.element_size(), + meta_.element_size())) != 0) { LOG_ERROR("Init DiskAnn Context failed"); delete ctx; diff --git a/src/core/algorithm/diskann/diskann_searcher.h b/src/core/algorithm/diskann/diskann_searcher.h index 903259c86..5724a7512 100644 --- a/src/core/algorithm/diskann/diskann_searcher.h +++ b/src/core/algorithm/diskann/diskann_searcher.h @@ -143,6 +143,7 @@ class DiskAnnSearcher : public IndexSearcher { IndexMetric::Pointer measure_{}; IndexMeta meta_{}; + IndexMeta search_meta_{}; ailego::Params params_{}; uint32_t list_size_{200}; diff --git a/src/core/algorithm/diskann/diskann_streamer.cc b/src/core/algorithm/diskann/diskann_streamer.cc index 7a978b69e..1a5bafec9 100644 --- a/src/core/algorithm/diskann/diskann_streamer.cc +++ b/src/core/algorithm/diskann/diskann_streamer.cc @@ -79,12 +79,25 @@ int DiskAnnStreamer::open(IndexStorage::Pointer storage) { node_list.shrink_to_fit(); } - measure_ = IndexFactory::CreateMetric(meta_.metric_name()); + search_meta_ = meta_; + if (meta_.metric_name() == "InnerProduct") { + search_meta_.set_metric("SquaredEuclidean", 0, ailego::Params()); + } else if (meta_.metric_name() == "Cosine") { + search_meta_.set_metric("SquaredEuclidean", 0, ailego::Params()); + if (meta_.data_type() == IndexMeta::DataType::DT_FP32) { + search_meta_.set_dimension(meta_.dimension() - 1); + } else { + search_meta_.set_dimension(meta_.dimension() - 2); + } + } + + measure_ = IndexFactory::CreateMetric(search_meta_.metric_name()); if (!measure_) { - LOG_ERROR("CreateMetric failed, name: %s", meta_.metric_name().c_str()); + LOG_ERROR("CreateMetric failed, name: %s", + search_meta_.metric_name().c_str()); return IndexError_NoExist; } - ret = measure_->init(meta_, meta_.metric_params()); + ret = measure_->init(search_meta_, search_meta_.metric_params()); if (ret != 0) { LOG_ERROR("IndexMetric init failed, ret=%d", ret); return ret; @@ -118,8 +131,8 @@ int DiskAnnStreamer::update_context(DiskAnnContext *ctx) const { return IndexError_Runtime; } - return ctx->update_context(DiskAnnContext::kSearcherContext, meta_, measure_, - entity, magic_); + return ctx->update_context(DiskAnnContext::kSearcherContext, search_meta_, + measure_, entity, magic_); } int DiskAnnStreamer::search_impl(const void *query, const IndexQueryMeta &qmeta, @@ -320,14 +333,16 @@ IndexSearcher::Context::Pointer DiskAnnStreamer::create_context() const { } DiskAnnContext *ctx = - new (std::nothrow) DiskAnnContext(meta_, measure_, search_ctx_entity); + new (std::nothrow) DiskAnnContext(search_meta_, measure_, + search_ctx_entity); if (ctx == nullptr) { LOG_ERROR("Failed to allocate DiskAnn Context"); return Context::Pointer(); } if (ailego_unlikely(ctx->init( DiskAnnContext::kSearcherContext, search_ctx_entity->max_degree(), - search_ctx_entity->pq_chunk_num(), meta_.element_size())) != 0) { + search_ctx_entity->pq_chunk_num(), search_meta_.element_size(), + meta_.element_size())) != 0) { LOG_ERROR("Init DiskAnn Context failed"); delete ctx; diff --git a/src/core/algorithm/diskann/diskann_streamer.h b/src/core/algorithm/diskann/diskann_streamer.h index b60bc2a00..a3ecf6582 100644 --- a/src/core/algorithm/diskann/diskann_streamer.h +++ b/src/core/algorithm/diskann/diskann_streamer.h @@ -153,6 +153,7 @@ class DiskAnnStreamer : public IndexStreamer { IndexMetric::Pointer measure_{}; IndexMeta meta_{}; + IndexMeta search_meta_{}; ailego::Params params_{}; uint32_t list_size_{200}; diff --git a/tools/core/recall_original.cc b/tools/core/recall_original.cc index bf9b2c8a4..09952462d 100644 --- a/tools/core/recall_original.cc +++ b/tools/core/recall_original.cc @@ -14,6 +14,7 @@ #include #include +#include #include #include #include @@ -135,12 +136,8 @@ class Recall { // Prepare file handler vector> output_fs; if (!output_.empty()) { - string cmd = "mkdir -p " + output_; - int ret = system(cmd.c_str()); - if (ret != 0) { - std::cerr << "execute cmd " << cmd << " failed" << std::endl; - return; - } + std::error_code ec; + std::filesystem::create_directories(output_, ec); struct stat sb; if (stat(output_.c_str(), &sb) == 0 && S_ISDIR(sb.st_mode)) { cout << "logs output to : " << output_ << endl; @@ -993,12 +990,8 @@ class SparseRecall { // Prepare file handler vector> output_fs; if (!output_.empty()) { - string cmd = "mkdir -p " + output_; - int ret = system(cmd.c_str()); - if (ret != 0) { - std::cerr << "execute cmd " << cmd << " failed" << std::endl; - return; - } + std::error_code ec; + std::filesystem::create_directories(output_, ec); struct stat sb; if (stat(output_.c_str(), &sb) == 0 && S_ISDIR(sb.st_mode)) { cout << "logs output to : " << output_ << endl; From c7f34c234927d15fff5788caf3d64c9a1eb81160 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 10:57:44 +0800 Subject: [PATCH 16/41] fix: fix windows --- src/core/algorithm/diskann/diskann_searcher.cc | 5 ++--- src/core/algorithm/diskann/diskann_streamer.cc | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_searcher.cc b/src/core/algorithm/diskann/diskann_searcher.cc index ddb7d0f43..f52c5261f 100644 --- a/src/core/algorithm/diskann/diskann_searcher.cc +++ b/src/core/algorithm/diskann/diskann_searcher.cc @@ -294,9 +294,8 @@ IndexSearcher::Context::Pointer DiskAnnSearcher::create_context() const { return Context::Pointer(); } - DiskAnnContext *ctx = - new (std::nothrow) DiskAnnContext(search_meta_, measure_, - search_ctx_entity); + DiskAnnContext *ctx = new (std::nothrow) + DiskAnnContext(search_meta_, measure_, search_ctx_entity); if (ctx == nullptr) { LOG_ERROR("Failed to allocate DiskAnn Context"); return Context::Pointer(); diff --git a/src/core/algorithm/diskann/diskann_streamer.cc b/src/core/algorithm/diskann/diskann_streamer.cc index 1a5bafec9..fb97ef49a 100644 --- a/src/core/algorithm/diskann/diskann_streamer.cc +++ b/src/core/algorithm/diskann/diskann_streamer.cc @@ -332,9 +332,8 @@ IndexSearcher::Context::Pointer DiskAnnStreamer::create_context() const { return Context::Pointer(); } - DiskAnnContext *ctx = - new (std::nothrow) DiskAnnContext(search_meta_, measure_, - search_ctx_entity); + DiskAnnContext *ctx = new (std::nothrow) + DiskAnnContext(search_meta_, measure_, search_ctx_entity); if (ctx == nullptr) { LOG_ERROR("Failed to allocate DiskAnn Context"); return Context::Pointer(); From 77a7b4d6d772c39831e0e4836e5865f972d98706 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 11:14:15 +0800 Subject: [PATCH 17/41] fix: fix windows --- .../algorithm/diskann/diskann_file_reader.cc | 43 +++++++------------ 1 file changed, 15 insertions(+), 28 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index ae25f4700..d376c248c 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -619,34 +619,21 @@ int WindowsAlignedFileReader::read(std::vector &read_reqs, } } - // Wait for all batch reads to complete via the IOCP. - DWORD n_read = 0; - uint64_t n_complete = 0; - ULONG_PTR completion_key = 0; - OVERLAPPED *lp_os = NULL; - - while (n_complete < batch_size) { - BOOL ok = GetQueuedCompletionStatus(iocp_, &n_read, &completion_key, - &lp_os, INFINITE); - if (ok != 0) { - // Successfully dequeued a completed I/O. - n_complete++; - } else { - if (lp_os == NULL) { - DWORD error = GetLastError(); - if (error != WAIT_TIMEOUT) { - LOG_ERROR("GetQueuedCompletionStatus() failed with error = %lu", - error); - return IndexError_Runtime; - } - // No completion packet dequeued; sleep briefly and retry. - std::this_thread::sleep_for(std::chrono::microseconds(5)); - } else { - // Completion packet for a failed I/O. - DWORD error = GetLastError(); - LOG_ERROR("I/O failed with error code: %lu", error); - return IndexError_Runtime; - } + // Wait for all batch reads to complete. + // Use GetOverlappedResult per-read instead of GetQueuedCompletionStatus + // on the shared IOCP. The shared IOCP causes completion-packet stealing + // when multiple threads call read() concurrently, leading to data + // corruption and segfaults. + for (uint64_t j = 0; j < batch_size; j++) { + OVERLAPPED &os = ctx.reqs[j]; + DWORD bytes_transferred = 0; + + BOOL ok = GetOverlappedResult(file_handle_, &os, &bytes_transferred, TRUE); + if (ok == FALSE) { + DWORD error = GetLastError(); + LOG_ERROR("GetOverlappedResult failed for read %lu, error=%lu", + (unsigned long)j, error); + return IndexError_Runtime; } } } From 292322c115ce478cd6c8ca9aa1c3aa4ed4bb22e0 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 11:28:47 +0800 Subject: [PATCH 18/41] fix: fix ut --- python/tests/test_collection_diskann.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/python/tests/test_collection_diskann.py b/python/tests/test_collection_diskann.py index 92cbc74e4..93382aba4 100644 --- a/python/tests/test_collection_diskann.py +++ b/python/tests/test_collection_diskann.py @@ -32,7 +32,6 @@ from __future__ import annotations import math -import os import platform import sys @@ -46,13 +45,6 @@ reason="DiskAnn plugin is only supported on Linux x86_64", ) -# Promote all symbols in subsequently-loaded DSOs to the global namespace and -# resolve relocations eagerly. This is REQUIRED so the DiskAnn plugin can see -# the ``IndexFactory`` singleton that lives in ``_zvec.so`` and vice versa. -# See: DiskAnn RTLD_GLOBAL + RTLD_NOW Requirement. -if sys.platform == "linux": - sys.setdlopenflags(sys.getdlopenflags() | os.RTLD_GLOBAL | os.RTLD_NOW) - import zvec # noqa: E402 from zvec import ( # noqa: E402 From 3f59037a64862fb3e093f70c672d58ff7e644400 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 11:39:19 +0800 Subject: [PATCH 19/41] fix: fix reader --- .../algorithm/diskann/diskann_file_reader.cc | 28 +++++++++++++++++-- .../algorithm/diskann/diskann_file_reader.h | 1 + 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index d376c248c..183ec3585 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -91,12 +91,25 @@ int setup_io_ctx(IOContext &ctx) { for (uint64_t i = 0; i < MAX_IO_DEPTH; i++) { OVERLAPPED os; memset(&os, 0, sizeof(OVERLAPPED)); + HANDLE ev = CreateEventA(NULL, TRUE, FALSE, NULL); + if (ev == NULL) { + LOG_ERROR("CreateEventA failed (error=%lu)", GetLastError()); + return IndexError_Runtime; + } + os.hEvent = ev; ctx.reqs.push_back(os); + ctx.events.push_back(ev); } return 0; } int destroy_io_ctx(IOContext &ctx) { + for (auto &ev : ctx.events) { + if (ev != NULL) { + CloseHandle(ev); + } + } + ctx.events.clear(); ctx.reqs.clear(); return 0; } @@ -573,7 +586,14 @@ int WindowsAlignedFileReader::read(std::vector &read_reqs, for (size_t i = ctx.reqs.size(); i < MAX_IO_DEPTH; i++) { OVERLAPPED os; memset(&os, 0, sizeof(OVERLAPPED)); + HANDLE ev = CreateEventA(NULL, TRUE, FALSE, NULL); + if (ev == NULL) { + LOG_ERROR("CreateEventA failed (error=%lu)", GetLastError()); + return IndexError_Runtime; + } + os.hEvent = ev; ctx.reqs.push_back(os); + ctx.events.push_back(ev); } } @@ -582,9 +602,13 @@ int WindowsAlignedFileReader::read(std::vector &read_reqs, uint64_t n_batches = DiskAnnUtil::div_round_up(n_reqs, MAX_IO_DEPTH); for (uint64_t batch = 0; batch < n_batches; batch++) { - // Reset all OVERLAPPED objects for this batch. - for (auto &os : ctx.reqs) { + // Reset OVERLAPPED objects for this batch (preserve hEvent). + for (size_t i = 0; i < ctx.reqs.size(); i++) { + OVERLAPPED &os = ctx.reqs[i]; + HANDLE ev = os.hEvent; memset(&os, 0, sizeof(OVERLAPPED)); + os.hEvent = ev; + ResetEvent(ev); } uint64_t batch_start = MAX_IO_DEPTH * batch; diff --git a/src/core/algorithm/diskann/diskann_file_reader.h b/src/core/algorithm/diskann/diskann_file_reader.h index 3118f34d9..1c0a65e82 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.h +++ b/src/core/algorithm/diskann/diskann_file_reader.h @@ -65,6 +65,7 @@ typedef IoBackend *IOContext; #elif defined(_WIN32) || defined(_WIN64) struct IOContext { std::vector reqs; + std::vector events; }; #else typedef uint32_t IOContext; From a0a9ce98b441843340d0f5bb02da03fbf0f4fbaa Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 11:40:49 +0800 Subject: [PATCH 20/41] fix: remove export map --- src/binding/python/CMakeLists.txt | 14 -------------- src/binding/python/exports.map | 27 +-------------------------- 2 files changed, 1 insertion(+), 40 deletions(-) diff --git a/src/binding/python/CMakeLists.txt b/src/binding/python/CMakeLists.txt index 4cc53b6da..e6439a55a 100644 --- a/src/binding/python/CMakeLists.txt +++ b/src/binding/python/CMakeLists.txt @@ -19,20 +19,6 @@ set(SRC_LISTS pybind11_add_module(_zvec ${SRC_LISTS}) -# pybind11_add_module() defaults to CXX_VISIBILITY_PRESET=hidden + -# VISIBILITY_INLINES_HIDDEN=ON, which hides the compiler-generated helper -# symbols attached to inline functions (guard variables for static locals, -# vtables, typeinfo ...). DiskAnn is now whole-archived directly into -# _zvec.so (no separate runtime .so), so guard-variable duplication across -# DSOs is no longer a concern. We still keep default visibility so that -# the version script (exports.map / exports.mac) — not the compiler — is -# the sole gatekeeper of the dynamic symbol table, exporting only zvec::* -# and PyInit_*. -set_target_properties(_zvec PROPERTIES - CXX_VISIBILITY_PRESET default - C_VISIBILITY_PRESET default - VISIBILITY_INLINES_HIDDEN OFF) - # Ensure any change to the linker version script (exports.map) triggers a # re-link of _zvec.so. target_link_options() alone is a command-line flag # and does not register the script file as a build dependency, so stale diff --git a/src/binding/python/exports.map b/src/binding/python/exports.map index 76cc27953..66d92e04f 100644 --- a/src/binding/python/exports.map +++ b/src/binding/python/exports.map @@ -1,31 +1,6 @@ { global: - # Python module entry point(s). - PyInit_*; - - # Expose the full zvec C++ namespace so that the C API binding - # (and any C++ consumer that links against _zvec.so) can resolve - # zvec:: symbols. DiskAnn is now statically linked into _zvec.so, - # so these exports are no longer needed for runtime plugin loading, - # but they are still required for the C API and for C++ consumers - # that link against the shared module. - extern "C++" { - "zvec::*"; - zvec::*; - # Also export the compiler-generated helper symbols that live - # alongside symbols in the zvec namespace (guard variables for - # static locals, vtables, typeinfo, VTT, construction vtables, - # thunks). These are needed so that factory singletons and - # vtables are unified across translation units. - "guard variable for zvec::*"; - "vtable for zvec::*"; - "VTT for zvec::*"; - "typeinfo for zvec::*"; - "typeinfo name for zvec::*"; - "construction vtable for zvec::*"; - "non-virtual thunk to zvec::*"; - "virtual thunk to zvec::*"; - }; + PyInit_*; # export only python related functions local: *; }; From 37780e7089307cc1712d70045e48285c3ead3496 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 14:52:33 +0800 Subject: [PATCH 21/41] fix: foramt --- src/core/algorithm/diskann/diskann_file_reader.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index 183ec3585..ff07faa95 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -652,7 +652,8 @@ int WindowsAlignedFileReader::read(std::vector &read_reqs, OVERLAPPED &os = ctx.reqs[j]; DWORD bytes_transferred = 0; - BOOL ok = GetOverlappedResult(file_handle_, &os, &bytes_transferred, TRUE); + BOOL ok = + GetOverlappedResult(file_handle_, &os, &bytes_transferred, TRUE); if (ok == FALSE) { DWORD error = GetLastError(); LOG_ERROR("GetOverlappedResult failed for read %lu, error=%lu", From ba9be509a3f3f812b0624de435bc252129ca905b Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 15:20:42 +0800 Subject: [PATCH 22/41] fix: fix unused --- src/core/algorithm/diskann/diskann_searcher.cc | 2 +- src/core/algorithm/diskann/diskann_searcher.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_searcher.cc b/src/core/algorithm/diskann/diskann_searcher.cc index f52c5261f..e369d2c72 100644 --- a/src/core/algorithm/diskann/diskann_searcher.cc +++ b/src/core/algorithm/diskann/diskann_searcher.cc @@ -41,7 +41,7 @@ int DiskAnnSearcher::cleanup() { } int DiskAnnSearcher::load(IndexStorage::Pointer storage, - IndexMetric::Pointer measure) { + IndexMetric::Pointer /*measure*/) { LOG_INFO("DiskAnnSearcher::load Begin"); auto start_time = ailego::Monotime::MilliSeconds(); diff --git a/src/core/algorithm/diskann/diskann_searcher.h b/src/core/algorithm/diskann/diskann_searcher.h index 5724a7512..060fda752 100644 --- a/src/core/algorithm/diskann/diskann_searcher.h +++ b/src/core/algorithm/diskann/diskann_searcher.h @@ -39,7 +39,8 @@ class DiskAnnSearcher : public IndexSearcher { int cleanup(void) override; //! Load Index from storage - int load(IndexStorage::Pointer storage, IndexMetric::Pointer metric) override; + int load(IndexStorage::Pointer storage, + IndexMetric::Pointer /*metric*/) override; //! Unload index from storage int unload(void) override; From 69b1e23fad75a1a8043c8433848861c9d4860438 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 15:37:45 +0800 Subject: [PATCH 23/41] fix: clean code --- python/tests/detail/fixture_helper.py | 10 ++-- python/tests/test_collection_diskann.py | 2 +- python/zvec/__init__.py | 34 ++++++------- src/binding/python/CMakeLists.txt | 3 -- src/binding/python/binding.cc | 41 ++++++++-------- src/core/CMakeLists.txt | 3 +- src/core/interface/CMakeLists.txt | 7 ++- .../diskann_runtime.cc} | 23 ++++----- src/core/interface/indexes/diskann_index.cc | 2 +- src/core/plugin/CMakeLists.txt | 29 ----------- src/db/index/common/schema.cc | 12 ++--- .../interface/diskann_runtime.h} | 48 ++++++------------- tests/core/algorithm/diskann/CMakeLists.txt | 2 +- .../algorithm/diskann/diskann_builder_test.cc | 4 +- 14 files changed, 84 insertions(+), 136 deletions(-) rename src/core/{plugin/diskann_plugin.cc => interface/diskann_runtime.cc} (89%) delete mode 100644 src/core/plugin/CMakeLists.txt rename src/include/zvec/{plugin/diskann_plugin.h => core/interface/diskann_runtime.h} (61%) diff --git a/python/tests/detail/fixture_helper.py b/python/tests/detail/fixture_helper.py index 2054546cf..e37fc307a 100644 --- a/python/tests/detail/fixture_helper.py +++ b/python/tests/detail/fixture_helper.py @@ -38,17 +38,17 @@ def _ensure_diskann_runtime_or_reason() -> str | None: _DISKANN_PRELOAD_REASON = "DiskAnn only supported on Linux x86_64" return _DISKANN_PRELOAD_REASON - status = zvec.load_diskann_plugin() - if status == zvec.DISKANN_PLUGIN_UNSUPPORTED_PLATFORM: + status = zvec.init_diskann_runtime() + if status == zvec.DISKANN_RUNTIME_UNSUPPORTED_PLATFORM: _DISKANN_PRELOAD_REASON = ( f"DiskAnn is not supported on this platform (status={status})." ) return _DISKANN_PRELOAD_REASON - # DISKANN_PLUGIN_OK and DISKANN_PLUGIN_LIBAIO_MISSING are both acceptable: + # DISKANN_RUNTIME_OK and DISKANN_RUNTIME_LIBAIO_MISSING are both acceptable: # the latter means DiskAnn will use synchronous pread() instead of async I/O. if status not in ( - zvec.DISKANN_PLUGIN_OK, - zvec.DISKANN_PLUGIN_LIBAIO_MISSING, + zvec.DISKANN_RUNTIME_OK, + zvec.DISKANN_RUNTIME_LIBAIO_MISSING, ): _DISKANN_PRELOAD_REASON = ( f"Failed to initialize DiskAnn runtime (status={status})." diff --git a/python/tests/test_collection_diskann.py b/python/tests/test_collection_diskann.py index 93382aba4..e90751a04 100644 --- a/python/tests/test_collection_diskann.py +++ b/python/tests/test_collection_diskann.py @@ -19,7 +19,7 @@ 1. DiskAnn is currently built only for Linux x86_64 — other platforms are skipped wholesale. -2. The DiskAnn runtime is initialized via ``zvec.load_diskann_plugin()``, +2. The DiskAnn runtime is initialized via ``zvec.init_diskann_runtime()``, which eagerly loads libaio via dlopen(). If libaio is missing, DiskAnn falls back to synchronous pread() — the tests still run but with degraded performance. DiskAnn is compiled directly into ``_zvec.so``; there is no diff --git a/python/zvec/__init__.py b/python/zvec/__init__.py index 630602be2..cef509077 100644 --- a/python/zvec/__init__.py +++ b/python/zvec/__init__.py @@ -43,19 +43,19 @@ # Public API — grouped by category # ============================== -# —— DiskAnn runtime plugin —— -# Re-export the plugin management entry points defined by the C++ extension. -# DiskAnn normally auto-loads on first use; these APIs let tests and -# diagnostic tools preload the plugin and get a clear error if libaio is -# missing or the plugin shared object cannot be located. +# —— DiskAnn runtime —— +# Re-export the runtime management entry points defined by the C++ extension. +# DiskAnn normally auto-initializes on first use; these APIs let tests and +# diagnostic tools force initialization up-front and get a clear error if +# libaio is missing. from zvec._zvec import ( - DISKANN_PLUGIN_DLOPEN_FAILED, - DISKANN_PLUGIN_LIBAIO_MISSING, - DISKANN_PLUGIN_OK, - DISKANN_PLUGIN_UNSUPPORTED_PLATFORM, - is_diskann_plugin_loaded, + DISKANN_RUNTIME_DLOPEN_FAILED, + DISKANN_RUNTIME_LIBAIO_MISSING, + DISKANN_RUNTIME_OK, + DISKANN_RUNTIME_UNSUPPORTED_PLATFORM, + init_diskann_runtime, + is_diskann_runtime_ready, is_libaio_available, - load_diskann_plugin, ) from . import model as model @@ -204,13 +204,13 @@ # Tools "require_module", # DiskAnn runtime - "load_diskann_plugin", - "is_diskann_plugin_loaded", + "init_diskann_runtime", + "is_diskann_runtime_ready", "is_libaio_available", - "DISKANN_PLUGIN_OK", - "DISKANN_PLUGIN_UNSUPPORTED_PLATFORM", - "DISKANN_PLUGIN_LIBAIO_MISSING", - "DISKANN_PLUGIN_DLOPEN_FAILED", + "DISKANN_RUNTIME_OK", + "DISKANN_RUNTIME_UNSUPPORTED_PLATFORM", + "DISKANN_RUNTIME_LIBAIO_MISSING", + "DISKANN_RUNTIME_DLOPEN_FAILED", ] # ============================== diff --git a/src/binding/python/CMakeLists.txt b/src/binding/python/CMakeLists.txt index e6439a55a..7524502be 100644 --- a/src/binding/python/CMakeLists.txt +++ b/src/binding/python/CMakeLists.txt @@ -47,7 +47,6 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux") $ $ $ - $ -Wl,--no-whole-archive zvec ${CMAKE_DL_LIBS} @@ -75,7 +74,6 @@ elseif (APPLE) -Wl,-force_load,$ -Wl,-force_load,$ -Wl,-force_load,$ - -Wl,-force_load,$ zvec ) target_link_libraries(_zvec PRIVATE @@ -95,7 +93,6 @@ elseif (MSVC) core_metric_static core_utility_static core_quantizer_static - core_plugin ) target_link_libraries(_zvec PRIVATE ${_zvec_whole_archive_libs} diff --git a/src/binding/python/binding.cc b/src/binding/python/binding.cc index 4e257472f..2d6332644 100644 --- a/src/binding/python/binding.cc +++ b/src/binding/python/binding.cc @@ -13,7 +13,7 @@ // limitations under the License. #include -#include +#include #include "python_collection.h" #include "python_config.h" #include "python_doc.h" @@ -27,34 +27,35 @@ namespace zvec { namespace { // Expose DiskAnn runtime management to Python. DiskAnn is compiled directly -// into _zvec.so, so "loading" just means eagerly dlopen()-ing libaio and +// into _zvec.so, so "initializing" just means eagerly dlopen()-ing libaio and // caching the result. Tests (and diagnostic tooling) use these entry points -// to force the load up-front and get actionable warnings when libaio is +// to force the init up-front and get actionable warnings when libaio is // missing. -void InitializeDiskAnnPluginBindings(pybind11::module_ &m) { +void InitializeDiskAnnRuntimeBindings(pybind11::module_ &m) { m.def( - "load_diskann_plugin", - [](const std::string &path) { return ::zvec::LoadDiskAnnPlugin(path); }, + "init_diskann_runtime", + [](const std::string &path) { return ::zvec::InitDiskAnnRuntime(path); }, pybind11::arg("path") = std::string(), - "Load libaio for the DiskAnn runtime. Returns DISKANN_PLUGIN_OK (0) " - "on success, or DISKANN_PLUGIN_LIBAIO_MISSING if libaio is not " - "available (DiskAnn falls back to synchronous pread in that case). " - "Returns a negative code for unsupported platforms."); - m.def("is_diskann_plugin_loaded", &::zvec::IsDiskAnnPluginLoaded, - "Return True if the DiskAnn runtime plugin is currently loaded."); + "Initialize the DiskAnn runtime by loading libaio via dlopen(). " + "Returns DISKANN_RUNTIME_OK (0) on success, or " + "DISKANN_RUNTIME_LIBAIO_MISSING if libaio is not available (DiskAnn " + "falls back to synchronous pread in that case). Returns a negative " + "code for unsupported platforms."); + m.def("is_diskann_runtime_ready", &::zvec::IsDiskAnnRuntimeReady, + "Return True if the DiskAnn runtime has been initialized."); m.def("is_libaio_available", &::zvec::IsLibAioAvailable, "Return True if libaio is resolvable on this host (required by the " "DiskAnn runtime)."); // Status constants so callers can compare against well-known codes without // hard-coding integers. - m.attr("DISKANN_PLUGIN_OK") = static_cast(::zvec::kDiskAnnPluginOk); - m.attr("DISKANN_PLUGIN_UNSUPPORTED_PLATFORM") = - static_cast(::zvec::kDiskAnnPluginUnsupportedPlatform); - m.attr("DISKANN_PLUGIN_LIBAIO_MISSING") = - static_cast(::zvec::kDiskAnnPluginLibAioMissing); - m.attr("DISKANN_PLUGIN_DLOPEN_FAILED") = - static_cast(::zvec::kDiskAnnPluginDlopenFailed); + m.attr("DISKANN_RUNTIME_OK") = static_cast(::zvec::kDiskAnnRuntimeOk); + m.attr("DISKANN_RUNTIME_UNSUPPORTED_PLATFORM") = + static_cast(::zvec::kDiskAnnRuntimeUnsupportedPlatform); + m.attr("DISKANN_RUNTIME_LIBAIO_MISSING") = + static_cast(::zvec::kDiskAnnRuntimeLibAioMissing); + m.attr("DISKANN_RUNTIME_DLOPEN_FAILED") = + static_cast(::zvec::kDiskAnnRuntimeDlopenFailed); } } // namespace @@ -69,6 +70,6 @@ PYBIND11_MODULE(_zvec, m) { ZVecPyConfig::Initialize(m); ZVecPyDoc::Initialize(m); ZVecPyCollection::Initialize(m); - InitializeDiskAnnPluginBindings(m); + InitializeDiskAnnRuntimeBindings(m); } } // namespace zvec diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 15e684188..13e835ef9 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -49,7 +49,6 @@ cc_directory(quantizer) cc_directory(utility) cc_directory(interface) cc_directory(mixed_reducer) -cc_directory(plugin) git_version(GIT_SRCS_VER ${CMAKE_CURRENT_SOURCE_DIR}) file(GLOB_RECURSE ALL_CORE_SRCS *.cc *.c *.h) @@ -73,7 +72,7 @@ if(NOT DISKANN_SUPPORTED) endif() set(ZVEC_CORE_LIBS zvec_ailego zvec_turbo sparsehash magic_enum rabitqlib) -# The plugin loader uses dlopen/dlsym, so link libdl on Linux. +# The DiskAnn runtime loader uses dlopen/dlsym, so link libdl on Linux. if(CMAKE_SYSTEM_NAME STREQUAL "Linux") list(APPEND ZVEC_CORE_LIBS ${CMAKE_DL_LIBS}) endif() diff --git a/src/core/interface/CMakeLists.txt b/src/core/interface/CMakeLists.txt index d5475a4b5..ffb3cb043 100644 --- a/src/core/interface/CMakeLists.txt +++ b/src/core/interface/CMakeLists.txt @@ -1,10 +1,15 @@ include(${PROJECT_ROOT_DIR}/cmake/bazel.cmake) include(${PROJECT_ROOT_DIR}/cmake/option.cmake) +set(CORE_INTERFACE_LIBS zvec_ailego core_framework sparsehash magic_enum rabitqlib) +if(CMAKE_SYSTEM_NAME STREQUAL "Linux") + list(APPEND CORE_INTERFACE_LIBS ${CMAKE_DL_LIBS}) +endif() + cc_library( NAME core_interface STATIC STRICT ALWAYS_LINK SRCS *.cc indexes/*.cc INCS . ${PROJECT_ROOT_DIR}/src/ ${PROJECT_ROOT_DIR}/src/core - LIBS zvec_ailego core_framework core_plugin sparsehash magic_enum rabitqlib + LIBS ${CORE_INTERFACE_LIBS} VERSION "${PROXIMA_ZVEC_VERSION}" ) diff --git a/src/core/plugin/diskann_plugin.cc b/src/core/interface/diskann_runtime.cc similarity index 89% rename from src/core/plugin/diskann_plugin.cc rename to src/core/interface/diskann_runtime.cc index d9af30276..9fef28690 100644 --- a/src/core/plugin/diskann_plugin.cc +++ b/src/core/interface/diskann_runtime.cc @@ -16,7 +16,7 @@ #include #include #include -#include +#include #if defined(__linux__) || defined(__linux) || defined(__APPLE__) #include @@ -64,29 +64,29 @@ bool IsLibAioAvailable() { #endif } -bool IsDiskAnnPluginLoaded() { +bool IsDiskAnnRuntimeReady() { return g_runtime_ready.load(std::memory_order_acquire); } -int LoadDiskAnnPlugin(const std::string &path) { +int InitDiskAnnRuntime(const std::string &path) { (void)path; // No external path needed — DiskAnn is linked in statically. if (!kPlatformSupportsDiskAnn) { LOG_ERROR( "DiskAnn is not supported on this platform; it is only " "available on Linux x86_64 with libaio."); - return kDiskAnnPluginUnsupportedPlatform; + return kDiskAnnRuntimeUnsupportedPlatform; } #if defined(__linux__) || defined(__linux) // Fast path: already initialised. if (g_runtime_ready.load(std::memory_order_acquire)) { - return kDiskAnnPluginOk; + return kDiskAnnRuntimeOk; } std::lock_guard lock(g_runtime_mutex); if (g_runtime_ready.load(std::memory_order_relaxed)) { - return kDiskAnnPluginOk; + return kDiskAnnRuntimeOk; } // Eagerly load libaio at DiskAnn bring-up time so the user gets immediate @@ -104,20 +104,15 @@ int LoadDiskAnnPlugin(const std::string &path) { // the file reader will gracefully fall back to pread(). The user gets // a clear warning now rather than a hard failure later. g_runtime_ready.store(true, std::memory_order_release); - return kDiskAnnPluginLibAioMissing; + return kDiskAnnRuntimeLibAioMissing; } LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); g_runtime_ready.store(true, std::memory_order_release); - return kDiskAnnPluginOk; + return kDiskAnnRuntimeOk; #else - return kDiskAnnPluginUnsupportedPlatform; + return kDiskAnnRuntimeUnsupportedPlatform; #endif } -bool UnloadDiskAnnPlugin() { - // DiskAnn is statically linked — there is nothing to unload. - return false; -} - } // namespace zvec diff --git a/src/core/interface/indexes/diskann_index.cc b/src/core/interface/indexes/diskann_index.cc index 1ec54f265..36f0c20fb 100644 --- a/src/core/interface/indexes/diskann_index.cc +++ b/src/core/interface/indexes/diskann_index.cc @@ -23,7 +23,7 @@ namespace zvec::core_interface { int DiskAnnIndex::CreateAndInitStreamer(const BaseIndexParam ¶m) { // Platform and libaio checks are handled earlier at schema validation - // time (schema.cc calls LoadDiskAnnPlugin). If libaio is missing, DiskAnn + // time (schema.cc calls InitDiskAnnRuntime). If libaio is missing, DiskAnn // falls back to synchronous pread() in diskann_file_reader.cc — no need // to re-check here. if (is_sparse_) { diff --git a/src/core/plugin/CMakeLists.txt b/src/core/plugin/CMakeLists.txt deleted file mode 100644 index 808e35f57..000000000 --- a/src/core/plugin/CMakeLists.txt +++ /dev/null @@ -1,29 +0,0 @@ -## -## Copyright (C) The Software Authors. All rights reserved. -## -## \file CMakeLists.txt -## \brief Build script for the zvec internal DiskAnn runtime-init glue. -## Lives inside the main zvec_core artifact and provides the -## implicit DiskAnn runtime bring-up used by DiskAnnIndex on first -## use. These APIs are NOT part of the public user surface: users -## simply instantiate ``DiskAnnIndexParam`` / ``DiskAnnIndex`` and -## libaio is loaded behind the scenes via dlopen(). DiskAnn itself -## is compiled directly into the hosting binary. -## - -include(${PROJECT_ROOT_DIR}/cmake/bazel.cmake) -include(${PROJECT_ROOT_DIR}/cmake/option.cmake) - -set(CORE_PLUGIN_LIBS zvec_ailego core_framework) -if(CMAKE_SYSTEM_NAME STREQUAL "Linux") - list(APPEND CORE_PLUGIN_LIBS ${CMAKE_DL_LIBS}) -endif() - -cc_library( - NAME core_plugin - STATIC STRICT ALWAYS_LINK - SRCS *.cc - LIBS ${CORE_PLUGIN_LIBS} - INCS . ${PROJECT_ROOT_DIR}/src/core - VERSION "${PROXIMA_ZVEC_VERSION}" -) diff --git a/src/db/index/common/schema.cc b/src/db/index/common/schema.cc index bf5b02d38..4eb673a68 100644 --- a/src/db/index/common/schema.cc +++ b/src/db/index/common/schema.cc @@ -16,11 +16,11 @@ #include #include #include +#include #include #include #include #include -#include #include "ailego/internal/cpu_features.h" #include "db/common/constants.h" #include "db/common/typedef.h" @@ -180,14 +180,14 @@ Status FieldSchema::validate() const { // are creation-time only, so triggering the runtime init here is // safe (and idempotent/cached). // - // kDiskAnnPluginLibAioMissing is non-fatal: DiskAnn falls back to + // kDiskAnnRuntimeLibAioMissing is non-fatal: DiskAnn falls back to // synchronous pread() with degraded performance. - const int rc = ::zvec::LoadDiskAnnPlugin(); + const int rc = ::zvec::InitDiskAnnRuntime(); switch (rc) { - case kDiskAnnPluginOk: - case kDiskAnnPluginLibAioMissing: + case kDiskAnnRuntimeOk: + case kDiskAnnRuntimeLibAioMissing: break; - case kDiskAnnPluginUnsupportedPlatform: + case kDiskAnnRuntimeUnsupportedPlatform: return Status::NotSupported( "DiskAnn is not supported on this platform (Linux x86_64 " "only)"); diff --git a/src/include/zvec/plugin/diskann_plugin.h b/src/include/zvec/core/interface/diskann_runtime.h similarity index 61% rename from src/include/zvec/plugin/diskann_plugin.h rename to src/include/zvec/core/interface/diskann_runtime.h index ef1437692..657e12061 100644 --- a/src/include/zvec/plugin/diskann_plugin.h +++ b/src/include/zvec/core/interface/diskann_runtime.h @@ -18,67 +18,47 @@ // NOTE: The APIs declared in this header are INTERNAL to zvec. They are // invoked implicitly by ``DiskAnnIndex`` on first use so that DiskAnn works -// out of the box, without users ever calling a ``load_diskann_plugin()`` / +// out of the box, without users ever calling a ``init_diskann_runtime()`` / // ``is_libaio_available()`` entry point. External callers should not depend // on these symbols; they may change or be removed in future releases. // // DiskAnn is compiled directly into the hosting binary (_zvec.so for the // Python wheel, the test executable for gtest, or the tool binary for C++ -// tools). ``LoadDiskAnnPlugin`` no longer dlopens a separate .so — it simply +// tools). ``InitDiskAnnRuntime`` does not dlopen a separate .so — it simply // loads libaio eagerly via dlopen()/dlsym() and logs the result. On hosts // missing libaio, DiskAnn falls back to synchronous pread() (with a warning) // while other index types (HNSW / IVF / Flat / Vamana) keep working. -#if defined(_WIN32) || defined(__CYGWIN__) -#ifdef ZVEC_BUILD_SHARED -#define ZVEC_PLUGIN_EXPORT __declspec(dllexport) -#elif defined(ZVEC_USE_SHARED) -#define ZVEC_PLUGIN_EXPORT __declspec(dllimport) -#else -#define ZVEC_PLUGIN_EXPORT -#endif -#else -#if __GNUC__ >= 4 -#define ZVEC_PLUGIN_EXPORT __attribute__((visibility("default"))) -#else -#define ZVEC_PLUGIN_EXPORT -#endif -#endif - namespace zvec { -// Return codes for LoadDiskAnnPlugin(). -enum DiskAnnPluginStatus { - kDiskAnnPluginOk = 0, - kDiskAnnPluginUnsupportedPlatform = -1, - kDiskAnnPluginLibAioMissing = -2, - kDiskAnnPluginDlopenFailed = -3, +// Return codes for InitDiskAnnRuntime(). +enum DiskAnnRuntimeStatus { + kDiskAnnRuntimeOk = 0, + kDiskAnnRuntimeUnsupportedPlatform = -1, + kDiskAnnRuntimeLibAioMissing = -2, + kDiskAnnRuntimeDlopenFailed = -3, }; // Returns true if libaio is present on the host and the minimum set of symbols // required by the DiskAnn runtime (io_setup / io_submit / io_getevents / // io_destroy) can be resolved at runtime. // -// Internal probe used by ``LoadDiskAnnPlugin`` before attempting dlopen. Not +// Internal probe used by ``InitDiskAnnRuntime`` before attempting dlopen. Not // part of the user-facing API. -ZVEC_PLUGIN_EXPORT bool IsLibAioAvailable(); +bool IsLibAioAvailable(); // Load libaio at runtime via dlopen()/dlsym() and mark the DiskAnn runtime // as ready. DiskAnn code is compiled directly into the hosting binary, so // no separate .so is loaded. Invoked implicitly by // ``DiskAnnIndex::CreateAndInitStreamer`` on first use; callers should not // invoke it directly. The call is idempotent and returns -// ``kDiskAnnPluginOk`` when the runtime is already active. +// ``kDiskAnnRuntimeOk`` when the runtime is already active. // // The ``path`` parameter is retained for API compatibility but is ignored. -ZVEC_PLUGIN_EXPORT int LoadDiskAnnPlugin(const std::string &path = ""); +int InitDiskAnnRuntime(const std::string &path = ""); -// Returns true if the DiskAnn runtime is currently loaded in this process. +// Returns true if the DiskAnn runtime has been initialized in this process. // Internal diagnostic; not a user-facing API. -ZVEC_PLUGIN_EXPORT bool IsDiskAnnPluginLoaded(); - -// Unload the DiskAnn runtime. Since DiskAnn is statically linked, this is -// a no-op that always returns false. Retained for API compatibility. -ZVEC_PLUGIN_EXPORT bool UnloadDiskAnnPlugin(); +bool IsDiskAnnRuntimeReady(); } // namespace zvec diff --git a/tests/core/algorithm/diskann/CMakeLists.txt b/tests/core/algorithm/diskann/CMakeLists.txt index 2d919f270..e6ad1af12 100644 --- a/tests/core/algorithm/diskann/CMakeLists.txt +++ b/tests/core/algorithm/diskann/CMakeLists.txt @@ -7,7 +7,7 @@ foreach(CC_SRCS ${ALL_TEST_SRCS}) cc_gtest( NAME ${CC_TARGET} STRICT - LIBS zvec_ailego core_framework core_utility core_metric core_quantizer core_knn_cluster core_plugin core_knn_diskann + LIBS zvec_ailego core_framework core_utility core_metric core_quantizer core_knn_cluster core_knn_diskann SRCS ${CC_SRCS} INCS . ${PROJECT_ROOT_DIR}/src/core ${PROJECT_ROOT_DIR}/src/core/algorithm/diskann ) diff --git a/tests/core/algorithm/diskann/diskann_builder_test.cc b/tests/core/algorithm/diskann/diskann_builder_test.cc index 108123b79..62d40b474 100644 --- a/tests/core/algorithm/diskann/diskann_builder_test.cc +++ b/tests/core/algorithm/diskann/diskann_builder_test.cc @@ -144,8 +144,8 @@ TEST_F(DiskAnnBuilderTest, SmallDatasetBuildTime) { } // DiskAnn is now exposed implicitly: no caller ever invokes a -// ``LoadDiskAnnPlugin`` / ``IsLibAioAvailable`` API (those were removed from -// the public surface together with ``zvec.load_diskann_plugin()`` in Python). +// ``InitDiskAnnRuntime`` / ``IsLibAioAvailable`` API (those were removed from +// the public surface together with ``zvec.init_diskann_runtime()`` in Python). // The only contract this test validates is the UX guarantee: once the DiskAnn // module has been linked into the hosting binary (here, directly into the // test via the ``core_knn_diskann`` target), its factory entries are From 081aee33810be5849d360b1e846292d3e7b5facd Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 16:21:07 +0800 Subject: [PATCH 24/41] fix: add ci job to test libaio --- .github/workflows/01-ci-pipeline.yml | 8 ++ .github/workflows/09-diskann-libaio-test.yml | 109 +++++++++++++++++++ 2 files changed, 117 insertions(+) create mode 100644 .github/workflows/09-diskann-libaio-test.yml diff --git a/.github/workflows/01-ci-pipeline.yml b/.github/workflows/01-ci-pipeline.yml index ce9f8e2ef..b0c3c7e27 100644 --- a/.github/workflows/01-ci-pipeline.yml +++ b/.github/workflows/01-ci-pipeline.yml @@ -97,6 +97,14 @@ jobs: os: ubuntu-24.04 compiler: clang + # DiskAnn w/ libaio: explicitly install libaio and run tests to exercise + # the async I/O path. The existing CI (without libaio-dev) already covers + # the w/o libaio pread() fallback path. + diskann-libaio-test: + name: DiskAnn w/ libaio (linux-x64) + needs: [lint, clang-tidy] + uses: ./.github/workflows/09-diskann-libaio-test.yml + build-android: if: github.event_name != 'push' || github.ref != 'refs/heads/main' name: Build & Test (android) diff --git a/.github/workflows/09-diskann-libaio-test.yml b/.github/workflows/09-diskann-libaio-test.yml new file mode 100644 index 000000000..1024c9ffb --- /dev/null +++ b/.github/workflows/09-diskann-libaio-test.yml @@ -0,0 +1,109 @@ +name: DiskAnn libaio Test + +# Tests DiskAnn on Linux x86_64 with libaio explicitly installed, exercising +# the async I/O path (io_setup/io_submit/io_getevents). +# +# The existing CI (03-macos-linux-build.yml without libaio-dev installed) and +# non-Linux platform jobs already cover the "w/o libaio" fallback path — +# DiskAnn gracefully degrades to synchronous pread() when libaio is absent. +# This workflow complements that by ensuring the async I/O path is also +# exercised when libaio is present. + +on: + workflow_call: + workflow_dispatch: + +permissions: + contents: read + +jobs: + libaio-test: + name: DiskAnn w/ libaio (linux-x64) + runs-on: ubuntu-24.04 + + steps: + - name: Checkout code + uses: actions/checkout@v7 + with: + submodules: recursive + + - name: Install libaio runtime + run: | + sudo apt-get update -y + # libaio1t64 on Ubuntu 24.04+ (t64 transition), libaio1 on older + sudo apt-get install -y libaio1t64 || sudo apt-get install -y libaio1 + echo "=== libaio status (should be present) ===" + dpkg -l | grep -i libaio || true + ldconfig -p | grep libaio || true + shell: bash + + - name: Setup ccache + uses: hendrikmuhs/ccache-action@v1.2 + with: + key: linux-x64-libaio-test + max-size: 150M + + - name: Set up Python + uses: actions/setup-python@v6 + with: + python-version: '3.10' + cache: 'pip' + cache-dependency-path: 'pyproject.toml' + + - name: Set up environment variables + run: | + NPROC=$(nproc 2>/dev/null || echo 2) + echo "NPROC=$NPROC" >> $GITHUB_ENV + echo "$(python -c 'import site; print(site.USER_BASE)')/bin" >> $GITHUB_PATH + shell: bash + + - name: Install dependencies + run: | + python -m pip install --upgrade pip + python -m pip install \ + pybind11==3.0 \ + cmake==3.30.0 \ + ninja==1.11.1 \ + pytest \ + pytest-xdist \ + scikit-build-core \ + setuptools_scm + shell: bash + + - name: Build from source + run: | + cd "$GITHUB_WORKSPACE" + CMAKE_GENERATOR="Ninja" \ + CMAKE_BUILD_PARALLEL_LEVEL="$NPROC" \ + python -m pip install -v . \ + --no-build-isolation \ + --config-settings='cmake.define.BUILD_TOOLS=ON' \ + --config-settings='cmake.define.ENABLE_WERROR=ON' \ + --config-settings='cmake.define.CMAKE_C_COMPILER_LAUNCHER=ccache' \ + --config-settings='cmake.define.CMAKE_CXX_COMPILER_LAUNCHER=ccache' + shell: bash + + - name: Run C++ Tests (w/ libaio) + run: | + cd "$GITHUB_WORKSPACE/build" + cmake --build . --target unittest --parallel $NPROC + shell: bash + + - name: Verify no libaio in test binary + run: | + # Confirm the test binary does NOT have a NEEDED entry for libaio. + # This verifies the dlopen decoupling — libaio is loaded at runtime, + # not linked at build time. + TEST_BIN="$GITHUB_WORKSPACE/build/bin/diskann_searcher_test" + if [ -f "$TEST_BIN" ]; then + ldd "$TEST_BIN" | grep 'libaio' \ + && { echo "ERROR: test binary links libaio directly!"; exit 1; } \ + || echo "OK: test binary does not link libaio (dlopen-based)" + fi + shell: bash + + - name: Run Python Tests (w/ libaio) + run: | + cd "$GITHUB_WORKSPACE" + python -m pytest python/tests/ + shell: bash From ad071970d20c71674d1c50932c38880955c2d106 Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 16:24:28 +0800 Subject: [PATCH 25/41] fix: fix type --- src/core/algorithm/diskann/diskann_context.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/algorithm/diskann/diskann_context.cc b/src/core/algorithm/diskann/diskann_context.cc index 28969b8d8..b48785653 100644 --- a/src/core/algorithm/diskann/diskann_context.cc +++ b/src/core/algorithm/diskann/diskann_context.cc @@ -108,7 +108,7 @@ int DiskAnnContext::update_context(ContextType type, const IndexMeta &meta, const IndexMetric::Pointer &measure, const DiskAnnEntity::Pointer &entity, uint32_t magic_num) { - if (ailego_unlikely(type != type_)) { + if (ailego_unlikely(type != static_cast(type_))) { LOG_ERROR( "DiskAnnContext does not support shared by different type, " "src=%u dst=%u", From ce93b1696d34812d4f98a5f4c1ce8c1121dfb9fd Mon Sep 17 00:00:00 2001 From: ray Date: Fri, 3 Jul 2026 17:19:17 +0800 Subject: [PATCH 26/41] fix: fix array --- src/core/algorithm/diskann/diskann_holder.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_holder.h b/src/core/algorithm/diskann/diskann_holder.h index beb422ba2..8c2333a3e 100644 --- a/src/core/algorithm/diskann/diskann_holder.h +++ b/src/core/algorithm/diskann/diskann_holder.h @@ -25,7 +25,7 @@ struct DiskAnnIndexHolderMeta { uint32_t key_size_; uint32_t sector_size_; uint32_t doc_cnt_; - uint8_t reserve_[]; + uint8_t reserve_[4080]; //!< pad to kMetaSectorSize (4096) }; class DiskAnnIndexHolder : public IndexHolder { @@ -182,7 +182,7 @@ class DiskAnnIndexHolder : public IndexHolder { return IndexError_OpenFile; } - DiskAnnIndexHolderMeta holder_meta; + DiskAnnIndexHolderMeta holder_meta{}; holder_meta.element_size_ = element_size_; holder_meta.key_size_ = sizeof(diskann_key_t); holder_meta.sector_size_ = data_sector_size_; From ab8901a3d5a24ee3b305da1474727b292aece4ba Mon Sep 17 00:00:00 2001 From: ray Date: Mon, 6 Jul 2026 16:56:14 +0800 Subject: [PATCH 27/41] fix: fix on comment --- .github/workflows/nightly_coverage.yml | 2 +- pyproject.toml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/nightly_coverage.yml b/.github/workflows/nightly_coverage.yml index 4c9aca50b..16c3e46de 100644 --- a/.github/workflows/nightly_coverage.yml +++ b/.github/workflows/nightly_coverage.yml @@ -49,7 +49,7 @@ jobs: run: | sudo apt-get update sudo apt-get install -y --no-install-recommends \ - lcov + lcov libaio-dev shell: bash - name: Install dependencies diff --git a/pyproject.toml b/pyproject.toml index bce1670d5..6296b3402 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -181,7 +181,6 @@ test-command = "cd {project} && pytest python/tests -v --tb=short" build-verbosity = 1 [tool.cibuildwheel.linux] -# libaio is loaded at runtime via dlopen (no build-time dependency). archs = ["auto"] environment = { CMAKE_GENERATOR = "Unix Makefiles", CMAKE_BUILD_PARALLEL_LEVEL = "16" } manylinux-x86_64-image = "manylinux_2_28" From 63f5ff7e19d43e74a10df3e35e7babf5dfd2faec Mon Sep 17 00:00:00 2001 From: ray Date: Mon, 6 Jul 2026 17:32:35 +0800 Subject: [PATCH 28/41] fix: remove diskann runtime --- python/tests/detail/fixture_helper.py | 34 +---- python/tests/test_collection_diskann.py | 8 +- python/zvec/__init__.py | 23 ---- src/binding/python/binding.cc | 38 ------ src/core/algorithm/diskann/diskann_builder.cc | 15 +++ .../algorithm/diskann/diskann_searcher.cc | 15 +++ .../algorithm/diskann/diskann_streamer.cc | 16 +++ src/core/interface/diskann_runtime.cc | 118 ------------------ src/core/interface/indexes/diskann_index.cc | 4 - src/db/index/common/schema.cc | 30 ++--- .../zvec/core/interface/diskann_runtime.h | 64 ---------- .../algorithm/diskann/diskann_builder_test.cc | 12 -- 12 files changed, 61 insertions(+), 316 deletions(-) delete mode 100644 src/core/interface/diskann_runtime.cc delete mode 100644 src/include/zvec/core/interface/diskann_runtime.h diff --git a/python/tests/detail/fixture_helper.py b/python/tests/detail/fixture_helper.py index e37fc307a..f5e6c08e4 100644 --- a/python/tests/detail/fixture_helper.py +++ b/python/tests/detail/fixture_helper.py @@ -13,22 +13,14 @@ from zvec.typing import DataType, StatusCode, MetricType, QuantizeType import zvec - -# Cache the DiskAnn runtime preload status so we pay the init cost once per -# test session. The runtime normally auto-loads on first DiskAnn use, but we -# preload it explicitly here so a missing libaio surfaces as a clear pytest -# skip instead of a confusing "Create vector column indexer failed" deep -# inside the collection code path. -# Note: DiskAnn is now compiled directly into _zvec.so — there is no separate -# plugin .so to locate. If libaio is missing, DiskAnn falls back to -# synchronous pread() with degraded performance. _DISKANN_PRELOAD_REASON: str | None = None _DISKANN_PRELOAD_DONE: bool = False def _ensure_diskann_runtime_or_reason() -> str | None: - """Initialize the DiskAnn runtime and return None on success or a - human-readable skip reason on failure. Idempotent across calls.""" + """Check whether DiskAnn is available on this platform and return None + on success or a human-readable skip reason on failure. Idempotent across + calls.""" global _DISKANN_PRELOAD_DONE, _DISKANN_PRELOAD_REASON if _DISKANN_PRELOAD_DONE: return _DISKANN_PRELOAD_REASON @@ -38,23 +30,6 @@ def _ensure_diskann_runtime_or_reason() -> str | None: _DISKANN_PRELOAD_REASON = "DiskAnn only supported on Linux x86_64" return _DISKANN_PRELOAD_REASON - status = zvec.init_diskann_runtime() - if status == zvec.DISKANN_RUNTIME_UNSUPPORTED_PLATFORM: - _DISKANN_PRELOAD_REASON = ( - f"DiskAnn is not supported on this platform (status={status})." - ) - return _DISKANN_PRELOAD_REASON - # DISKANN_RUNTIME_OK and DISKANN_RUNTIME_LIBAIO_MISSING are both acceptable: - # the latter means DiskAnn will use synchronous pread() instead of async I/O. - if status not in ( - zvec.DISKANN_RUNTIME_OK, - zvec.DISKANN_RUNTIME_LIBAIO_MISSING, - ): - _DISKANN_PRELOAD_REASON = ( - f"Failed to initialize DiskAnn runtime (status={status})." - ) - return _DISKANN_PRELOAD_REASON - _DISKANN_PRELOAD_REASON = None return None @@ -152,8 +127,7 @@ def full_schema_new(request) -> CollectionSchema: else: nullable, has_index, vector_index = True, False, HnswIndexParam() - # Skip DiskAnn tests on unsupported platforms or when the runtime cannot - # be brought up (missing libaio, plugin .so not installed, etc.). + # Skip DiskAnn tests on unsupported platforms. from zvec.model.param import DiskAnnIndexParam if isinstance(vector_index, DiskAnnIndexParam): diff --git a/python/tests/test_collection_diskann.py b/python/tests/test_collection_diskann.py index e90751a04..8daf8c770 100644 --- a/python/tests/test_collection_diskann.py +++ b/python/tests/test_collection_diskann.py @@ -19,11 +19,9 @@ 1. DiskAnn is currently built only for Linux x86_64 — other platforms are skipped wholesale. -2. The DiskAnn runtime is initialized via ``zvec.init_diskann_runtime()``, - which eagerly loads libaio via dlopen(). If libaio is missing, DiskAnn - falls back to synchronous pread() — the tests still run but with degraded - performance. DiskAnn is compiled directly into ``_zvec.so``; there is no - separate plugin .so to locate. +2. libaio is loaded eagerly (via dlopen) inside DiskAnnBuilder::init() / + DiskAnnStreamer::init(). If libaio is missing, DiskAnn falls back to + synchronous pread() — the tests still run but with degraded performance. If either prerequisite fails the whole module is skipped so the rest of the test-suite is not affected. diff --git a/python/zvec/__init__.py b/python/zvec/__init__.py index cef509077..9e02c7575 100644 --- a/python/zvec/__init__.py +++ b/python/zvec/__init__.py @@ -43,21 +43,6 @@ # Public API — grouped by category # ============================== -# —— DiskAnn runtime —— -# Re-export the runtime management entry points defined by the C++ extension. -# DiskAnn normally auto-initializes on first use; these APIs let tests and -# diagnostic tools force initialization up-front and get a clear error if -# libaio is missing. -from zvec._zvec import ( - DISKANN_RUNTIME_DLOPEN_FAILED, - DISKANN_RUNTIME_LIBAIO_MISSING, - DISKANN_RUNTIME_OK, - DISKANN_RUNTIME_UNSUPPORTED_PLATFORM, - init_diskann_runtime, - is_diskann_runtime_ready, - is_libaio_available, -) - from . import model as model # —— Extensions —— @@ -203,14 +188,6 @@ "StatusCode", # Tools "require_module", - # DiskAnn runtime - "init_diskann_runtime", - "is_diskann_runtime_ready", - "is_libaio_available", - "DISKANN_RUNTIME_OK", - "DISKANN_RUNTIME_UNSUPPORTED_PLATFORM", - "DISKANN_RUNTIME_LIBAIO_MISSING", - "DISKANN_RUNTIME_DLOPEN_FAILED", ] # ============================== diff --git a/src/binding/python/binding.cc b/src/binding/python/binding.cc index 2d6332644..729a54d15 100644 --- a/src/binding/python/binding.cc +++ b/src/binding/python/binding.cc @@ -13,7 +13,6 @@ // limitations under the License. #include -#include #include "python_collection.h" #include "python_config.h" #include "python_doc.h" @@ -24,42 +23,6 @@ namespace zvec { -namespace { - -// Expose DiskAnn runtime management to Python. DiskAnn is compiled directly -// into _zvec.so, so "initializing" just means eagerly dlopen()-ing libaio and -// caching the result. Tests (and diagnostic tooling) use these entry points -// to force the init up-front and get actionable warnings when libaio is -// missing. -void InitializeDiskAnnRuntimeBindings(pybind11::module_ &m) { - m.def( - "init_diskann_runtime", - [](const std::string &path) { return ::zvec::InitDiskAnnRuntime(path); }, - pybind11::arg("path") = std::string(), - "Initialize the DiskAnn runtime by loading libaio via dlopen(). " - "Returns DISKANN_RUNTIME_OK (0) on success, or " - "DISKANN_RUNTIME_LIBAIO_MISSING if libaio is not available (DiskAnn " - "falls back to synchronous pread in that case). Returns a negative " - "code for unsupported platforms."); - m.def("is_diskann_runtime_ready", &::zvec::IsDiskAnnRuntimeReady, - "Return True if the DiskAnn runtime has been initialized."); - m.def("is_libaio_available", &::zvec::IsLibAioAvailable, - "Return True if libaio is resolvable on this host (required by the " - "DiskAnn runtime)."); - - // Status constants so callers can compare against well-known codes without - // hard-coding integers. - m.attr("DISKANN_RUNTIME_OK") = static_cast(::zvec::kDiskAnnRuntimeOk); - m.attr("DISKANN_RUNTIME_UNSUPPORTED_PLATFORM") = - static_cast(::zvec::kDiskAnnRuntimeUnsupportedPlatform); - m.attr("DISKANN_RUNTIME_LIBAIO_MISSING") = - static_cast(::zvec::kDiskAnnRuntimeLibAioMissing); - m.attr("DISKANN_RUNTIME_DLOPEN_FAILED") = - static_cast(::zvec::kDiskAnnRuntimeDlopenFailed); -} - -} // namespace - PYBIND11_MODULE(_zvec, m) { m.doc() = "Zvec core module"; @@ -70,6 +33,5 @@ PYBIND11_MODULE(_zvec, m) { ZVecPyConfig::Initialize(m); ZVecPyDoc::Initialize(m); ZVecPyCollection::Initialize(m); - InitializeDiskAnnRuntimeBindings(m); } } // namespace zvec diff --git a/src/core/algorithm/diskann/diskann_builder.cc b/src/core/algorithm/diskann/diskann_builder.cc index e344844f0..dd43fb29d 100644 --- a/src/core/algorithm/diskann/diskann_builder.cc +++ b/src/core/algorithm/diskann/diskann_builder.cc @@ -32,6 +32,21 @@ namespace core { int DiskAnnBuilder::init(const IndexMeta &meta, const ailego::Params ¶ms) { LOG_INFO("Begin DiskAnnBuilder::init"); +#if defined(__linux__) || defined(__linux) + // Eagerly load libaio at init time so the user gets immediate feedback + // about whether async I/O is available. LibAioLoader::Load() is idempotent + // and thread-safe. + if (!LibAioLoader::Instance().Load()) { + LOG_WARN( + "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " + "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " + "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " + "to synchronous pread() — performance will be degraded."); + } else { + LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); + } +#endif + params.get(PARAM_DISKANN_BUILDER_MAX_DEGREE, &max_degree_); params.get(PARAM_DISKANN_BUILDER_LIST_SIZE, &list_size_); params.get(PARAM_DISKANN_BUILDER_THREAD_COUNT, &build_thread_count_); diff --git a/src/core/algorithm/diskann/diskann_searcher.cc b/src/core/algorithm/diskann/diskann_searcher.cc index 905fdf2bd..c56d23b8f 100644 --- a/src/core/algorithm/diskann/diskann_searcher.cc +++ b/src/core/algorithm/diskann/diskann_searcher.cc @@ -25,6 +25,21 @@ DiskAnnSearcher::DiskAnnSearcher() {} DiskAnnSearcher::~DiskAnnSearcher() {} int DiskAnnSearcher::init(const ailego::Params &search_params) { +#if defined(__linux__) || defined(__linux) + // Eagerly load libaio at init time so the user gets immediate feedback + // about whether async I/O is available. LibAioLoader::Load() is idempotent + // and thread-safe. + if (!LibAioLoader::Instance().Load()) { + LOG_WARN( + "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " + "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " + "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " + "to synchronous pread() — performance will be degraded."); + } else { + LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); + } +#endif + search_params.get(PARAM_DISKANN_SEARCHER_LIST_SIZE, &list_size_); search_params.get(PARAM_DISKANN_SEARCHER_CACHE_NODE_NUM, &cache_nodes_num_); return 0; diff --git a/src/core/algorithm/diskann/diskann_streamer.cc b/src/core/algorithm/diskann/diskann_streamer.cc index 7a978b69e..37de6ec81 100644 --- a/src/core/algorithm/diskann/diskann_streamer.cc +++ b/src/core/algorithm/diskann/diskann_streamer.cc @@ -28,6 +28,22 @@ DiskAnnStreamer::~DiskAnnStreamer() {} int DiskAnnStreamer::init(const IndexMeta &meta, const ailego::Params &search_params) { meta_ = meta; + +#if defined(__linux__) || defined(__linux) + // Eagerly load libaio at init time so the user gets immediate feedback + // about whether async I/O is available. LibAioLoader::Load() is idempotent + // and thread-safe. + if (!LibAioLoader::Instance().Load()) { + LOG_WARN( + "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " + "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " + "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " + "to synchronous pread() — performance will be degraded."); + } else { + LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); + } +#endif + search_params.get(PARAM_DISKANN_SEARCHER_LIST_SIZE, &list_size_); search_params.get(PARAM_DISKANN_SEARCHER_CACHE_NODE_NUM, &cache_nodes_num_); return 0; diff --git a/src/core/interface/diskann_runtime.cc b/src/core/interface/diskann_runtime.cc deleted file mode 100644 index 9fef28690..000000000 --- a/src/core/interface/diskann_runtime.cc +++ /dev/null @@ -1,118 +0,0 @@ -// Copyright 2025-present the zvec project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -#include -#include -#include -#include -#include - -#if defined(__linux__) || defined(__linux) || defined(__APPLE__) -#include -#include -#endif - -#if defined(__linux__) || defined(__linux) -#include -#endif - -// Include the libaio dlopen wrapper so we can load libaio eagerly at DiskAnn -// bring-up time (instead of waiting for the first I/O operation). -#if defined(__linux__) || defined(__linux) -#include "algorithm/diskann/libaio_loader.h" -#endif - -namespace zvec { - -namespace { - -#if defined(__linux__) || defined(__linux) -constexpr bool kPlatformSupportsDiskAnn = true; -#elif defined(__APPLE__) -constexpr bool kPlatformSupportsDiskAnn = false; -#else -constexpr bool kPlatformSupportsDiskAnn = false; -#endif - -// Tracks whether the DiskAnn runtime has been initialised. Since DiskAnn is -// now compiled directly into the hosting binary (_zvec.so for Python, the test -// executable for gtest, etc.) there is no separate .so to dlopen; the "loaded" -// flag simply means libaio has been probed and the result cached. -std::atomic g_runtime_ready{false}; -std::mutex g_runtime_mutex; - -} // namespace - -bool IsLibAioAvailable() { -#if defined(__linux__) || defined(__linux) - // Use the LibAioLoader singleton so we share the cached dlopen handle with - // the DiskAnn file reader. Load() is idempotent and thread-safe. - return LibAioLoader::Instance().Load(); -#else - return false; -#endif -} - -bool IsDiskAnnRuntimeReady() { - return g_runtime_ready.load(std::memory_order_acquire); -} - -int InitDiskAnnRuntime(const std::string &path) { - (void)path; // No external path needed — DiskAnn is linked in statically. - - if (!kPlatformSupportsDiskAnn) { - LOG_ERROR( - "DiskAnn is not supported on this platform; it is only " - "available on Linux x86_64 with libaio."); - return kDiskAnnRuntimeUnsupportedPlatform; - } - -#if defined(__linux__) || defined(__linux) - // Fast path: already initialised. - if (g_runtime_ready.load(std::memory_order_acquire)) { - return kDiskAnnRuntimeOk; - } - - std::lock_guard lock(g_runtime_mutex); - if (g_runtime_ready.load(std::memory_order_relaxed)) { - return kDiskAnnRuntimeOk; - } - - // Eagerly load libaio at DiskAnn bring-up time so the user gets immediate - // feedback (success or failure) rather than a delayed error on the first - // async-I/O operation. - LOG_INFO("DiskAnn: initializing runtime — loading libaio ..."); - if (!LibAioLoader::Instance().Load()) { - LOG_WARN( - "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " - "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " - "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " - "to synchronous pread() — performance will be degraded. Other " - "index types (HNSW/IVF/Flat/Vamana) are unaffected."); - // We still mark the runtime as "ready" — DiskAnn code is linked in and - // the file reader will gracefully fall back to pread(). The user gets - // a clear warning now rather than a hard failure later. - g_runtime_ready.store(true, std::memory_order_release); - return kDiskAnnRuntimeLibAioMissing; - } - - LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); - g_runtime_ready.store(true, std::memory_order_release); - return kDiskAnnRuntimeOk; -#else - return kDiskAnnRuntimeUnsupportedPlatform; -#endif -} - -} // namespace zvec diff --git a/src/core/interface/indexes/diskann_index.cc b/src/core/interface/indexes/diskann_index.cc index 36f0c20fb..25274f727 100644 --- a/src/core/interface/indexes/diskann_index.cc +++ b/src/core/interface/indexes/diskann_index.cc @@ -22,10 +22,6 @@ namespace zvec::core_interface { int DiskAnnIndex::CreateAndInitStreamer(const BaseIndexParam ¶m) { - // Platform and libaio checks are handled earlier at schema validation - // time (schema.cc calls InitDiskAnnRuntime). If libaio is missing, DiskAnn - // falls back to synchronous pread() in diskann_file_reader.cc — no need - // to re-check here. if (is_sparse_) { LOG_ERROR("Failed to create streamer. Sparse is not Supported."); return core::IndexError_Unsupported; diff --git a/src/db/index/common/schema.cc b/src/db/index/common/schema.cc index 4eb673a68..b494f946e 100644 --- a/src/db/index/common/schema.cc +++ b/src/db/index/common/schema.cc @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include @@ -174,27 +173,14 @@ Status FieldSchema::validate() const { } if (index_params_->type() == IndexType::DISKANN) { - // Probe the DiskAnn runtime eagerly at creation time so unsupported - // platforms (non Linux x86_64) fail fast with a clear message instead - // of surfacing later during optimize(). All validate() call sites - // are creation-time only, so triggering the runtime init here is - // safe (and idempotent/cached). - // - // kDiskAnnRuntimeLibAioMissing is non-fatal: DiskAnn falls back to - // synchronous pread() with degraded performance. - const int rc = ::zvec::InitDiskAnnRuntime(); - switch (rc) { - case kDiskAnnRuntimeOk: - case kDiskAnnRuntimeLibAioMissing: - break; - case kDiskAnnRuntimeUnsupportedPlatform: - return Status::NotSupported( - "DiskAnn is not supported on this platform (Linux x86_64 " - "only)"); - default: - return Status::NotSupported( - "DiskAnn runtime could not be initialized on this host"); - } + // DiskAnn requires Linux x86_64. The libaio runtime is loaded + // eagerly (via dlopen) inside DiskAnnBuilder::init() and + // DiskAnnStreamer::init(); if libaio is missing, DiskAnn falls back + // to synchronous pread() with degraded performance. +#if !defined(__linux__) && !defined(__linux) + return Status::NotSupported( + "DiskAnn is not supported on this platform (Linux x86_64 only)"); +#endif } diff --git a/src/include/zvec/core/interface/diskann_runtime.h b/src/include/zvec/core/interface/diskann_runtime.h deleted file mode 100644 index 657e12061..000000000 --- a/src/include/zvec/core/interface/diskann_runtime.h +++ /dev/null @@ -1,64 +0,0 @@ -// Copyright 2025-present the zvec project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -#pragma once - -#include - -// NOTE: The APIs declared in this header are INTERNAL to zvec. They are -// invoked implicitly by ``DiskAnnIndex`` on first use so that DiskAnn works -// out of the box, without users ever calling a ``init_diskann_runtime()`` / -// ``is_libaio_available()`` entry point. External callers should not depend -// on these symbols; they may change or be removed in future releases. -// -// DiskAnn is compiled directly into the hosting binary (_zvec.so for the -// Python wheel, the test executable for gtest, or the tool binary for C++ -// tools). ``InitDiskAnnRuntime`` does not dlopen a separate .so — it simply -// loads libaio eagerly via dlopen()/dlsym() and logs the result. On hosts -// missing libaio, DiskAnn falls back to synchronous pread() (with a warning) -// while other index types (HNSW / IVF / Flat / Vamana) keep working. - -namespace zvec { - -// Return codes for InitDiskAnnRuntime(). -enum DiskAnnRuntimeStatus { - kDiskAnnRuntimeOk = 0, - kDiskAnnRuntimeUnsupportedPlatform = -1, - kDiskAnnRuntimeLibAioMissing = -2, - kDiskAnnRuntimeDlopenFailed = -3, -}; - -// Returns true if libaio is present on the host and the minimum set of symbols -// required by the DiskAnn runtime (io_setup / io_submit / io_getevents / -// io_destroy) can be resolved at runtime. -// -// Internal probe used by ``InitDiskAnnRuntime`` before attempting dlopen. Not -// part of the user-facing API. -bool IsLibAioAvailable(); - -// Load libaio at runtime via dlopen()/dlsym() and mark the DiskAnn runtime -// as ready. DiskAnn code is compiled directly into the hosting binary, so -// no separate .so is loaded. Invoked implicitly by -// ``DiskAnnIndex::CreateAndInitStreamer`` on first use; callers should not -// invoke it directly. The call is idempotent and returns -// ``kDiskAnnRuntimeOk`` when the runtime is already active. -// -// The ``path`` parameter is retained for API compatibility but is ignored. -int InitDiskAnnRuntime(const std::string &path = ""); - -// Returns true if the DiskAnn runtime has been initialized in this process. -// Internal diagnostic; not a user-facing API. -bool IsDiskAnnRuntimeReady(); - -} // namespace zvec diff --git a/tests/core/algorithm/diskann/diskann_builder_test.cc b/tests/core/algorithm/diskann/diskann_builder_test.cc index 62d40b474..752759e9d 100644 --- a/tests/core/algorithm/diskann/diskann_builder_test.cc +++ b/tests/core/algorithm/diskann/diskann_builder_test.cc @@ -143,18 +143,6 @@ TEST_F(DiskAnnBuilderTest, SmallDatasetBuildTime) { << " ms — likely a lost-wakeup regression in progress loops."; } -// DiskAnn is now exposed implicitly: no caller ever invokes a -// ``InitDiskAnnRuntime`` / ``IsLibAioAvailable`` API (those were removed from -// the public surface together with ``zvec.init_diskann_runtime()`` in Python). -// The only contract this test validates is the UX guarantee: once the DiskAnn -// module has been linked into the hosting binary (here, directly into the -// test via the ``core_knn_diskann`` target), its factory entries are -// registered automatically and the global ``IndexFactory`` can hand out a -// ``DiskAnnBuilder`` without any explicit setup step. On hosts missing -// libaio, DiskAnn falls back to synchronous pread() with a warning while -// other index types (HNSW/IVF/Flat/Vamana) remain unaffected; that runtime -// branch lives in ``DiskAnnIndex::CreateAndInitStreamer`` and is covered by -// the higher-level interface tests. TEST_F(DiskAnnBuilderTest, TestImplicitFactoryRegistration) { IndexBuilder::Pointer builder = IndexFactory::CreateBuilder("DiskAnnBuilder"); ASSERT_NE(builder, nullptr) From 0bb0a61d8c09e3939b759836b1d49a316844b750 Mon Sep 17 00:00:00 2001 From: ray Date: Mon, 6 Jul 2026 18:56:09 +0800 Subject: [PATCH 29/41] fix: fix read --- .../algorithm/diskann/diskann_file_reader.cc | 49 ++++++++++--------- .../algorithm/diskann/diskann_file_reader.h | 1 - 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index ff07faa95..b7b888adc 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -525,20 +525,25 @@ void WindowsAlignedFileReader::deregister_thread() { LOG_ERROR("deregister_thread: thread not registered"); return; } + destroy_io_ctx(it->second); ctx_map.erase(it); } void WindowsAlignedFileReader::deregister_all_threads() { std::unique_lock lk(ctx_mut); + for (auto &kv : ctx_map) { + destroy_io_ctx(kv.second); + } ctx_map.clear(); } void WindowsAlignedFileReader::open(const std::string &fname) { - file_handle_ = CreateFileA(fname.c_str(), GENERIC_READ, FILE_SHARE_READ, NULL, - OPEN_EXISTING, - FILE_ATTRIBUTE_READONLY | FILE_FLAG_NO_BUFFERING | - FILE_FLAG_OVERLAPPED | FILE_FLAG_RANDOM_ACCESS, - NULL); + file_handle_ = + CreateFileA(fname.c_str(), GENERIC_READ, + FILE_SHARE_READ | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, + FILE_ATTRIBUTE_READONLY | FILE_FLAG_NO_BUFFERING | + FILE_FLAG_OVERLAPPED | FILE_FLAG_RANDOM_ACCESS, + NULL); if (file_handle_ == INVALID_HANDLE_VALUE) { DWORD error = GetLastError(); @@ -546,16 +551,6 @@ void WindowsAlignedFileReader::open(const std::string &fname) { return; } - // Create an I/O Completion Port and associate the file handle with it. - iocp_ = CreateIoCompletionPort(file_handle_, NULL, 0, 0); - if (iocp_ == NULL) { - DWORD error = GetLastError(); - LOG_ERROR("CreateIoCompletionPort failed (error=%lu)", error); - CloseHandle(file_handle_); - file_handle_ = INVALID_HANDLE_VALUE; - return; - } - LOG_INFO("Opened file: %s", fname.c_str()); } @@ -564,10 +559,6 @@ void WindowsAlignedFileReader::close() { CloseHandle(file_handle_); file_handle_ = INVALID_HANDLE_VALUE; } - if (iocp_ != NULL) { - CloseHandle(iocp_); - iocp_ = NULL; - } } int WindowsAlignedFileReader::read(std::vector &read_reqs, @@ -616,6 +607,8 @@ int WindowsAlignedFileReader::read(std::vector &read_reqs, std::min((uint64_t)(n_reqs - batch_start), (uint64_t)MAX_IO_DEPTH); // Issue ReadFile calls for this batch. + bool batch_error = false; + uint64_t issued_count = 0; for (uint64_t j = 0; j < batch_size; j++) { AlignedRead &req = read_reqs[batch_start + j]; OVERLAPPED &os = ctx.reqs[j]; @@ -638,17 +631,23 @@ int WindowsAlignedFileReader::read(std::vector &read_reqs, DWORD error = GetLastError(); if (error != ERROR_IO_PENDING) { LOG_ERROR("Error queuing IO -- error=%lu", error); - return IndexError_Runtime; + batch_error = true; + break; } } + issued_count++; } - // Wait for all batch reads to complete. + // Wait for all issued reads to complete. // Use GetOverlappedResult per-read instead of GetQueuedCompletionStatus // on the shared IOCP. The shared IOCP causes completion-packet stealing // when multiple threads call read() concurrently, leading to data // corruption and segfaults. - for (uint64_t j = 0; j < batch_size; j++) { + // + // We must wait for ALL reads that were successfully issued, even if an + // error occurred mid-batch. Otherwise the caller may free the read + // buffers while the OS still has pending writes, causing a use-after-free. + for (uint64_t j = 0; j < issued_count; j++) { OVERLAPPED &os = ctx.reqs[j]; DWORD bytes_transferred = 0; @@ -658,9 +657,13 @@ int WindowsAlignedFileReader::read(std::vector &read_reqs, DWORD error = GetLastError(); LOG_ERROR("GetOverlappedResult failed for read %lu, error=%lu", (unsigned long)j, error); - return IndexError_Runtime; + batch_error = true; } } + + if (batch_error) { + return IndexError_Runtime; + } } return 0; diff --git a/src/core/algorithm/diskann/diskann_file_reader.h b/src/core/algorithm/diskann/diskann_file_reader.h index 1c0a65e82..f57a6f889 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.h +++ b/src/core/algorithm/diskann/diskann_file_reader.h @@ -138,7 +138,6 @@ class LinuxAlignedFileReader : public AlignedFileReader { class WindowsAlignedFileReader : public AlignedFileReader { private: HANDLE file_handle_ = INVALID_HANDLE_VALUE; - HANDLE iocp_ = NULL; public: WindowsAlignedFileReader(); From 5ffc23a1d7261ac9223273fb2bc24767db336646 Mon Sep 17 00:00:00 2001 From: ray Date: Tue, 7 Jul 2026 15:02:42 +0800 Subject: [PATCH 30/41] refactor: move libaio loader to ailego --- .../algorithm/diskann/diskann_file_reader.h | 2 +- src/core/algorithm/diskann/libaio_def.h | 190 ------------------ src/core/algorithm/diskann/libaio_loader.h | 144 ------------- 3 files changed, 1 insertion(+), 335 deletions(-) delete mode 100644 src/core/algorithm/diskann/libaio_def.h delete mode 100644 src/core/algorithm/diskann/libaio_loader.h diff --git a/src/core/algorithm/diskann/diskann_file_reader.h b/src/core/algorithm/diskann/diskann_file_reader.h index 2abe8c1aa..a81ee401a 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.h +++ b/src/core/algorithm/diskann/diskann_file_reader.h @@ -18,7 +18,7 @@ #include #if (defined(__linux) || defined(__linux__)) -#include "libaio_loader.h" // dlopen-based libaio wrapper +#include // dlopen-based libaio wrapper #endif #include diff --git a/src/core/algorithm/diskann/libaio_def.h b/src/core/algorithm/diskann/libaio_def.h deleted file mode 100644 index ce95bc982..000000000 --- a/src/core/algorithm/diskann/libaio_def.h +++ /dev/null @@ -1,190 +0,0 @@ -// Copyright 2025-present the zvec project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -// Private replacement for . -// -// This header declares *only* the types, constants, and inline helpers that -// zvec needs from libaio. By doing so the project is completely decoupled -// from the system libaio-dev header: there is no `#include ` anywhere -// in the source tree, which means libaio-dev does not need to be installed at -// build time and the code is portable to cross-compilation environments that -// lack the header. -// -// The struct layouts (struct iocb, struct io_event, ...) are part of the Linux -// kernel ABI. They are copied verbatim from the upstream , including -// the PADDED macros that handle architecture-specific padding. The inline -// helper io_prep_pread() is likewise copied — it only manipulates struct fields -// and does not call into the library. - -#pragma once - -#include // struct timespec (used by io_getevents signature) -#include // memset() — used by io_prep_pread() inline helper - -#if defined(__linux) || defined(__linux__) - -struct sockaddr; -struct iovec; - -// --------------------------------------------------------------------------- -// Type and struct definitions copied from -// --------------------------------------------------------------------------- - -typedef struct io_context *io_context_t; - -typedef enum io_iocb_cmd { - IO_CMD_PREAD = 0, - IO_CMD_PWRITE = 1, - IO_CMD_FSYNC = 2, - IO_CMD_FDSYNC = 3, - IO_CMD_POLL = 5, - IO_CMD_NOOP = 6, - IO_CMD_PREADV = 7, - IO_CMD_PWRITEV = 8, -} io_iocb_cmd_t; - -// PADDED macros — copied verbatim from to guarantee ABI-compatible -// struct layout on every supported architecture. - -/* little endian, 32 bits */ -#if defined(__i386__) || (defined(__x86_64__) && defined(__ILP32__)) || \ - (defined(__arm__) && !defined(__ARMEB__)) || \ - (defined(__sh__) && defined(__LITTLE_ENDIAN__)) || defined(__bfin__) || \ - (defined(__MIPSEL__) && !defined(__mips64)) || defined(__cris__) || \ - defined(__loongarch32) || (defined(__riscv) && __riscv_xlen == 32) || \ - (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ - __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ && __SIZEOF_LONG__ == 4) -#define AIO_PADDED(x, y) \ - x; \ - unsigned y -#define AIO_PADDEDptr(x, y) \ - x; \ - unsigned y -#define AIO_PADDEDul(x, y) \ - unsigned long x; \ - unsigned y - -/* little endian, 64 bits */ -#elif defined(__ia64__) || defined(__x86_64__) || defined(__alpha__) || \ - (defined(__mips64) && defined(__MIPSEL__)) || \ - (defined(__aarch64__) && defined(__AARCH64EL__)) || \ - defined(__loongarch64) || (defined(__riscv) && __riscv_xlen == 64) || \ - (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ - __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ && __SIZEOF_LONG__ == 8) -#define AIO_PADDED(x, y) x, y -#define AIO_PADDEDptr(x, y) x -#define AIO_PADDEDul(x, y) unsigned long x - -/* big endian, 64 bits */ -#elif defined(__powerpc64__) || defined(__s390x__) || \ - (defined(__hppa__) && defined(__arch64__)) || \ - (defined(__sparc__) && defined(__arch64__)) || \ - (defined(__mips64) && defined(__MIPSEB__)) || \ - (defined(__aarch64__) && defined(__AARCH64EB__)) || \ - (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ - __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ && __SIZEOF_LONG__ == 8) -#define AIO_PADDED(x, y) \ - unsigned y; \ - x -#define AIO_PADDEDptr(x, y) x -#define AIO_PADDEDul(x, y) unsigned long x - -/* big endian, 32 bits */ -#elif defined(__PPC__) || defined(__s390__) || \ - (defined(__arm__) && defined(__ARMEB__)) || \ - (defined(__sh__) && defined(__BIG_ENDIAN__)) || defined(__sparc__) || \ - defined(__MIPSEB__) || defined(__m68k__) || defined(__hppa__) || \ - defined(__frv__) || defined(__avr32__) || \ - (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ - __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ && __SIZEOF_LONG__ == 4) -#define AIO_PADDED(x, y) \ - unsigned y; \ - x -#define AIO_PADDEDptr(x, y) \ - unsigned y; \ - x -#define AIO_PADDEDul(x, y) \ - unsigned y; \ - unsigned long x - -#else -#error endianness? -#endif - -struct io_iocb_poll { - AIO_PADDED(int events, __pad1); -}; - -struct io_iocb_sockaddr { - AIO_PADDEDptr(struct sockaddr *addr, __pad1); - AIO_PADDEDul(len, __pad2); -}; - -struct io_iocb_common { - AIO_PADDEDptr(void *buf, __pad1); - AIO_PADDEDul(nbytes, __pad2); - long long offset; - long long __pad3; - unsigned flags; - unsigned resfd; -}; - -struct io_iocb_vector { - AIO_PADDEDptr(const struct iovec *vec, __pad1); - AIO_PADDEDul(nr, __pad2); - long long offset; -}; - -struct iocb { - AIO_PADDEDptr(void *data, __pad1); - AIO_PADDED(unsigned key, aio_rw_flags); - short aio_lio_opcode; - short aio_reqprio; - int aio_fildes; - union { - struct io_iocb_common c; - struct io_iocb_vector v; - struct io_iocb_poll poll; - struct io_iocb_sockaddr saddr; - } u; -}; - -struct io_event { - AIO_PADDEDptr(void *data, __pad1); - AIO_PADDEDptr(struct iocb *obj, __pad2); - AIO_PADDEDul(res, __pad3); - AIO_PADDEDul(res2, __pad4); -}; - -#undef AIO_PADDED -#undef AIO_PADDEDptr -#undef AIO_PADDEDul - -// Inline helper — copied from . Only manipulates struct fields. -static inline void io_prep_pread(struct iocb *iocb, int fd, void *buf, - size_t count, long long offset) { - memset(iocb, 0, sizeof(*iocb)); - iocb->aio_fildes = fd; - iocb->aio_lio_opcode = IO_CMD_PREAD; - iocb->aio_reqprio = 0; - iocb->u.c.buf = buf; - iocb->u.c.nbytes = count; - iocb->u.c.offset = offset; -} - -// --------------------------------------------------------------------------- -// End: type and struct definitions from -// --------------------------------------------------------------------------- - -#endif // __linux__ diff --git a/src/core/algorithm/diskann/libaio_loader.h b/src/core/algorithm/diskann/libaio_loader.h deleted file mode 100644 index dca400ff9..000000000 --- a/src/core/algorithm/diskann/libaio_loader.h +++ /dev/null @@ -1,144 +0,0 @@ -// Copyright 2025-present the zvec project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -// dlopen-based wrapper for libaio. Instead of linking against -laio at build -// time, the DiskAnn plugin loads libaio at runtime via dlopen()/dlsym(). This -// removes libaio as a hard build- and load-time dependency: the plugin .so no -// longer carries a NEEDED entry for libaio.so.1, so it can be dlopen'ed on -// hosts that don't have libaio installed. Callers that actually exercise the -// async-I/O path will fall back to synchronous pread() when libaio is absent. -// -// All ABI-stable type and struct definitions (struct iocb, struct io_event, -// io_context_t, PADDED macros, io_prep_pread(), ...) now live in libaio_def.h — -// a private header that replaces so the project has zero build-time -// dependency on libaio-dev. - -#pragma once - -#if defined(__linux) || defined(__linux__) - -#include -#include -#include -#include -#include "libaio_def.h" // ABI-stable struct definitions (replaces ) - -// Function-pointer typedefs for the four libaio syscalls used by DiskAnn. -typedef int (*aio_setup_fn)(int maxevents, io_context_t *ctxp); -typedef int (*aio_destroy_fn)(io_context_t ctx); -typedef int (*aio_submit_fn)(io_context_t ctx, long nr, struct iocb *ios[]); -typedef int (*aio_getevents_fn)(io_context_t ctx, long min_nr, long nr, - struct io_event *events, - struct timespec *timeout); - -// Runtime loader for libaio. Thread-safe singleton that dlopen()'s libaio -// once and caches the function pointers. If libaio is not present on the -// host, all pointers remain nullptr and callers should fall back to -// synchronous I/O (pread). -// -// Usage: -// if (LibAioLoader::Instance().Load()) { -// LibAioLoader::Instance().io_setup(...); -// } -class LibAioLoader { - public: - static LibAioLoader &Instance() { - static LibAioLoader instance; - return instance; - } - - // Load (or confirm already loaded) libaio. Returns true on success. - // Thread-safe and idempotent. - bool Load() { - if (available_.load(std::memory_order_acquire)) { - return true; - } - std::call_once(once_, [this] { this->TryLoad(); }); - return available_.load(std::memory_order_relaxed); - } - - bool IsAvailable() const { - return available_.load(std::memory_order_acquire); - } - - // Function pointers — nullptr until Load() succeeds. - aio_setup_fn io_setup; - aio_destroy_fn io_destroy; - aio_submit_fn io_submit; - aio_getevents_fn io_getevents; - - private: - LibAioLoader() - : io_setup(nullptr), - io_destroy(nullptr), - io_submit(nullptr), - io_getevents(nullptr) {} - - ~LibAioLoader() { - if (handle_ != nullptr) { - dlclose(handle_); - } - } - - LibAioLoader(const LibAioLoader &) = delete; - LibAioLoader &operator=(const LibAioLoader &) = delete; - - void TryLoad() { - // On Ubuntu 24.04 the libaio package was renamed with the t64 suffix - // (64-bit time_t transition), so probe both spellings. - static constexpr const char *kSonames[] = { - "libaio.so.1", - "libaio.so.1t64", - }; - - for (const char *soname : kSonames) { - void *h = dlopen(soname, RTLD_LAZY); - if (h == nullptr) { - continue; - } - - io_setup = reinterpret_cast(dlsym(h, "io_setup")); - io_destroy = reinterpret_cast(dlsym(h, "io_destroy")); - io_submit = reinterpret_cast(dlsym(h, "io_submit")); - - // io_getevents may be redirected to io_getevents_time64 on 32-bit - // platforms compiled with _TIME_BITS=64. - io_getevents = - reinterpret_cast(dlsym(h, "io_getevents")); - if (io_getevents == nullptr) { - io_getevents = - reinterpret_cast(dlsym(h, "io_getevents_time64")); - } - - if (io_setup && io_destroy && io_submit && io_getevents) { - handle_ = h; - available_.store(true, std::memory_order_release); - return; - } - - // Some symbols missing — try the next soname. - dlclose(h); - io_setup = nullptr; - io_destroy = nullptr; - io_submit = nullptr; - io_getevents = nullptr; - } - } - - std::once_flag once_; - std::atomic available_{false}; - void *handle_{nullptr}; -}; - -#endif // __linux__ From 1c7ff606c286b038578069a1d21e15c65cb2f2b4 Mon Sep 17 00:00:00 2001 From: ray Date: Tue, 7 Jul 2026 16:29:12 +0800 Subject: [PATCH 31/41] fix: add io backend --- python/zvec/__init__.py | 2 + src/ailego/io/io_backend.h | 114 +++++++++++ src/ailego/io/libaio_def.h | 190 ++++++++++++++++++ src/ailego/io/libaio_loader.h | 144 +++++++++++++ .../python/model/common/python_config.cc | 21 ++ src/core/algorithm/diskann/diskann_builder.cc | 21 +- .../algorithm/diskann/diskann_file_reader.cc | 41 ++-- .../algorithm/diskann/diskann_searcher.cc | 21 +- .../algorithm/diskann/diskann_streamer.cc | 21 +- src/core/interface/indexes/diskann_index.cc | 13 ++ src/include/zvec/core/interface/index.h | 5 + 11 files changed, 548 insertions(+), 45 deletions(-) create mode 100644 src/ailego/io/io_backend.h create mode 100644 src/ailego/io/libaio_def.h create mode 100644 src/ailego/io/libaio_loader.h diff --git a/python/zvec/__init__.py b/python/zvec/__init__.py index 9e02c7575..d11cfea69 100644 --- a/python/zvec/__init__.py +++ b/python/zvec/__init__.py @@ -30,6 +30,7 @@ from zvec._zvec import ( get_default_jieba_dict_dir, + io_backend_type, set_default_jieba_dict_dir, ) @@ -127,6 +128,7 @@ "open", "set_default_jieba_dict_dir", "get_default_jieba_dict_dir", + "io_backend_type", # Core classes "Collection", "Doc", diff --git a/src/ailego/io/io_backend.h b/src/ailego/io/io_backend.h new file mode 100644 index 000000000..647fb653c --- /dev/null +++ b/src/ailego/io/io_backend.h @@ -0,0 +1,114 @@ +// Copyright 2025-present the zvec project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Abstract I/O backend selector. +// +// Wraps the low-level loaders (LibAioLoader for libaio) and provides a uniform +// way to initialize, query, and report the active I/O backend. The actual I/O +// operations are still performed by the underlying loaders; this class is +// responsible only for backend initialization and reporting. +// +// When no async backend is available, the caller should fall back to +// synchronous pread(). +// +// Usage: +// auto& backend = ailego::IOBackend::Instance(); +// if (backend.available() != ailego::IOBackendType::kSyncPread) { ... } +// LOG_INFO("I/O backend: %s", backend.name()); + +#pragma once + +#include + +namespace zvec { +namespace ailego { + +// Supported I/O backend types. +enum class IOBackendType { + kSyncPread, // Synchronous pread() — no async I/O + kLibAio, // libaio loaded at runtime via dlopen() +}; + +// Returns a human-readable name for the given backend type. +inline const char *IOBackendTypeName(IOBackendType type) { + switch (type) { + case IOBackendType::kLibAio: + return "libaio"; + case IOBackendType::kSyncPread: + return "sync_pread"; + } + return "unknown"; +} + +// Singleton that loads and queries an I/O backend on demand. +// +// available() (no arg) tries the best backend with priority (libaio > pread) +// and returns the loaded backend type. +// available(IOBackendType) tries a specific backend. +// Use type() / name() to query the loaded backend without triggering a load. +class IOBackend { + public: + static IOBackend &Instance() { + static IOBackend instance; + return instance; + } + + // Try to load the best available backend (libaio > sync_pread). + // Returns the loaded backend type. + // Idempotent — if already loaded, returns immediately. + IOBackendType available() { + if (type_ != IOBackendType::kSyncPread) { + return type_; + } + return available(IOBackendType::kLibAio); + } + + // Try to load the requested backend. Returns the loaded backend type + // (may differ from requested if the load failed — falls back to kSyncPread). + // Idempotent — if the same backend is already loaded, returns immediately. + IOBackendType available(IOBackendType requested) { + if (type_ == requested && type_ != IOBackendType::kSyncPread) { + return type_; + } +#if defined(__linux) || defined(__linux__) + if (requested == IOBackendType::kLibAio) { + if (LibAioLoader::Instance().load() && + LibAioLoader::Instance().is_available()) { + type_ = IOBackendType::kLibAio; + return type_; + } + } +#endif + type_ = IOBackendType::kSyncPread; + return type_; + } + + // Returns the loaded backend type. + IOBackendType type() const { + return type_; + } + + // Human-readable name for the selected backend. + const char *name() const { + return IOBackendTypeName(type_); + } + + private: + IOBackend() = default; + + IOBackendType type_{IOBackendType::kSyncPread}; +}; + +} // namespace ailego +} // namespace zvec diff --git a/src/ailego/io/libaio_def.h b/src/ailego/io/libaio_def.h new file mode 100644 index 000000000..ce95bc982 --- /dev/null +++ b/src/ailego/io/libaio_def.h @@ -0,0 +1,190 @@ +// Copyright 2025-present the zvec project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Private replacement for . +// +// This header declares *only* the types, constants, and inline helpers that +// zvec needs from libaio. By doing so the project is completely decoupled +// from the system libaio-dev header: there is no `#include ` anywhere +// in the source tree, which means libaio-dev does not need to be installed at +// build time and the code is portable to cross-compilation environments that +// lack the header. +// +// The struct layouts (struct iocb, struct io_event, ...) are part of the Linux +// kernel ABI. They are copied verbatim from the upstream , including +// the PADDED macros that handle architecture-specific padding. The inline +// helper io_prep_pread() is likewise copied — it only manipulates struct fields +// and does not call into the library. + +#pragma once + +#include // struct timespec (used by io_getevents signature) +#include // memset() — used by io_prep_pread() inline helper + +#if defined(__linux) || defined(__linux__) + +struct sockaddr; +struct iovec; + +// --------------------------------------------------------------------------- +// Type and struct definitions copied from +// --------------------------------------------------------------------------- + +typedef struct io_context *io_context_t; + +typedef enum io_iocb_cmd { + IO_CMD_PREAD = 0, + IO_CMD_PWRITE = 1, + IO_CMD_FSYNC = 2, + IO_CMD_FDSYNC = 3, + IO_CMD_POLL = 5, + IO_CMD_NOOP = 6, + IO_CMD_PREADV = 7, + IO_CMD_PWRITEV = 8, +} io_iocb_cmd_t; + +// PADDED macros — copied verbatim from to guarantee ABI-compatible +// struct layout on every supported architecture. + +/* little endian, 32 bits */ +#if defined(__i386__) || (defined(__x86_64__) && defined(__ILP32__)) || \ + (defined(__arm__) && !defined(__ARMEB__)) || \ + (defined(__sh__) && defined(__LITTLE_ENDIAN__)) || defined(__bfin__) || \ + (defined(__MIPSEL__) && !defined(__mips64)) || defined(__cris__) || \ + defined(__loongarch32) || (defined(__riscv) && __riscv_xlen == 32) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ && __SIZEOF_LONG__ == 4) +#define AIO_PADDED(x, y) \ + x; \ + unsigned y +#define AIO_PADDEDptr(x, y) \ + x; \ + unsigned y +#define AIO_PADDEDul(x, y) \ + unsigned long x; \ + unsigned y + +/* little endian, 64 bits */ +#elif defined(__ia64__) || defined(__x86_64__) || defined(__alpha__) || \ + (defined(__mips64) && defined(__MIPSEL__)) || \ + (defined(__aarch64__) && defined(__AARCH64EL__)) || \ + defined(__loongarch64) || (defined(__riscv) && __riscv_xlen == 64) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ && __SIZEOF_LONG__ == 8) +#define AIO_PADDED(x, y) x, y +#define AIO_PADDEDptr(x, y) x +#define AIO_PADDEDul(x, y) unsigned long x + +/* big endian, 64 bits */ +#elif defined(__powerpc64__) || defined(__s390x__) || \ + (defined(__hppa__) && defined(__arch64__)) || \ + (defined(__sparc__) && defined(__arch64__)) || \ + (defined(__mips64) && defined(__MIPSEB__)) || \ + (defined(__aarch64__) && defined(__AARCH64EB__)) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ && __SIZEOF_LONG__ == 8) +#define AIO_PADDED(x, y) \ + unsigned y; \ + x +#define AIO_PADDEDptr(x, y) x +#define AIO_PADDEDul(x, y) unsigned long x + +/* big endian, 32 bits */ +#elif defined(__PPC__) || defined(__s390__) || \ + (defined(__arm__) && defined(__ARMEB__)) || \ + (defined(__sh__) && defined(__BIG_ENDIAN__)) || defined(__sparc__) || \ + defined(__MIPSEB__) || defined(__m68k__) || defined(__hppa__) || \ + defined(__frv__) || defined(__avr32__) || \ + (defined(__GNUC__) && defined(__BYTE_ORDER__) && \ + __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ && __SIZEOF_LONG__ == 4) +#define AIO_PADDED(x, y) \ + unsigned y; \ + x +#define AIO_PADDEDptr(x, y) \ + unsigned y; \ + x +#define AIO_PADDEDul(x, y) \ + unsigned y; \ + unsigned long x + +#else +#error endianness? +#endif + +struct io_iocb_poll { + AIO_PADDED(int events, __pad1); +}; + +struct io_iocb_sockaddr { + AIO_PADDEDptr(struct sockaddr *addr, __pad1); + AIO_PADDEDul(len, __pad2); +}; + +struct io_iocb_common { + AIO_PADDEDptr(void *buf, __pad1); + AIO_PADDEDul(nbytes, __pad2); + long long offset; + long long __pad3; + unsigned flags; + unsigned resfd; +}; + +struct io_iocb_vector { + AIO_PADDEDptr(const struct iovec *vec, __pad1); + AIO_PADDEDul(nr, __pad2); + long long offset; +}; + +struct iocb { + AIO_PADDEDptr(void *data, __pad1); + AIO_PADDED(unsigned key, aio_rw_flags); + short aio_lio_opcode; + short aio_reqprio; + int aio_fildes; + union { + struct io_iocb_common c; + struct io_iocb_vector v; + struct io_iocb_poll poll; + struct io_iocb_sockaddr saddr; + } u; +}; + +struct io_event { + AIO_PADDEDptr(void *data, __pad1); + AIO_PADDEDptr(struct iocb *obj, __pad2); + AIO_PADDEDul(res, __pad3); + AIO_PADDEDul(res2, __pad4); +}; + +#undef AIO_PADDED +#undef AIO_PADDEDptr +#undef AIO_PADDEDul + +// Inline helper — copied from . Only manipulates struct fields. +static inline void io_prep_pread(struct iocb *iocb, int fd, void *buf, + size_t count, long long offset) { + memset(iocb, 0, sizeof(*iocb)); + iocb->aio_fildes = fd; + iocb->aio_lio_opcode = IO_CMD_PREAD; + iocb->aio_reqprio = 0; + iocb->u.c.buf = buf; + iocb->u.c.nbytes = count; + iocb->u.c.offset = offset; +} + +// --------------------------------------------------------------------------- +// End: type and struct definitions from +// --------------------------------------------------------------------------- + +#endif // __linux__ diff --git a/src/ailego/io/libaio_loader.h b/src/ailego/io/libaio_loader.h new file mode 100644 index 000000000..7fbbbbfa1 --- /dev/null +++ b/src/ailego/io/libaio_loader.h @@ -0,0 +1,144 @@ +// Copyright 2025-present the zvec project +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// dlopen-based wrapper for libaio. Instead of linking against -laio at build +// time, the DiskAnn plugin loads libaio at runtime via dlopen()/dlsym(). This +// removes libaio as a hard build- and load-time dependency: the plugin .so no +// longer carries a NEEDED entry for libaio.so.1, so it can be dlopen'ed on +// hosts that don't have libaio installed. Callers that actually exercise the +// async-I/O path will fall back to synchronous pread() when libaio is absent. +// +// All ABI-stable type and struct definitions (struct iocb, struct io_event, +// io_context_t, PADDED macros, io_prep_pread(), ...) now live in libaio_def.h — +// a private header that replaces so the project has zero build-time +// dependency on libaio-dev. + +#pragma once + +#if defined(__linux) || defined(__linux__) + +#include +#include +#include +#include +#include // ABI-stable struct definitions (replaces ) + +// Function-pointer typedefs for the four libaio syscalls used by DiskAnn. +typedef int (*aio_setup_fn)(int maxevents, io_context_t *ctxp); +typedef int (*aio_destroy_fn)(io_context_t ctx); +typedef int (*aio_submit_fn)(io_context_t ctx, long nr, struct iocb *ios[]); +typedef int (*aio_getevents_fn)(io_context_t ctx, long min_nr, long nr, + struct io_event *events, + struct timespec *timeout); + +// Runtime loader for libaio. Thread-safe singleton that dlopen()'s libaio +// once and caches the function pointers. If libaio is not present on the +// host, all pointers remain nullptr and callers should fall back to +// synchronous I/O (pread). +// +// Usage: +// if (LibAioLoader::Instance().load()) { +// LibAioLoader::Instance().io_setup(...); +// } +class LibAioLoader { + public: + static LibAioLoader &Instance() { + static LibAioLoader instance; + return instance; + } + + // Load (or confirm already loaded) libaio. Returns true on success. + // Thread-safe and idempotent. + bool load() { + if (available_.load(std::memory_order_acquire)) { + return true; + } + std::call_once(once_, [this] { this->try_load(); }); + return available_.load(std::memory_order_relaxed); + } + + bool is_available() const { + return available_.load(std::memory_order_acquire); + } + + // Function pointers — nullptr until load() succeeds. + aio_setup_fn io_setup; + aio_destroy_fn io_destroy; + aio_submit_fn io_submit; + aio_getevents_fn io_getevents; + + private: + LibAioLoader() + : io_setup(nullptr), + io_destroy(nullptr), + io_submit(nullptr), + io_getevents(nullptr) {} + + ~LibAioLoader() { + if (handle_ != nullptr) { + dlclose(handle_); + } + } + + LibAioLoader(const LibAioLoader &) = delete; + LibAioLoader &operator=(const LibAioLoader &) = delete; + + void try_load() { + // On Ubuntu 24.04 the libaio package was renamed with the t64 suffix + // (64-bit time_t transition), so probe both spellings. + static constexpr const char *kSonames[] = { + "libaio.so.1", + "libaio.so.1t64", + }; + + for (const char *soname : kSonames) { + void *h = dlopen(soname, RTLD_LAZY); + if (h == nullptr) { + continue; + } + + io_setup = reinterpret_cast(dlsym(h, "io_setup")); + io_destroy = reinterpret_cast(dlsym(h, "io_destroy")); + io_submit = reinterpret_cast(dlsym(h, "io_submit")); + + // io_getevents may be redirected to io_getevents_time64 on 32-bit + // platforms compiled with _TIME_BITS=64. + io_getevents = + reinterpret_cast(dlsym(h, "io_getevents")); + if (io_getevents == nullptr) { + io_getevents = + reinterpret_cast(dlsym(h, "io_getevents_time64")); + } + + if (io_setup && io_destroy && io_submit && io_getevents) { + handle_ = h; + available_.store(true, std::memory_order_release); + return; + } + + // Some symbols missing — try the next soname. + dlclose(h); + io_setup = nullptr; + io_destroy = nullptr; + io_submit = nullptr; + io_getevents = nullptr; + } + } + + std::once_flag once_; + std::atomic available_{false}; + void *handle_{nullptr}; +}; + +#endif // __linux__ diff --git a/src/binding/python/model/common/python_config.cc b/src/binding/python/model/common/python_config.cc index dade4bbc3..866f14c9a 100644 --- a/src/binding/python/model/common/python_config.cc +++ b/src/binding/python/model/common/python_config.cc @@ -13,6 +13,7 @@ // limitations under the License. #include "python_config.h" +#include #include namespace zvec { @@ -217,6 +218,26 @@ void ZVecPyConfig::Initialize(pybind11::module_ &m) { "get_default_jieba_dict_dir", []() -> std::string { return GlobalConfig::Instance().jieba_dict_dir(); }, "Read the currently registered default jieba dict directory."); + + // Returns the current I/O backend type for DiskAnn async disk reads. + // When only sync_pread is available, prints the install hint to stdout. + m.def( + "io_backend_type", + []() -> std::string { + auto type = ailego::IOBackend::Instance().available(); + std::string name = ailego::IOBackendTypeName(type); + if (type == ailego::IOBackendType::kSyncPread) { + py::print( + "No async I/O backend available. Install libaio (e.g. " + "'apt-get install libaio1', or 'libaio1t64' on Ubuntu 24.04+) " + "and retry. DiskAnn will fall back to synchronous pread() — " + "performance will be degraded."); + } + return name; + }, + "Returns the current I/O backend type for DiskAnn async disk reads. " + "\"libaio\" if libaio is available, \"sync_pread\" otherwise. " + "When \"sync_pread\", prints the install hint to stdout."); } diff --git a/src/core/algorithm/diskann/diskann_builder.cc b/src/core/algorithm/diskann/diskann_builder.cc index dd43fb29d..0186dfdf3 100644 --- a/src/core/algorithm/diskann/diskann_builder.cc +++ b/src/core/algorithm/diskann/diskann_builder.cc @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -33,17 +34,19 @@ int DiskAnnBuilder::init(const IndexMeta &meta, const ailego::Params ¶ms) { LOG_INFO("Begin DiskAnnBuilder::init"); #if defined(__linux__) || defined(__linux) - // Eagerly load libaio at init time so the user gets immediate feedback - // about whether async I/O is available. LibAioLoader::Load() is idempotent - // and thread-safe. - if (!LibAioLoader::Instance().Load()) { + // Eagerly probe the I/O backend at init time so the user gets immediate + // feedback about whether async I/O is available. IOBackend auto-probes on + // first Instance() access. + auto &backend = ailego::IOBackend::Instance(); + if (backend.available() == ailego::IOBackendType::kSyncPread) { LOG_WARN( - "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " - "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " - "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " - "to synchronous pread() — performance will be degraded."); + "DiskAnn: no async I/O backend available. Install libaio (e.g. " + "'apt-get install libaio1', or 'libaio1t64' on Ubuntu 24.04+) and " + "retry. DiskAnn will fall back to synchronous pread() — performance " + "will be degraded."); } else { - LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); + LOG_INFO("DiskAnn: I/O backend '%s' loaded — async I/O enabled.", + backend.name()); } #endif diff --git a/src/core/algorithm/diskann/diskann_file_reader.cc b/src/core/algorithm/diskann/diskann_file_reader.cc index bc19d8eb5..b1b1dd033 100644 --- a/src/core/algorithm/diskann/diskann_file_reader.cc +++ b/src/core/algorithm/diskann/diskann_file_reader.cc @@ -18,6 +18,7 @@ #include #include #include +#include #include #define MAX_EVENTS 1024 @@ -37,15 +38,16 @@ static std::once_flag g_io_backend_log_once; int setup_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) - LibAioLoader::Instance().Load(); - std::call_once(g_io_backend_log_once, [] { - if (LibAioLoader::Instance().IsAvailable()) { - LOG_INFO("DiskAnn I/O backend: libaio (async I/O enabled)"); + auto &backend = ailego::IOBackend::Instance(); + std::call_once(g_io_backend_log_once, [&backend] { + if (backend.available() != ailego::IOBackendType::kSyncPread) { + LOG_INFO("DiskAnn I/O backend: %s (async I/O enabled)", backend.name()); } else { - LOG_WARN("DiskAnn I/O backend: synchronous pread (libaio not available)"); + LOG_WARN( + "DiskAnn I/O backend: synchronous pread (no async I/O available)"); } }); - if (!LibAioLoader::Instance().IsAvailable()) { + if (backend.available() == ailego::IOBackendType::kSyncPread) { return 0; } int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); @@ -58,7 +60,8 @@ int setup_io_ctx(IOContext &ctx) { int destroy_io_ctx(IOContext &ctx) { #if (defined(__linux) || defined(__linux__)) - if (!LibAioLoader::Instance().IsAvailable()) { + if (ailego::IOBackend::Instance().available() == + ailego::IOBackendType::kSyncPread) { return 0; } int ret = LibAioLoader::Instance().io_destroy(ctx); @@ -90,7 +93,8 @@ static int execute_io_pread(int fd, std::vector &read_reqs) { int execute_io(IOContext ctx, int fd, std::vector &read_reqs, uint64_t n_retries = 0) { #if (defined(__linux) || defined(__linux__)) - if (!LibAioLoader::Instance().Load()) { + if (ailego::IOBackend::Instance().available() == + ailego::IOBackendType::kSyncPread) { return execute_io_pread(fd, read_reqs); } uint64_t iters = DiskAnnUtil::div_round_up(read_reqs.size(), MAX_EVENTS); @@ -211,28 +215,27 @@ void LinuxAlignedFileReader::register_thread() { IOContext ctx = nullptr; - LibAioLoader::Instance().Load(); - std::call_once(g_io_backend_log_once, [] { - if (LibAioLoader::Instance().IsAvailable()) { - LOG_INFO("DiskAnn I/O backend: libaio (async I/O enabled)"); + auto &backend = ailego::IOBackend::Instance(); + std::call_once(g_io_backend_log_once, [&backend] { + if (backend.available() != ailego::IOBackendType::kSyncPread) { + LOG_INFO("DiskAnn I/O backend: %s (async I/O enabled)", backend.name()); } else { - LOG_WARN("DiskAnn I/O backend: synchronous pread (libaio not available)"); + LOG_WARN( + "DiskAnn I/O backend: synchronous pread (no async I/O available)"); } }); - if (!LibAioLoader::Instance().IsAvailable()) { + if (backend.available() == ailego::IOBackendType::kSyncPread) { lk.unlock(); return; } int ret = LibAioLoader::Instance().io_setup(MAX_EVENTS, &ctx); if (ret != 0) { - lk.unlock(); if (ret == -EAGAIN) { LOG_ERROR( "io_setup failed with EAGAIN: Consider increasing " "/proc/sys/fs/aio-max-nr"); } else { LOG_ERROR("io_setup failed; returned: %d, %s", ret, ::strerror(-ret)); - ; } } else { LOG_INFO("allocating ctx: %lu", (uint64_t)ctx); @@ -261,7 +264,8 @@ void LinuxAlignedFileReader::deregister_thread() { } // io_destroy is a syscall; keep it outside the lock to avoid blocking others - if (LibAioLoader::Instance().IsAvailable()) { + if (ailego::IOBackend::Instance().available() != + ailego::IOBackendType::kSyncPread) { LibAioLoader::Instance().io_destroy(ctx); } LOG_INFO("returned ctx from thread"); @@ -271,7 +275,8 @@ void LinuxAlignedFileReader::deregister_thread() { void LinuxAlignedFileReader::deregister_all_threads() { #if (defined(__linux) || defined(__linux__)) std::unique_lock lk(ctx_mut); - bool aio_available = LibAioLoader::Instance().IsAvailable(); + bool aio_available = ailego::IOBackend::Instance().available() != + ailego::IOBackendType::kSyncPread; for (auto x = ctx_map.begin(); x != ctx_map.end(); x++) { IOContext ctx = x->second; if (aio_available) { diff --git a/src/core/algorithm/diskann/diskann_searcher.cc b/src/core/algorithm/diskann/diskann_searcher.cc index c56d23b8f..75c6d81d1 100644 --- a/src/core/algorithm/diskann/diskann_searcher.cc +++ b/src/core/algorithm/diskann/diskann_searcher.cc @@ -13,6 +13,7 @@ // limitations under the License. #include "diskann_searcher.h" +#include #include "diskann_context.h" #include "diskann_indexer.h" #include "diskann_params.h" @@ -26,17 +27,19 @@ DiskAnnSearcher::~DiskAnnSearcher() {} int DiskAnnSearcher::init(const ailego::Params &search_params) { #if defined(__linux__) || defined(__linux) - // Eagerly load libaio at init time so the user gets immediate feedback - // about whether async I/O is available. LibAioLoader::Load() is idempotent - // and thread-safe. - if (!LibAioLoader::Instance().Load()) { + // Eagerly probe the I/O backend at init time so the user gets immediate + // feedback about whether async I/O is available. IOBackend auto-probes on + // first Instance() access. + auto &backend = ailego::IOBackend::Instance(); + if (backend.available() == ailego::IOBackendType::kSyncPread) { LOG_WARN( - "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " - "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " - "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " - "to synchronous pread() — performance will be degraded."); + "DiskAnn: no async I/O backend available. Install libaio (e.g. " + "'apt-get install libaio1', or 'libaio1t64' on Ubuntu 24.04+) and " + "retry. DiskAnn will fall back to synchronous pread() — performance " + "will be degraded."); } else { - LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); + LOG_INFO("DiskAnn: I/O backend '%s' loaded — async I/O enabled.", + backend.name()); } #endif diff --git a/src/core/algorithm/diskann/diskann_streamer.cc b/src/core/algorithm/diskann/diskann_streamer.cc index 37de6ec81..6fbd22b1c 100644 --- a/src/core/algorithm/diskann/diskann_streamer.cc +++ b/src/core/algorithm/diskann/diskann_streamer.cc @@ -13,6 +13,7 @@ // limitations under the License. #include "diskann_streamer.h" +#include #include "diskann_context.h" #include "diskann_index_provider.h" #include "diskann_indexer.h" @@ -30,17 +31,19 @@ int DiskAnnStreamer::init(const IndexMeta &meta, meta_ = meta; #if defined(__linux__) || defined(__linux) - // Eagerly load libaio at init time so the user gets immediate feedback - // about whether async I/O is available. LibAioLoader::Load() is idempotent - // and thread-safe. - if (!LibAioLoader::Instance().Load()) { + // Eagerly probe the I/O backend at init time so the user gets immediate + // feedback about whether async I/O is available. IOBackend auto-probes on + // first Instance() access. + auto &backend = ailego::IOBackend::Instance(); + if (backend.available() == ailego::IOBackendType::kSyncPread) { LOG_WARN( - "DiskAnn: libaio could not be loaded (tried libaio.so.1 and " - "libaio.so.1t64). Install it (e.g. 'apt-get install libaio1', or " - "'libaio1t64' on Ubuntu 24.04+) and retry. DiskAnn will fall back " - "to synchronous pread() — performance will be degraded."); + "DiskAnn: no async I/O backend available. Install libaio (e.g. " + "'apt-get install libaio1', or 'libaio1t64' on Ubuntu 24.04+) and " + "retry. DiskAnn will fall back to synchronous pread() — performance " + "will be degraded."); } else { - LOG_INFO("DiskAnn: libaio loaded successfully — async I/O enabled."); + LOG_INFO("DiskAnn: I/O backend '%s' loaded — async I/O enabled.", + backend.name()); } #endif diff --git a/src/core/interface/indexes/diskann_index.cc b/src/core/interface/indexes/diskann_index.cc index 25274f727..111bb8052 100644 --- a/src/core/interface/indexes/diskann_index.cc +++ b/src/core/interface/indexes/diskann_index.cc @@ -15,6 +15,7 @@ #include #include #include +#include #include #include "algorithm/diskann/diskann_params.h" #include "holder_builder.h" @@ -266,4 +267,16 @@ int DiskAnnIndex::Merge(const std::vector &indexes, return 0; } +ailego::IOBackendType DiskAnnIndex::io_backend_type() const { + auto &backend = ailego::IOBackend::Instance(); + ailego::IOBackendType type = backend.type(); + if (type == ailego::IOBackendType::kSyncPread) { + LOG_WARN( + "DiskAnn: only synchronous pread() is available. Install libaio " + "(e.g. 'apt-get install libaio1', or 'libaio1t64' on Ubuntu 24.04+) " + "for async I/O support — performance will be degraded without it."); + } + return type; +} + } // namespace zvec::core_interface \ No newline at end of file diff --git a/src/include/zvec/core/interface/index.h b/src/include/zvec/core/interface/index.h index e9ed39051..7b4d288e7 100644 --- a/src/include/zvec/core/interface/index.h +++ b/src/include/zvec/core/interface/index.h @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -360,6 +361,10 @@ class DiskAnnIndex : public Index { public: DiskAnnIndex() = default; + // Returns the I/O backend type currently loaded for DiskAnn async disk reads. + // If only sync_pread is available, logs a hint to install libaio. + ailego::IOBackendType io_backend_type() const; + protected: virtual int CreateAndInitStreamer(const BaseIndexParam ¶m) override; From 54eaa118d59a0083a620e9155689d9248796a1fe Mon Sep 17 00:00:00 2001 From: ray Date: Tue, 7 Jul 2026 16:33:41 +0800 Subject: [PATCH 32/41] fix: add io backend --- src/core/interface/indexes/diskann_index.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/interface/indexes/diskann_index.cc b/src/core/interface/indexes/diskann_index.cc index 111bb8052..e518898ab 100644 --- a/src/core/interface/indexes/diskann_index.cc +++ b/src/core/interface/indexes/diskann_index.cc @@ -272,7 +272,7 @@ ailego::IOBackendType DiskAnnIndex::io_backend_type() const { ailego::IOBackendType type = backend.type(); if (type == ailego::IOBackendType::kSyncPread) { LOG_WARN( - "DiskAnn: only synchronous pread() is available. Install libaio " + "Only synchronous pread() is available. Install libaio " "(e.g. 'apt-get install libaio1', or 'libaio1t64' on Ubuntu 24.04+) " "for async I/O support — performance will be degraded without it."); } From 4b4a00b1957185394f2f8b01e86a82a771575f52 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 10:53:32 +0800 Subject: [PATCH 33/41] fix: fix --- examples/c++/CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/c++/CMakeLists.txt b/examples/c++/CMakeLists.txt index d58814d52..4e4551cf2 100644 --- a/examples/c++/CMakeLists.txt +++ b/examples/c++/CMakeLists.txt @@ -18,7 +18,9 @@ set(ZVEC_INCLUDE_DIR ${ZVEC_ROOT_DIR}/src/include) set(ZVEC_LIB_DIR ${ZVEC_ROOT_DIR}/${HOST_BUILD_DIR}/lib) # Add include and library search paths -include_directories(${ZVEC_INCLUDE_DIR}) +# ${ZVEC_ROOT_DIR}/src is needed because public headers under src/include/ +# reference ailego/ headers (e.g. ) that live in src/. +include_directories(${ZVEC_INCLUDE_DIR} ${ZVEC_ROOT_DIR}/src) set(ZVEC_LIB_SEARCH_DIRS ${ZVEC_LIB_DIR}) # Support multi-config builds (MSVC puts libs in Debug/Release subdirectories) From e1048c067078483fbdd0c99bd2525b85b9837a69 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 11:08:28 +0800 Subject: [PATCH 34/41] fix: remove ci --- .github/workflows/01-ci-pipeline.yml | 8 -- .github/workflows/09-diskann-libaio-test.yml | 109 ------------------- 2 files changed, 117 deletions(-) delete mode 100644 .github/workflows/09-diskann-libaio-test.yml diff --git a/.github/workflows/01-ci-pipeline.yml b/.github/workflows/01-ci-pipeline.yml index b0c3c7e27..ce9f8e2ef 100644 --- a/.github/workflows/01-ci-pipeline.yml +++ b/.github/workflows/01-ci-pipeline.yml @@ -97,14 +97,6 @@ jobs: os: ubuntu-24.04 compiler: clang - # DiskAnn w/ libaio: explicitly install libaio and run tests to exercise - # the async I/O path. The existing CI (without libaio-dev) already covers - # the w/o libaio pread() fallback path. - diskann-libaio-test: - name: DiskAnn w/ libaio (linux-x64) - needs: [lint, clang-tidy] - uses: ./.github/workflows/09-diskann-libaio-test.yml - build-android: if: github.event_name != 'push' || github.ref != 'refs/heads/main' name: Build & Test (android) diff --git a/.github/workflows/09-diskann-libaio-test.yml b/.github/workflows/09-diskann-libaio-test.yml deleted file mode 100644 index 1024c9ffb..000000000 --- a/.github/workflows/09-diskann-libaio-test.yml +++ /dev/null @@ -1,109 +0,0 @@ -name: DiskAnn libaio Test - -# Tests DiskAnn on Linux x86_64 with libaio explicitly installed, exercising -# the async I/O path (io_setup/io_submit/io_getevents). -# -# The existing CI (03-macos-linux-build.yml without libaio-dev installed) and -# non-Linux platform jobs already cover the "w/o libaio" fallback path — -# DiskAnn gracefully degrades to synchronous pread() when libaio is absent. -# This workflow complements that by ensuring the async I/O path is also -# exercised when libaio is present. - -on: - workflow_call: - workflow_dispatch: - -permissions: - contents: read - -jobs: - libaio-test: - name: DiskAnn w/ libaio (linux-x64) - runs-on: ubuntu-24.04 - - steps: - - name: Checkout code - uses: actions/checkout@v7 - with: - submodules: recursive - - - name: Install libaio runtime - run: | - sudo apt-get update -y - # libaio1t64 on Ubuntu 24.04+ (t64 transition), libaio1 on older - sudo apt-get install -y libaio1t64 || sudo apt-get install -y libaio1 - echo "=== libaio status (should be present) ===" - dpkg -l | grep -i libaio || true - ldconfig -p | grep libaio || true - shell: bash - - - name: Setup ccache - uses: hendrikmuhs/ccache-action@v1.2 - with: - key: linux-x64-libaio-test - max-size: 150M - - - name: Set up Python - uses: actions/setup-python@v6 - with: - python-version: '3.10' - cache: 'pip' - cache-dependency-path: 'pyproject.toml' - - - name: Set up environment variables - run: | - NPROC=$(nproc 2>/dev/null || echo 2) - echo "NPROC=$NPROC" >> $GITHUB_ENV - echo "$(python -c 'import site; print(site.USER_BASE)')/bin" >> $GITHUB_PATH - shell: bash - - - name: Install dependencies - run: | - python -m pip install --upgrade pip - python -m pip install \ - pybind11==3.0 \ - cmake==3.30.0 \ - ninja==1.11.1 \ - pytest \ - pytest-xdist \ - scikit-build-core \ - setuptools_scm - shell: bash - - - name: Build from source - run: | - cd "$GITHUB_WORKSPACE" - CMAKE_GENERATOR="Ninja" \ - CMAKE_BUILD_PARALLEL_LEVEL="$NPROC" \ - python -m pip install -v . \ - --no-build-isolation \ - --config-settings='cmake.define.BUILD_TOOLS=ON' \ - --config-settings='cmake.define.ENABLE_WERROR=ON' \ - --config-settings='cmake.define.CMAKE_C_COMPILER_LAUNCHER=ccache' \ - --config-settings='cmake.define.CMAKE_CXX_COMPILER_LAUNCHER=ccache' - shell: bash - - - name: Run C++ Tests (w/ libaio) - run: | - cd "$GITHUB_WORKSPACE/build" - cmake --build . --target unittest --parallel $NPROC - shell: bash - - - name: Verify no libaio in test binary - run: | - # Confirm the test binary does NOT have a NEEDED entry for libaio. - # This verifies the dlopen decoupling — libaio is loaded at runtime, - # not linked at build time. - TEST_BIN="$GITHUB_WORKSPACE/build/bin/diskann_searcher_test" - if [ -f "$TEST_BIN" ]; then - ldd "$TEST_BIN" | grep 'libaio' \ - && { echo "ERROR: test binary links libaio directly!"; exit 1; } \ - || echo "OK: test binary does not link libaio (dlopen-based)" - fi - shell: bash - - - name: Run Python Tests (w/ libaio) - run: | - cd "$GITHUB_WORKSPACE" - python -m pytest python/tests/ - shell: bash From fde7813b1130a1ce14a2732142a99ecd4ffea107 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 11:15:17 +0800 Subject: [PATCH 35/41] fix: add ci --- .github/workflows/03-macos-linux-build.yml | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/.github/workflows/03-macos-linux-build.yml b/.github/workflows/03-macos-linux-build.yml index 03fe2cafa..fdb11ce16 100644 --- a/.github/workflows/03-macos-linux-build.yml +++ b/.github/workflows/03-macos-linux-build.yml @@ -175,3 +175,31 @@ jobs: ./c_api_index_example ./c_api_optimized_example shell: bash + + # ------------------------------------------------------------------ # + # DiskAnn libaio round: install libaio and re-run tests + # ------------------------------------------------------------------ # + - name: Install libaio runtime + if: matrix.platform == 'linux-x64' + run: | + sudo apt-get update -y + # libaio1t64 on Ubuntu 24.04+ (t64 transition), libaio1 on older + sudo apt-get install -y libaio1t64 || sudo apt-get install -y libaio1 + echo "=== libaio status (should be present) ===" + dpkg -l | grep -i libaio || true + ldconfig -p | grep libaio || true + shell: bash + + - name: Run C++ Tests (w/ libaio) + if: matrix.platform == 'linux-x64' + run: | + cd "$GITHUB_WORKSPACE/build" + cmake --build . --target unittest --parallel $NPROC + shell: bash + + - name: Run Python Tests (w/ libaio) + if: matrix.platform == 'linux-x64' + run: | + cd "$GITHUB_WORKSPACE" + python -m pytest python/tests/ + shell: bash From ca89c3043cd335b1721a5d613e6a2f6eb0e14875 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 11:30:07 +0800 Subject: [PATCH 36/41] fix: debug output --- src/binding/python/model/python_collection.cc | 11 ++++++++++- src/db/collection.cc | 7 +++++++ src/include/zvec/db/collection.h | 5 +++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/binding/python/model/python_collection.cc b/src/binding/python/model/python_collection.cc index b1311f119..66944a0df 100644 --- a/src/binding/python/model/python_collection.cc +++ b/src/binding/python/model/python_collection.cc @@ -310,7 +310,16 @@ void ZVecPyCollection::bind_dql_methods( "given vector column. One of 'mmap', 'buffer_pool', 'contiguous'. " "Raises KeyError if no HNSW index exists on the column, or " "ValueError if the column's index is not an HNSW index. Intended " - "for introspection and testing only; not part of the stable API."); + "for introspection and testing only; not part of the stable API.") + .def( + "_debug_io_backend_type", + [](const Collection &self) { + const auto result = self.DebugGetIoBackendType(); + return unwrap_expected(result); + }, + "Debug-only: returns the I/O backend type used by DiskAnn. " + "One of 'libaio', 'sync_pread'. Intended for introspection and " + "testing only; not part of the stable API."); } } // namespace zvec \ No newline at end of file diff --git a/src/db/collection.cc b/src/db/collection.cc index 14cb2f4bc..c13096438 100644 --- a/src/db/collection.cc +++ b/src/db/collection.cc @@ -134,6 +134,8 @@ class CollectionImpl : public Collection { Result DebugGetHnswStorageMode( const std::string &column_name) const override; + Result DebugGetIoBackendType() const override; + private: void prepare_schema(); @@ -1893,6 +1895,11 @@ Result CollectionImpl::DebugGetHnswStorageMode( Status::NotFound("No HNSW index found for column '", column_name, "'")); } +Result CollectionImpl::DebugGetIoBackendType() const { + auto type = ailego::IOBackend::Instance().available(); + return std::string(ailego::IOBackendTypeName(type)); +} + Status CollectionImpl::recovery() { if (!FileHelper::DirectoryExists(path_.c_str())) { return Status::InvalidArgument("collection path{", path_, "} not exist."); diff --git a/src/include/zvec/db/collection.h b/src/include/zvec/db/collection.h index 83a289c52..bc9f0d63b 100644 --- a/src/include/zvec/db/collection.h +++ b/src/include/zvec/db/collection.h @@ -117,6 +117,11 @@ class Collection { //! introspection and testing; not part of the stable public API. virtual Result DebugGetHnswStorageMode( const std::string &column_name) const = 0; + + //! Debug-only: retrieve the I/O backend type used by DiskAnn. Returns + //! "libaio" or "sync_pread". Intended for introspection and testing; not + //! part of the stable public API. + virtual Result DebugGetIoBackendType() const = 0; }; } // namespace zvec \ No newline at end of file From 0583231cf90aab57d0f5cb551f1bb8c589191ce5 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 12:27:08 +0800 Subject: [PATCH 37/41] fix: fix ut --- tests/core/interface/index_group_by_test.cc | 28 +++++++++++++++++---- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/tests/core/interface/index_group_by_test.cc b/tests/core/interface/index_group_by_test.cc index bb41938fb..d2fd72b14 100644 --- a/tests/core/interface/index_group_by_test.cc +++ b/tests/core/interface/index_group_by_test.cc @@ -44,6 +44,7 @@ struct GroupByCase { bool is_sparse = false; uint32_t dimension = kDimension; bool with_refiner = false; + bool optional = false; // skip when plugin unavailable (e.g. DiskAnn) }; std::shared_ptr> AllPks() { @@ -246,7 +247,16 @@ class GroupByInterfaceTest : public ::testing::Test { ASSERT_EQ(0, source->Train()) << test_case.name; auto index = IndexFactory::CreateAndInitIndex(*test_case.index_param); - ASSERT_NE(nullptr, index) << test_case.name; + if (index == nullptr) { + if (test_case.optional) { + // Optional plugin (e.g. DiskAnn shared module) unavailable at runtime + source->Close(); + zvec::test_util::RemoveTestFiles(index_name + "*"); + zvec::test_util::RemoveTestFiles(source_index_name + "*"); + return; + } + ASSERT_NE(nullptr, index) << test_case.name; + } ASSERT_EQ( 0, index->Open(index_name, {StorageOptions::StorageType::kMMAP, true})) << test_case.name; @@ -522,14 +532,22 @@ TEST_F(GroupByInterfaceTest, UnsupportedIndexTypes) { /*dimension=*/kDimension, /*with_refiner=*/true}, #if DISKANN_SUPPORTED - {"unsupported_diskann_graph", DenseDiskAnnParam(), DiskAnnQuery()}, + {"unsupported_diskann_graph", DenseDiskAnnParam(), DiskAnnQuery(), + /*is_sparse=*/false, /*dimension=*/kDimension, + /*with_refiner=*/false, /*optional=*/true}, {"unsupported_diskann_linear", DenseDiskAnnParam(), - DiskAnnQuery(/*fetch_vector=*/false, /*is_linear=*/true)}, + DiskAnnQuery(/*fetch_vector=*/false, /*is_linear=*/true), + /*is_sparse=*/false, /*dimension=*/kDimension, + /*with_refiner=*/false, /*optional=*/true}, {"unsupported_diskann_bf_pks", DenseDiskAnnParam(), DiskAnnQuery(/*fetch_vector=*/false, /*is_linear=*/false, - /*with_bf_pks=*/true)}, + /*with_bf_pks=*/true), + /*is_sparse=*/false, /*dimension=*/kDimension, + /*with_refiner=*/false, /*optional=*/true}, {"unsupported_diskann_fetch_vector", DenseDiskAnnParam(), - DiskAnnQuery(/*fetch_vector=*/true)}, + DiskAnnQuery(/*fetch_vector=*/true), + /*is_sparse=*/false, /*dimension=*/kDimension, + /*with_refiner=*/false, /*optional=*/true}, #endif }; From 0afa1d5377aec4aebc5008481f6fa4e7050a34a1 Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 14:06:25 +0800 Subject: [PATCH 38/41] fix: fix ut --- src/ailego/io/io_backend.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ailego/io/io_backend.h b/src/ailego/io/io_backend.h index a118a7d9d..183473ca1 100644 --- a/src/ailego/io/io_backend.h +++ b/src/ailego/io/io_backend.h @@ -30,11 +30,14 @@ #pragma once -#include #include #include #include +#if defined(__linux) || defined(__linux__) +#include // close(), syscall() — POSIX only, used in Linux backend probe +#endif + namespace zvec { namespace ailego { From 232e72a6c02c59b1584fd12d203e6a877b04c21b Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 15:35:50 +0800 Subject: [PATCH 39/41] fix: fix --- src/db/index/common/schema.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/db/index/common/schema.cc b/src/db/index/common/schema.cc index f2acc915a..a5a6c09da 100644 --- a/src/db/index/common/schema.cc +++ b/src/db/index/common/schema.cc @@ -197,13 +197,15 @@ Status FieldSchema::validate() const { } if (index_params_->type() == IndexType::DISKANN) { - // DiskAnn requires Linux x86_64. The libaio runtime is loaded - // eagerly (via dlopen) inside DiskAnnBuilder::init() and - // DiskAnnStreamer::init(); if libaio is missing, DiskAnn falls back - // to synchronous pread() with degraded performance. -#if !defined(__linux__) && !defined(__linux) + // DiskAnn is supported wherever DISKANN_SUPPORTED is enabled (Linux + // x86_64 with libaio/io_uring, Windows x86_64 with IOCP). On Linux the + // libaio runtime is loaded eagerly via dlopen inside + // DiskAnnBuilder::init() and DiskAnnStreamer::init(); if libaio is + // missing, DiskAnn falls back to synchronous pread() with degraded + // performance. +#if !DISKANN_SUPPORTED return Status::NotSupported( - "DiskAnn is not supported on this platform (Linux x86_64 only)"); + "DiskAnn is not supported on this platform"); #endif } From bf4f6307abccdd1c28c66cde66c06198ae1e5dde Mon Sep 17 00:00:00 2001 From: ray Date: Wed, 8 Jul 2026 16:42:42 +0800 Subject: [PATCH 40/41] fix: fix ut --- src/db/index/common/schema.cc | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/db/index/common/schema.cc b/src/db/index/common/schema.cc index a5a6c09da..f2acc915a 100644 --- a/src/db/index/common/schema.cc +++ b/src/db/index/common/schema.cc @@ -197,15 +197,13 @@ Status FieldSchema::validate() const { } if (index_params_->type() == IndexType::DISKANN) { - // DiskAnn is supported wherever DISKANN_SUPPORTED is enabled (Linux - // x86_64 with libaio/io_uring, Windows x86_64 with IOCP). On Linux the - // libaio runtime is loaded eagerly via dlopen inside - // DiskAnnBuilder::init() and DiskAnnStreamer::init(); if libaio is - // missing, DiskAnn falls back to synchronous pread() with degraded - // performance. -#if !DISKANN_SUPPORTED + // DiskAnn requires Linux x86_64. The libaio runtime is loaded + // eagerly (via dlopen) inside DiskAnnBuilder::init() and + // DiskAnnStreamer::init(); if libaio is missing, DiskAnn falls back + // to synchronous pread() with degraded performance. +#if !defined(__linux__) && !defined(__linux) return Status::NotSupported( - "DiskAnn is not supported on this platform"); + "DiskAnn is not supported on this platform (Linux x86_64 only)"); #endif } From 31c0fe5bf919db978835e8e2cd38c3532801fc92 Mon Sep 17 00:00:00 2001 From: ray Date: Thu, 9 Jul 2026 15:44:39 +0800 Subject: [PATCH 41/41] fix: schema --- src/db/index/common/schema.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/db/index/common/schema.cc b/src/db/index/common/schema.cc index f2acc915a..a5a6c09da 100644 --- a/src/db/index/common/schema.cc +++ b/src/db/index/common/schema.cc @@ -197,13 +197,15 @@ Status FieldSchema::validate() const { } if (index_params_->type() == IndexType::DISKANN) { - // DiskAnn requires Linux x86_64. The libaio runtime is loaded - // eagerly (via dlopen) inside DiskAnnBuilder::init() and - // DiskAnnStreamer::init(); if libaio is missing, DiskAnn falls back - // to synchronous pread() with degraded performance. -#if !defined(__linux__) && !defined(__linux) + // DiskAnn is supported wherever DISKANN_SUPPORTED is enabled (Linux + // x86_64 with libaio/io_uring, Windows x86_64 with IOCP). On Linux the + // libaio runtime is loaded eagerly via dlopen inside + // DiskAnnBuilder::init() and DiskAnnStreamer::init(); if libaio is + // missing, DiskAnn falls back to synchronous pread() with degraded + // performance. +#if !DISKANN_SUPPORTED return Status::NotSupported( - "DiskAnn is not supported on this platform (Linux x86_64 only)"); + "DiskAnn is not supported on this platform"); #endif }