Duplicated groups for EP and DP_EP #222
Description
In MockNcclGroup, this line:
just repeats the group creation EP times, but keeps creating the same groups (with same ranks), as the
j index is not used.In my understanding, only one iteration should be enough for creating all the needed groups (i.e.,
_EP_nums).
A similar problem affects the DP_EP groups creation:
At last, this does not create a problem in the simulation run because there are just redundant groups (and they just keep replacing themselves in the GroupIndex structure, as the key is the same, eventually leaving only the last one there), but it creates a lot of confusion to me.