Skip to content

FIX: release please config doesn't capture current tag format #478

@lwasser

Description

@lwasser

@lwasser So, I believe there's an issue with the Release Please setup. It's not detecting any previous releases, so I believe this effectively is every change that's ever happened (that fits into feat or fix - and it may be capped at 500).

For instance this change in the changelog is from 2019, but the last release was 2023, so it shouldn't be included.
image

The problem is that the Release Please config is setup to use the component name as part of the tag name (default behavior when using manifest releases), and the existing tags aren't using that format. So, it fails to find any previous release tags.

image

That format is really meant for monorepos with multiple packages being published out of it. When it's disabled, the tag format is the same as what you're already using. So, you just need to add this to your release please config:
"include-component-in-tag": false,

Ref: https://github.com/michaelfaith/package-json-validator/blob/main/.github/release-please/release-please-config.main.json#L17

Before merging that, I'd suggest closing this PR, and deleting the release-please branch, so that when the above change merges it regenerates the branch and pr from scratch. At that point it should detect your previous releases, and only include unreleased changes in the new PR.

(for the lint error, we just excluded the changelog from our eslint config, since it's being generated)

Originally posted by @michaelfaith in #476 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions