From f88ee38f511468f37d689ad3e5e11560d20e9966 Mon Sep 17 00:00:00 2001 From: Maicol Battistini Date: Thu, 5 Mar 2026 15:30:37 +0100 Subject: [PATCH 1/2] feat: Add `onClick` parameter to `SettingsTileScaffold` and use it in `SettingsMenuLink` --- .../compose/settings/ui/expressive/SettingsMenuLink.kt | 6 ++---- .../compose/settings/ui/expressive/SettingsTileScaffold.kt | 3 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt b/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt index 7dbf9027..627f5cc0 100644 --- a/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt +++ b/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt @@ -29,12 +29,10 @@ fun SettingsMenuLink( SettingsTileScaffold( modifier = Modifier - .clickable( - enabled = enabled, - onClick = onClick, - ).semantics(properties = semanticProperties) + .semantics(properties = semanticProperties) .then(modifier), enabled = enabled, + onClick = onClick, title = title, supportingContent = subtitle, leadingContent = icon, diff --git a/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsTileScaffold.kt b/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsTileScaffold.kt index ff607f25..3e1c7ed3 100644 --- a/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsTileScaffold.kt +++ b/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsTileScaffold.kt @@ -15,6 +15,7 @@ fun SettingsTileScaffold( title: @Composable () -> Unit, modifier: Modifier = Modifier, enabled: Boolean = true, + onClick: () -> Unit = {}, supportingContent: @Composable (() -> Unit)? = null, leadingContent: @Composable (() -> Unit)? = null, colors: ListItemColors = SettingsTileDefaults.colors(), @@ -24,7 +25,7 @@ fun SettingsTileScaffold( ) { SegmentedListItem( selected = false, - onClick = {}, + onClick = onClick, shapes = shapes, modifier = Modifier.fillMaxWidth().then(modifier), enabled = enabled, From 900e940f2bf1ed6ce5a01adad30138f47b437db7 Mon Sep 17 00:00:00 2001 From: Maicol Battistini Date: Thu, 5 Mar 2026 17:03:04 +0100 Subject: [PATCH 2/2] refactor: Remove unused import for clickable from SettingsMenuLink --- .../alorma/compose/settings/ui/expressive/SettingsMenuLink.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt b/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt index 627f5cc0..7be4e6dc 100644 --- a/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt +++ b/ui-tiles-expressive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt @@ -1,6 +1,5 @@ package com.alorma.compose.settings.ui.expressive -import androidx.compose.foundation.clickable import androidx.compose.material3.ExperimentalMaterial3ExpressiveApi import androidx.compose.material3.ListItemColors import androidx.compose.material3.ListItemElevation