From 2ad1a4dbaa95568236e91c3bab0e3bba54eabe5e Mon Sep 17 00:00:00 2001 From: Taimuraz Kaitmazov Date: Sat, 25 Jul 2026 16:15:19 +0300 Subject: [PATCH] gelu: re-enable the tile_size=8192 test Closes #113. #113 disabled this case pending the LUT alignment fix in mlir-aie PR #3045 ("Fix alignment for look up tables"), which has since merged. That fix is present in the mlir_aie version pinned here: #3045 merged as 6032217 (2026-05-11), requirements.txt pins mlir_aie==1.3.5.dev20+g167f34d (167f34d, 2026-07-08), and 6032217 is an ancestor of 167f34d. Locally the case passes: the parameter set generates exactly one tile_size=8192 config (input_length=8192, 1 column, 1 channel), it passed 5/5 standalone, and the full gelu suite is green with the skip removed (160 passed on Strix). Worth noting this test is marked extensive (is_extensive = input_length != 2048) and the extensive workflows run on push/schedule rather than pull_request, so PR CI will not exercise it. A workflow_dispatch run of phoenix-extensive or krackan-extensive on this branch would confirm it before merge. _marks no longer needs the tile size, so it takes only the extensive flag. --- iron/operators/gelu/test.py | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/iron/operators/gelu/test.py b/iron/operators/gelu/test.py index 257fc1cd..d2c7cb4b 100755 --- a/iron/operators/gelu/test.py +++ b/iron/operators/gelu/test.py @@ -10,21 +10,11 @@ def get_params(): - def _marks(ext, ts): - marks = [] - if ext: - marks.append(pytest.mark.extensive) - # TODO: temporary - disable tile_size=8192 for GeLU, issue #113 - if ts == 8192: - marks.append( - pytest.mark.skip( - reason="temporary: tile_size=8192 disabled for GeLU, see issue #113" - ) - ) - return marks + def _marks(ext): + return [pytest.mark.extensive] if ext else [] return [ - pytest.param(il, nac, nc, ts, marks=_marks(ext, ts)) + pytest.param(il, nac, nc, ts, marks=_marks(ext)) for il, nac, nc, ts, ext in make_channeled_unary_params( [1024, 2048, 4096, 8192], 8192, [1, 2] )