👍🎉 First off, thanks for taking the time to contribute! 🎉👍
The following is a set of guidelines for contributing to AMF:
- Ensure the bug was not already reported by searching on GitHub under Issues.
- If you're unable to find an open issue addressing the problem, open a new one. If possible, use the relevant bug report templates to create the issue. If not, be sure to include a title and clear description, as much relevant information as possible, and a code sample or an executable test case demonstrating the expected behavior that is not occurring.
- Read and sign the Contributors License Agreement
- Open a new GitHub pull request with the change.
- Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.
- Before submitting, please read the Code contributions section to know more about the technical contribution requirements.
- Scala 2.12.15
- sbt 1.7.3
- Node
- Always branch from
masterbranch to ensure you are updated with the latest release. - Don’t submit unrelated changes in the same branch/pull request.
- If you need to update your branch because of changes in
masteryou should always rebase, not merge. - You should always be up-to-date with the latest changes in
master.
We use Scalafmt to format our code! Please format your code before opening a Pull Request.
Important: Please include tests with any code contributions
Writing tests before the implementation is strongly encouraged.
To run tests:
$ sbt test
$ sbt cliJVM/testOnly // to run tests only for the JVM platform
$ sbt cliJS/testOnly // to run tests only for the JS platformCode contributions must comply with a minimum of 80% coverage rate.
To run a coverage report of the whole project:
sbt coverage test coverageReportTravis CI will automatically run tests upon creation of your PR, please make sure all tests pass before someone can review you contribution.
Contributions must comply with a minimum of 80% coverage rate.
To run a coverage report of the whole project:
sbt coverage test coverageReportPlease read and accept the Contributors Agreement. This should automatically create a Github issue with the record of your signature here. If for any reason, you do not see your signature there, please contact us.